Re: [PATCH HID v2 08/11] HID: add per device quirk to force bind to hid-generic

2024-09-11 Thread Peter Hutterer
hid_driver I like this one a lot more than the previous approach, series is Reviewed-by: Peter Hutterer although for 01 and 06 this should be taken with a grain of salt :) Cheers, Peter > --- > drivers/hid/hid-core.c| 5 +++-- > drivers/hid/hid-generic.c | 3 +++ > includ

Re: [PATCH HID v2 02/11] HID: core: save one kmemdup during .probe()

2024-09-11 Thread Peter Hutterer
On Tue, Sep 10, 2024 at 11:43:38PM +0900, Benjamin Tissoires wrote: > Turns out the first kmemdup is only required for the .report_fixup() > driver callback. There is no need to do two kmemdup() in a raw in case typo: "in a row"? Cheers, Peter > .report_fixup() is not present. > > Signed-off-

Re: [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series

2021-04-14 Thread Peter Hutterer
On Wed, Apr 14, 2021 at 10:26:13AM -0700, Dmitry Torokhov wrote: > Hi Giulio, Peter, > > On Wed, Apr 14, 2021 at 01:22:55PM +0200, Giulio Benetti wrote: > > Hi Peter, Dmitry, > > > > On 4/14/21 8:46 AM, Peter Hutterer wrote: > > > On Tue, Apr 13, 2021 at 10:

Re: [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series

2021-04-13 Thread Peter Hutterer
On Tue, Apr 13, 2021 at 10:44:07PM -0700, Dmitry Torokhov wrote: > Hi Giulio, > > On Tue, Apr 13, 2021 at 04:44:46PM +0200, Giulio Benetti wrote: > > + > > + input_mt_report_pointer_emulation(tsdata->input, true); > > For touchscreens it does not make much sense to report BTN_DOUBLETAP, > BTN_T

Re: [PATCH] HID: hid-input: avoid splitting keyboard, system and consumer controls

2021-01-14 Thread Peter Hutterer
rol and consumer control reports with > keyboard report, if one has already been processed. > > Signed-off-by: Dmitry Torokhov Acked-by: Peter Hutterer I think, let's see if there's any fallout from that :) Cheers, Peter

[PATCH] Documentation: input: define ABS_PRESSURE/ABS_MT_PRESSURE resolution as grams

2021-01-12 Thread Peter Hutterer
libinput/-/issues/562 Signed-off-by: Peter Hutterer --- Documentation/input/event-codes.rst | 15 +++ Documentation/input/multi-touch-protocol.rst | 4 2 files changed, 19 insertions(+) diff --git a/Documentation/input/event-codes.rst b/Documentation/input/event-codes.r

Re: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp'

2020-11-15 Thread Peter Hutterer
On Fri, Nov 13, 2020 at 08:42:37AM +0100, Benjamin Tissoires wrote: > On Fri, Nov 13, 2020 at 8:40 AM Dmitry Torokhov > wrote: > > > > On Thu, Nov 12, 2020 at 11:01:57AM +, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/input/touchscreen/surface3_s

Re: [PATCH] HID: logitech-hidpp: Add PID for MX Anywhere 2

2020-10-22 Thread Peter Hutterer
resolution scrolling on > Logitech mice") > Signed-off-by: Harry Cutts Acked-by: Peter Hutterer we have the same PID for this device in libratbag so there must be some truth to it ;) Cheers, Peter > --- > > drivers/hid/hid-logitech-hidpp.c | 1 + > 1 file changed, 1

Re: INFO: task hung in corrupted (2)

2020-06-10 Thread Peter Hutterer
On Thu, Jun 04, 2020 at 01:41:07PM +0200, Jiri Kosina wrote: > On Tue, 2 Jun 2020, Andrey Konovalov wrote: > > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:b0c3ba31 Merge tag 'fsnotify_for_v5.7-rc8' of > > > git://git.ke.. > > > git tree: upstream

Re: [PATCH] input: API for Setting a Timestamp from a Driver

2019-07-12 Thread Peter Hutterer
On Fri, Jul 12, 2019 at 09:23:20AM +0200, Benjamin Tissoires wrote: > On Fri, Jul 12, 2019 at 8:41 AM Dmitry Torokhov > wrote: > > > > Hi Atif, > > > > On Wed, Jul 10, 2019 at 04:04:10PM -0700, Atif Niyaz wrote: > > > Currently, evdev stamps time with timestamps acquired in > > > evdev_events. How

Re: [PATCH v2 08/10] Input: elan_i2c - export true width/height

2019-05-29 Thread Peter Hutterer
On Wed, May 29, 2019 at 09:16:38AM +0200, Benjamin Tissoires wrote: > On Wed, May 29, 2019 at 2:12 AM Sean O'Brien wrote: > > > > We do still use a maxed out major axis as a signal for a palm in the > > touchscreen > > logic, but I'm not too concerned because if that axis is maxed out, the > > c

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-24 Thread Peter Hutterer
On Fri, May 24, 2019 at 06:43:58PM +0800, Hui Wang wrote: > > On 2019/5/24 下午5:37, Peter Hutterer wrote: > > On Fri, May 24, 2019 at 03:37:57PM +0800, Hui Wang wrote: > > > On 2019/5/24 下午3:26, Pali Rohár wrote: > > > > On Friday 24 May 2019 13:50:53 Hui Wang wro

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-24 Thread Peter Hutterer
On Fri, May 24, 2019 at 03:37:57PM +0800, Hui Wang wrote: > > On 2019/5/24 下午3:26, Pali Rohár wrote: > > On Friday 24 May 2019 13:50:53 Hui Wang wrote: > > > On 2019/5/24 下午1:36, Peter Hutterer wrote: > > > > On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wro

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-24 Thread Peter Hutterer
On Fri, May 24, 2019 at 09:26:48AM +0200, Pali Rohár wrote: > On Friday 24 May 2019 13:50:53 Hui Wang wrote: > > On 2019/5/24 下午1:36, Peter Hutterer wrote: > > > On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: > > > > On 2019/5/23 下午2:01, Peter Hutterer w

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-23 Thread Peter Hutterer
On Fri, May 24, 2019 at 01:25:52PM +0800, Hui Wang wrote: > > On 2019/5/23 下午2:01, Peter Hutterer wrote: > > On Wed, May 22, 2019 at 09:40:30AM +0200, Pali Rohár wrote: > > > On Wednesday 22 May 2019 07:30:43 Xiaoxiao Liu wrote: > > > > Hi Pali, > &

Re: 答复: 答复: 答复: [PATCH] input: alps-fix the issue the special alps trackpoint do not work.

2019-05-22 Thread Peter Hutterer
hing which is configurable. Have you configured it > somehow? Also there is libinput project should handle these settings > more properly. > > Adding Peter Hutterer, maintainer of libinput to loop. I think he could > help with this problem. libinput has a quirk for a magic multip

Re: [PATCH] HID: fix A4Tech horizontal scrolling

2019-05-06 Thread Peter Hutterer
On Fri, May 03, 2019 at 01:59:23PM +0200, Benjamin Tissoires wrote: > Hi, > > On Fri, May 3, 2019 at 11:43 AM Igor Kushnir wrote: > > > > Hi Benjamin, > > > > On 5/3/19 10:36 AM, Benjamin Tissoires wrote: > > > Hi, > > > > > > On Thu, May 2, 2019 at 11:37 PM Błażej Szczygieł wrote: > > >> > > >>

Re: [PATCH v2] HID: fix A4Tech horizontal scrolling

2019-05-06 Thread Peter Hutterer
On Fri, May 03, 2019 at 10:28:36PM +0200, Błażej Szczygieł wrote: > Since recent high resolution scrolling changes the A4Tech driver must > check for the "REL_WHEEL_HI_RES" usage code. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203369 > Fixes: 2dc702c991e3774af9d7ce410eef410ca9e2357e ("

[PATCH] HID: logitech: Handle 0 scroll events for the m560

2019-03-19 Thread Peter Hutterer
hidpp_scroll_counter_handle_scroll() doesn't expect a 0-value scroll event, it gets interpreted as a negative scroll direction event. This can cause scroll direction resets and thus broken scrolling. Reported-and-tested-by: Aimo Metsälä Signed-off-by: Peter Hutterer --- drivers/hi

Re: [PATCH] Input: uinput - fix undefined behavior in uinput_validate_absinfo()

2019-01-14 Thread Peter Hutterer
7 @@ static int uinput_validate_absinfo(struct input_dev > > *dev, unsigned int code, > > return -EINVAL; > > } > > > > - if (abs->flat > max - min) { > > + if (check_sub_overflow(max, min, &range) && abs->flat >

Re: [PATCH] Input: elantech - Disable elan-i2c for P52 and P72

2018-12-18 Thread Peter Hutterer
gt; Fixes: df077237cf55 Input: elantech - detect new ICs and setup Host Notify > for them > > Cc: sta...@vger.kernel.org # v4.18+ > Signed-off-by: Benjamin Tissoires Acked-by: Peter Hutterer Cheers, Peter > --- > drivers/input/mouse/elantech.c | 18 -- >

[PATCH] Documentation: hid: fix wrong data structure reference for UHID_OUTPUT

2018-12-12 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Documentation/hid/uhid.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/hid/uhid.txt b/Documentation/hid/uhid.txt index c8656dd029a9..958fff945304 100644 --- a/Documentation/hid/uhid.txt +++ b/Documentation/hid/uhid.txt

Re: [PATCH] Input: restore EV_ABS ABS_RESERVED

2018-12-06 Thread Peter Hutterer
On Thu, Dec 06, 2018 at 10:24:11AM +0100, Benjamin Tissoires wrote: > On Thu, Dec 6, 2018 at 9:36 AM Martin Kepplinger > wrote: > > > > On 06.12.18 00:03, Peter Hutterer wrote: > > > ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of > >

[PATCH] Input: restore EV_ABS ABS_RESERVED

2018-12-05 Thread Peter Hutterer
ABS_RESERVED was added in d9ca1c990a7 and accidentally removed as part of ffe0e7cf290f5c9 when the high-resolution scrolling code was removed. Signed-off-by: Peter Hutterer --- include/uapi/linux/input-event-codes.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/uapi/linux

[PATCH v3 7/8] HID: logitech: Enable high-resolution scrolling on Logitech mice

2018-12-04 Thread Peter Hutterer
-logitech-hidpp.c and renamed accordingly. Signed-off-by: Harry Cutts Signed-off-by: Peter Hutterer --- Changes to v1: - get rid of the timer in favour of sched_clock() - drop storing the multiplier and calculate value on the fly Changes to v2: - m560 now has REL_HWHEEL_HI_RES (untested, I don&#

[PATCH v3 3/8] HID: core: process the Resolution Multiplier

2018-12-04 Thread Peter Hutterer
the multiplier has to be a fraction of 120 to work with Windows. Signed-off-by: Peter Hutterer --- Changes since v1, v2: - expanded the commit message with more detail drivers/hid/hid-core.c | 170 + include/linux/hid.h| 5 ++ 2 files changed, 175

[PATCH v3 8/8] HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice

2018-12-04 Thread Peter Hutterer
From: Harry Cutts Signed-off-by: Harry Cutts Reviewed-by: Benjamin Tissoires Signed-off-by: Peter Hutterer --- Changes to v1, v2: - reordered from 6/8 to 8/8 so the intermediate steps all build drivers/hid/hid-logitech-hidpp.c | 15 +-- 1 file changed, 5 insertions(+), 10

[PATCH v3 5/8] HID: logitech-hidpp: fix typo, hiddpp to hidpp

2018-12-04 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- Unchanged since v1 drivers/hid/hid-logitech-hidpp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 19cc980eebce..22b37a3844d1 100644 --- a/drivers/hid

[PATCH v3 2/8] HID: core: store the collections as a basic tree

2018-12-04 Thread Peter Hutterer
For each collection parsed, store a pointer to the parent collection (if any). This makes it a lot easier to look up which collection(s) any given item is part of Signed-off-by: Peter Hutterer --- No changes since v1 drivers/hid/hid-core.c | 4 include/linux/hid.h| 2 ++ 2 files

[PATCH v3 6/8] HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration"

2018-12-04 Thread Peter Hutterer
From: Harry Cutts "Scrolling acceleration" is a bit of a misnomer: it doesn't deal with acceleration at all. However, that's the name used in Logitech's spec, so I used it here. Signed-off-by: Harry Cutts Reviewed-by: Benjamin Tissoires Signed-off-by: Peter Huttere

[PATCH v3 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-12-04 Thread Peter Hutterer
hat is the one to be used. Potential side-effect: a device with a Resolution Multiplier applying to other Input items will have those items set to the logical max as well. This cannot easily be worked around but it is doubtful such devices exist. Signed-off-by: Peter Hutterer --- Changes since

[PATCH v3 0/8] HID: MS and Logitech high-resolution scroll wheel support

2018-12-04 Thread Peter Hutterer
itech mice HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice Peter Hutterer (5): Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES` HID: core: store the collections as a basic tree HID: core: process the Resolution Multiplier HID: input: use the

[PATCH v3 1/8] Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES`

2018-12-04 Thread Peter Hutterer
/previous-versions/windows/hardware/design/dn613912(v=vs.85) These new axes obsolete REL_WHEEL and REL_HWHEEL. The legacy axes are emulated by the kernel but the most accurate (and most granular) data is available through the new axes. Signed-off-by: Peter Hutterer --- No changes since v1

Re: [PATCH 0/8] HID: MS and Logitech high-resolution scroll wheel support

2018-11-28 Thread Peter Hutterer
On Wed, Nov 28, 2018 at 03:22:14PM -0800, Harry Cutts wrote: > On Wed, 21 Nov 2018 at 22:34, Peter Hutterer wrote: > > [snip] > > Devices tested: > > - Microsoft Comfort Optical Mouse 3000 > > - Microsoft Sculpt Ergonomic Mouse > > - Microsoft Surface mo

Re: [PATCH] Input: synaptics - Add PNP ID for ThinkPad P50 to SMBus

2018-11-27 Thread Peter Hutterer
ctly fine on here. > > Signed-off-by: Lyude Paul Acked-by: Peter Hutterer Cheers, Peter > --- > drivers/input/mouse/synaptics.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c > index 5e85f3cc

[PATCH v2 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-11-27 Thread Peter Hutterer
hat is the one to be used. Potential side-effect: a device with a Resolution Multiplier applying to other Input items will have those items set to the logical max as well. This cannot easily be worked around but it is doubtful such devices exist. Signed-off-by: Peter Hutterer --- Changes to

[PATCH v2 8/8] HID: logitech: Enable high-resolution scrolling on Logitech mice

2018-11-27 Thread Peter Hutterer
-logitech-hidpp.c and renamed accordingly. Signed-off-by: Harry Cutts Signed-off-by: Peter Hutterer --- Changes to v1: - get rid of the timer in favour of sched_clock() - drop storing the multiplier and calculate value on the fly drivers/hid/hid-logitech-hidpp.c | 292

Re: [PATCH 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-11-27 Thread Peter Hutterer
On Mon, Nov 26, 2018 at 06:30:04PM -0800, Linus Torvalds wrote: > On Thu, Nov 22, 2018 at 3:28 PM Peter Hutterer > wrote: > > > > The device sends hi-res values of 4, so it should end up as REL_WHEEL_HI_RES > > 30. We are getting 28 instead which doesn't add up to a

Re: [PATCH 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-11-22 Thread Peter Hutterer
On Thu, Nov 22, 2018 at 04:34:05PM +1000, Peter Hutterer wrote: > Windows uses a magic number of 120 for a wheel click. High-resolution > scroll wheels are supposed to use a fraction of 120 to signal smaller > scroll steps. This is implemented by the Resolution Multiplier in the > d

[PATCH 5/8] HID: logitech-hidpp: fix typo, hiddpp to hidpp

2018-11-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer --- drivers/hid/hid-logitech-hidpp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 19cc980eebce..22b37a3844d1 100644 --- a/drivers/hid/hid-logitech-hidpp.c

[PATCH 6/8] HID: logitech: Use LDJ_DEVICE macro for existing Logitech mice

2018-11-21 Thread Peter Hutterer
From: Harry Cutts Signed-off-by: Harry Cutts Reviewed-by: Benjamin Tissoires Signed-off-by: Peter Hutterer --- Unmodified, same as the reverted 3fe1d6bbcd1 drivers/hid/hid-logitech-hidpp.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/hid/hid

[PATCH 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-11-21 Thread Peter Hutterer
hat is the one to be used. Potential side-effect: a device with a Resolution Multiplier applying to other Input items will have those items set to the logical max as well. This cannot easily be worked around but it is doubtful such devices exist. Signed-off-by: Peter Hutterer --- drivers/h

[PATCH 8/8] HID: logitech: Enable high-resolution scrolling on Logitech mice

2018-11-21 Thread Peter Hutterer
-logitech-hidpp.c and renamed accordingly. Signed-off-by: Harry Cutts Signed-off-by: Peter Hutterer --- Changes to the previous version: - this is a squash of the commits above, splitting it up after all the changes was a tad difficult - this looks to be a logitech-specific requirement because

[PATCH 7/8] HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration"

2018-11-21 Thread Peter Hutterer
From: Harry Cutts "Scrolling acceleration" is a bit of a misnomer: it doesn't deal with acceleration at all. However, that's the name used in Logitech's spec, so I used it here. Signed-off-by: Harry Cutts Reviewed-by: Benjamin Tissoires Signed-off-by: Peter Hutterer

[PATCH 0/8] HID: MS and Logitech high-resolution scroll wheel support

2018-11-21 Thread Peter Hutterer
Use LDJ_DEVICE macro for existing Logitech mice HID: logitech: Add function to enable HID++ 1.0 "scrolling acceleration" HID: logitech: Enable high-resolution scrolling on Logitech mice Peter Hutterer (5): Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES` HID: cor

[PATCH 2/8] HID: core: store the collections as a basic tree

2018-11-21 Thread Peter Hutterer
For each collection parsed, store a pointer to the parent collection (if any). This makes it a lot easier to look up which collection(s) any given item is part of Signed-off-by: Peter Hutterer --- drivers/hid/hid-core.c | 4 include/linux/hid.h| 2 ++ 2 files changed, 6 insertions

[PATCH 3/8] HID: core: process the Resolution Multiplier

2018-11-21 Thread Peter Hutterer
heels where the multiplier has to be a fraction of 120 to work with Windows. Signed-off-by: Peter Hutterer --- drivers/hid/hid-core.c | 170 + include/linux/hid.h| 5 ++ 2 files changed, 175 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hi

[PATCH 1/8] Input: add `REL_WHEEL_HI_RES` and `REL_HWHEEL_HI_RES`

2018-11-21 Thread Peter Hutterer
the most accurate (and most granular) data is available through the new axes. Signed-off-by: Peter Hutterer --- Documentation/input/event-codes.rst| 21 - include/uapi/linux/input-event-codes.h | 2 ++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a

Re: Logitech high-resolution scrolling..

2018-10-29 Thread Peter Hutterer
approach and use the center-point for the trigger. This gives us a few events to slide and still do the right thing, and any direction change will reset anyway. Biggest drawback is that the first event after a direction change is triggered faster than the next event. Otherwise it feels correct to m

Re: [PATCH] Input: synaptics - avoid using uninitialized variable when probing

2018-10-18 Thread Peter Hutterer
ot use garbage on stack that just happen to be 0x47. > > Reported-by: syzbot+13cb3b01d0784e4ff...@syzkaller.appspotmail.com > Signed-off-by: Dmitry Torokhov doh, was just about to send out the same patch. Reviewed-by: Peter Hutterer Cheers, Peter > --- > drivers/input/mous

Re: [PATCH] [v3] HID: add support for Apple Magic Trackpad 2

2018-10-02 Thread Peter Hutterer
On Tue, Oct 02, 2018 at 03:39:31PM -0700, Sean O'Brien wrote: > On Mon, Oct 1, 2018 at 1:43 AM Benjamin Tissoires > wrote: > > > > [adding Peter, for the libinput question] > > > > On Fri, Sep 21, 2018 at 1:13 AM Sean O'Brien wrote: > > > > > > USB device > > > Vendor 05ac (Apple) > > >

[PATCH] Input: uinput - allow for max == min during input_absinfo validation

2018-09-17 Thread Peter Hutterer
These values are inclusive, so a range of 1 requires min == max. Signed-off-by: Peter Hutterer --- drivers/input/misc/uinput.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c index 96a887f33698..eb14ddf69346 100644

Re: [PATCH] Input: reserve 2 events code because of HID

2018-09-07 Thread Peter Hutterer
On Fri, Sep 07, 2018 at 10:51:15AM +0200, Benjamin Tissoires wrote: > From: Benjamin Tissoires > > Prior to commit 190d7f02ce8e ("HID: input: do not increment usages when > a duplicate is found") from the v4.18 kernel, HID used to shift the > event codes if a duplicate usage was found. This ended

Re: [PATCH v2 1/5] Add the `REL_WHEEL_HI_RES` event code

2018-09-03 Thread Peter Hutterer
On Thu, Aug 30, 2018 at 02:56:18PM -0700, Harry Cutts wrote: > This event code represents scroll reports from high-resolution wheels, > and will be used by future patches in this series. See the linux-input > "Reporting high-resolution scroll events" thread [0] for more details. > > [0]: https://w

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-24 Thread Peter Hutterer
On Tue, Jul 24, 2018 at 10:23:27AM +0200, Benjamin Tissoires wrote: > On Tue, Jul 24, 2018 at 12:34 AM Dmitry Torokhov > wrote: > > > > On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > > > From: Nick Dyer > > > > > > input_mt_report_slot_state() ignores the tool when the slot is close

Re: [PATCH v3 12/12] HID: multitouch: handle palm for touchscreens

2018-06-26 Thread Peter Hutterer
off in the > same report. > > Work around that by keeping the slot active for one frame where we report > MT_TOOL_PALM, and then synthesizing the release event in a separate frame. > frame > > Signed-off-by: Dmitry Torokhov > [rebased and new commit message] > Signed

Re: [PATCH v3 10/12] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-26 Thread Peter Hutterer
On Thu, Jun 21, 2018 at 02:09:06PM +0200, Benjamin Tissoires wrote: > From: Dmitry Torokhov > > According to Microsoft specification [1] for Precision Touchpads (and > Touchscreens) the devices use "confidence" reports to signal accidental > touches, or contacts that are "too large to be a finger

Re: [PATCH v3 01/12] input: add MT_TOOL_DIAL

2018-06-26 Thread Peter Hutterer
able to deal with FOO == MAX but there are some corner-cases that get more quirky. e.g. converting the string "SW_MAX" to value is 0xf, but 0xf to name is "SW_PEN_INSERTED". Compare that to "REL_MAX" -> 0xf -> "REL_MAX". I know this case needs to be handled etc but not having max as an already used value papers over some of the quirks needed. Either way, Reviewed-by: Peter Hutterer Cheers, Peter > > /* > * Values describing the status of a force-feedback effect > -- > 2.14.3 >

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
On Mon, Jun 04, 2018 at 04:28:01PM -0700, Dmitry Torokhov wrote: > On Tue, Jun 05, 2018 at 09:06:24AM +1000, Peter Hutterer wrote: > > On Mon, Jun 04, 2018 at 02:32:55PM -0700, Dmitry Torokhov wrote: > > > On Mon, Jun 04, 2018 at 10:59:16PM +0200, Benjamin Tissoires wrote: >

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
trying to support everything in a generic manner with the X drivers and it's a nightmare to maintain. libinput instead takes a use case and tries to make it sensible - but for that to work we need to know both the hardware and the use-cases. That's why tablet handling coming out of libinput

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-06-04 Thread Peter Hutterer
On Mon, Jun 04, 2018 at 02:19:44PM -0700, Dmitry Torokhov wrote: > On Mon, Jun 04, 2018 at 10:42:31PM +0200, Benjamin Tissoires wrote: > > On Mon, Jun 4, 2018 at 7:33 PM, Dmitry Torokhov > > wrote: > > > On Mon, Jun 04, 2018 at 03:18:12PM +0200, Benjamin Tissoires wrote: > > >> On Fri, Jun 1, 2018

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2018-05-30 Thread Peter Hutterer
Hi Dmitry, On Thu, Aug 10, 2017 at 05:44:59PM -0700, Dmitry Torokhov wrote: > According to Microsoft specification [1] for Precision Touchpads (and > Touchscreens) the devices use "confidence" reports to signal accidental > touches, or contacts that are "too large to be a finger". Instead of > sim

Re: [PATCH] HID: rmi: use HID_QUIRK_NO_INPUT_SYNC

2018-05-27 Thread Peter Hutterer
report and the rest > in a subsequent one. And this messes up user space. > > Link: https://bugs.freedesktop.org/show_bug.cgi?id=100436 > > Signed-off-by: Benjamin Tissoires > --- yes please! Acked-by: Peter Hutterer Cheers, Peter > > Hi, > > Oscar, do you

Re: [PATCH] Input: leds - fix out of bound access

2018-04-11 Thread Peter Hutterer
6] Write of size 8 at addr 88003377b2c0 by task > ckb-next-daemon/5128 > > This happens because we were writing to the led structure before making > sure that it exists. > > Reported-by: Tasos Sahanidis > Tested-by: Tasos Sahanidis > Cc: sta...@vger.kernel.org > Sig

Re: [PATCH 0/7] HID core and multitouch fixups

2018-03-21 Thread Peter Hutterer
time. > Patches 5..7 are cleanups I realized while trying to merge hid-multitouch > into hid-core, so that other drivers could reuse the hid-mt logic (but it's > not that easy I must confess). Series: Acked-by: Peter Hutterer Cheers, Peter > > Cheers, > Benj

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-02-18 Thread Peter Hutterer
On Sat, Feb 17, 2018 at 10:19:14PM +0100, Pavel Machek wrote: > Hi! > > > > > > So, do you mean to implement this "disable" action as ioctl for > > > > > particular /dev/input/event* device (instead of sysfs entry)? > > > > > > > > Yes, so the device can be powered down without the device node be

Re: ALPS Trackpoint & pressure

2018-02-08 Thread Peter Hutterer
On Fri, Feb 09, 2018 at 12:21:41AM +0100, Pali Rohár wrote: > On Tuesday 06 February 2018 10:29:47 Peter Hutterer wrote: > > On Mon, Feb 05, 2018 at 02:49:55PM -0800, Dmitry Torokhov wrote: > > > On Sun, Feb 04, 2018 at 04:08:39PM +0100, Pali Rohár wrote: > > > &

Re: ALPS Trackpoint & pressure

2018-02-05 Thread Peter Hutterer
On Mon, Feb 05, 2018 at 02:49:55PM -0800, Dmitry Torokhov wrote: > On Sun, Feb 04, 2018 at 04:08:39PM +0100, Pali Rohár wrote: > > Hi! Now playing again with trackpoint connected to ALPS rushmore > > touchpad and I'm seeking a nice feature. Via ALPS PS/2 protocol it > > reports pressure of trackpoi

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-01-08 Thread Peter Hutterer
On Wed, Jan 03, 2018 at 10:31:33AM +0100, Pali Rohár wrote: > On Wednesday 03 January 2018 02:47:29 Bastien Nocera wrote: > > On Tue, 2018-01-02 at 22:54 +0100, Pali Rohár wrote: > > > On Wednesday 04 January 2017 15:37:35 Bastien Nocera wrote: > > > > I don't doubt that the use cases should be cat

Re: [RFC PATCH] input: Add disable sysfs entry for every input device

2018-01-08 Thread Peter Hutterer
On Thu, Jan 05, 2017 at 01:48:08PM +0100, Pali Rohár wrote: > On Wednesday 04 January 2017 15:37:35 Bastien Nocera wrote: > > On Wed, 2017-01-04 at 09:43 +0200, Ivaylo Dimitrov wrote: > > > > > > On  3.01.2017 13:21, Bastien Nocera wrote: > > > > On Mon, 2017-01-02 at 18:09 +0100, Pali Rohár wrote

Re: [PATCH v4 0/4] Make input drivers y2038 safe

2017-12-13 Thread Peter Hutterer
e maintainer. > > The userspace library changes to libevdev, libuinput and mtdev > will be posted to the respective mailing groups for review. Acked-by: Peter Hutterer Cheers, Peter > Changes from v3: > * Updated uinput to support monotonic time only > * Addressed revi

Re: [PATCH v2 2/2] HID: input: do not increment usages when a duplicate is found

2017-12-10 Thread Peter Hutterer
ny > devices. > > I my headset case, the ABS_MISC axes are created because of some > proprietary usages, so we might not break that many devices. > > For backward compatibility, a quirk HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE > is created and can be applied to any device that

[PATCH] asus-wireless: send an EV_SYN/SYN_REPORT between state changes

2017-12-03 Thread Peter Hutterer
to only process the device state and SYN_REPORT time, so now the key event is lost. https://bugs.freedesktop.org/show_bug.cgi?id=104041 Signed-off-by: Peter Hutterer --- drivers/platform/x86/asus-wireless.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/asus-wireless.c

Re: [PATCH] HID: input: enable Totem on the Dell Canvas 27

2017-11-15 Thread Peter Hutterer
On Wed, Nov 15, 2017 at 02:42:40PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Sent: Wednesday, November 15, 2017 6:53 AM > > To: Dmitry Torokhov > > Cc

Re: [PATCH] HID: input: enable Totem on the Dell Canvas 27

2017-11-14 Thread Peter Hutterer
sorry, this one got stuck in my outbox. On Fri, Nov 10, 2017 at 11:26:35AM +0100, Benjamin Tissoires wrote: > The Dell Canvas 27 has a tool that can be put on the surface and acts > as a dial. The firmware processes the detection of the tool and forward > regular HID reports with X, Y, Azimuth, ro

Re: [RFC] HID: input: do not increment usages when a duplicate is found

2017-10-22 Thread Peter Hutterer
usage, it uses *_MISC. But there is something > else which increments the usage if the evdev code is already used. this sentence is a bit confusing, needs to be reworded. Acked-by: Peter Hutterer Cheers, Peter > This leads to few issues: > - some devices may have their ABS_X mapped

Re: [PATCH v4] HID: hid-multitouch: support fine-grain orientation reporting

2017-10-11 Thread Peter Hutterer
On Wed, Oct 11, 2017 at 10:43:24PM +0200, Henrik Rydberg wrote: > > > > , but I'd go for fixing the documentation. And re-reading it, it's not > > > > clear that the doc tells us to have [0,90]. It mentions negative values > > > > and out of ranges too, so we might just as well simply clarify tha

Re: [PATCH 1/2] HID: multitouch: report MT_TOOL_PALM for non-confident touches

2017-08-17 Thread Peter Hutterer
sorry, was at a conference/travelling and I'm slowly catching up. On Fri, Aug 11, 2017 at 10:29:07AM +0200, Henrik Rydberg wrote: > Hi Dmitry, > > > The meaning of confidence is literally "contact is too large to be a > > finger", so it is not touch state, but really tool identity. We do > > allo

Re: [PATCH] Revert "HID: magicmouse: Set multi-touch keybits for Magic Mouse"

2017-06-20 Thread Peter Hutterer
On Thu, Jun 15, 2017 at 01:35:50PM +0100, Daniel Stone wrote: > Setting these bits causes libinput to fail to initialize the device; > setting BTN_TOUCH and BTN_TOOL_FINGER causes it to treat the mouse as a > touchpad, and it then refuses to continue when it discovers ABS_X is not > set. What happ

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-15 Thread Peter Hutterer
On Thu, Jun 15, 2017 at 07:33:58AM +, Zheng, Lv wrote: > Hi, Peter > > > From: Peter Hutterer [mailto:peter.hutte...@who-t.net] > > Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID > > switch exported by ACPI > > > > On Thu, Jun 15,

Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID switch exported by ACPI

2017-06-14 Thread Peter Hutterer
On Thu, Jun 15, 2017 at 02:52:57AM +, Zheng, Lv wrote: > Hi, Benjamin > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Subject: Re: [systemd-devel] [WIP PATCH 0/4] Rework the unreliable LID > > switch exported by ACPI > > > > Hi, > > > > [Sorry for the delay, I have

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-06-09 Thread Peter Hutterer
On Fri, Jun 09, 2017 at 01:39:53PM +0200, Michal Suchánek wrote: > On Thu, 8 Jun 2017 16:18:28 -0700 > Dmitry Torokhov wrote: > > > On Thu, Jun 8, 2017 at 4:07 PM, Peter Hutterer > > wrote: > > > On Thu, Jun 08, 2017 at 03:18:42PM +0200, Michal Suchánek wrote

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-06-08 Thread Peter Hutterer
On Thu, Jun 08, 2017 at 03:18:42PM +0200, Michal Suchánek wrote: > This is what evtest reports about my keyboard: > > Select the device event number [0-12]: 2 > Input driver version is 1.0.1 > Input device ID: bus 0x3 vendor 0x413c product 0x2107 version 0x111 > Input device name: "DELL Dell USB E

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-06-07 Thread Peter Hutterer
On Wed, Jun 07, 2017 at 09:17:37PM +0200, Michal Suchánek wrote: > On Wed, 7 Jun 2017 10:16:22 -0700 > Dmitry Torokhov wrote: > > > On Wed, Jun 07, 2017 at 06:53:51PM +0200, Michal Suchánek wrote: > > > On Sun, 28 May 2017 10:55:40 -0700 > > > Dmitry Torokhov wrote: > > > > > > > On Sun, May

Re: [WIP PATCH 2/4] ACPI: button: remove the LID input node when the state is unknown

2017-06-06 Thread Peter Hutterer
On Tue, Jun 06, 2017 at 12:22:09PM +0200, Benjamin Tissoires wrote: [...] > > This is because the aml table puts many Notify(LID, 0x80) in various > > control methods. > > And not one of them but multiple of them will be invoked by various OS > > drivers during suspend/resume period. > > I think

Re: [PATCH] macintosh: move mac_hid driver to input/mouse.

2017-05-30 Thread Peter Hutterer
n > > > > libinput, it should be available in X.org directly, and you will > > > > be saved. > > > > > > Not everything uses libinput. So no, using libinput is not the > > > answer. > > > > If you do not want to upgrade and use the lat

Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open"

2017-05-26 Thread Peter Hutterer
On May 25 2017, Benjamin Tissoires wrote: > On May 15 2017 or thereabouts, Rafael J. Wysocki wrote: > > >> >> Benjamin, my understanding is that this is the case, is it correct? > > >> > > > >> > That is correct. This patch I reverted introduces regression for > > >> > professional > > >> > lapto

RE: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open"

2017-05-17 Thread Peter Hutterer
Hi Lv > > Yes, it's called a quirk. And the good practice is to register those > > quirks and make them available to everybody. Being in hwdb in user space > > or in acpi/button in kernel space doesn't matter, we need them. > > I have no objections but concerns related to the combination of "defa

Re: Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-28 Thread Peter Hutterer
On Tue, Mar 28, 2017 at 06:50:44PM -0700, Andrew Duggan wrote: > On 03/19/2017 10:00 PM, Peter Hutterer wrote: > > On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote: > > > On 03/17/2017 09:57 AM, Benjamin Tissoires wrote: > > > > On Wed, Mar 15,

Re: [PATCH v4] Documentation: Input: Add uinput documentation

2017-03-27 Thread Peter Hutterer
On Mon, Mar 27, 2017 at 09:01:19PM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > > v3 -> v4: > Add comment and a sleep call before UI_DEV_DESTROY (requested by Peter) > On emit function, add an fd parameter, avoiding global variables > Check return of ioct

Re: [PATCH v3] Documentation: Input: Add uinput documentation

2017-03-26 Thread Peter Hutterer
On Sun, Mar 26, 2017 at 01:48:12PM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > v2 -> v3: > Changes in libevdev's description (suggested by Peter) > Added uinput version check when using the old interface (suggested by Peter) > Removed section numbers from

Re: [PATCH v2] Documentation: Input: Add uinput documentation

2017-03-26 Thread Peter Hutterer
On Sun, Mar 26, 2017 at 01:21:14PM -0300, Marcos Paulo de Souza wrote: > On Fri, Mar 24, 2017 at 02:39:13PM +1000, Peter Hutterer wrote: > > as usual, reading through these things multiple times means one spots a > > couple of different things. sorry about that. > > > >

Re: [PATCH v2] Documentation: Input: Add uinput documentation

2017-03-23 Thread Peter Hutterer
as usual, reading through these things multiple times means one spots a couple of different things. sorry about that. On Fri, Mar 24, 2017 at 12:34:59AM -0300, Marcos Paulo de Souza wrote: > Signed-off-by: Marcos Paulo de Souza > --- > Documentation/input/uinput.rst | 196 >

Re: [PATCH] Documentation: Input: Add uinput documentation

2017-03-22 Thread Peter Hutterer
just two comments below: > On Wed, Mar 22, 2017 at 02:03:31PM +1000, Peter Hutterer wrote: [...] > > > +memset(&ie, 0, sizeof(ie)); > > > +ie.type = type; > > > +ie.code = code; > > > +ie.value = val; > > > + >

Re: [PATCH] Documentation: Input: Add uinput documentation

2017-03-21 Thread Peter Hutterer
Thanks for this, I'm getting enough questions about this, so it's nice to have a link :) First comment: I don't think rst requires unwrapped lines, so please break those up. Second comment: I'd really like to have a link to libevdev here. It has a uinput interface that's a bit more obvious and ta

Re: [PATCH] Input: synaptics-rmi4 - Report slot as inactive when contact is a palm

2017-03-19 Thread Peter Hutterer
On Thu, Mar 16, 2017 at 05:52:07PM -0700, Andrew Duggan wrote: > On 03/16/2017 05:04 PM, Dmitry Torokhov wrote: > > On Thu, Mar 16, 2017 at 04:56:31PM -0700, Andrew Duggan wrote: > > > When the firmware identifies a contact as a palm the driver sets the tool > > > type to MT_TOOL_PALM, but sets the

Re: Synaptics RMI4 touchpad regression in 4.11-rc1

2017-03-19 Thread Peter Hutterer
On Fri, Mar 17, 2017 at 12:23:36PM -0700, Andrew Duggan wrote: > On 03/17/2017 09:57 AM, Benjamin Tissoires wrote: > > On Wed, Mar 15, 2017 at 2:19 AM, Andrew Duggan > > wrote: > > > On 03/13/2017 10:10 PM, Cameron Gutman wrote: > > > > > > > > On 03/13/2017 06:35 PM, Andrew Duggan wrote: > > >

Re: [PATCH] Input: synaptics-rmi4 - Report slot as inactive when contact is a palm

2017-03-16 Thread Peter Hutterer
On Thu, Mar 16, 2017 at 05:04:50PM -0700, Dmitry Torokhov wrote: > On Thu, Mar 16, 2017 at 04:56:31PM -0700, Andrew Duggan wrote: > > When the firmware identifies a contact as a palm the driver sets the tool > > type to MT_TOOL_PALM, but sets the slot state as active. Reporting the > > palm as acti

Re: [GIT PULL] HID for 4.11

2017-02-28 Thread Peter Hutterer
On Tue, Feb 28, 2017 at 06:31:10PM -0800, Andrew Duggan wrote: > On 02/28/2017 04:56 PM, Linus Torvalds wrote: > > On Mon, Feb 20, 2017 at 8:37 PM, Linus Torvalds > > wrote: > > > Yeah, so enabling HID_RMI makes my touchpad work again. > > .. so I just noticed something: it works subtly differentl

Re: [PATCH] Input: mousedev - stop offering PS/2 to userspace by default

2016-12-29 Thread Peter Hutterer
On 30/12/2016 04:07 , Dmitry Torokhov wrote: Evdev interface has been available for many years and by now everyone is switched to using it, so let's stop offering /dev/input/mouseN and /dev/psaux by default. Signed-off-by: Dmitry Torokhov Acked-by: Peter Hutterer Cheers,

  1   2   >