Re: [PATCH v2 3/3] thermal/core: Remove ms based delay fields

2020-12-16 Thread Peter Kästle
; Signed-off-by: Daniel Lezcano > Reviewed-by: Lukasz Luba > --- > drivers/platform/x86/acerhdf.c | 3 ++- Reviewed-by: Peter Kästle > drivers/thermal/da9062-thermal.c | 4 ++-- > drivers/thermal/gov_power_allocator.c | 2 +- > drivers/thermal/thermal_core.c | 4 +--- > dr

Re: [PATCH v2 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-03 Thread Peter Kästle
3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: > Currently the code checks the interval value when the temperature is > read which is bad for two reasons: > > - checking and setting the interval in the get_temp callback is > inaccurate and awful, that can be done when changing the value. > >

Re: [PATCH v2 1/2] platform/x86/drivers/acerhdf: Use module_param_cb to set/get polling interval

2020-12-03 Thread Peter Kästle
3. Dezember 2020 08:17, "Daniel Lezcano" schrieb: > The module parameter can be set by using ops to get and set the > values. The change will allow to check the correctness of the interval > value everytime it is changed instead of checking in the get_temp > function. > > Signed-off-by: Daniel L

Re: [PATCH 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set

2020-12-02 Thread Peter Kästle
2. Dezember 2020 23:22, "Daniel Lezcano" schrieb: > Currently the code checks the interval value when the temperature is > read which is bad for two reasons: > > - checking and setting the interval in the get_temp callback is > inaccurate and awful, that can be done when changing the value. > >