I executed a clone detection tool* on drivers source code and I found
that there are similar files between drivers/gpu/drm/amd/ and
drivers/gpu/drm/radeon, but also inside each of theses folders.
Some examples:
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c,drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
I executed a clone detection tool* on drivers source code and I found
that the files
drivers/usb/host/fusbh200-hcd.c
and
drivers/usb/host/fotg210-hcd.c
are very similar. The main difference between the two files are
replacing the string 'USBH20' by 'OTG21' and some white space fixes.
Some
I executed a clone detection tool* on drivers source code and I found
that the files
drivers/usb/host/fusbh200-hcd.c
and
drivers/usb/host/fotg210-hcd.c
are very similar. The main difference between the two files are
replacing the string 'USBH20' by 'OTG21' and some white space fixes.
Some
I executed a clone detection tool* on drivers source code and I found
that there are similar files between drivers/gpu/drm/amd/ and
drivers/gpu/drm/radeon, but also inside each of theses folders.
Some examples:
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c,drivers/gpu/drm/amd/amdgpu/dce_v10_0.c
Remove unneeded semicolon.
The semantic patch that detects this change is available
at scripts/coccinelle/misc/semicolon.cocci.
Signed-off-by: Peter Senna Tschudin
---
Tested by cross compilation only.
drivers/s390/block/dasd_alias.c | 6 +++---
drivers/s390/char/monreader.c | 2 +-
drivers
This patch remove unneeded variables used to store return values.
These issues were detected with the Coccinelle script:
scripts/coccinelle/misc/returnvar.cocci
Signed-off-by: Peter Senna Tschudin
---
Tested by cross compilation only.
drivers/s390/cio/eadm_sch.c | 3 +--
drivers/s390/net
This patch remove unneeded variables used to store return values.
These issues were detected with the Coccinelle script:
scripts/coccinelle/misc/returnvar.cocci
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by cross compilation only.
drivers/s390/cio/eadm_sch.c | 3
Remove unneeded semicolon.
The semantic patch that detects this change is available
at scripts/coccinelle/misc/semicolon.cocci.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by cross compilation only.
drivers/s390/block/dasd_alias.c | 6 +++---
drivers/s390/char
.
gf_write_dma_addr() was added to handle dma_addr_t values which is
used at drivers/staging/goldfish/goldfish_audio.c.
Signed-off-by: Dan Carpenter
Signed-off-by: Peter Senna Tschudin
---
When submiting V5, I havent tested the patch properly. It was
my fault. Tested by compilation only for i386
.
gf_write_dma_addr() was added to handle dma_addr_t values which is
used at drivers/staging/goldfish/goldfish_audio.c.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
When submiting V5, I havent tested the patch properly. It was
my fault
.
gf_write_dma_addr() was added to handle dma_addr_t values which is
used at drivers/staging/goldfish/goldfish_audio.c.
Signed-off-by: Dan Carpenter
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only for x86 and for x86_64.
Changes from V4:
- Added the function gf_write_dma_addr()
- Changed
.
gf_write_dma_addr() was added to handle dma_addr_t values which is
used at drivers/staging/goldfish/goldfish_audio.c.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by compilation only for x86 and for x86_64.
Changes from V4:
- Added
On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox wrote:
> On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote:
>> On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote:
>> > On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote:
>> > > Actually, my patch seems like a good idea to me but it's
On Fri, Apr 17, 2015 at 4:10 PM, Alan Cox a...@linux.intel.com wrote:
On Fri, 2015-04-17 at 16:59 +0300, Dan Carpenter wrote:
On Fri, Apr 17, 2015 at 02:31:49PM +0100, Alan Cox wrote:
On Fri, 2015-04-17 at 11:20 +0300, Dan Carpenter wrote:
Actually, my patch seems like a good idea to me
On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox wrote:
> On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote:
>> On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote:
>> > On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin
>> > wrote:
>> &
-by: Peter Senna Tschudin
---
Tested by compilation only for x86, x86 with CONFIG_X86_PAE=y, and
for x86_64.
Changes from V3:
- Changed type of first argument of gf_write64
- Renamed from gf_write64 to gf_write_ptr
- Updated all calls to gf_write_ptr
Changes from V2:
- Fixed spelling
-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by compilation only for x86, x86 with CONFIG_X86_PAE=y, and
for x86_64.
Changes from V3:
- Changed type of first argument of gf_write64
- Renamed from gf_write64 to gf_write_ptr
- Updated all calls to gf_write_ptr
Changes from V2
On Thu, Apr 16, 2015 at 7:05 PM, Alan Cox a...@linux.intel.com wrote:
On Thu, 2015-04-16 at 20:01 +0300, Dan Carpenter wrote:
On Thu, Apr 16, 2015 at 06:14:55PM +0200, Geert Uytterhoeven wrote:
On Thu, Apr 16, 2015 at 3:39 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote
gt;
> On Mon, Apr 13, 2015 at 1:14 PM, Peter Senna Tschudin
> wrote:
>>> Perhaps checkpatch should complain about casts outside header files?
>> Cocinelle found 664 double casts:
>> http://pastebin.com/2bi9Dg7k
>>
>> and 9 triple casts:
>> http://paste
On Sun, Apr 12, 2015 at 5:38 PM, Geert Uytterhoeven
wrote:
> On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin
> wrote:
>> On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven
>> wrote:
>>> On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin
>>> wrote:
On Mon, Apr 13, 2015 at 11:10 AM, Dan Carpenter
wrote:
> On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote:
>> Sparse compalins about casting void * to u64 on i386.
>> Change the cast to resource_size_t.
>>
>> Signed-off-by: Peter Senna Ts
On Mon, Apr 13, 2015 at 11:10 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote:
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Signed-off-by: Peter Senna Tschudin peter.se
On Sun, Apr 12, 2015 at 5:38 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna
Peter,
On Mon, Apr 13, 2015 at 1:14 PM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Perhaps checkpatch should complain about casts outside header files?
Cocinelle found 664 double casts:
http://pastebin.com/2bi9Dg7k
and 9 triple casts:
http://pastebin.com/RkJhPTTV
I think double
On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven
wrote:
> On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin
> wrote:
>> Sparse compalins about casting void * to u64 on i386.
>> Change the cast to resource_size_t.
>>
>> Signed-off-by: Peter Senna
Sparse complains about casting void * to u64 on i386.
Change the cast to resource_size_t.
Also update the type of the first argument of gf_write64()
from unsigned long to resource_size_t.
Signed-off-by: Peter Senna Tschudin
---
Changes from V2:
- Fixed spelling of complains
- Updated commit
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Also update the gf_write64 function definition changing
the first argument type from unsigned long data to
resource_size_t.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Updated commit
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only. Tested for x86 and x86_64.
drivers/staging/goldfish/goldfish_nand.c | 3 ++-
include/linux/goldfish.h | 2 +-
2 files
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Also update the gf_write64 function definition changing
the first argument type from unsigned long data to
resource_size_t.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by compilation only. Tested for x86 and x86_64.
drivers/staging/goldfish/goldfish_nand.c | 3 ++-
include/linux/goldfish.h
Sparse complains about casting void * to u64 on i386.
Change the cast to resource_size_t.
Also update the type of the first argument of gf_write64()
from unsigned long to resource_size_t.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V2:
- Fixed spelling
On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven
ge...@linux-m68k.org wrote:
On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Sparse compalins about casting void * to u64 on i386.
Change the cast to resource_size_t.
Signed-off-by: Peter Senna Tschudin
sparse was complaining that the symbols 'lstcon_console_init'
and 'lstcon_console_fini' were not declared.
Declaring both as static.
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/lustre/lnet/selftest/console.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
On my test environment the throughput of a file transfer drops
from 4.4MBps to 116KBps due the number of repeated warning
messages. This patch removes the warning messages as DMA works
correctly with addresses using 0xC000 bits.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1
On my test environment the throughput of a file transfer drops
from 4.4MBps to 116KBps due the number of repeated warning
messages. This patch removes the warning messages.
Signed-off-by: Peter Senna Tschudin
---
Changes from: bgmac: ratelimit warning messages
- Remove the messages instead
On Sat, Mar 7, 2015 at 12:27 AM, Rafał Miłecki wrote:
> On 6 March 2015 at 19:17, Peter Senna Tschudin wrote:
>> On my test environment the troughput of a file transfer drops from
>> 4.4Mbps to 116Kbps due the number of repeated warning messages.
>> Adding printk_ratelim
On my test environment the throughput of a file transfer drops
from 4.4MBps to 116KBps due the number of repeated warning
messages. This patch removes the warning messages as DMA works
correctly with addresses using 0xC000 bits.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
On my test environment the throughput of a file transfer drops
from 4.4MBps to 116KBps due the number of repeated warning
messages. This patch removes the warning messages.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from: bgmac: ratelimit warning messages
- Remove
sparse was complaining that the symbols 'lstcon_console_init'
and 'lstcon_console_fini' were not declared.
Declaring both as static.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/lustre/lnet/selftest/console.c | 6 ++
1 file changed, 2 insertions(+), 4
On Sat, Mar 7, 2015 at 12:27 AM, Rafał Miłecki zaj...@gmail.com wrote:
On 6 March 2015 at 19:17, Peter Senna Tschudin peter.se...@gmail.com wrote:
On my test environment the troughput of a file transfer drops from
4.4Mbps to 116Kbps due the number of repeated warning messages.
Adding
On my test environment the troughput of a file transfer drops from
4.4Mbps to 116Kbps due the number of repeated warning messages.
Adding printk_ratelimit() solves the issue without removing the
warning message.
Signed-off-by: Peter Senna Tschudin
---
drivers/net/ethernet/broadcom/bgmac.c | 6
On my test environment the troughput of a file transfer drops from
4.4Mbps to 116Kbps due the number of repeated warning messages.
Adding printk_ratelimit() solves the issue without removing the
warning message.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/ethernet
sparse was complaining that symbol 'vgamode' was not declared.
Declaring vgamode as static.
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xx.h b
sparse was complaining that symbol 'vgamode' was not declared.
Declaring vgamode as static.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by compilation only
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
I have a dirty and ugly Perl script that return source files for a
given set of Kconfig symbols:
https://gist.github.com/petersenna/6329591
On Thu, Oct 30, 2014 at 7:16 AM, Julia Lawall wrote:
>
>
> On Wed, 29 Oct 2014, Luis R. Rodriguez wrote:
>
>> On Wed, Oct 29, 2014 at 4:15 PM, Luis R.
I have a dirty and ugly Perl script that return source files for a
given set of Kconfig symbols:
https://gist.github.com/petersenna/6329591
On Thu, Oct 30, 2014 at 7:16 AM, Julia Lawall julia.law...@lip6.fr wrote:
On Wed, 29 Oct 2014, Luis R. Rodriguez wrote:
On Wed, Oct 29, 2014 at 4:15
= 0,
PHY_TYPE_11B,
PHY_TYPE_11G,
PHY_TYPE_11A
} CARD_PHY_TYPE, *PCARD_PHY_TYPE;
The following typedefs were removed, but enums were kept at device.h:
typedef enum __device_msg_level
typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V5
- Refresh for staging-next of 16/07/2014
drivers/staging/vt6656/main_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V5
- Refresh for staging-next of 16/07/2014
drivers/staging/vt6656/main_usb.c | 3 ++-
1 file changed, 2 insertions
= 0,
PHY_TYPE_11B,
PHY_TYPE_11G,
PHY_TYPE_11A
} CARD_PHY_TYPE, *PCARD_PHY_TYPE;
The following typedefs were removed, but enums were kept at device.h:
typedef enum __device_msg_level
typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
OOPS on 3.16.0-rc5-next-20140715
[ 74.423074] BUG: unable to handle kernel NULL pointer dereference at
0028
[ 74.425506] IP: [] blk_throtl_drain+0x28/0x110
[ 74.426276] PGD 0
[ 74.426931] Oops: [#1] SMP
[ 74.427596] Modules linked in: usb_storage rfcomm fuse
This patch cleanup the follwoing coding style issues:
- indentation style
- new line after declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/main_usb.c | 36
This patch cleanup coding style issues on comments.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/baseband.c | 15 ---
drivers/staging/vt6656/card.c | 4 ++--
drivers
This patch cleanup coding style issues on #defines.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/card.h | 6 +++---
drivers/staging/vt6656/device.h | 10 +-
drivers
This patch cleanup the follwoing coding style issues:
- line over 80 chars
- spaces on the beginning of a line
- put { and } on the correct places
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers
Use tabs instead of spaces in a set of statements and fix lines
over 80 chars. Reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V4:
- Fix identation issue found on V4
drivers/staging/vt6656/main_usb.c | 44
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V4:
- use dev_warn instead of pr_warn
drivers/staging/vt6656/main_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On Tue, Jul 15, 2014 at 5:06 PM, Greg KH wrote:
> On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
>> This patch removes uneeded typedefs reported by chackpatch and removes
>> one enum. The removed enum from card.h:
>>
>> typedef enum _CARD_PHY_TYPE
On Tue, Jul 15, 2014 at 5:06 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote:
This patch removes uneeded typedefs reported by chackpatch and removes
one enum. The removed enum from card.h:
typedef enum _CARD_PHY_TYPE
This patch fixes a checkpatch warning by replacing printk
by dev_warn. Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- use dev_warn instead of pr_warn
drivers/staging/vt6656/main_usb.c | 3 ++-
1 file changed, 2 insertions(+), 1
Use tabs instead of spaces in a set of statements and fix lines
over 80 chars. Reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V4:
- Fix identation issue found on V4
drivers/staging/vt6656/main_usb.c | 44
This patch cleanup coding style issues on #defines.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/card.h | 6 +++---
drivers/staging/vt6656/device.h | 10
This patch cleanup the follwoing coding style issues:
- line over 80 chars
- spaces on the beginning of a line
- put { and } on the correct places
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller
This patch cleanup coding style issues on comments.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/baseband.c | 15 ---
drivers/staging/vt6656/card.c
This patch cleanup the follwoing coding style issues:
- indentation style
- new line after declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V4:
- Splitted [PATCH V4 1/6] in 4 smaller patches
drivers/staging/vt6656/main_usb.c
OOPS on 3.16.0-rc5-next-20140715
[ 74.423074] BUG: unable to handle kernel NULL pointer dereference at
0028
[ 74.425506] IP: [8141f168] blk_throtl_drain+0x28/0x110
[ 74.426276] PGD 0
[ 74.426931] Oops: [#1] SMP
[ 74.427596] Modules linked in: usb_storage
This patch cleanup a checkpatch warning by removing double parentheses
from if condition. Additionally it fixes a line over 80 chars.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/baseband.c
This patch remove uneeded return statements reported by checkpatch
and fixes the indentation of a multi-line call.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/card.c | 6 +-
drivers
, but enums were kept at device.h:
typedef enum __device_msg_level
typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/card.h | 7 ---
drivers/staging/vt6656/device.h
Use tabs instead of spaces in a set of statements and fix lines
over 80 chars. Reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 44
This patch fixes a checkpatch warning by replacing printk by pr_warn.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/baseband.c | 23 ---
drivers/staging/vt6656/card.c | 13 +
drivers/staging/vt6656/card.h | 6 ++--
drivers
way, I may as well give you
> the normal feedback for these kinds of patches.
>
>> >From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001
>> From: Peter Senna Tschudin
>> Date: Mon, 14 Jul 2014 10:28:42 +0200
>> Subject: [PATCH V3] staging:
On Mon, Jul 14, 2014 at 2:58 PM, Greg KH wrote:
> On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
>> On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
>> > On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
>> > > T
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
> On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
> > This patch cleanup coding style issues reported by checkpatch.
> >
> > Tested by compilation only.
> >
> > Signed-off-by: Peter Se
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
On Mon, Jul 14, 2014 at 2:58 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup
going to redo this patch anyway, I may as well give you
the normal feedback for these kinds of patches.
From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001
From: Peter Senna Tschudin peter.se...@gmail.com
Date: Mon, 14 Jul 2014 10:28:42 +0200
Subject: [PATCH V3] staging
declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/baseband.c | 23 ---
drivers/staging/vt6656/card.c | 13 +
drivers/staging/vt6656/card.h
This patch fixes a checkpatch warning by replacing printk by pr_warn.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1
Use tabs instead of spaces in a set of statements and fix lines
over 80 chars. Reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 44
This patch cleanup a checkpatch warning by removing double parentheses
from if condition. Additionally it fixes a line over 80 chars.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers
This patch remove uneeded return statements reported by checkpatch
and fixes the indentation of a multi-line call.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/card.c
, but enums were kept at device.h:
typedef enum __device_msg_level
typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/card.h | 7 ---
drivers
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/main_usb.c | 118
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/baseband.c | 28
1 file
-by: Peter Senna Tschudin
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/card.c | 19 ---
drivers/staging/vt6656/card.h | 13 +++--
2 files changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers
This patch cleanup coding style issues reported by checkpatch.
This patch change the following enums:
- typedef enum __device_msg_level
- typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Cahnges from V1:
- Sent all patches in a series
This patch cleanup coding style issues reported by checkpatch.
This patch change the following enums:
- typedef enum __device_msg_level
- typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Made against latest staging-next.
drivers/staging
-by: Peter Senna Tschudin
---
Done against latest staging-next.
drivers/staging/vt6656/card.c | 19 ---
drivers/staging/vt6656/card.h | 13 +++--
2 files changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Based on latest staging-next.
drivers/staging/vt6656/main_usb.c | 118 +-
1 file changed, 54 insertions(+), 64 deletions
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Based on latests staging-next.
drivers/staging/vt6656/baseband.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Based on latests staging-next.
drivers/staging/vt6656/baseband.c | 28
1 file changed, 16 insertions(+), 12
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Based on latest staging-next.
drivers/staging/vt6656/main_usb.c | 118 +-
1 file changed, 54 insertions
-by: Peter Senna Tschudin peter.se...@gmail.com
---
Done against latest staging-next.
drivers/staging/vt6656/card.c | 19 ---
drivers/staging/vt6656/card.h | 13 +++--
2 files changed, 11 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers
This patch cleanup coding style issues reported by checkpatch.
This patch change the following enums:
- typedef enum __device_msg_level
- typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Made against latest staging
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/baseband.c | 28
-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/card.c | 19 ---
drivers/staging/vt6656/card.h | 13 +++--
2 files changed, 11 insertions(+), 21 deletions(-)
diff
This patch cleanup coding style issues reported by checkpatch.
This patch change the following enums:
- typedef enum __device_msg_level
- typedef enum __DEVICE_NDIS_STATUS
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V1:
- Sent all
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V1:
- Sent all patches in a series
Made against latest staging-next.
drivers/staging/vt6656/main_usb.c | 118
401 - 500 of 1112 matches
Mail list logo
