This patch fixes the following checkpatch warnings:
- Remove else after return
- Add space after declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/android/sync_debug.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git
This patch fixes the following checkpatch warnings:
- Remove else after return
- Add space after declaration
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/android/sync_debug.c | 11 ---
1 file changed, 8 insertions(+), 3
out
> another guy who has key 160 unknown and was planning on putting up a patch
> for that.
>
>
> On 06/01/2014 06:02 AM, Peter Senna Tschudin wrote:
>>
>> Hi,
>>
>> I'm using:
>>
>> 3.15.0-rc7-next-20140530
>>
>> On a:
>>
? I'm helping out
another guy who has key 160 unknown and was planning on putting up a patch
for that.
On 06/01/2014 06:02 AM, Peter Senna Tschudin wrote:
Hi,
I'm using:
3.15.0-rc7-next-20140530
On a:
Toshiba R830-10p
And dmesg started to show:
toshiba_acpi: Unknown key 14b
This semantic patch looks for variables that are initialized with a
constant, are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Move the comment about coverage and acceptance
-off-by: Peter Senna Tschudin
---
scripts/coccinelle/misc/returnvar.cocci | 66 +
1 file changed, 66 insertions(+)
create mode 100644 scripts/coccinelle/misc/returnvar.cocci
diff --git a/scripts/coccinelle/misc/returnvar.cocci
b/scripts/coccinelle/misc
.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
//
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V2:
- added #define IBM_DONGLE_ID 9
Hi,
I'm using:
3.15.0-rc7-next-20140530
On a:
Toshiba R830-10p
And dmesg started to show:
toshiba_acpi: Unknown key 14b
toshiba_acpi: Unknown key 14d
How can I help make this useful?
--
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Hi,
I'm using:
3.15.0-rc7-next-20140530
On a:
Toshiba R830-10p
And dmesg started to show:
toshiba_acpi: Unknown key 14b
toshiba_acpi: Unknown key 14d
How can I help make this useful?
--
Peter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
.
Verified by compilation only.
The coccinelle script that find and fixes this issue is:
// smpl
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V2:
- added
-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
scripts/coccinelle/misc/returnvar.cocci | 66 +
1 file changed, 66 insertions(+)
create mode 100644 scripts/coccinelle/misc/returnvar.cocci
diff --git a/scripts/coccinelle/misc/returnvar.cocci
b/scripts
This semantic patch looks for variables that are initialized with a
constant, are never updated, and are only used as parameter of return.
Return the constant instead of using a variable.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Move the comment about
On Sat, May 31, 2014 at 6:17 PM, Sergei Shtylyov
wrote:
> Hello.
>
>
> On 05/31/2014 05:14 PM, Peter Senna Tschudin wrote:
>
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Ret
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Do not remove comment after the definition of return variable
drivers/media/pci/ngene/ngene-core.c | 11 ++-
drivers/media/usb/cx231xx
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Moved comment about return value to near the return value
drivers/net/irda/via-ircc.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions
On Sat, May 31, 2014 at 12:17 PM, walter harms wrote:
>
>
> Am 31.05.2014 15:14, schrieb Peter Senna Tschudin:
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Return the constant
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Keep commented code instead of removing it
drivers/net/wireless/cw1200/sta.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions
On Sat, May 31, 2014 at 11:58 AM, Johan Hovold wrote:
> On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote:
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Return
This patch remove the function klsi_105_tiocmset which was only
returning -EINVAL. It also removes the function prototype and
the .tiocmset entry in the struct usb_serial_driver.
Verified by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- remove the function
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/usb/serial/kl5kusb105.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/scsi/isci/request.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/isci/request.c b/drivers/scsi/isci/request.c
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/wireless/cw1200/sta.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/net/wireless/cw1200/sta.c
b/drivers/net
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/irda/via-ircc.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c
index
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/media/usb/usbvision/usbvision-core.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/media/usb/usbvision/usbvision
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/media/pci/ngene/ngene-core.c | 11 ++-
drivers/media/usb/cx231xx/cx231xx-video.c | 11 +--
2 files changed, 7 insertions(+), 15 deletions
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ethernet/neterion
this issue is:
//
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 18 ++
drivers/net/wireless/brcm80211/brcmsmac/phy/phy_cmn.c
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/scsi/bfa/bfad_bsg.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/bfa/bfad_bsg.c b/drivers/scsi/bfa/bfad_bsg.c
index
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 12 +++-
drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 12 +++-
drivers/net/ethernet/intel/igb
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/ethernet/intel/i40e/i40e_adminq.c | 12 +++-
drivers/net/ethernet/intel/i40evf/i40e_adminq.c | 12 +++-
drivers
this issue is:
// smpl
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 18 ++
drivers/net/wireless
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/scsi/bfa/bfad_bsg.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/scsi/bfa/bfad_bsg.c b
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/pci/ngene/ngene-core.c | 11 ++-
drivers/media/usb/cx231xx/cx231xx-video.c | 11 +--
2 files changed, 7
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/ethernet/neterion/vxge/vxge-config.c | 22 +++---
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/media/usb/usbvision/usbvision-core.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/wireless/cw1200/sta.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/net/wireless
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/scsi/isci/request.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/isci/request.c b
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/net/irda/via-ircc.c |9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/irda/via-ircc.c b/drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/usb/serial/kl5kusb105.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/usb/serial
This patch remove the function klsi_105_tiocmset which was only
returning -EINVAL. It also removes the function prototype and
the .tiocmset entry in the struct usb_serial_driver.
Verified by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1
On Sat, May 31, 2014 at 11:58 AM, Johan Hovold jhov...@gmail.com wrote:
On Sat, May 31, 2014 at 10:14:01AM -0300, Peter Senna Tschudin wrote:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Keep commented code instead of removing it
drivers/net/wireless/cw1200/sta.c | 19 +--
1 file changed, 1
On Sat, May 31, 2014 at 12:17 PM, walter harms wha...@bfs.de wrote:
Am 31.05.2014 15:14, schrieb Peter Senna Tschudin:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return the constant instead of using
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Moved comment about return value to near the return value
drivers/net/irda/via-ircc.c |9 +++--
1 file changed, 3
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Do not remove comment after the definition of return variable
drivers/media/pci/ngene/ngene-core.c | 11
On Sat, May 31, 2014 at 6:17 PM, Sergei Shtylyov
sergei.shtyl...@cogentembedded.com wrote:
Hello.
On 05/31/2014 05:14 PM, Peter Senna Tschudin wrote:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V2:
- Refreshed for staging/staging-next
drivers/staging/bcm/Bcmchar.c |3 +--
drivers/staging/bcm/InterfaceIdleMode.c
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V2:
- Refreshed for staging/staging-next
drivers/staging/bcm/Bcmchar.c |3 +--
drivers/staging/bcm
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
//
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Updated semantic patch
- Refreshed for next-20140523
drivers/staging/bcm/Bcmchar.c |3 +--
drivers/staging/bcm
;
identifier ret;
@@
- T ret = C;
... when != ret
when strict
return
- ret
+ C
;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Updated semantic patch
- Refreshed for next-20140523
drivers/staging/bcm/Bcmchar.c |3
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/wlags49_h2/wl_priv.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wlags49_h2/wl_priv.c
b/drivers/staging
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/ft1000/ft1000-usb/ft1000_download.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_download.c
b
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/et131x/et131x.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 15e0f4d
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/bcm/Bcmchar.c |3 +--
drivers/staging/bcm/InterfaceIdleMode.c |3 +--
drivers/staging/bcm/PHSModule.c
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/rtl8712/ieee80211.c|8 ++--
drivers/staging/rtl8712/rtl8712_cmd.c |3 -
drivers/staging/rtl8712/rtl8712_recv.c |7 +---
drivers/staging
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/vt6655/hostap.c | 10 --
drivers/staging/vt6655/wpactl.c | 19 ++-
2 files changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/ozwpan/ozhcd.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
//
Signed-off-by: Peter Senna Tschudin
---
drivers/staging/media/as102/as102_usb_drv.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/as102/as102_usb_drv.c
b/drivers/staging
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/media/as102/as102_usb_drv.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/as102
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/vt6655/hostap.c | 10 --
drivers/staging/vt6655/wpactl.c | 19 ++-
2 files changed, 10 insertions(+), 19
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/ozwpan/ozhcd.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/bcm/Bcmchar.c |3 +--
drivers/staging/bcm/InterfaceIdleMode.c |3 +--
drivers
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/rtl8712/ieee80211.c|8 ++--
drivers/staging/rtl8712/rtl8712_cmd.c |3 -
drivers/staging/rtl8712/rtl8712_recv.c
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/et131x/et131x.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/ft1000/ft1000-usb/ft1000_download.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000
;
identifier ret;
@@
- T ret = C;
... when != ret
- return ret;
+ return C;
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/staging/wlags49_h2/wl_priv.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/wlags49_h2
;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Convert printk(KERN_WARNING ... to pr_warn(...
drivers/atm/idt77252.c | 8
1 file changed, 4 insertions(+), 4
;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Convert printk(KERN_WARNING ... to pr_warn(...
drivers/atm/idt77252.c | 8
1
Added CC: triv...@vger.kernel.org
On Sun, May 18, 2014 at 7:04 AM, Andi Kleen wrote:
> Peter Senna Tschudin writes:
>
>> This patch remove variables that are initialized with a constant,
>> are never updated, and are only used as parameter of return.
>> Return the c
Added CC: triv...@vger.kernel.org
On Sun, May 18, 2014 at 7:04 AM, Andi Kleen a...@firstfloor.org wrote:
Peter Senna Tschudin peter.se...@gmail.com writes:
This patch remove variables that are initialized with a constant,
are never updated, and are only used as parameter of return.
Return
On Sat, May 17, 2014 at 11:56 PM, Dan Carpenter
wrote:
> On Sat, May 17, 2014 at 11:34:46PM +0200, Peter Senna Tschudin wrote:
>> On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
>> wrote:
>> > On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
>&g
;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Untested.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Replaced break with a return
- Return 0 instead of ret on success
tools/power/cpupower/utils/cpufreq
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from V1:
- Replaced break with a return
- On success return 0 instead of status
drivers/infiniband/hw/ocrdma/ocrdma_hw.c |6
On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
wrote:
> On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
>> diff --git a/tools/power/cpupower/utils/cpufreq-set.c
>> b/tools/power/cpupower/utils/cpufreq-set.c
>> index a416de8..4e2f35a 100644
>>
is as follows:
//
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
Changes from
;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/atm/idt77252.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/atm/idt77252.c b
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/misc/vmw_vmci/vmci_context.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/vmw_vmci/vmci_context.c
b
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Untested.
Signed-off-by: Peter Senna Tschudin
---
tools/power/cpupower/utils/cpufreq-set.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/power/cpupower/utils/cpufreq-set.c
b/tools
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
//
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c |6 +++---
drivers/infiniband/ulp/srpt/ib_srpt.c|8
2 files changed, 7 insertions(+), 7
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Untested.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
tools/power/cpupower/utils/cpufreq-set.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tools/power/cpupower
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c |6 +++---
drivers/infiniband/ulp/srpt/ib_srpt.c|8
2 files
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/misc/vmw_vmci/vmci_context.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers
;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
drivers/atm/idt77252.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
is as follows:
// smpl
@@
expression E; identifier pr; expression list es;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se
On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin wrote:
diff --git a/tools/power/cpupower/utils/cpufreq-set.c
b/tools/power/cpupower/utils/cpufreq-set.c
index a416de8..4e2f35a 100644
--- a/tools
){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Replaced break with a return
- On success return 0 instead of status
drivers/infiniband/hw/ocrdma
;
@@
for(...;...;...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// /smpl
Untested.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Changes from V1:
- Replaced break with a return
- Return 0 instead of ret on success
On Sat, May 17, 2014 at 11:56 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Sat, May 17, 2014 at 11:34:46PM +0200, Peter Senna Tschudin wrote:
On Sat, May 17, 2014 at 10:22 PM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Sat, May 17, 2014 at 08:22:58PM +0200, Peter Senna Tschudin
Hi,
I'm being blamed for some bugs for more than one year, and this
weekend I was able to reproduce the error for the first time. I have
the impression that the issue is related to Kconfig because when
compiling the Kernel for x86(not x86_64), and
when:
CONFIG_VIDEO_CX23885=y
and
Hi,
I'm being blamed for some bugs for more than one year, and this
weekend I was able to reproduce the error for the first time. I have
the impression that the issue is related to Kconfig because when
compiling the Kernel for x86(not x86_64), and
when:
CONFIG_VIDEO_CX23885=y
and
When Fedora updated the Kernel package from 3.12 to 3.13 my notebook
stopped booting (Kernel freezes) when a 2560 x 1440 high res monitor
is attached. I have tried using 3.13.6 from kernel.org and the problem
persists. The problem can be partially solved by passing nomodeset to
Kernel which will
When Fedora updated the Kernel package from 3.12 to 3.13 my notebook
stopped booting (Kernel freezes) when a 2560 x 1440 high res monitor
is attached. I have tried using 3.13.6 from kernel.org and the problem
persists. The problem can be partially solved by passing nomodeset to
Kernel which will
On Wed, Mar 19, 2014 at 1:02 PM, Bernd Petrovitsch
wrote:
> On Die, 2014-03-18 at 22:11 +0100, Peter Senna Tschudin wrote:
>> The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
>> for opportunities to replace a call to memcpy by a struct assignment.
>&g
On Wed, Mar 19, 2014 at 1:02 PM, Bernd Petrovitsch
be...@petrovitsch.priv.at wrote:
On Die, 2014-03-18 at 22:11 +0100, Peter Senna Tschudin wrote:
The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
for opportunities to replace a call to memcpy by a struct assignment
The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look
for opportunities to replace a call to memcpy by a struct assignment.
This patch removes memcpy-assign.cocci as it is not clear that this
convention has an impact on the generated code.
Signed-off-by: Peter Senna Tschudin
)
//
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_main.c
b/drivers/net/ethernet/intel/igb/igb_main.c
index 340a344..fc49177
)
//
Signed-off-by: Peter Senna Tschudin
---
Tested by compilation only.
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
b/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
index
)
// /smpl
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Tested by compilation only.
drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c
b/drivers/net/ethernet
501 - 600 of 1112 matches
Mail list logo
