[PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 2/4] drivers/crypto/hifn_795x.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

Re: [PATCH v3 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-17 Thread Peter Senna Tschudin
Please ignore this patch. On Fri, Sep 14, 2012 at 5:13 PM, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Remove useless kfree() and clean up code related to the removal. > > The semantic patch that finds this problem is as follows: > (http://coccinelle.lip6

Re: [PATCH v2 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-17 Thread Peter Senna Tschudin
> As I already applid your first patch, care to just send an incremental > patch that makes the change you did here? I've just sent a patch for that: [PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc -- Peter -- To unsubscribe from this list: send the line

[PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc

2012-09-17 Thread Peter Senna Tschudin
Replace kmalloc+memset for kzalloc and cleanup related code. To be applied after 47ad3428a1086af425447f763705e06b16ae905d: [PATCH 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree Signed-off-by: Peter Senna Tschudin --- drivers/staging/gdm72xx/gdm_sdio.c | 6 ++ 1 file changed

[PATCH v2 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

Re: [PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
On Mon, Sep 17, 2012 at 11:54 AM, Seungwon Jeon wrote: > On Monday, September 17, 2012, Peter Senna Tschudin > wrote: >> From: Peter Senna Tschudin >> >> Convert a nonnegative error return code to a negative one, as returned >> elsewhere in the functi

[PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 4/4] drivers/mmc/host/mxs-mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 2/4] drivers/mmc/host/omap.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH] drivers/rapidio/devices/tsi721.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 1/2] drivers/s390/char/monreader.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 2/2] drivers/s390/net/ctcm_main.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return

[PATCH 2/3] cx25821: Replace kmemdup for kstrdup and clean up

2012-09-17 Thread Peter Senna Tschudin
Replace kmemdup for kstrdup and cleanup related code. Signed-off-by: Peter Senna Tschudin --- drivers/media/pci/cx25821/cx25821-audio-upstream.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/pci/cx25821/cx25821-audio-upstream.c b/drivers/media

[PATCH 1/3] cx25821: fix error return code and clean up

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin The function cx25821_sram_channel_setup_upstream_audio always return zero, so the return value is not saved any more. Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match

[PATCH 3/3] cx25821: Cleanup filename assignment code

2012-09-17 Thread Peter Senna Tschudin
GFP_KERNEL); else dev->_audiofilename = kstrdup(_defaultAudioName, GFP_KERNEL); if (!dev->_audiofilename) { err = -ENOMEM; goto error; } Signed-off-by: Peter Senna Tschudin --- driver

[PATCH 3/3] cx25821: Cleanup filename assignment code

2012-09-17 Thread Peter Senna Tschudin
(_defaultAudioName, GFP_KERNEL); if (!dev-_audiofilename) { err = -ENOMEM; goto error; } Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/pci/cx25821/cx25821-audio-upstream.c | 21 ++--- 1 file changed, 6

[PATCH 1/3] cx25821: fix error return code and clean up

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com The function cx25821_sram_channel_setup_upstream_audio always return zero, so the return value is not saved any more. Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version

[PATCH 2/3] cx25821: Replace kmemdup for kstrdup and clean up

2012-09-17 Thread Peter Senna Tschudin
Replace kmemdup for kstrdup and cleanup related code. Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/media/pci/cx25821/cx25821-audio-upstream.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/media/pci/cx25821/cx25821-audio

[PATCH 2/2] drivers/s390/net/ctcm_main.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 1/2] drivers/s390/char/monreader.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH] drivers/rapidio/devices/tsi721.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 2/4] drivers/mmc/host/omap.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 4/4] drivers/mmc/host/mxs-mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 3/4] drivers/mmc/host/omap_hsmmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

Re: [PATCH 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
On Mon, Sep 17, 2012 at 11:54 AM, Seungwon Jeon tgih@samsung.com wrote: On Monday, September 17, 2012, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere

[PATCH v2 1/4] drivers/mmc/host/dw_mmc.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc

2012-09-17 Thread Peter Senna Tschudin
Replace kmalloc+memset for kzalloc and cleanup related code. To be applied after 47ad3428a1086af425447f763705e06b16ae905d: [PATCH 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/staging/gdm72xx/gdm_sdio.c | 6

Re: [PATCH v2 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-17 Thread Peter Senna Tschudin
As I already applid your first patch, care to just send an incremental patch that makes the change you did here? I've just sent a patch for that: [PATCH] drivers/staging/gdm72xx/gdm_sdio.c: Replace kmalloc+memset for kzalloc -- Peter -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-17 Thread Peter Senna Tschudin
Please ignore this patch. On Fri, Sep 14, 2012 at 5:13 PM, Peter Senna Tschudin peter.se...@gmail.com wrote: From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http

[PATCH 2/4] drivers/crypto/hifn_795x.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 1/4] drivers/crypto/ux500/cryp/cryp_core.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 4/4] drivers/crypto/tegra-aes.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH 3/4] drivers/crypto/amcc/crypto4xx_core.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH] drivers/virtio/virtio_pci.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH] drivers/target/target_core_configfs.c: fix error return code

2012-09-17 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Convert a nonnegative error return code to a negative one, as returned elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl ( if@p1 (\(ret 0\|ret != 0

[PATCH] drivers/media/platform/davinci/vpbe.c: Remove unused label and rename remaining labels

2012-09-14 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove unused label and rename remaining labels Signed-off-by: Peter Senna Tschudin --- Depends on patch [v2,7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree() - http://patchwork.linuxtv.org/patch/14307/ drivers/media/platform/davinci/vpbe.c

[PATCH v3 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-14 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

Re: [PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

2012-09-14 Thread Peter Senna Tschudin
On Thu, Sep 13, 2012 at 4:42 PM, Dan Carpenter wrote: > On Thu, Sep 13, 2012 at 04:13:07PM +0200, walter harms wrote: >> > diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c >> > index 5461faa..cbb0521 100644 >> > --- a/drivers/block/aoe/aoecmd.c >> > +++

Re: [PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

2012-09-14 Thread Peter Senna Tschudin
On Thu, Sep 13, 2012 at 4:42 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Sep 13, 2012 at 04:13:07PM +0200, walter harms wrote: diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c index 5461faa..cbb0521 100644 --- a/drivers/block/aoe/aoecmd.c +++

[PATCH v3 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-14 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH] drivers/media/platform/davinci/vpbe.c: Remove unused label and rename remaining labels

2012-09-14 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove unused label and rename remaining labels Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- Depends on patch [v2,7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree() - http://patchwork.linuxtv.org/patch/14307

Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree

2012-09-13 Thread Peter Senna Tschudin
> Seems to me that (assuming kfree(NULL) is ok) the kfree() > is best left in - just in case some other error path is > added after drv->cs is assigned. > Better safe than a memory leak. I'm not sure if I got your point. Now the label "error:" is only reached if drv->cs is NULL. There is not

Re: [PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree

2012-09-13 Thread Peter Senna Tschudin
Seems to me that (assuming kfree(NULL) is ok) the kfree() is best left in - just in case some other error path is added after drv-cs is assigned. Better safe than a memory leak. I'm not sure if I got your point. Now the label error: is only reached if drv-cs is NULL. There is not other way to

[PATCH 7/15] drivers/s390/net: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/s390/net/ctcm_fsms.c |2 +- drivers/s390/net/qeth_core_main.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 4/15] drivers/sbus/char: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/sbus/char/display7seg.c |2 +- drivers/sbus/char/envctrl.c |8 drivers/sbus/char/openprom.c|4 ++-- 3 files

[PATCH 5/15] arch/sparc/kernel/pci_sun4v.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- arch/sparc/kernel/pci_sun4v.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/kernel/pci_sun4v.c b/arch/sparc

[PATCH 6/15] drivers/scsi/pmcraid.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/pmcraid.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c

[PATCH 8/15] drivers/scsi: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/ibmvscsi/ibmvfc.c | 36 ++-- drivers/scsi/ibmvscsi/ibmvstgt.c |2 +- drivers/scsi/qlogicpti.c

[PATCH 9/15] arch/arm/mach-s3c24xx/mach-h1940.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- arch/arm/mach-s3c24xx/mach-h1940.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/mach-h1940.c b

[PATCH 10/15] drivers/usb/host/xhci-ring.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/usb/host/xhci-ring.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb

[PATCH 11/15] drivers/char: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/char/nwbutton.c |4 ++-- drivers/char/rtc.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH 12/15] fs/notify/inotify/inotify_fsnotify.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- fs/notify/inotify/inotify_fsnotify.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/notify/inotify/inotify_fsnotify.c

[PATCH 14/15] fs/jffs2/wbuf.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- fs/jffs2/wbuf.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c index a6597d6..bea0487

[PATCH 13/15] drivers/usb/misc/rio500.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/usb/misc/rio500.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/rio500.c b/drivers/usb/misc

[PATCH 15/15] drivers/usb/host/sl811-hcd.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/usb/host/sl811-hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb

[PATCH 2/15] drivers/scsi/bfa: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/scsi/bfa/bfa_fcs_lport.c |2 +- drivers/scsi/bfa/bfa_fcs_rport.c |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/15] fs/dlm/rcom.c: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- fs/dlm/rcom.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dlm/rcom.c b/fs/dlm/rcom.c index 9d61947..73d3715 100644

[PATCH 3/15] drivers/rtc: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin --- drivers/rtc/rtc-isl12022.c |2 +- drivers/rtc/rtc-pcf8563.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
Marcos, > Now that you removed this kfree, you could remove this label too. Very > nice your cleanup :) Thanks! > >> vpbe_fail_sd_register: >> kfree(vpbe_dev->encoders); >> vpbe_fail_v4l2_device: The problem removing the label is that it will require some more work naming the labels.

[PATCH 2/9] block/blk-tag.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 6/9] drivers/staging/rtl8192u/r8192U_core.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 7/9] drivers/char/mmtimer.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 3/9] drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 6/8] drivers/media/dvb-frontends/tda665x.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 5/8] drivers/media/dvb-frontends/stb6100.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 4/8] drivers/media/dvb-frontends/s921.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 1/8] drivers/media/dvb-frontends/dvb_dummy_fe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 3/8] drivers/media/dvb-frontends/s5h1432.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 2/8] drivers/media/dvb-frontends/lg2160.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

[PATCH v2 8/8] drivers/media/tuners/mt2063.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x); ... return ...; } @unchanged

Re: [PATCH] drivers/media: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
I'll split this patch in one patch for file and resend. On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter wrote: > On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote: >> diff --git a/drivers/media/dvb-frontends/lg2160.c >> b/drivers/media/dvb-frontends/lg2160.c &

Re: [PATCH] drivers/media: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
I'll split this patch in one patch for file and resend. On Wed, Sep 12, 2012 at 10:06 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Sep 11, 2012 at 08:00:32PM +0200, Peter Senna Tschudin wrote: diff --git a/drivers/media/dvb-frontends/lg2160.c b/drivers/media/dvb-frontends/lg2160

[PATCH v2 8/8] drivers/media/tuners/mt2063.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 2/8] drivers/media/dvb-frontends/lg2160.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 3/8] drivers/media/dvb-frontends/s5h1432.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 1/8] drivers/media/dvb-frontends/dvb_dummy_fe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 4/8] drivers/media/dvb-frontends/s921.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 5/8] drivers/media/dvb-frontends/stb6100.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 6/8] drivers/media/dvb-frontends/tda665x.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 1/9] drivers/block/aoe/aoecmd.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 3/9] drivers/gpu/drm/ttm/ttm_page_alloc_dma.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 9/9] drivers/isdn/gigaset/common.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 8/9] sound/soc/soc-core.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 5/9] drivers/staging/gdm72xx/gdm_sdio.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 7/9] drivers/char/mmtimer.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 6/9] drivers/staging/rtl8192u/r8192U_core.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 4/9] drivers/hwmon/asus_atk0110.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

[PATCH 2/9] block/blk-tag.c: Remove useless kfree

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com Remove useless kfree() and clean up code related to the removal. The semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @r exists@ position p1,p2; expression x; @@ if (x@p1 == NULL) { ... kfree@p2(x

Re: [PATCH v2 7/8] drivers/media/platform/davinci/vpbe.c: Removes useless kfree()

2012-09-12 Thread Peter Senna Tschudin
Marcos, Now that you removed this kfree, you could remove this label too. Very nice your cleanup :) Thanks! vpbe_fail_sd_register: kfree(vpbe_dev-encoders); vpbe_fail_v4l2_device: The problem removing the label is that it will require some more work naming the labels. See: if

[PATCH 3/15] drivers/rtc: removes unnecessary semicolon

2012-09-12 Thread Peter Senna Tschudin
From: Peter Senna Tschudin peter.se...@gmail.com removes unnecessary semicolon Found by Coccinelle: http://coccinelle.lip6.fr/ Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com --- drivers/rtc/rtc-isl12022.c |2 +- drivers/rtc/rtc-pcf8563.c |2 +- 2 files changed, 2

<    5   6   7   8   9   10   11   12   >