Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-23 Thread Philip Chen
Hi maintainers, Are there any other concerns I should address for this patch? On Mon, Sep 9, 2024 at 4:52 PM Philip Chen wrote: > > Hi > > On Wed, Sep 4, 2024 at 10:54 AM Ira Weiny wrote: > > > > Philip Chen wrote: > > > Hi maintainers, > > > > &

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-09-09 Thread Philip Chen
Hi On Wed, Sep 4, 2024 at 10:54 AM Ira Weiny wrote: > > Philip Chen wrote: > > Hi maintainers, > > > > Can anyone let me know if this patch makes sense? > > Any comment/feedback is appreciated. > > Thanks in advance! > > I'm not an expert on vir

[PATCH v3] virtio_pmem: Check device status before requesting flush

2024-08-26 Thread Philip Chen
If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. So add a status check in the beginning of virtio_pmem_flush() to return early if the device is not activated. Signed-off-by: Philip Chen --- v3: - Fix a typo

Re: [PATCH] virtio_pmem: Add freeze/restore callbacks

2024-08-23 Thread Philip Chen
Hi maintainers, Can anyone let me know if this patch makes sense? Any comment/feedback is appreciated. Thanks in advance! On Wed, Aug 14, 2024 at 5:46 PM Philip Chen wrote: > > Add basic freeze/restore PM callbacks to support hibernation (S4): > - On freeze, delete vq and quiesce the

Re: [PATCH v2] virtio_pmem: Check device status before requesting flush

2024-08-21 Thread Philip Chen
Hi On Wed, Aug 21, 2024 at 1:37 PM Ira Weiny wrote: > > Philip Chen wrote: > > Hi, > > > > On Tue, Aug 20, 2024 at 1:01 PM Dave Jiang wrote: > > > > > > > > > > > > On 8/20/24 10:22 AM, Philip Chen wrote: > > > > If a pme

Re: [PATCH v2] virtio_pmem: Check device status before requesting flush

2024-08-20 Thread Philip Chen
Hi, On Tue, Aug 20, 2024 at 1:01 PM Dave Jiang wrote: > > > > On 8/20/24 10:22 AM, Philip Chen wrote: > > If a pmem device is in a bad status, the driver side could wait for > > host ack forever in virtio_pmem_flush(), causing the system to hang. > > > > So ad

Re: [PATCH] virtio_pmem: Check device status before requesting flush

2024-08-20 Thread Philip Chen
Hi, On Tue, Aug 20, 2024 at 7:23 AM Ira Weiny wrote: > > Philip Chen wrote: > > On Mon, Aug 19, 2024 at 2:56 PM Ira Weiny wrote: > > > > > > Philip Chen wrote: > > > > If a pmem device is in a bad status, the driver side could wait for > > >

[PATCH v2] virtio_pmem: Check device status before requesting flush

2024-08-20 Thread Philip Chen
If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. So add a status check in the beginning of virtio_pmem_flush() to return early if the device is not activated. Signed-off-by: Philip Chen --- v2: - Remove

Re: [PATCH] virtio_pmem: Check device status before requesting flush

2024-08-19 Thread Philip Chen
On Mon, Aug 19, 2024 at 2:56 PM Ira Weiny wrote: > > Philip Chen wrote: > > If a pmem device is in a bad status, the driver side could wait for > > host ack forever in virtio_pmem_flush(), causing the system to hang. > > I assume this was supposed to be v2 and you re

[PATCH v2] virtio_pmem: Check device status before requesting flush

2024-08-14 Thread Philip Chen
If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. Signed-off-by: Philip Chen --- Change since v1: - Remove change id from the patch description drivers/nvdimm/nd_virtio.c | 9 + 1 file changed, 9

[PATCH] virtio_pmem: Check device status before requesting flush

2024-08-14 Thread Philip Chen
If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. Signed-off-by: Philip Chen --- drivers/nvdimm/nd_virtio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/nvdimm/nd_virtio.c b/drivers

[PATCH] virtio_pmem: Add freeze/restore callbacks

2024-08-14 Thread Philip Chen
Add basic freeze/restore PM callbacks to support hibernation (S4): - On freeze, delete vq and quiesce the device to prepare for snapshotting. - On restore, re-init vq and mark DRIVER_OK. Signed-off-by: Philip Chen --- drivers/nvdimm/virtio_pmem.c | 24 1 file changed

[PATCH] virtio_pmem: Check device status before requesting flush

2024-08-14 Thread Philip Chen
If a pmem device is in a bad status, the driver side could wait for host ack forever in virtio_pmem_flush(), causing the system to hang. Change-Id: Icc1d0a4405359fb5364751031589d15a455f849b Signed-off-by: Philip Chen --- drivers/nvdimm/nd_virtio.c | 9 + 1 file changed, 9 insertions

RE: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings

2021-03-16 Thread Li, Philip
> Subject: [kbuild-all] Re: [PATCH] wfx: fix irqf_oneshot.cocci warnings > > Hello, > > On Monday 15 March 2021 22:09:20 CET kernel test robot wrote: > > > > From: kernel test robot > > > > drivers/net/wireless/silabs/wfx/bus_sdio.c:134:8-33: ERROR: Threaded IRQ > > with no primary handler requ

Re: [PATCH mvebu v2 00/10] Armada 37xx: Fix cpufreq changing base CPU speed to 800 MHz from 1000 MHz

2021-02-22 Thread Philip Soares
Tested-by: Philip Soares On Mon, Feb 22, 2021, at 8:36 AM, nnet wrote: > > Could I add your Tested-by line to patch series? > > Yes, by: Philip Soares > > Thank you for the patches! >

Re: [PATCH v6 3/3] dt-bindings: input: Fix the keymap for LOCK key

2021-02-04 Thread Philip Chen
Hi maintainers, Friendly ping - can we actually land patch series v6? Or do you expect any update from me? On Fri, Jan 15, 2021 at 2:39 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-15 14:36:17) > > Decouple LOCK from F13 and directly map the LOCK key (KSI3/KSO9) to &

Re: [PATCH v7 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-02-04 Thread Philip Chen
Hi maintainers, Friendly ping - can we actually land patch series v7? Or do you expect any update from me? On Fri, Jan 15, 2021 at 12:34 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-15 12:24:30) > > The top-row keys in a keyboard usually have dual functionalities. > &g

Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help?

2021-02-02 Thread Philip Li
On Tue, Feb 02, 2021 at 04:48:04AM -0800, Joe Perches wrote: > On Mon, 2021-02-01 at 22:41 +0530, Dwaipayan Ray wrote: > > The idea of a bot seems nice though in general. > > People do have all the style checking scripts at their disposal, but still > > we see style issues on the list. > > > > Som

Re: [kbuild-all] aarch64-linux-gnu-ld: warning: orphan section `.eh_frame' from `kernel/trace/trace_recursion_record.o' being placed in section `.eh_frame'

2021-01-30 Thread Philip Li
On Sun, Jan 31, 2021 at 10:09:22AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 8c947645151cc2c279c75c7f640dd8f0fc0b9aa2 > commit: 773c16705058e9be7b0f4ce124e89cd231c120a2 ftrace: Add recording of > functions that

Re: [kbuild-all] aarch64-linux-gnu-ld: warning: orphan section `.eh_frame' from `drivers/tty/serial/liteuart.o' being placed in section `.eh_frame'

2021-01-30 Thread Philip Li
On Sun, Jan 31, 2021 at 11:36:33AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 6642d600b541b81931fb1ab0c041b0d68f77be7e > commit: 1da81e5562fac8286567422cc56a7fbd0dc646d4 drivers/tty/serial: add > LiteUART driver

Re: [PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap

2021-01-15 Thread Philip Chen
On Fri, Jan 15, 2021 at 2:38 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-15 14:36:15) > > In Chrome OS, the keyboard matrix can be split to two groups: > > > > The keymap for the top row keys can be customized based on OEM > > preference, while the keymap

[PATCH v6 3/3] dt-bindings: input: Fix the keymap for LOCK key

2021-01-15 Thread Philip Chen
Decouple LOCK from F13 and directly map the LOCK key (KSI3/KSO9) to KEY_SLEEP action key code. Signed-off-by: Philip Chen --- Changes in v6: - New patch in v6 include/dt-bindings/input/cros-ec-keyboard.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/dt

[PATCH v6 2/3] ARM: dts: cros-ec-keyboard: Use keymap macros

2021-01-15 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. This patch also creates an alias for keyboard-controller to make it easier to override the keymap in board-specific dts later. Signed-off-by: Philip Chen

[PATCH v6 1/3] dt-bindings: input: Create macros for cros-ec keymap

2021-01-15 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP include/dt-bindings/input/cros-ec-keyboard.h | 103

[PATCH v7 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-15 Thread Philip Chen
be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- (no changes since v6) Changes in v6: - add to Documentation/ABI - update cros_ec_keyb_register_matrix() to improve readability Changes in v5: - change the data type for a few loca

[PATCH v7 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-15 Thread Philip Chen
Add a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- Changes in v7: - Use MATRIX_KEY macro to describe `function-row-physmap` Changes

Re: [PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-15 Thread Philip Chen
On Thu, Jan 14, 2021 at 6:38 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-14 18:30:30) > > Add a new property `function-row-physmap` to the > > device tree for the custom keyboard top row design. > > > > The property describes the rows/columns of the top r

Re: [PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-14 Thread Philip Chen
On Wed, Jan 13, 2021 at 5:36 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-13 17:25:13) > > diff --git a/drivers/input/keyboard/cros_ec_keyb.c > > b/drivers/input/keyboard/cros_ec_keyb.c > > index b379ed7628781..273e3c9ba0b03 100644 > > --- a/drivers

[PATCH v6 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-14 Thread Philip Chen
be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- Changes in v6: - add to Documentation/ABI - update cros_ec_keyb_register_matrix() to improve readability Changes in v5: - change the data type for a few local variables - update function_ro

[PATCH v6 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-14 Thread Philip Chen
Add a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- Changes in v6: - remove $ref and add `function-row-physmap` to the example

Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-13 Thread Philip Chen
On Wed, Jan 13, 2021 at 5:39 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-13 17:29:05) > > On Wed, Jan 13, 2021 at 3:14 PM Stephen Boyd wrote: > > > > > > Quoting Philip Chen (2021-01-13 14:47:18) > > > > On Tue, Jan 12, 202

Re: [PATCH v5 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-13 Thread Philip Chen
On Wed, Jan 13, 2021 at 5:30 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-13 17:25:12) > > This patch adds a new property `function-row-physmap` to the > > :) Sorry, I'll make it imperative tense. > > > device tree for the custom keyboard top row design

[PATCH v5 1/2] dt-bindings: input: Create macros for cros-ec keymap

2021-01-13 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP include/dt-bindings/input/cros-ec-keyboard.h | 103

[PATCH v5 2/2] ARM: dts: cros-ec-keyboard: Use keymap macros

2021-01-13 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. This patch also creates an alias for keyboard-controller to make it easier to override the keymap in board-specific dts later. Signed-off-by: Philip Chen

Re: [PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-13 Thread Philip Chen
On Mon, Jan 11, 2021 at 6:07 PM Stephen Boyd wrote: > > BTW, subject says 'marcos' when it should say 'macros' Thanks - I fixed it in v5. > > Quoting Philip Chen (2021-01-08 17:23:32) > > The common cros-ec keymap has been defined as macros. This patch uses

Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-13 Thread Philip Chen
On Tue, Jan 12, 2021 at 10:49 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-12 15:55:28) > > On Mon, Jan 11, 2021 at 6:24 PM Stephen Boyd wrote: > > > > > > Quoting Philip Chen (2021-01-07 15:42:09) > > > > The top-row keys in a keyboard usua

Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-13 Thread Philip Chen
On Wed, Jan 13, 2021 at 3:14 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-13 14:47:18) > > On Tue, Jan 12, 2021 at 10:49 PM Stephen Boyd wrote: > > > > > > Quoting Philip Chen (2021-01-12 15:55:28) > > > > On Mon, Jan 11, 20

[PATCH v5 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-13 Thread Philip Chen
will only be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- Changes in v5: - change the data type for a few local variables - update function_row_physmap_show() and cros_ec_keyb_register_matrix() to improve readability/efficiency Chan

[PATCH v5 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-13 Thread Philip Chen
This patch adds a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- Changes in v5: - add minItems and maxItems for `function-row-physmap

Re: [PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-12 Thread Philip Chen
On Mon, Jan 11, 2021 at 6:24 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-07 15:42:09) > > The top-row keys in a keyboard usually have dual functionalities. > > E.g. A function key "F1" is also an action key "Browser back". > > > > The

Re: [PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-12 Thread Philip Chen
On Mon, Jan 11, 2021 at 6:10 PM Stephen Boyd wrote: > > Quoting Philip Chen (2021-01-07 15:42:08) > > This patch adds a new property `function-row-physmap` to the > > From Documentation/process/submitting-patches.rst > > Describe your changes in imperative mood, e

[PATCH v4 1/2] dt-bindings: input: Create macros for cros-ec keymap

2021-01-08 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP include/dt-bindings/input/cros-ec-keyboard.h | 103

[PATCH v4 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-08 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. This patch also creates an alias for keyboard-controller to make it easier to override the keymap in board-specific dts later. Signed-off-by: Philip Chen

[PATCH v3 1/2] dt-bindings: input: Create macros for cros-ec keymap

2021-01-08 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP include/dt-bindings/input/cros-ec-keyboard.h | 103

[PATCH v3 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-08 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. This patch also creates an alias for keyboard-controller to make it easier to override the keymap in board-specific dts later. Signed-off-by: Philip Chen

[PATCH v2 2/2] ARM: dts: cros-ec-keyboard: Use keymap marcos

2021-01-08 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. Signed-off-by: Philip Chen --- Changes in v2: - Replace CROS_STD_NON_TOP_ROW_KEYMAP with CROS_STD_MAIN_KEYMAP arch/arm/boot/dts/cros-ec-keyboard.dtsi | 91

[PATCH v2 1/2] dt-bindings: input: Create macros for cros-ec keymap

2021-01-08 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- Changes in v2: - Rename CROS_STD_NON_TOP_ROW_KEYMAP to CROS_STD_MAIN_KEYMAP include/dt-bindings/input/cros-ec-keyboard.h | 103 +++ 1 file

[PATCH 2/2] ARM: dts: cros-ec-keyboard: use keymap marcos

2021-01-08 Thread Philip Chen
The common cros-ec keymap has been defined as macros. This patch uses the macros to simply linux,keymap in cros-ec-keyboard.dtsi file. Signed-off-by: Philip Chen --- arch/arm/boot/dts/cros-ec-keyboard.dtsi | 91 + 1 file changed, 3 insertions(+), 88 deletions(-) diff

[PATCH 1/2] dt-bindings: input: Create macros for cros-ec keymap

2021-01-08 Thread Philip Chen
the generic portion of keymap when we override the keymap in the board-specific dts for custom top row design. Signed-off-by: Philip Chen --- include/dt-bindings/input/cros-ec-keyboard.h | 103 +++ 1 file changed, 103 insertions(+) create mode 100644 include/dt-bindings/input/cros

[PATCH v4 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-07 Thread Philip Chen
This patch adds a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - add `function-row-physmap

[PATCH v4 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-07 Thread Philip Chen
will only be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- Changes in v4: - replace sysfs_create_group() with devm_device_add_group() - remove an unused member in struct cros_ec_keyb Changes in v3: - parse `function-row-physmap` from DT ea

[PATCH v3 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-04 Thread Philip Chen
will only be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- Changes in v3: - parse `function-row-physmap` from DT earlier, when we probe cros_ec_keyb, and then store the extracted info in struct cros_ec_keyb. Changes in v2: - create function-row-p

[PATCH v3 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-04 Thread Philip Chen
This patch adds a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- (no changes since v2) Changes in v2: - add `function-row-physmap

[PATCH v2 2/2] Input: cros-ec-keyb - Expose function row physical map to userspace

2021-01-04 Thread Philip Chen
will only be present when the device has a custom design for the top-row keys. Signed-off-by: Philip Chen --- Changes in v2: - create function-row-physmap file in sysfs by parsing `function-row-physmap` property from DT - assume the device already has a correct keymap to reflect the custom t

[PATCH v2 1/2] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-04 Thread Philip Chen
This patch adds a new property `function-row-physmap` to the device tree for the custom keyboard top row design. The property describes the rows/columns of the top row keys from left to right. Signed-off-by: Philip Chen --- Changes in v2: - add `function-row-physmap` instead of `google,custom

Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-04 Thread Philip Chen
Hi Dmitry, On Sun, Jan 3, 2021 at 2:48 PM Dmitry Torokhov wrote: > > Hi Philip, > > On Sat, Jan 02, 2021 at 10:11:21PM -0800, Philip Chen wrote: > > Hi Dmitry, > > > > I have one more question below. > > Could you take a look? > > > > O

Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-02 Thread Philip Chen
Hi Dmitry, I have one more question below. Could you take a look? On Sat, Jan 2, 2021 at 8:53 PM Philip Chen wrote: > > Hi Dmitry, > > I see. > I'll update these patch sets shortly based on your suggestion. > Thanks. > > On Sat, Jan 2, 2021 at 1:04 PM Dmitry Toro

Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-02 Thread Philip Chen
Hi Dmitry, I see. I'll update these patch sets shortly based on your suggestion. Thanks. On Sat, Jan 2, 2021 at 1:04 PM Dmitry Torokhov wrote: > > On Sat, Jan 02, 2021 at 11:39:34AM -0800, Philip Chen wrote: > > Hi Dmitry, > > > > Thanks for reviewing my

Re: [PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

2021-01-02 Thread Philip Chen
Hi Dmitry, Thanks for reviewing my patch over the holiday season. Please check my CIL. On Mon, Dec 28, 2020 at 10:18 PM Dmitry Torokhov wrote: > > Hi Philip, > > On Mon, Dec 21, 2020 at 05:47:57PM -0800, Philip Chen wrote: > > This patch adds a new property `google,custom-ke

Re: [kbuild-all] drivers/clocksource/timer-clint.c:72:24: sparse: sparse: cast removes address space '__iomem' of expression

2020-12-24 Thread Philip Li
On Thu, Dec 24, 2020 at 04:11:17PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 58cf05f597b03a8212d9ecf2c79ee046d3ee8ad9 > commit: 2ac6795fcc085e8d03649f1bbd0d70aaff612cad clocksource/drivers: Add > CLINT timer dri

[PATCH 2/3] Input: cros_ec_keyb - Support custom top-row keys

2020-12-21 Thread Philip Chen
n. If a board specifies a custom layout for the top row keys in dt binding, cros_ec_keyb will explicitly sends action key code to applications when any top-row key is pressed, so the applications no longer have to make assumptions. Signed-off-by: Philip Chen --- drivers/input/key

[PATCH 3/3] Input: cros-ec-keyb - Expose function row physical map to userspace

2020-12-21 Thread Philip Chen
only be present when cros-ec-keyb sends action key codes for the top-row keys, otherwise the attribute shall not be visible. Signed-off-by: Philip Chen --- drivers/input/keyboard/cros_ec_keyb.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/input/keyboa

[PATCH 1/3] dt-bindings: input: cros-ec-keyb: Add a new property

2020-12-21 Thread Philip Chen
This patch adds a new property `google,custom-keyb-top-row` to the device tree for the custom keyboard top row design. Signed-off-by: Philip Chen --- .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree

Re: [kbuild-all] Re: [linux-next:master 13538/13785] /tmp/metronomefb-846872.s:300: Error: unrecognized opcode `zext.b a2,a2'

2020-12-19 Thread Philip Li
nomefb-846872.s:300: Error: unrecognized opcode `zext.b > > > > > >> a2,a2' > > > > > > Thanks > > > > > > > > > > > Whoever is responsible for this, please sign emails with your real > > > > name! > > This is

Re: [kbuild-all] Re: [linux-next:master 13538/13785] /tmp/metronomefb-846872.s:300: Error: unrecognized opcode `zext.b a2,a2'

2020-12-19 Thread Philip Li
On Sat, Dec 19, 2020 at 06:28:20PM +0800, Philip Li wrote: > On Sat, Dec 19, 2020 at 08:56:06AM +0100, Pavel Machek wrote: > > Crazy robot, stop spamming. This report is obviously bogus, yet, you > > sent me 5 copies. > Thanks Pavel for input, sorry for the false positive. It

Re: [kbuild-all] Re: [linux-next:master 13538/13785] /tmp/metronomefb-846872.s:300: Error: unrecognized opcode `zext.b a2,a2'

2020-12-19 Thread Philip Li
On Sat, Dec 19, 2020 at 08:56:06AM +0100, Pavel Machek wrote: > Crazy robot, stop spamming. This report is obviously bogus, yet, you > sent me 5 copies. Thanks Pavel for input, sorry for the false positive. It tries to bisect error like below (the new error), but it may be related to assember suppo

Re: [kbuild-all] Re: ERROR: "snd_soc_new_ac97_component" undefined!

2020-12-12 Thread Philip Li
On Thu, Dec 10, 2020 at 04:16:17PM -0800, Randy Dunlap wrote: > On 12/6/20 10:11 AM, kernel test robot wrote: > > Hi Geert, > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 7059c2c00a2196865c

Re: [kbuild-all] Re: [PATCH 1/3] Add TX sending hardware timestamp.

2020-12-12 Thread Philip Li
On Thu, Dec 10, 2020 at 12:41:32PM +, Geva, Erez wrote: > > On 10/12/2020 04:11, kernel test robot wrote: > > Hi Erez, > > > > Thank you for the patch! Yet something to improve: > > > Thanks for the robot, > as we rarely use clang for kernel. It is very helpful. > > > [auto build test ERROR

Re: [LKP] Re: [drm/fb] 1d46491d4a: WARNING:at_drivers/gpu/drm/drm_fb_helper.c:#drm_fb_helper_damage_work[drm_kms_helper]

2020-12-06 Thread Philip Li
On Thu, Dec 03, 2020 at 10:34:49AM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.12.20 um 09:36 schrieb Oliver Sang: > > On Thu, Dec 03, 2020 at 08:41:49AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > there should be a line in the kernel log that says something like "Damage > > > blitter

Re: arch/powerpc/mm/book3s64/pgtable.c:174:15: error: no previous prototype for 'create_section_mapping'

2020-11-23 Thread Philip Li
On Mon, Nov 23, 2020 at 07:20:46PM -0800, Dan Williams wrote: > On Mon, Nov 23, 2020 at 6:13 PM kernel test robot wrote: > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: d5beb3140f91b1c8a3d41b14d729aefa4dcc58bc > > commit: a927bd6ba952d13c5

Re: [LKP] Re: [block, scsi, ide] 3e3b42fee6: kmsg.sd#:#:#:#:[sdf]Asking_for_cache_data_failed

2020-11-17 Thread Philip Li
On Tue, Nov 17, 2020 at 08:46:46AM -0800, Bart Van Assche wrote: > On 11/17/20 8:00 AM, kernel test robot wrote: > > on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G > > memory > > > > caused below changes (please refer to attached dmesg/kmsg for entire > > log/backtra

RE: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Li, Philip
> > On Fri, 13 Nov 2020 00:32:55 +0000 Li, Philip wrote: > > > Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC > with > > > prefixes of arbitrary length in PIO > > > > > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wr

RE: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-11-12 Thread Li, Philip
> Subject: [kbuild-all] Re: [PATCH net-next] net: Variable SLAAC: SLAAC with > prefixes of arbitrary length in PIO > > On Wed, 11 Nov 2020 09:34:24 +0800 kernel test robot wrote: > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > Good people

Re: [kbuild-all] Re: [PATCH] fs/nfsd: remove unused NFSDDBG_FACILITY to tame gcc

2020-11-10 Thread Philip Li
On Wed, Nov 11, 2020 at 01:35:11PM +0800, Alex Shi wrote: > I had a recall email for this patch > https://www.spinics.net/lists/linux-nfs/msg80135.html > seem your robot just omit it. :) sorry for the meaningless report, that currently the bot can't analyze the mail like this to abandon the patch

[0-Day CI notification] the service will be paused from 11/6/2020 5 PM to 11/9/2020 10 AM (PRC time)

2020-11-05 Thread Li, Philip
Hi all, this is Philip who maintains the 0-Day CI test service. Thanks for anyone who subscribes to the service. We will have a lab power construction this weekend, thus need to pause the service for about 3 days, at PRC time from 11/6/2020 5 PM to 11/9/2020 10 AM. Sorry for any inconvenience

Re: [LKP] Re: [mm] e6e88712e4: stress-ng.tmpfs.ops_per_sec -69.7% regression

2020-10-30 Thread Philip Li
On Fri, Oct 30, 2020 at 02:58:35PM +, Matthew Wilcox wrote: > On Fri, Oct 30, 2020 at 10:02:45PM +0800, Chen, Rong A wrote: > > On 10/30/2020 9:17 PM, Matthew Wilcox wrote: > > > On Fri, Oct 30, 2020 at 03:17:15PM +0800, kernel test robot wrote: > > > > Details are as below: > > > > ---

Re: [LKP] Re: [rcu] 44bad5b3cc: dmesg.INFO:rcu_preempt_detected_stalls_on_CPUs/tasks

2020-10-30 Thread Philip Li
On Fri, Oct 30, 2020 at 06:56:21AM -0700, Paul E. McKenney wrote: > On Fri, Oct 30, 2020 at 03:47:40PM +0800, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 44bad5b3cca2d452d17ef82841b20b42a2cf11a0 ("rcu: Do full report for

Re: [Build fail] i386 & nvdimm is unhappy

2020-10-29 Thread Philip Li
On Thu, Oct 29, 2020 at 03:52:42PM -0700, Dan Williams wrote: > On Thu, Oct 29, 2020 at 3:44 PM Thomas Gleixner wrote: > > > > Dan, > > > > x86 32bit build fails with the config below with this: > > > > ERROR: modpost: "phys_to_target_node" [drivers/nvdimm/nd_e820.ko] > > undefined! > > Ackno

Re: [MPTCP] Re: [selftests] f2ff7f11f9: WARNING:suspicious_RCU_usage

2020-10-27 Thread Philip Li
On Tue, Oct 27, 2020 at 04:07:28PM +0100, Matthieu Baerts wrote: > Hi all, > > On 27/10/2020 14:16, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: f2ff7f11f9a74842245db52d685bf9bc7ac2c4b1 ("selftests: mptcp: add > > ADD_AD

RE: [kbuild-all] Re: ld.lld: warning: fs/built-in.a(afs/cell.o):(.data..L__unnamed_8) is being placed in '.data..L__unnamed_8'

2020-10-24 Thread Li, Philip
> Subject: [kbuild-all] Re: ld.lld: warning: fs/built- > in.a(afs/cell.o):(.data..L__unnamed_8) is being placed in > '.data..L__unnamed_8' > > https://github.com/ClangBuiltLinux/linux/issues/1185 sorry for false positive, we will ignore all lld warning related to "being placed in", the initial ig

Re: [LKP] Unreliable will-it-scale context_switch1 test on 0day bot

2020-10-19 Thread Philip Li
On Mon, Oct 19, 2020 at 09:27:32AM -0400, Mathieu Desnoyers wrote: > Hi, > > I pointed out an issue with the will-it-scale context_switch1 test run by the > 0day bot on > October 7, 2020, and got no reply. Thanks Mathieu for the feedback, we had added it to the TODO list but sorry for not reply i

Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration

2020-10-12 Thread Philip Li
On Fri, Oct 02, 2020 at 10:55:06AM -0700, Roman Gushchin wrote: > On Fri, Oct 02, 2020 at 01:34:06PM +0800, Philip Li wrote: > > On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > > > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote

Re: [mac80211_hwsim] 148fe295b7: hwsim.ap_long_preamble.fail

2020-10-12 Thread Philip Li
On Fri, Oct 02, 2020 at 09:38:45AM -0700, Thomas Pedersen wrote: > On 2020-10-02 01:29, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 148fe295b7d9d892b2b0f47070233ccdc70c83cd ("mac80211_hwsim: > > indicate support for S1G")

Re: [perf report] 977f739b71: perf-test.skid_test.round2.MEM_LOAD_L3_MISS_RETIRED.LOCAL_DRAM_dtlb_withou t_NMI_fixed_period.fail

2020-10-01 Thread Philip Li
On Wed, Sep 30, 2020 at 02:41:07PM +0200, Michael Petlan wrote: > Hello. To me, it looks rather a random failure. Is it actually reproducible > and proven that the patch has caused it? The patch doesn't seem to cause thanks for the input, we will look into this and provide update. Now since we are

Re: [PATCH 4/5] clk: qcom: Add SDM660 GPU Clock Controller (GPUCC) driver

2020-10-01 Thread Philip Li
On Wed, Sep 30, 2020 at 11:58:50PM +0200, AngeloGioacchino Del Regno wrote: > The kernel test robot is wrong: this commit builds fine by Thanks for the info and sorry for the wrong report. Currently it is hard to detect the base in this case automatically, if possible, we recommend to use --base op

Re: [kbuild-all] Re: [PATCH v5 03/15] misc: bcm-vk: add autoload support

2020-10-01 Thread Philip Li
On Thu, Oct 01, 2020 at 10:48:08AM -0700, Scott Branden wrote: > > > On 2020-09-30 9:07 p.m., kernel test robot wrote: > > Hi Scott, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on char-misc/char-misc-testing] > > [also build test ERROR on soc/for-next kees/

Re: [kbuild-all] Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration

2020-10-01 Thread Philip Li
On Thu, Oct 01, 2020 at 05:55:59PM -0700, Roman Gushchin wrote: > On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote: > > Hi Roman, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on mmotm/master] > > It's a bogus error, the patch was appl

Business Relationship

2020-09-23 Thread Philip Li Wong
. Could you please take a few minutes of your time to revert back to this mail??? Best Regards, Philip Li Wong. hkbannkco...@gmail.com

Re: [tip:x86/pti] BUILD SUCCESS WITH WARNING 767d46ab566dd489733666efe48732d523c8c332

2020-09-17 Thread Philip Li
On Thu, Sep 17, 2020 at 10:00:44AM +0200, Borislav Petkov wrote: > On Thu, Sep 17, 2020 at 03:36:20PM +0800, Philip Li wrote: > > The 2nd type is this one, which is a summarized report of head > > to provide an overview. Most of time, repo owner can receive the > > bisecte

Re: [kbuild-all] Re: undefined reference to `start_isolate_page_range'

2020-09-07 Thread Philip Li
On Mon, Sep 07, 2020 at 03:40:08PM -0700, Randy Dunlap wrote: > Hi lkp, (or is it ktr?) > > This is sort of a shame-on-you post. As a robot, I hope that you > don't have any hard feelings about it. :) Hi Randy, thanks for the input, below warning is helpful to identify issues, we will add this to

Re: [LKP] Re: [mm] 3e38e0aaca: WARNING:at_mm/memcontrol.c:#mem_cgroup_alloc

2020-08-15 Thread Philip Li
On Fri, Aug 14, 2020 at 10:00:44AM -0700, Linus Torvalds wrote: > On Fri, Aug 14, 2020 at 7:14 AM kernel test robot wrote: > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 3e38e0aaca9eafb12b1c4b731d1c10975cbe7974 ("mm: memcg: charge memcg > > percpu memory to the p

Re: [kbuild-all] Re: fs/ocfs2/suballoc.c:2430:2-8: preceding lock on line 2413

2020-08-15 Thread Philip Li
On Fri, Aug 14, 2020 at 09:52:13PM +0200, Julia Lawall wrote: > > > On Fri, 14 Aug 2020, Thomas Gleixner wrote: > > > Julia, > > > > On Fri, Aug 14 2020 at 21:00, Julia Lawall wrote: > > > On Fri, 14 Aug 2020, Thomas Gleixner wrote: > > >> That's clearly a false positive. Is there anything what

Re: [LKP] Re: db57e98d87 ("mm/sparse.c: fix ALIGN() without power of 2 in .."): BUG: kernel reboot-without-warning in early-boot stage, last printk: early console in setup code

2020-07-16 Thread Philip Li
On Thu, Jul 16, 2020 at 03:06:13PM -0700, Andrew Morton wrote: > On Thu, 16 Jul 2020 16:32:00 +0800 kernel test robot wrote: > > > Greetings, > > > > 0day kernel testing robot got the below dmesg and the first bad commit is > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.

RE: [kbuild-all] Re: [PATCH v4 4/7] iommu/vt-d: Handle non-page aligned address

2020-07-08 Thread Li, Philip
> Subject: [kbuild-all] Re: [PATCH v4 4/7] iommu/vt-d: Handle non-page aligned > address > > Hi Jacob, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on iommu/next] > [also build test WARNING on linux/master linus/master v5.8-rc4 next-20200707] > [If your

Re: [PATCH] mm/sparse: only sub-section aligned range would be populated

2020-07-08 Thread Philip Li
>config: x86_64-allnoconfig (attached as .config) > > Another issue was that this was an allnoconfig x86_64 build with > Clang. While ARCH=x86_64 defconfigs set: > CONFIG_64BIT=y > CONFIG_X86_64=y > > allnoconfig turns those off, making it a 32b x86 build. We cannot yet &

Re: [kbuild-all] Re: [PATCH v1 1/4] qlge/qlge_main.c: use genric power management

2020-06-29 Thread Philip Li
On Mon, Jun 29, 2020 at 12:31:16PM -0500, Bjorn Helgaas wrote: > Vaibhav: s/genric/generic/ in the subject > > On Tue, Jun 30, 2020 at 12:09:36AM +0800, kernel test robot wrote: > > Hi Vaibhav, > > > > Thank you for the patch! Yet something to improve: > > > > [auto build test ERROR on staging/s

Re: [kbuild-all] ERROR: "__mulsi3" undefined!

2020-06-29 Thread Philip Li
On Tue, Jun 30, 2020 at 02:46:22AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 9ebcfadb0610322ac537dd7aa5d9cbc2b2894c68 > commit: f26e433185cb2830b933df3a4d378558fe2fccd9 arch: nios2: Enable the > common clk subsy

Re: [kbuild-all] ERROR: "__mulsi3" undefined!

2020-06-29 Thread Philip Li
On Mon, Jun 29, 2020 at 08:04:37PM +0800, kernel test robot wrote: > Hi Sebastian, Sorry for the noise, kindly ignore this report, which is a false positive. > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > hea

Re: [kbuild-all] ERROR: "__mulsi3" undefined!

2020-06-29 Thread Philip Li
On Tue, Jun 30, 2020 at 06:09:49AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 7c30b859a947535f2213277e827d7ac7dcff9c84 > commit: 57a10d8c1123068e3cb06434fbc9634f945d3062 ptp: Add a ptp clock driver > for IDT 82P3

Re: [kbuild-all] Re: ERROR: modpost: "__mulsi3" undefined!

2020-06-20 Thread Philip Li
On Sat, Jun 20, 2020 at 09:41:28AM +0300, Denis Efremov wrote: > > > On 6/19/20 7:17 PM, kernel test robot wrote: > > Hi Denis, > > > > First bad commit (maybe != root cause): > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head: 5e857ce6eae7

  1   2   3   4   5   6   7   8   9   >