[PATCH v2 08/12] media: atomisp: Delete braces

WARNING:BRACES: braces {} are not necessary for single statement blocks Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH v2 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Ge

[PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1

[PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Ge

[PATCH v2 04/12] media: atomisp: Fix OPEN_ENDED_LINE

Lines should not end with a '(' Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH v2 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 05/12] media: atomisp: Fix overlong line

Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH v2 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1

[PATCH v2 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning

Use the automatically defined __func__ macro instead of the function name, so it stays correct when the function is renamed. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8

[PATCH v2 06/12] media: atomisp: Remove defines

Remov defines, they don't make sense. The programmer should know what things need to be static and what not. Also leave "inline" out and let the compiler decide Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../me

[PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 07/12] media: atomisp: Fix funciton decleration

Write return_type, function_name and parameters in one line because lines should not end with a '(' [OPEN_ENDED_LINE] Write open brace ’{’ on the next line to fix OPEN_BRACE Error Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --

[PATCH v2 02/12] media: atomisp: Fix Block Comments

Block comments should use * on subsequent lines and should use a trailing */ on a separate line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++-- 1 file changed, 3

[PATCH v2 00/12] media: atomisp: Codingstyle

Hello! This series fix some codingstyle errors in the files rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c in the drivers/staging/media area. V2: [Patch 1/12] Also remove NULL, 0 and false members to make it C99 standard comform. [Patch 6/12] Checkpatch throws COMPLEX_MAC

[PATCH v2 01/12] media: atomisp: Convert comments to C99 initializers

The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Also remove all the false, 0, and NULL members. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src

[PATCH 00/12] media: atomisp: Codingstyle

Hello! This series fix some codingstyle errors in the files rmgr_vbuf.c, ia_css_rmgr.h, timer.c, spctrl.c and queue.c in the drivers/staging/media area. Best regards Philipp -- media: atomsip: Convert comments to C99 initializ

[PATCH 11/12] media: atomisp: Write function decleration in one line

CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' WARNING:LEADING_SPACE: please, no spaces at the start of a line Avoid these errors by writing the function decleration in one line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Ge

[PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE

Block comments should align the * on each line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT

You can sum up the two lines, because the maximum line length of 100 columns is not exceeded. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 3 +-- 1 file changed, 1

[PATCH 08/12] media: atomisp: Delete braces

WARNING:BRACES: braces {} are not necessary for single statement blocks Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/timer/src/timer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a

[PATCH 07/12] media: atomisp: Fix funciton decleration

Write return_type, function_name and parameters in one line because lines should not end with a '(' [OPEN_ENDED_LINE] Write open brace ’{’ on the next line to fix OPEN_BRACE Error Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --

[PATCH 04/12] media: atomisp: Fix OPEN_ENDED_LINE

Lines should not end with a '(' Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH 01/12] media: atomsip: Convert comments to C99 initializers

The struct initalizers have been changed as recommended on https://kernelnewbies.org/KernelJanitors/Todo Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 30 +-- 1 file

[PATCH 06/12] media: atomisp: Add parentheses

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h| 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS

Logical continuations should be on the previous line Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning

Use the automatically defined __func__ macro instead of the function name, so it stays correct when the function is renamed. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c| 8

[PATCH 05/12] media: atomisp: Fix overlong line

Line length of 105 exceeds 100 columns. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH 02/12] media: atomisp: Fix Block Comments

Block comments should use * on subsequent lines and should use a trailing */ on a separate line. Co-developed-by: Andrey Khlopkov Signed-off-by: Andrey Khlopkov Signed-off-by: Philipp Gerlesberger --- .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 5 +++-- 1 file changed, 3