Re: [PATCH v4] vdpa/octeon_ep: Control PCI dev enabling manually

2025-05-15 Thread Philipp Stanner
On Thu, 2025-05-08 at 10:51 +0200, Philipp Stanner wrote: > PCI region request functions such as pci_request_region() currently > have > the problem of becoming sometimes managed functions, if > pcim_enable_device() instead of pci_enable_device() was called. The > PCI > subsyst

[PATCH v4] vdpa/octeon_ep: Control PCI dev enabling manually

2025-05-08 Thread Philipp Stanner
disablement manually. Replace pcim_enable_device() with pci_enable_device(). Add the necessary calls to pci_disable_device(). Signed-off-by: Philipp Stanner Acked-by: Vamsi Attunuru --- Changes in v4: - s/AF/PF - Add Vamsi's AB Changes in v3: - Only call pci_disable_device() for t

[PATCH v3] vdpa/octeon_ep: Control PCI dev enabling manually

2025-04-24 Thread Philipp Stanner
disablement manually. Replace pcim_enable_device() with pci_enable_device(). Add the necessary calls to pci_disable_device(). Signed-off-by: Philipp Stanner --- Changes in v3: - Only call pci_disable_device() for the PF version. For AF it would cause a WARN_ON because pcim_enable_device()&#

Re: [PATCH v2] vdpa/octeon_ep: Control PCI dev enabling manually

2025-04-23 Thread Philipp Stanner
On Wed, 2025-04-23 at 12:39 +0200, Philipp Stanner wrote: > PCI region request functions such as pci_request_region() currently > have > the problem of becoming sometimes managed functions, if > pcim_enable_device() instead of pci_enable_device() was called. The > PCI > subsyst

[PATCH v2] vdpa/octeon_ep: Control PCI dev enabling manually

2025-04-23 Thread Philipp Stanner
pcim_enable_device() with pci_enable_device(). Add the necessary calls to pci_disable_device(). Signed-off-by: Philipp Stanner --- Was formerly called "Use non-hybrid PCI devres API" Changes in v2: - Don't replace the request functions. Enable / disable manually instead. (Vamsi) --

Re: [EXTERNAL] [PATCH] vdpa/octeon_ep: Use non-hybrid PCI devres API

2025-04-17 Thread Philipp Stanner
On Thu, 2025-04-17 at 12:56 +, Vamsi Krishna Attunuru wrote: > > > > -Original Message- > > From: Philipp Stanner > > Sent: Thursday, April 17, 2025 4:09 PM > > To: Vamsi Krishna Attunuru ; Philipp Stanner > > ; Srujana Challa ; Michael &g

Re: [EXTERNAL] [PATCH] vdpa/octeon_ep: Use non-hybrid PCI devres API

2025-04-17 Thread Philipp Stanner
On Thu, 2025-04-17 at 09:02 +, Vamsi Krishna Attunuru wrote: > > > > -Original Message- > > From: Philipp Stanner > > Sent: Thursday, April 17, 2025 1:32 PM > > To: Srujana Challa ; Vamsi Krishna Attunuru > > ; Michael S. Tsirkin ; Jason >

[PATCH] vdpa/octeon_ep: Use non-hybrid PCI devres API

2025-04-17 Thread Philipp Stanner
-managed pcim_request_region(). Signed-off-by: Philipp Stanner --- drivers/vdpa/octeon_ep/octep_vdpa_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_main.c b/drivers/vdpa/octeon_ep/octep_vdpa_main.c index f3d4dda4e04c..e0da6367661e

Re: [PATCH v4] vdpa: solidrun: Replace deprecated PCI functions

2025-01-20 Thread Philipp Stanner
On Thu, 2024-12-19 at 10:51 +0100, Stefano Garzarella wrote: > On Thu, Dec 19, 2024 at 10:44:29AM +0100, Philipp Stanner wrote: > > From: Philipp Stanner > > > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > &

[PATCH v4] vdpa: solidrun: Replace deprecated PCI functions

2024-12-19 Thread Philipp Stanner
From: Philipp Stanner The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounmap_region(). Signed-off-by: Philipp

Re: [PATCH v3] vdpa: solidrun: Replace deprecated PCI functions

2024-12-13 Thread Philipp Stanner
On Fri, 2024-12-13 at 16:10 +0100, Stefano Garzarella wrote: > On Wed, Dec 11, 2024 at 11:47:05AM +0100, Philipp Stanner wrote: > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > > pcim_iomap_table() > > > &

[PATCH v3] vdpa: solidrun: Replace deprecated PCI functions

2024-12-11 Thread Philipp Stanner
The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounmap_region(). Signed-off-by: Philipp Stanner --- Changes in v3

Re: [PATCH v2] vdpa: solidrun: Replace deprecated PCI functions

2024-12-09 Thread Philipp Stanner
On Mon, 2024-12-09 at 14:31 +0100, Stefano Garzarella wrote: > On Mon, Dec 09, 2024 at 12:51:18PM +0100, Philipp Stanner wrote: > > The PCI functions > > > > pcim_iomap_regions() > > pcim_iounmap_regions() > > pcim_iomap_table() > > > &

[PATCH v2] vdpa: solidrun: Replace deprecated PCI functions

2024-12-09 Thread Philipp Stanner
The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounmap_region(). Signed-off-by: Philipp Stanner --- Changes in v2

[PATCH] vdpa: solidrun: Replace deprecated PCI functions

2024-12-02 Thread Philipp Stanner
The PCI functions pcim_iomap_regions() pcim_iounmap_regions() pcim_iomap_table() have been deprecated by the PCI subsystem. Replace these functions with their successors pcim_iomap_region() and pcim_iounmap_region(). Signed-off-by: Philipp Stanner --- drivers/vdpa

[PATCH v2] vdpa: solidrun: Fix UB bug with devres

2024-10-28 Thread Philipp Stanner
-ac59-49e2-9b1d-d825c9c9f...@wanadoo.fr/ Suggested-by: Andy Shevchenko Signed-off-by: Philipp Stanner Reviewed-by: Stefano Garzarella --- Changes in v2: - Add Stefano's RB --- drivers/vdpa/solidrun/snet_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Philipp Stanner
On Wed, 2024-10-16 at 12:51 +0200, Greg KH wrote: > On Wed, Oct 16, 2024 at 11:22:48AM +0200, Philipp Stanner wrote: > > On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > > > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > > &

Re: [PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Philipp Stanner
On Wed, 2024-10-16 at 12:08 +0300, Andy Shevchenko wrote: > On Wed, Oct 16, 2024 at 09:25:54AM +0200, Philipp Stanner wrote: > > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed > > to > > pcim_iomap_regions() is placed on the stack. Neither > > p

[PATCH RESEND] vdpa: solidrun: Fix UB bug with devres

2024-10-16 Thread Philipp Stanner
-ac59-49e2-9b1d-d825c9c9f...@wanadoo.fr/ Suggested-by: Andy Shevchenko Signed-off-by: Philipp Stanner --- drivers/vdpa/solidrun/snet_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet_ma

[PATCH] vdpa: solidrun: Fix UB bug with devres

2024-10-08 Thread Philipp Stanner
-ac59-49e2-9b1d-d825c9c9f...@wanadoo.fr/ Suggested-by: Andy Shevchenko Signed-off-by: Philipp Stanner --- drivers/vdpa/solidrun/snet_main.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet_ma