Re: [PATCH v4 20/26] ARM: pxa: magician: Add support for MAX1587A Vcore regulator

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:39 +0200 schrieb Petr Cvek: > HTC Magician contains a MAX1587A voltage regulator for a Vcore > supply. > The Vcore regulation is required for a CPU speed switching. This > patch adds > declaration for the max1586 driver. > > Notice: > > - MAX1587A version does not su

Re: [PATCH v4 21/26] ARM: pxa: magician: Add support for PXA27x UDC

2015-10-03 Thread Philipp Zabel
gt; + .udc_command= magician_udc_command, > + .gpio_pullup= GPIO27_MAGICIAN_USBC_PUEN, > +}; > + > +/* > + * USB device VUSB detection > + */ > + Move this comment to the earlier comment fixup patch. Otherwise, Acked-by: Philipp Zabel regards Philipp -

Re: [PATCH v4 18/26] ARM: pxa: magician: Add support for ADS7846

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > Add support for an ADS7846 touchscreen. It's actually a TSC2045. > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 86 > > 1 file changed, 86 insertions(+) > > diff --git a/

Re: [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > This patch adds support for an OV9640 camera to the HTC Magician > machine. > > Signed-off-by: Petr Cvek Still untested, but looks good to me. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:38 +0200 schrieb Petr Cvek: > USB host ports on the HTC Magician are wrongly enabled. Port 1 is for > bluetooth and port 2 is for OTG (mux in the charger connector). > > Signed-off-by: Petr Cvek > --- > arch/arm/mach-pxa/magician.c | 4 +++- > 1 file changed, 3 inse

Re: [PATCH v4 14/26] ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers

2015-10-03 Thread Philipp Zabel
- .fast_mode = 1, > + /* FIXME both I2C devices should support fast mode */ Maybe add the info from the commit description here (it's OV9640 that doesn't support fast mode). Otherwise, Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the li

Re: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: > This patch renames EGPIOs, which are used for the charging cable > presence > and type detection. Old names did not correspond with an observed > functionality (on board_id 0x3a). The behavior is not: > > - AC charger > - USB charger > -

Re: [PATCH v4 11/26] ARM: pxa: magician: Optimize EGPIO initial values

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek: > This patch optimizes initial values of the EGPIO chip driver. > > GSM and sound should be powered off during boot. A weak accumulator > and > a powered GSM sometimes cause a system reboot. A charging current > should be > as high as possi

Re: [PATCH v4 10/26] ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz

2015-10-03 Thread Philipp Zabel
ned-off-by: Petr Cvek Acked-by: Philipp Zabel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 09/26] ARM: pxa: magician: Optimize powerup delays for Samsung LCD

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:16 +0200 schrieb Petr Cvek: > Delays for the Samsung LCD are greater than needed. These values were > extracted from a datasheet. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line

Re: [PATCH v4 08/26] ARM: pxa: magician: Rename abstract LCD GPIOs

2015-10-03 Thread Philipp Zabel
Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 07/26] ARM: pxa: magician: Fix HTC Magician pin mux definitions

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: > This patch fixes a pin mux for the HTC Magician machine. Wrong and > missing > definitions caused a bad LCD operation and an unavailability of > several > peripherals. > > Signed-off-by: Petr Cvek NAK on this one. Until this patch I can

Re: [PATCH v4 06/26] ARM: pxa: magician: Add new discovered EGPIO pins

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:15 +0200 schrieb Petr Cvek: > This patch adds EGPIO pins: Infra transceiver power, NiCD charging > and > inserted charger cable. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel Do you have more details how NiCD charging works? regard

Re: [PATCH v4 04/26] ARM: pxa: magician: Optimize debug messages for LCD power

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:11 +0200 schrieb Petr Cvek: > Optimize the debug messages for the LCD power. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH v4 05/26] ARM: pxa: magician: Change description of LCD power GPIO

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:11 +0200 schrieb Petr Cvek: > This patch changes the description of the LCD power GPIO to be more > specific. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v4 03/26] ARM: pxa: magician: Print more specific error message for global GPIOs

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek: > Print more specific error message for global GPIOs. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel > --- > arch/arm/mach-pxa/magician.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH v4 02/26] ARM: pxa: magician: Change comments to be more informative

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:10 +0200 schrieb Petr Cvek: > This patch changes the comments in the HTC Magician machine source > code > to better describe used devices and interfaces. > > Signed-off-by: Petr Cvek This is mostly fine, some comments below. [...] > static struct resource egpio_re

Re: [PATCH v4 01/26] ARM: pxa: magician: Fix indentation in machine files

2015-10-03 Thread Philipp Zabel
Am Montag, den 28.09.2015, 23:09 +0200 schrieb Petr Cvek: > This patch fixes the indentation for the HTC Magician machine > definition. > > Signed-off-by: Petr Cvek Acked-by: Philipp Zabel I still think these are a lot of arbitrary changes, maybe the description shoul

Re: [PATCH 3/6] drm/imx: Build monolithic driver

2015-09-25 Thread Philipp Zabel
Am Freitag, den 25.09.2015, 15:09 +0200 schrieb Philipp Zabel: > Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding: > > I think you gain much less by splitting up than you realize. Compare > > this from before the series: > > > > $ du -ch drivers/gp

Re: [PATCH 3/6] drm/imx: Build monolithic driver

2015-09-25 Thread Philipp Zabel
Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding: > I think you gain much less by splitting up than you realize. Compare > this from before the series: > > $ du -ch drivers/gpu/drm/imx/*.ko > 8.0Kdrivers/gpu/drm/imx/dw_hdmi-imx.ko Oh right, I didn't realize that this

Re: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin

2015-09-25 Thread Philipp Zabel
Am Montag, den 21.09.2015, 15:15 +0100 schrieb Russell King - ARM Linux: > On Mon, Sep 21, 2015 at 11:51:06AM +0200, Thierry Reding wrote: > > On Wed, Sep 16, 2015 at 01:41:38PM -0700, Douglas Anderson wrote: > > > There's a member in 'struct dw_hdmi' called cable_plugin. It's never > > > set to a

Re: [PATCH 3/6] drm/imx: Build monolithic driver

2015-09-25 Thread Philipp Zabel
Hi Thierry, Am Donnerstag, den 24.09.2015, 19:02 +0200 schrieb Thierry Reding: > From: Thierry Reding > > There's no use building the individual drivers as separate modules > because they are all only useful if combined into a single DRM/KMS > device. Why not? On an i.MX5 device with VGA(tve) o

Re: [PATCH 16/38] gpu: ipu-v3: fix div_ratio type

2015-09-23 Thread Philipp Zabel
Hi Andrzej, Am Montag, den 21.09.2015, 15:33 +0200 schrieb Andrzej Hajda: > The variable can be negative. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576

Re: [PATCH V4 3/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC

2015-09-18 Thread Philipp Zabel
Am Donnerstag, den 17.09.2015, 20:00 +0800 schrieb Chen Feng: > Add reset controller for hi6220 hikey-board. > > Signed-off-by: Chen Feng > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi

Re: [PATCH] [media] gpu: ipu-v3: csi: add support for 8 bpp grayscale sensors.

2015-09-18 Thread Philipp Zabel
Am Freitag, den 18.09.2015, 15:41 +0200 schrieb Philippe De Muyter: > Signed-off-by: Philippe De Muyter > Cc: Steve Longerbeam > Cc: Boris BREZILLON > Cc: Philipp Zabel > Cc: Hans Verkuil > --- > drivers/gpu/ipu-v3/ipu-csi.c |1 + > 1 file changed, 1 insert

Re: [PATCH V3 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC

2015-09-15 Thread Philipp Zabel
Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng: > Add reset controller for hi6220 hikey-board. > > Signed-off-by: Chen Feng > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >

Re: [PATCH V3 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

2015-09-15 Thread Philipp Zabel
Hi, Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng: [...] > diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig > new file mode 100644 > index 000..26bf95a > --- /dev/null > +++ b/drivers/reset/hisilicon/Kconfig > @@ -0,0 +1,5 @@ > +config COMMON_RESET_HI

Re: [PATCH V3 2/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings

2015-09-15 Thread Philipp Zabel
Am Dienstag, den 15.09.2015, 11:58 +0800 schrieb Chen Feng: > Add DT bindings documentation for hi6220 SoC reset controller. > > Signed-off-by: Chen Feng > --- > .../bindings/reset/hisilicon,hi6220-reset.txt | 97 > ++ > 1 file changed, 97 insertions(+) > create mode 1

Re: [RESEND PATCH 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

2015-09-10 Thread Philipp Zabel
Am Donnerstag, den 10.09.2015, 14:11 +0800 schrieb Chen Feng: > Add reset driver for hi6220-hikey board,this driver supply deassert > of IP. on hi6220 SoC. > > Signed-off-by: Chen Feng > --- > drivers/reset/Kconfig | 1 + > drivers/reset/Makefile | 1 + > drive

Re: [RESEND PATCH 2/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings

2015-09-10 Thread Philipp Zabel
Am Donnerstag, den 10.09.2015, 14:11 +0800 schrieb Chen Feng: > Add DT bindings documentation for hi6220 SoC reset controller. > > Signed-off-by: Chen Feng > --- > .../bindings/reset/hisilicon,hi6220-reset.txt | 97 > ++ > arch/arm64/boot/dts/hisilicon/hi6220.dtsi

Re: [RESEND PATCH 1/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC

2015-09-10 Thread Philipp Zabel
Hi, Am Donnerstag, den 10.09.2015, 14:11 +0800 schrieb Chen Feng: > Add reset controller for hi6220 hikey-board. > > Signed-off-by: Chen Feng > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.d

Re: [PATCH] reset: Fix of_reset_control_get() for consistent return values

2015-09-03 Thread Philipp Zabel
Hi Alban, Am Mittwoch, den 02.09.2015, 18:35 +0200 schrieb Alban: [...] > That's no really the case. If the property doesn't exists, or the > requested index is out of range, of_parse_phandle_with_args() always > return -ENOENT. This is important for optional properties. You are right, I've looke

Re: [PATCH] reset: Fix of_reset_control_get() for consistent return values

2015-09-02 Thread Philipp Zabel
Hi Alban, Am Dienstag, den 01.09.2015, 17:28 +0200 schrieb Alban Bedel: > When of_reset_control_get() is called without connection ID it returns > -ENOENT when the 'resets' property doesn't exists or is an empty entry. > However when a connection ID is given it returns -EINVAL when the 'resets' >

Re: [PATCH] reset: ath79: Fix missing spin_lock_init

2015-09-01 Thread Philipp Zabel
Am Dienstag, den 01.09.2015, 14:43 +0200 schrieb Alban: > On Tue, 01 Sep 2015 20:15:10 +0800 > Axel Lin wrote: > > > Signed-off-by: Axel Lin > Acked-by: Alban Bedel Applied, thanks. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH v2] reset: Add (devm_)reset_control_get stub functions

2015-09-01 Thread Philipp Zabel
Am Dienstag, den 01.09.2015, 07:56 +0800 schrieb Axel Lin: > So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. > > Signed-off-by: Axel Lin Applied, thanks. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] reset: Add (devm_)reset_control_get stub functions

2015-08-31 Thread Philipp Zabel
Hi Axel, thank you for the patch. Am Montag, den 31.08.2015, 17:22 +0800 schrieb Axel Lin: > So the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. > > Signed-off-by: Axel Lin > --- > include/linux/reset.h | 12 > 1 file changed, 12 insertions(+) > > diff --git a/i

Re: [PATCH 04/12] gpu: imx: fix support for interlaced modes

2015-08-27 Thread Philipp Zabel
Am Donnerstag, den 27.08.2015, 09:54 +0100 schrieb Russell King - ARM Linux: > On Thu, Aug 27, 2015 at 10:39:12AM +0200, Philipp Zabel wrote: > > Hi Russell, > > > > Am Samstag, den 08.08.2015, 17:03 +0100 schrieb Russell King: > > > The support for interlaced vide

Re: [PATCH 0/9] dw-hdmi audio support

2015-08-27 Thread Philipp Zabel
upport found on Rockchip patches. > Thanks to Yakir Yang for contributing the I2S support. > > I suspect that there is still some discussion to be had on this > series, though I would like to see it moving forward so that we can > get something merged. Tested-by: Philipp Zabel on i.MX6

Re: [PATCH 04/12] gpu: imx: fix support for interlaced modes

2015-08-27 Thread Philipp Zabel
st this series: Tested-by: Philipp Zabel on i.MX6 GK802 via HDMI connected to a TV (1080p60, 1080i60). Unfortunately these timings are completely different from what Freescale came up with for the TV Encoder on i.MX5, but the code we have currently in mainline doesn't work for that either. I

Re: [RFC][PATCH 1/2] dt-bindings: drm/mediatek: Add Mediatek DRM dts binding

2015-08-26 Thread Philipp Zabel
Hi, overall it looks to me like this binding is modeled after the Linux DRM abstractions. Instead, the device nodes should be modeled after the hardware. Describing each function block as a separate device node is probably not the best choice, as would be combining all devices in the mmsys range

Re: [PATCH v2] pwm-backlight: Avoid backlight flicker when probed from DT

2015-08-26 Thread Philipp Zabel
Hi Thierry, Jingoo, Lee, Am Donnerstag, den 30.07.2015, 19:22 +0200 schrieb Philipp Zabel: > If the driver is probed from the device tree, and there is a phandle > property set on it, and the enable GPIO is already configured as output, > and the backlight is currently disabled, keep it

Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function

2015-08-07 Thread Philipp Zabel
Am Freitag, den 07.08.2015, 14:29 +0100 schrieb Mark Brown: > On Fri, Aug 07, 2015 at 03:21:36PM +0200, Philipp Zabel wrote: > > Am Freitag, den 07.08.2015, 13:31 +0100 schrieb Mark Brown: > > > > (or ideally split out the updates to the > > > drivers into

Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function

2015-08-07 Thread Philipp Zabel
Am Freitag, den 07.08.2015, 13:31 +0100 schrieb Mark Brown: > On Fri, Aug 07, 2015 at 11:29:23AM +0200, Philipp Zabel wrote: > > > Could there any side effects for regulators that currently don't set > > set_voltage_time_sel at all? How about this: > > That look

Re: [PATCH] regulator: da9063: Add set_voltage_time_sel function

2015-08-07 Thread Philipp Zabel
Am Donnerstag, den 06.08.2015, 19:33 +0100 schrieb Mark Brown: > On Thu, Aug 06, 2015 at 06:38:24PM +0200, Philipp Zabel wrote: > > This allows to set the regulator-ramp-delay in the device tree. > > > @@ -433,6 +433,7 @@ static struct regulator_ops da9063_buck_ops = { &

[PATCH] regulator: da9063: Add set_voltage_time_sel function

2015-08-06 Thread Philipp Zabel
This allows to set the regulator-ramp-delay in the device tree. Signed-off-by: Philipp Zabel --- drivers/regulator/da9063-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index aed1ad3..d870028 100644

Re: [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-08-04 Thread Philipp Zabel
Hi Moritz, Am Dienstag, den 04.08.2015, 08:05 -0700 schrieb Moritz Fischer: > Hi Philip, > > On Tue, Aug 4, 2015 at 1:09 AM, Philipp Zabel wrote: > > Hi Moritz, > > > > Am Donnerstag, den 30.07.2015, 18:13 -0700 schrieb Moritz Fischer: [...] > >> +Required p

Re: [PATCH v9 0/9] Add simple NVMEM Framework via regmap.

2015-08-04 Thread Philipp Zabel
l bone cape manager" and few more on the way. Tested-by: Philipp Zabel using the i.MX6 OCOTP shadow register range. regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: [PATCH 3/3] MIPS: ath79: Add the reset controller to the AR9132 dtsi

2015-08-04 Thread Philipp Zabel
Am Montag, den 03.08.2015, 20:23 +0200 schrieb Ralf Baechle: > On Mon, Aug 03, 2015 at 07:23:53PM +0200, Alban Bedel wrote: > > Acked-by: Ralf Baechle t > > Philipp, > > Feel free to take this through the reset tree. Or I can carry this in > the MIPS tree which is probably better for testing.

Re: [RFCv3 4/4] ARM: zynq: Select ARCH_HAS_RESET_CONTROLLER

2015-08-04 Thread Philipp Zabel
Hi, Am Freitag, den 31.07.2015, 09:47 -0700 schrieb Sören Brinkmann: > On Fri, 2015-07-31 at 10:09AM +0200, Michal Simek wrote: [...] > > Reviewed-by: Michal Simek > Acked-by: Sören Brinkmann I'll assume these apply to the whole series and queue patches 1 and 3. best regards Philipp -- To uns

Re: [RFCv3 1/4] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-08-04 Thread Philipp Zabel
Hi Moritz, Am Donnerstag, den 30.07.2015, 18:13 -0700 schrieb Moritz Fischer: > Signed-off-by: Moritz Fischer > --- > .../devicetree/bindings/reset/zynq-reset.txt | 68 > ++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rese

Re: [PATCHv2 3/4] reset: socfpga: Update reset-socfpga to read the altr,modrst-offset property

2015-08-03 Thread Philipp Zabel
Hi Dinh, Am Freitag, den 31.07.2015, 16:03 -0500 schrieb dingu...@opensource.altera.com: > From: Dinh Nguyen > > In order for the Arria10 to be able to re-use the reset driver for SoCFPGA > Cyclone5/Arria5, we need to read the 'altr,modrst-offset' property from the > device tree entry. The 'altr

[PATCH v2] pwm-backlight: Avoid backlight flicker when probed from DT

2015-07-30 Thread Philipp Zabel
backlight at the appropriate time. Signed-off-by: Philipp Zabel --- Changes since v1: - Also check if the regulator is enabled. If the power supply is disabled, and a phandle points to it, the backlight should stay powered down. --- drivers/video/backlight/pwm_bl.c | 23 +++ 1

Re: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-07-28 Thread Philipp Zabel
Hi Moritz, Michal, Am Dienstag, den 28.07.2015, 06:57 -0700 schrieb Moritz Fischer: [...] > >>> +Example: > >>> +rstc: rstc@240 { > >>> +#reset-cells = <1>; > >>> +compatible = "xlnx,zynq-reset-pl"; > >>> +syscon = <&slcr>; > >> > >> Why the syscon phandle i

Re: [PATCH 3/4] reset: socfpga: Update reset-socfpga to read the altr,modrst-offset property

2015-07-28 Thread Philipp Zabel
Am Montag, den 27.07.2015, 13:57 -0500 schrieb dingu...@opensource.altera.com: > From: Dinh Nguyen > > In order for the Arria10 to be able to re-use the reset driver for SoCFPGA > Cyclone5/Arria5, we need to read the 'altr,modrst-offset' property from the > device tree entry. The 'altr,modrst-off

Re: [RFCv2 3/3] reset: reset-zynq: Adding support for Xilinx Zynq reset controller.

2015-07-28 Thread Philipp Zabel
Hi Moritz, Am Freitag, den 24.07.2015, 17:21 -0700 schrieb Moritz Fischer: > This adds a reset controller driver to control the Xilinx Zynq > SoC's various resets. > > Signed-off-by: Moritz Fischer > --- > drivers/reset/Makefile | 1 + > drivers/reset/reset-zynq.c | 142 > +++

Re: [RFCv2 1/3] docs: dts: Added documentation for Xilinx Zynq Reset Controller bindings.

2015-07-28 Thread Philipp Zabel
Am Freitag, den 24.07.2015, 17:21 -0700 schrieb Moritz Fischer: > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 + > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.txt

Re: [RFC 1/3] docs: dts: Added documentation for Xilinx Zynq PL Reset bindings.

2015-07-24 Thread Philipp Zabel
Am Donnerstag, den 23.07.2015, 15:51 -0700 schrieb Moritz Fischer: > Signed-off-by: Moritz Fischer > --- > Documentation/devicetree/bindings/reset/zynq-reset-pl.txt | 13 + > 1 file changed, 13 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/zynq-reset-pl.t

Re: [PATCH v3] serial: mxs-auart: keep the AUART unit in reset state when not in use

2015-07-17 Thread Philipp Zabel
Am Freitag, den 17.07.2015, 09:10 -0400 schrieb Peter Hurley: > Hi Juergen, > > On 07/16/2015 03:40 AM, Juergen Borleis wrote: > > Whenever the UART device driver gets closed from userland, the driver > > disables the UART unit and then stops its clock to save power. > > > > The bit which disable

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-13 Thread Philipp Zabel
Hi Srinivas, Am Freitag, den 10.07.2015, 10:44 +0100 schrieb Srinivas Kandagatla: > This patch adds just providers part of the framework just to enable easy > review. [...] > +/** > + * nvmem_register() - Register a nvmem device for given nvmem_config. > + * Also creates an binary entry in /sys/bu

Re: [PATCH] pwm-backlight: Avoid backlight flicker when probed from DT

2015-07-13 Thread Philipp Zabel
Hi, Am Freitag, den 12.06.2015, 18:26 +0200 schrieb Philipp Zabel: > If the driver is probed from the device tree, and there is a phandle > property set on it, and the enable GPIO is already configured as output, > and the backlight is currently disabled, keep it disabled. >

[PATCH] pwm-backlight: Avoid backlight flicker when probed from DT

2015-06-12 Thread Philipp Zabel
backlight at the appropriate time. Signed-off-by: Philipp Zabel --- I have seen the thread at https://lkml.org/lkml/2014/7/31/259, but I'm not sure if it has come to a resolution. This is what I think could be useful to keep the current default behaviour of enabling the backlight while at the same

[PATCH] gpio: generic: add get_direction support

2015-06-12 Thread Philipp Zabel
Allow to determine the current direction configuration by reading back from the direction register. Signed-off-by: Philipp Zabel --- drivers/gpio/gpio-generic.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpio/gpio-generic.c b/drivers/gpio/gpio-generic.c

Re: [PATCH] mfd: syscon: allow to register syscon with a device

2015-06-09 Thread Philipp Zabel
Hi Arnd, any thought on this? Am Dienstag, den 28.04.2015, 16:19 +0530 schrieb Pankaj Dubey: > +To: Arnd Bergmann > > Hi Philipp, > > On Friday 24 April 2015 02:02 PM, Philipp Zabel wrote: > > Am Dienstag, den 17.03.2015, 11:24 +0100 schrieb Philipp Zabel: > >

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

2015-05-29 Thread Philipp Zabel
Hi Vladimir, Am Freitag, den 29.05.2015, 14:31 +0300 schrieb Vladimir Zapolskiy: [...] > > res->start is of type phys_addr_t (well, resource_size_t) already. > > block->start/size and cur_start/size are just offsets added to it. > > I agree. > > > I wonder if it wouldn't be more appropriate to u

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

2015-05-26 Thread Philipp Zabel
Hi Vladimir, Am Sonntag, den 24.05.2015, 23:12 +0300 schrieb Vladimir Zapolskiy: > Hi Philipp, > > On 20.05.2015 14:30, Philipp Zabel wrote: > > Hi Vladimir, > > > > Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: > >> Hi Philipp, &g

Re: [PATCH v2] ARM: dts: nitrogen6x: add CAN support

2015-05-22 Thread Philipp Zabel
Hi Peter, Am Donnerstag, den 21.05.2015, 19:45 +0200 schrieb Peter Seiderer: > Regulator stuff copied from imx6qdl-tx6.dtsi, pin configuration > taken from Boundary Devices linux kernel tree ([1] and [2]). > > [1] > https://github.com/boundarydevices/linux-imx6/blob/boundary-imx_3.10.17_1.0.2_ga

Re: [PATCH v4 1/2] arm, imx6, dts: add DT for aristainetos2 board

2015-05-22 Thread Philipp Zabel
rm/boot/dts/imx6dl-aristainetos2_4.dts > @@ -0,0 +1,158 @@ > +/* > + * Copyright (C) 2014 Rabeeh Khoury (rab...@solid-run.com) > + * Based on dt work by Russell King This is new. Copy & paste error? With proper copyright information restored, Reviewed-by: Philipp Zabel regards Philipp -- T

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

2015-05-20 Thread Philipp Zabel
Hi Vladimir, Am Dienstag, den 19.05.2015, 16:11 +0300 schrieb Vladimir Zapolskiy: > Hi Philipp, > > On 19.05.2015 13:41, Philipp Zabel wrote: > > Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: > >> If devm_gen_pool_create() fails, the previously enabl

Re: [PATCH v3] arm, imx6, dts: add DT for aristainetos2 board

2015-05-20 Thread Philipp Zabel
Hi Heiko, Am Mittwoch, den 20.05.2015, 07:31 +0200 schrieb Heiko Schocher: [...] > diff --git a/arch/arm/boot/dts/imx6dl-aristainetos2_4.dts > b/arch/arm/boot/dts/imx6dl-aristainetos2_4.dts > new file mode 100644 > index 000..780fc42 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6dl-aristainet

Re: [PATCH] [media] coda: remove extraneous TRACE_SYSTEM_STRING

2015-05-20 Thread Philipp Zabel
ot define TRACE_SYSTEM_STRING"). As he points out, this is the result of a bogus copy & paste. Kamil, would you queue either of them with my Acked-by: Philipp Zabel thanks Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH][linux-next] coda: Do not define TRACE_SYSTEM_STRING

2015-05-20 Thread Philipp Zabel
9,6 @@ > > #include "coda.h" > > -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > - > TRACE_EVENT(coda_bit_run, > TP_PROTO(struct coda_ctx *ctx, int cmd), Acked-by: Philipp Zabel thanks Philipp -- To unsubscribe from this list: send the line &qu

Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board

2015-05-19 Thread Philipp Zabel
Hi Heiko, Am Dienstag, den 19.05.2015, 15:44 +0200 schrieb Heiko Schocher: > Hello Philipp, > > Am 19.05.2015 10:48, schrieb Philipp Zabel: > > Hi Heiko, Shawn, > > > > Am Dienstag, den 19.05.2015, 09:09 +0200 schrieb Heiko Schocher: > > [...] > >&

Re: [PATCH v3 1/9] misc: sram: fix enabled clock leak on error path

2015-05-19 Thread Philipp Zabel
Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: > If devm_gen_pool_create() fails, the previously enabled sram->clk is > not disabled on probe() exit. > > Signed-off-by: Vladimir Zapolskiy > --- > drivers/misc/sram.c | 9 + > 1 file changed, 5 insertions(+), 4 deletion

Re: [PATCH v3 3/9] misc: sram: use phys_addr_t instead of u32 for physical address

2015-05-19 Thread Philipp Zabel
Hi Vladimir, Am Montag, den 18.05.2015, 22:08 +0300 schrieb Vladimir Zapolskiy: > To avoid any problems on non 32-bit platforms get and store memory > addresses under phys_addr_t type. > > Signed-off-by: Vladimir Zapolskiy > --- > Changes from v1 to v2: > - report size of SRAM in decimal format

Re: [PATCH v2] arm, imx6, dts: add DT for aristainetos2 board

2015-05-19 Thread Philipp Zabel
Hi Heiko, Shawn, Am Dienstag, den 19.05.2015, 09:09 +0200 schrieb Heiko Schocher: [...] > > What is this? I failed to find it in Documentation/devicetree/bindings/ > > Ah, this is not documentated, see commit: > > commit 628f435be4359e6ae8ecfdda9b492053be76a057 > Author:

Re: [PATCH v2 03/10] reset: berlin: convert to a platform driver

2015-05-13 Thread Philipp Zabel
Hi Antoine, Sebastian, Am Dienstag, den 12.05.2015, 16:43 +0200 schrieb Antoine Tenart: > On Tue, Mar 10, 2015 at 10:57:13AM +0100, Antoine Tenart wrote: > > On Mon, Mar 09, 2015 at 11:16:26AM +0100, Philipp Zabel wrote: > > > > > > Am Freitag, den 06.03.2015, 16:05 +

Re: [PATCH v7 05/15] dt-bindings: Document the STM32 reset bindings

2015-05-05 Thread Philipp Zabel
Am Dienstag, den 05.05.2015, 17:19 +0200 schrieb Maxime Coquelin: > >> For example, includes/dt-bindings/mfd/stm32f4-rcc.h would look like: > >> > >> #define GPIOA 0 > >> #define GPIOB 1 > >> ... > >> #define LTDC 186 That looks a bit fragile. At least the defines for the indices should be properl

Re: [PATCH v7 05/15] dt-bindings: Document the STM32 reset bindings

2015-05-04 Thread Philipp Zabel
Am Samstag, den 02.05.2015, 11:01 +0100 schrieb Daniel Thompson: > On 02/05/15 08:55, Maxime Coquelin wrote: > > 2015-05-01 10:08 GMT+02:00 Daniel Thompson : [...] > >> Do you intend the clock driver to use the same compatible string (given it > >> is the same bit of hardware). > >> > >> If so, is

Re: [PATCH] mfd: syscon: allow to register syscon with a device

2015-04-24 Thread Philipp Zabel
Am Dienstag, den 17.03.2015, 11:24 +0100 schrieb Philipp Zabel: > Commit bdb0066df96e ("mfd: syscon: Decouple syscon interface from platform > devices") > added the possibility to register syscon devices without associated platform > device. This also removed regmap deb

Re: linux-next: manual merge of the v4l-dvb tree with Linus' tree

2015-04-21 Thread Philipp Zabel
Am Dienstag, den 21.04.2015, 10:12 -0300 schrieb Mauro Carvalho Chehab: > Em Tue, 21 Apr 2015 15:38:02 +0300 > Laurent Pinchart escreveu: > > > Hi Mauro, > > > > On Tuesday 21 April 2015 06:56:40 Mauro Carvalho Chehab wrote: > > > Em Tue, 21 Apr 2015 18:02:43 +1000 Stephen Rothwell escreveu: > >

Re: linux-next: manual merge of the drm tree with the v4l-dvb tree

2015-04-17 Thread Philipp Zabel
Am Freitag, den 17.04.2015, 04:07 +0100 schrieb Dave Airlie: > > Am Mittwoch, den 15.04.2015, 13:33 +1000 schrieb Stephen Rothwell: > > > Hi Dave, > > > > > > Today's linux-next merge of the drm tree got a conflict in > > > Documentation/DocBook/media/v4l/subdev-formats.xml between commit > > > 7b

[PATCH] Fixup RGB444_1X12, RGB565_1X16, and YUV8_1X24 media bus format

2015-04-17 Thread Philipp Zabel
Change the constant values for RGB444_1X12, RGB565_1X16, and YUV8_1X24 media bus formats in anticipation of a merge conflict with the media tree, where the old values are already taken by RBG888_1X24, RGB888_1X32_PADHI, and VUY8_1X24, respectively. Signed-off-by: Philipp Zabel --- Documentation

Re: linux-next: manual merge of the drm tree with the v4l-dvb tree

2015-04-15 Thread Philipp Zabel
Am Mittwoch, den 15.04.2015, 13:33 +1000 schrieb Stephen Rothwell: > Hi Dave, > > Today's linux-next merge of the drm tree got a conflict in > Documentation/DocBook/media/v4l/subdev-formats.xml between commit > 7b0fd4568bee ("[media] v4l: Add RBG and RGB 8:8:8 media bus formats on > 24 and 32 bit

Re: linux-next: manual merge of the drm tree with the v4l-dvb tree

2015-04-15 Thread Philipp Zabel
Am Mittwoch, den 15.04.2015, 13:49 +1000 schrieb Stephen Rothwell: > Hi Dave, > > Today's linux-next merge of the drm tree got a conflict in > include/uapi/linux/media-bus-format.h between commits 7b0fd4568bee > ("[media] v4l: Add RBG and RGB 8:8:8 media bus formats on 24 and 32 bit > busses"), e8

Re: [PATCH v4 05/15] dt-bindings: Document the STM32 reset bindings

2015-04-01 Thread Philipp Zabel
RCC IP is both a reset and a clock controller. This documentation only > +document the reset part. documents? Otherwise, Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH v4 06/15] drivers: reset: Add STM32 reset driver

2015-04-01 Thread Philipp Zabel
f-by: Maxime Coquelin Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/6] clk: mediatek: Add reset controller support

2015-03-31 Thread Philipp Zabel
ines. > > Signed-off-by: Sascha Hauer Acked-by: Philipp Zabel regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RESEND PATCH v5] clk: Add PWM clock driver

2015-03-26 Thread Philipp Zabel
device tree, this is a fixed clock. Tested-by: Janusz Uzycki Signed-off-by: Philipp Zabel --- Changes since v4: - Added missing static keywords, as pointed out by Stephen Boyd - Turned to_clk_pwm into an inline function, - added MODULE_AUTHOR/DESCRIPTION/LICENSE, - and fixed PWM spelling issues

Re: [GIT PULL v2] of: Add of-graph helpers to loop over endpoints and find ports by id

2015-03-25 Thread Philipp Zabel
Hi Rob, Am Dienstag, den 24.03.2015, 23:42 -0500 schrieb Rob Herring: > On Tue, Mar 24, 2015 at 4:15 AM, Russell King - ARM Linux > wrote: > > On Mon, Mar 23, 2015 at 05:29:02PM +0100, Heiko Stuebner wrote: > >> Hi Rob, Philipp, > >> > >> Am Mittwoch,

Re: [PATCH 1/2] drm_modes: videomode: add pos/neg pixel clock polarity flag

2015-03-17 Thread Philipp Zabel
Hi Sébastien, Am Montag, den 16.03.2015, 18:29 +0100 schrieb Sébastien Szymanski: > From: Steve Longerbeam > > [Sébastien - rebase, update drm_display_mode_to_videomode function] > > Signed-off-by: Steve Longerbeam > Signed-off-by: Sébastien Szymanski Thanks for bringing this up again. This

[PATCH] mfd: syscon: allow to register syscon with a device

2015-03-17 Thread Philipp Zabel
ent, this patch allows again to register syscon regions with an associated device where that this device exists anyway. [fixed max_register parameter in case of device register] Signed-off-by: Peter Seiderer Signed-off-by: Philipp Zabel --- drivers/mfd/syscon.c | 29 +

Re: [PATCH 27/35 linux-next] reset: sti: constify of_device_id array

2015-03-17 Thread Philipp Zabel
Hi Fabian, Am Montag, den 16.03.2015, 20:54 +0100 schrieb Fabian Frederick: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > > Signed-off-by: Fabian Frederick > --- > drivers/reset/sti/reset-stih407.c | 2 +- > drivers/reset/sti/reset-stih415.c

Re: [PATCH v3 06/15] drivers: reset: Add STM32 reset driver

2015-03-13 Thread Philipp Zabel
Am Donnerstag, den 12.03.2015, 22:55 +0100 schrieb Maxime Coquelin: > From: Maxime Coquelin > > The STM32 MCUs family IP can be reset by accessing some shared registers. > > The specificity is that some reset lines are used by the timers. > At timer initialization time, the timer has to be reset

Re: [PATCH v3 05/15] dt-bindings: Document the STM32 reset bindings

2015-03-13 Thread Philipp Zabel
Hi Maxime, Am Donnerstag, den 12.03.2015, 22:55 +0100 schrieb Maxime Coquelin: > From: Maxime Coquelin > > This adds documentation of device tree bindings for the > STM32 reset controller. > > Signed-off-by: Maxime Coquelin > --- > .../devicetree/bindings/reset/st,stm32-rcc.txt | 102 > +

Re: [PATCH 0/3] clk: divider: three exactness fixes (and a rant)

2015-03-13 Thread Philipp Zabel
Am Freitag, den 13.03.2015, 08:50 +0100 schrieb Uwe Kleine-König: > On Thu, Mar 12, 2015 at 09:57:53AM +0100, Philipp Zabel wrote: > > Am Mittwoch, den 11.03.2015, 18:21 -0700 schrieb Stephen Boyd: > > [...] > > > Why does Philipp like 110Hz the most? Where is the desire fo

Re: [PATCH] input: eglx_ts, remove irq trigger flags

2015-03-12 Thread Philipp Zabel
Hi Markus, Am Donnerstag, den 12.03.2015, 15:50 +0100 schrieb Markus Pargmann: > The trigger settings for a given irq are parsed from DT. Defining them > as flag for devm_request_threaded_irq() overwrites these settings. This > results in wrong trigger settings for boards which have different irq

Re: [PATCH v2 01/17] reset: add of_reset_control_get_by_index()

2015-03-12 Thread Philipp Zabel
Hi Vince, Am Donnerstag, den 12.03.2015, 20:15 +0800 schrieb Vince Hsu: > Add of_reset_control_get_by_index() to allow the drivers to get reset device > without knowing its name. I see this is useful in the case of PM domain drivers that just need to trigger a list of resets in whatever order. >

Re: [PATCH v4 02/15] drm: bridge/dw_hdmi: wrap irq control in fucntions

2015-03-12 Thread Philipp Zabel
Hi Yakir, Am Donnerstag, den 12.03.2015, 22:31 +0800 schrieb yakir: > Hi Philipp, > > On 2015年03月12日 18:24, Philipp Zabel wrote: > > Hi Yakir, > > > > Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang: > >> Wrap irq control in functions, and t

Re: [PATCH v4 04/15] drm: bridge/dw_hdmi: add identification registers parse and record

2015-03-12 Thread Philipp Zabel
Am Samstag, den 28.02.2015, 21:35 -0500 schrieb Yakir Yang: > By parsing the identification registers we can know what functions > are present on the hdmi ip. > > Signed-off-by: Yakir Yang > --- > Changes in v4: > -Correct phy_type assignment bug > > Changes in v3: > - Add ID registers parse and

Re: [PATCH v4 02/15] drm: bridge/dw_hdmi: wrap irq control in fucntions

2015-03-12 Thread Philipp Zabel
Hi Yakir, Am Samstag, den 28.02.2015, 21:28 -0500 schrieb Yakir Yang: > Wrap irq control in functions, and then we can call in > dw_hdmi_bind/dw_hdmi_unbind/dw_hdmi_resume/dw_hdmi_suspend > functions. > > Signed-off-by: Yakir Yang [...] > @@ -1702,17 +1722,8 @@ EXPORT_SYMBOL_GPL(dw_hdmi_unbind);

<    9   10   11   12   13   14   15   16   17   18   >