RE: [Linux-stm32] [PATCH] drm/stm: ltdc: Use simple encoder

2021-03-08 Thread Philippe CORNU - foss
gan Teki; Yannick FERTRE; Philippe CORNU; Benjamin Gaignard; Vincent ABRIOU Cc : dri-de...@lists.freedesktop.org; linux-amar...@amarulasolutions.com; linux-kernel@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-st...@st-md-mailman.stormreply.com Objet : Re: [Linux-stm32] [PATCH] drm/s

RE: panel: panel-raydium68200 driver fails to write MIPI DSI init commands

2021-01-19 Thread Philippe CORNU
; David Airlie ; Daniel Vetter ; Sam Ravnborg ; Philippe CORNU ; Antonio BORNEO ; Subject: drm: panel: panel-raydium68200 driver fails to write MIPI DSI init commands I need to bring up my MIPI DSI 1280x720 EDT ETML0500F3DHA panel on a RockPro64 V2.1 board. There is no completely suitable in-tr

Re: [PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas

2020-10-15 Thread Philippe CORNU
lienne > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: "Guido Gúnther" > Cc: Robert Chiras > Cc: Philippe Cornu Hi Rob, and many thanks for the patch. For the stm32 part, Reviewed-by: Philippe Cornu Philippe :-)

Re: [PATCH v2] drm/stm: dsi: Use dev_ based logging

2020-10-15 Thread Philippe CORNU
dw_mipi_dsi_get_lane_mbps(void *priv_data, const struct > drm_display_mode *mode, > > /* Select the color coding */ > dsi_update_bits(dsi, DSI_WCFGR, WCFGR_COLMUX, > - dsi_color_from_mipi(format) << 1); > + dsi_color_from_m

Re: [PATCH] drm/panel: rm68200: fix mode to 50fps

2020-10-12 Thread Philippe CORNU
80 + 12 + 5, > + .vtotal = 1280 + 12 + 5 + 12, > .flags = 0, > .width_mm = 68, > .height_mm = 122, > Hi Yannick, Tested-by: Philippe Cornu Thank you, Philippe

Re: [PATCH] drm/bridge: dw-mipi-dsi: permit configuring the escape clock rate

2020-09-11 Thread Philippe CORNU
(*get_timing)(void *priv_data, unsigned int lane_mbps, > struct dw_mipi_dsi_dphy_timing *timing); > + int (*get_esc_clk_rate)(void *priv_data, unsigned int *esc_clk_rate); > }; > > struct dw_mipi_dsi_host_ops { > Hi Neil, Thank you for the patch Reviewed-by: Philippe Cornu Philippe :-)

Re: [PATCH] drm/bridge/synopsys: dsi: allow sending longer LP commands

2020-07-10 Thread Philippe CORNU
in high speed is enable (PHY_TXREQUESTCLKHS) > - */ > - dsi_write(dsi, DSI_DPI_LP_CMD_TIM, OUTVACT_LPCMD_TIME(4) > - | INVACT_LPCMD_TIME(4)); > } > > static void dw_mipi_dsi_packet_handler_config(struct dw_mipi_dsi *dsi) > (+ Antonio) Hi Yannick &a

Re: [PATCH] drm/bridge/synopsys: dsi: add support for non-continuous HS clock

2020-07-10 Thread Philippe CORNU
dsi_write(dsi, DSI_MODE_CFG, ENABLE_CMD_MODE); > } > > + val = PHY_TXREQUESTCLKHS; > + if (dsi->mode_flags & MIPI_DSI_CLOCK_NON_CONTINUOUS) > + val |= AUTO_CLKLANE_CTRL; > + dsi_write(dsi, DSI_LPCLK_CTRL, val); > + > dsi_write(

Re: [PATCH v2] drm/bridge/synopsys: dsi: allow LP commands in video mode

2020-07-10 Thread Philippe CORNU
VID_MODE_CFG, val); > } > > static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 > hdr_val) > (+ Antonio) Hi Yannick & Antonio, Reviewed-by: Philippe Cornu Tested-by: Philippe Cornu (Tested with the 3 patches named drm/bridge/synopsys: dsi: allow LP command

Re: [PATCH v2] drm/bridge: dw-mipi-dsi.c: Add VPG runtime config through debugfs

2020-07-09 Thread Philippe CORNU
On 7/8/20 7:08 PM, Angelo Ribeiro wrote: > Hi, > > Is this patch good to go? > @dan...@ffwll.ch, @Philippe CORNU > > Was already tested by @Yannick FERTRE > and @Adrian Pop > on https://lkml.org/lkml/2020/4/6/691 . > > Thanks, > Angelo > > From: Yannick

Re: [PATCH] drm/stm: ltdc: remove call of pm-runtime functions

2020-07-02 Thread Philippe CORNU
t; - if (ret) { > - DRM_ERROR("Failed to fixup mode, cannot get sync\n"); > - return false; > - } > - } > - > DRM_DEBUG_DRIVER("requested clock %dkHz, adjusted clock %dkHz\n", >mode->clock, adjusted_mode->clock); > > Hi Yannick, Many thanks for your patch, Acked-by: Philippe Cornu Philippe :-)

Re: [Linux-stm32] [PATCH v8 08/10] drm: stm: dw-mipi-dsi: let the bridge handle the HW version check

2020-05-29 Thread Philippe CORNU
Hi Adrian, and thank you very much for the patchset. Thank you also for having tested it on STM32F769 and STM32MP1. Sorry for the late response, Yannick and I will review it as soon as possible and we will keep you posted. Note: Do not hesitate to put us in copy for the next version (philippe.co.

Re: [PATCH] drm/stm: ltdc: add pinctrl for DPI encoder mode

2019-09-02 Thread Philippe CORNU
drm_encoder_init(ddev, encoder, <dc_encoder_funcs, >DRM_MODE_ENCODER_DPI, NULL); > > + drm_encoder_helper_add(encoder, <dc_encoder_helper_funcs); > + > ret = drm_bridge_attach(encoder, bridge, NULL); > if (ret) { >

Re: [PATCH] ARM: dts: stm32: move ltdc pinctrl on stm32mp157a dk1 board

2019-09-02 Thread Philippe CORNU
inctrl-0 = <<dc_pins_a>; > - pinctrl-1 = <<dc_pins_sleep_a>; > status = "okay"; > > ports { > @@ -276,6 +273,9 @@ > }; > > <dc { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <<dc_pins_a>; > + pinctrl-1 = <<dc_pins_sleep_a>; Reviewed-by: Philippe Cornu Thanks Philippe :) > status = "okay"; > > port { >

Re: [PATCH] drm/bridge: sii902x: add audio graph card support

2019-07-05 Thread Philippe CORNU
Hi Olivier, and many thanks for your patch. Good to have the audio graph card support, looks ok. Reviewed-by: Philippe Cornu Philippe :-) On 7/3/19 10:04 AM, Olivier Moysan wrote: > Implement get_dai_id callback of audio HDMI codec > to support ASoC audio graph card. > HDMI audio outp

Re: [PATCH 2/3] dt-bindings: display: sii902x: Change audio mclk binding

2019-07-05 Thread Philippe CORNU
s not required." So, even if #sound-dai-cells is there, this is not mandatory to have MCLK. Reviewed-by: Philippe Cornu Philippe :-) On 7/2/19 5:47 PM, Olivier Moysan wrote: > As stated in SiL9022/24 datasheet, master clock is not required for I2S. > Make mclk property optional in DT bind

Re: [PATCH v2] drm/stm: ltdc: remove clk_round_rate comment

2019-05-13 Thread Philippe CORNU
Dear Yannick, Acked-by: Philippe Cornu Thank you, Philippe :-) On 5/13/19 3:15 PM, Yannick Fertré wrote: > Clk_round_rate returns rounded clock without changing > the hardware in any way. > This function couldn't replace set_rate/get_rate calls. > Todo comment has been re

Re: [PATCH] drm/bridge: checkpatch strict minor updates

2018-05-17 Thread Philippe CORNU
37:36PM +0200, Philippe Cornu wrote: >> Minor fixes detected with "scripts/checkpatch.pl --strict" >> >> Signed-off-by: Philippe Cornu >> --- >> Detected when merging "drm: clarify adjusted_mode documentation for bridges" > > Acked-by: Daniel

[PATCH] drm/bridge: checkpatch strict minor updates

2018-05-15 Thread Philippe Cornu
Minor fixes detected with "scripts/checkpatch.pl --strict" Signed-off-by: Philippe Cornu --- Detected when merging "drm: clarify adjusted_mode documentation for bridges" include/drm/drm_bridge.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] drm: clarify adjusted_mode documentation for bridges

2018-05-15 Thread Philippe CORNU
Hi, Applied on drm-misc-next. Many thanks, Philippe :-) On 04/19/2018 07:00 PM, Archit Taneja wrote: > > > On Thursday 19 April 2018 09:20 PM, Philippe CORNU wrote: >> Hi Archit & Andrzej, >> >> May I ask you please a short review of this documentation upd

Re: [PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies

2018-05-14 Thread Philippe CORNU
Hi Andrzej, On 05/14/2018 12:33 PM, Andrzej Hajda wrote: > On 14.05.2018 11:38, Philippe CORNU wrote: >> Hi Laurent, Archit, Andrzej & Yannick, >> >> Do you have any comments on this v2 driver part? >> (more details regarding v1/v2 differences in the cover letter &

Re: [PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies

2018-05-14 Thread Philippe CORNU
Hi Laurent, Archit, Andrzej & Yannick, Do you have any comments on this v2 driver part? (more details regarding v1/v2 differences in the cover letter https://www.spinics.net/lists/dri-devel/msg174137.html) Thank you, Philippe :-) On 04/25/2018 09:53 AM, Philippe Cornu wrote: >

Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-05-14 Thread Philippe CORNU
Hi Rob & Laurent :) On 04/26/2018 12:05 AM, Laurent Pinchart wrote: > Hi Rob, > > On Wednesday, 25 April 2018 20:11:23 EEST Rob Herring wrote: >> On Wed, Apr 25, 2018 at 04:17:25PM +0300, Laurent Pinchart wrote: >>> On Wednesday, 25 April 2018 15:20:04 EEST Philipp

Re: [PATCH] drm/stm: ltdc: fix warnings in ltdc_plane_create()

2018-04-27 Thread Philippe CORNU
On 04/25/2018 09:13 AM, Yannick FERTRE wrote: > Hi Philippe, > > Reviewed-by: Yannick Fertré > Applied on drm-misc-next. Many thanks, Philippe :-) > > On 04/19/2018 03:28 PM, Philippe Cornu wrote: >> "make C=1" returns 2 warnings in ltdc_plane_create(

Re: [PATCH] drm/stm: ltdc: add mode_valid()

2018-04-27 Thread Philippe CORNU
On 04/25/2018 09:12 AM, Yannick FERTRE wrote: > Hi Philippe, > > Reviewed-by: Yannick Fertré > Applied on drm-misc-next. Many thanks, Philippe :-) > On 04/17/2018 01:40 PM, Philippe Cornu wrote: >> Add mode_valid() function to filter modes according to available &g

Re: [PATCH] drm/stm: ltdc: fix deferred endpoint management

2018-04-27 Thread Philippe CORNU
On 04/25/2018 09:12 AM, Yannick FERTRE wrote: > Hi Philippe, > > Reviewed-by: Yannick Fertré Applied on drm-misc-next. Many thanks, Philippe :-) > > > On 04/17/2018 01:34 PM, Philippe Cornu wrote: >> When a driver related to one of the endpoints is deferred >

Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-04-25 Thread Philippe CORNU
Hi Laurent & Rob :-) On 04/25/2018 11:01 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Wednesday, 25 April 2018 10:53:13 EEST Philippe Cornu wrote: >> Add optional power supplies using the description found in >> "SiI9022A/

[PATCH v2 2/2] drm/bridge: sii902x: add optional power supplies

2018-04-25 Thread Philippe Cornu
Add the optional power supplies using the description found in "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". The sii902x input IOs are not "io safe" so it is important to enable/disable voltage regulators during probe/remove phases to avoid damages. Signed-of

[PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-04-25 Thread Philippe Cornu
cc12 and avcc12 can be derived from the same power source" Signed-off-by: Philippe Cornu --- Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation

[PATCH v2 0/2] drm/bridge: sii902x: add optional power supplies

2018-04-25 Thread Philippe Cornu
ual platform is not an handheld device so power consumption is not critical. But in the future, it could be nice to add the standby mode, paying attention to wake-up events (hdmi cable plug)... Version 1: - Initial commit Philippe Cornu (2): dt-bindings/display/bridge: sii902x: add optional

[PATCH 0/4] drm/panel: otm8009a: backlight fixes & improvements

2018-04-23 Thread Philippe Cornu
This patch serie fixes 2 backlight issues and adds the new backlight api support. Philippe Cornu (4): drm/panel: otm8009a: fix backlight updates drm/panel: otm8009a: fix glitches by moving backlight enable to otm8009a_enable() drm/panel: otm8009a: no message if probe success drm/panel

[PATCH 3/4] drm/panel: otm8009a: no message if probe success

2018-04-23 Thread Philippe Cornu
Remove the message in case of probe success. This comes from a suggestion followed in the recent integration of the raydium rm68200 panel. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff

[PATCH 1/4] drm/panel: otm8009a: fix backlight updates

2018-04-23 Thread Philippe Cornu
, sleep in/out... dsi commands work in lp mode. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel

[PATCH 4/4] drm/panel: otm8009a: use new backlight api

2018-04-23 Thread Philippe Cornu
Use the new backlight api. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 26 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech

[PATCH 2/4] drm/panel: otm8009a: fix glitches by moving backlight enable to otm8009a_enable()

2018-04-23 Thread Philippe Cornu
, avoiding also image glitches visible on some "slow" devices. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drive

Re: [PATCH] drm: clarify adjusted_mode documentation for bridges

2018-04-19 Thread Philippe CORNU
Hi Archit & Andrzej, May I ask you please a short review of this documentation update. Many thanks Philippe :-) On 04/09/2018 05:24 PM, Philippe Cornu wrote: > This patch clarifies the adjusted_mode documentation > for bridges. > > Signed-off-by: Philippe Cornu > Sig

[PATCH] drm/stm: ltdc: fix warnings in ltdc_plane_create()

2018-04-19 Thread Philippe Cornu
"make C=1" returns 2 warnings in ltdc_plane_create() ("Using plain integer as NULL pointer"). This patch fixes them. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc

Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-04-19 Thread Philippe CORNU
Hi Laurent, On 04/19/2018 01:09 PM, Laurent Pinchart wrote: > Hi Philippe, > > On Thursday, 19 April 2018 12:31:15 EEST Philippe CORNU wrote: >> On 04/19/2018 10:11 AM, Laurent Pinchart wrote: >>> On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: >>&

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

2018-04-19 Thread Philippe CORNU
Applied on drm-misc-next. Many thanks, Philippe :-) On 02/08/2018 05:46 PM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Thursday, 8 February 2018 16:58:05 EET Philippe Cornu wrote: >> Add SPDX identifiers to the Synopsys DesignWare MIPI D

Re: [PATCH] drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()

2018-04-19 Thread Philippe CORNU
Applied on drm-misc-next. Many thanks, Philippe :-) On 04/16/2018 11:18 AM, Yannick FERTRE wrote: > Reviewed-by: yannick fertre > > > On 04/10/2018 03:53 PM, Philippe Cornu wrote: >> Fix the warning >> "warn: variable dereferenced before check 'crtc' (se

Re: [PATCH] drm/stm: move enable/disable_vblank to crtc

2018-04-19 Thread Philippe CORNU
Applied on drm-misc-next. Many thanks, Philippe :-) On 04/16/2018 11:07 AM, Vincent ABRIOU wrote: > Hi Philippe, > > Patch looks good to me. > > Reviewed-by: Vincent Abriou > > On 04/07/2018 11:29 PM, Philippe Cornu wrote: >> enable/disable_vblank() functions

Re: [PATCH] drm/stm: ltdc: add user update info in plane print state

2018-04-19 Thread Philippe CORNU
Applied on drm-misc-next. Many thanks, Philippe :-) On 04/16/2018 11:14 AM, Vincent ABRIOU wrote: > Hi Philippe, > > Reviewed-by: Vincent Abriou > > On 04/07/2018 11:35 PM, Philippe Cornu wrote: >> This patch adds the user update information in >> frames-per-second

Re: [PATCH 2/2] drm/bridge: sii902x: add optional power supplies

2018-04-19 Thread Philippe CORNU
Hi Laurent :-) On 04/19/2018 10:20 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday, 10 April 2018 08:19:27 EEST Philippe Cornu wrote: >> Add the 3 optional power supplies using the exact description >> found in the document named

Re: [PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-04-19 Thread Philippe CORNU
Hi Laurent : ) On 04/19/2018 10:11 AM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday, 10 April 2018 08:19:26 EEST Philippe Cornu wrote: >> Add the 3 optional power supplies using the exact description >> found in the document named

[PATCH] drm/stm: ltdc: add mode_valid()

2018-04-17 Thread Philippe Cornu
clock tolerances are bigger than hdmi ones and there is no reason to not accept them (the fps may vary a little but it is not a problem). - the hdmi preferred mode will be accepted too, but userland will be able to use others hdmi "valid" modes if necessary. Signed-off-by: Philippe C

[PATCH] drm/stm: ltdc: fix deferred endpoint management

2018-04-17 Thread Philippe Cornu
-off-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index e3121d9e4230..014cef8cef37 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/drivers/gpu/drm/stm/ltdc.c

[PATCH] drm/stm: ltdc: fix warning in ltdc_crtc_update_clut()

2018-04-10 Thread Philippe Cornu
or the bug report https://lists.freedesktop.org/archives/dri-devel/2018-February/166918.html Signed-off-by: Philippe Cornu Reported-by: Dan Carpenter --- drivers/gpu/drm/stm/ltdc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 061d2b6e5157..e3

[PATCH 2/2] drm/bridge: sii902x: add optional power supplies

2018-04-09 Thread Philippe Cornu
Add the 3 optional power supplies using the exact description found in the document named "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/sii902x.c | 39 +++ 1 file changed, 35

[PATCH 0/2] drm/bridge: sii902x: add optional power supplies

2018-04-09 Thread Philippe Cornu
This patchset adds the 3 optional power supplies to the sii902x drm bridge driver. Philippe Cornu (2): dt-bindings/display/bridge: sii902x: add optional power supplies drm/bridge: sii902x: add optional power supplies .../devicetree/bindings/display/bridge/sii902x.txt | 3 ++ drivers/gpu

[PATCH 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies

2018-04-09 Thread Philippe Cornu
Add the 3 optional power supplies using the exact description found in the document named "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". Signed-off-by: Philippe Cornu --- Documentation/devicetree/bindings/display/bridge/sii902x.txt | 3 +++ 1 file changed, 3 insertion

[PATCH] drm: clarify adjusted_mode documentation for bridges

2018-04-09 Thread Philippe Cornu
This patch clarifies the adjusted_mode documentation for bridges. Signed-off-by: Philippe Cornu Signed-off-by: Laurent Pinchart --- This patch follows discussions in: - "drm: clarify adjusted_mode for a bridge connected to a crtc" https://patchwork.freedesktop.org/patch/206801/ - &q

[PATCH] drm/stm: ltdc: add user update info in plane print state

2018-04-07 Thread Philippe Cornu
This patch adds the user update information in frames-per-second into the drm debugfs plane state. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 22 ++ drivers/gpu/drm/stm/ltdc.h | 8 2 files changed, 30 insertions(+) diff --git a/drivers/gpu/drm

[PATCH] drm/stm: move enable/disable_vblank to crtc

2018-04-07 Thread Philippe Cornu
enable/disable_vblank() functions at drm_driver level are deprecated. Move them to the ltdc drm_crtc_funcs structure. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/drv.c | 2 -- drivers/gpu/drm/stm/ltdc.c | 10 ++ drivers/gpu/drm/stm/ltdc.h | 2 -- 3 files changed, 6

Re: [PATCH] drm: clarify adjusted_mode for a bridge connected to a crtc

2018-04-06 Thread Philippe CORNU
Hi Laurent, On 04/06/2018 04:53 PM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Monday, 26 February 2018 14:16:04 EEST Philippe Cornu wrote: >> This patch clarifies the adjusted_mode documentation >> for a bridge directly connected to

Re: [PATCH] drm: clarify adjusted_mode for a bridge connected to a crtc

2018-04-05 Thread Philippe CORNU
On 03/29/2018 09:39 AM, Daniel Vetter wrote: > On Thu, Mar 29, 2018 at 9:35 AM, Philippe CORNU wrote: >> Hi Daniel, >> >> On 03/27/2018 05:51 PM, Daniel Vetter wrote: >>> On Mon, Feb 26, 2018 at 01:16:04PM +0100, Philippe Cornu wrote: >>>> This patch

Re: [PATCH] drm/sti: Depend on OF rather than selecting it

2018-04-05 Thread Philippe CORNU
On 04/05/2018 01:05 PM, Benjamin Gaignard wrote: > 2018-04-03 7:34 GMT+02:00 Oliver O'Halloran : >> Commit cc6b741c6f63 ("drm: sti: remove useless fields from vtg >> structure") reworked some code inside of this driver and made it select >> CONFIG_OF. This results in the entire OF layer being ena

Re: [PATCH] drm: clarify adjusted_mode for a bridge connected to a crtc

2018-03-29 Thread Philippe CORNU
Hi Daniel, On 03/27/2018 05:51 PM, Daniel Vetter wrote: > On Mon, Feb 26, 2018 at 01:16:04PM +0100, Philippe Cornu wrote: >> This patch clarifies the adjusted_mode documentation >> for a bridge directly connected to a crtc. >> >> Signed-off-by: Philippe Cornu >&g

Re: [PATCH v2 0/2] drm/panel: Add support for Raydium RM68200 panel

2018-03-12 Thread Philippe CORNU
Hi Thierry, On 03/12/2018 09:04 AM, Thierry Reding wrote: > On Fri, Mar 02, 2018 at 04:32:20PM +0100, Philippe Cornu wrote: >> The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 >> TFT LCD panel connected using a MIPI-DSI video interface. >> >>

Re: [PATCH v1 2/2] drm/panel: Add support for Raydium rm68200 panel driver

2018-03-02 Thread Philippe CORNU
Hi Thierry, A big thank you for your code review and comments. It helped me to improve the driver and to send a v2. Philippe :-) On 02/28/2018 08:16 PM, Thierry Reding wrote: > On Thu, Feb 08, 2018 at 03:30:26PM +0100, Philippe Cornu wrote: >> This patch adds Raydium Semiconductor Co

[PATCH v2 1/2] dt-bindings/display/panel: Add support for Raydium rm68200 dsi panel

2018-03-02 Thread Philippe Cornu
The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD panel connected using a MIPI-DSI video interface. Reviewed-by: Rob Herring Signed-off-by: Philippe Cornu --- .../bindings/display/panel/raydium,rm68200.txt | 25 ++ 1 file changed, 25 inser

[PATCH v2 0/2] drm/panel: Add support for Raydium RM68200 panel

2018-03-02 Thread Philippe Cornu
DRV_NAME where applicable, use backlight_enable/disable() & devm_of_find_backlight(), no extra gpio reset to 0, no more msg if successful, use RM68200 instead of rm68200 where necessary. Version 1: - Initial commit Philippe Cornu (2): dt-bindings/display/panel: Add support for Raydiu

[PATCH v2 2/2] drm/panel: Add support for Raydium RM68200 panel driver

2018-03-02 Thread Philippe Cornu
This patch adds Raydium Semiconductor Corporation RM68200 5.5" 720x1280 TFT LCD panel driver (MIPI-DSI video mode). Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-ra

Re: [PATCH] drm/bridge/synopsys: dsi: readl_poll_timeout return value clean up

2018-03-02 Thread Philippe CORNU
Hi Andrzej, On 03/02/2018 11:21 AM, Andrzej Hajda wrote: > On 01.03.2018 10:00, Philippe CORNU wrote: >> Hi Archit, Andrzej & Laurent, >> >> May I ask you please your feedback on this small patch? >> Many thanks, >> >> Philippe :-) >> >>

Re: [PATCH] drm/bridge/synopsys: dsi: readl_poll_timeout return value clean up

2018-03-01 Thread Philippe CORNU
Hi Archit, Andrzej & Laurent, May I ask you please your feedback on this small patch? Many thanks, Philippe :-) On 02/04/2018 10:36 PM, Philippe Cornu wrote: > The readl_poll_timeout() return value is 0 in case of success > so it is better to detect errors without taking care of th

[PATCH] drm: clarify adjusted_mode for a bridge connected to a crtc

2018-02-26 Thread Philippe Cornu
This patch clarifies the adjusted_mode documentation for a bridge directly connected to a crtc. Signed-off-by: Philippe Cornu --- This patch is linked to the discussion https://lkml.org/lkml/2018/1/25/367 include/drm/drm_bridge.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH v1 2/2] drm/panel: Add support for Raydium rm68200 panel driver

2018-02-23 Thread Philippe CORNU
09:31 AM, Yannick FERTRE wrote: > Reviewed-by: Yannick Fertré > > > On 02/08/2018 03:30 PM, Philippe Cornu wrote: >> This patch adds Raydium Semiconductor Corporation rm68200 >> 5.5" 720x1280 TFT LCD panel driver (MIPI-DSI video mode). >> >> Signed-off-by: P

Re: [PATCH v2] drm/stm: check pitch and size calculations even if !CONFIG_MMU

2018-02-23 Thread Philippe CORNU
, 8); > > /* > @@ -44,7 +43,6 @@ static int stm_gem_cma_dumb_create(struct drm_file *file, >*/ > args->pitch = roundup(min_pitch, 128); > args->height = roundup(args->height, 4); > -#endif Reviewed-by: Philippe Cornu Many thanks, Philippe :-) > > return drm_gem_cma_dumb_create_internal(file, dev, args); > } >

Re: [PATCH v1 2/2] drm/panel: otm8009a: Add support for the optional power-supply

2018-02-23 Thread Philippe CORNU
Hi Thierry & David, May I ask you please your feedback on this small patch? Many thanks, Philippe :-) On 02/05/2018 10:45 AM, Philippe Cornu wrote: > Add support for the optional power-supply. > > Note: A "dummy regulator" is returned by devm_regulator_get() > if the

[PATCH 3/3] ARM: dts: stm32: Add display support on stm32f469-disco

2018-02-15 Thread Philippe Cornu
From: Philippe CORNU Add display support on the stm32f469-disco board. Signed-off-by: Philippe Cornu --- arch/arm/boot/dts/stm32f469-disco.dts | 51 ++- 1 file changed, 50 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch

[PATCH 0/3] ARM: dts: stm32: Add display support on stm32f469-disco

2018-02-15 Thread Philippe Cornu
This serie adds the mipi dsi support to stm32f469 and enables it on the stm32f469-disco board. Philippe CORNU (1): ARM: dts: stm32: Add display support on stm32f469-disco Philippe Cornu (2): ARM: dts: stm32: Add dt-bindings gpio.h include on stm32f469-disco ARM: dts: stm32: Add new

[PATCH 2/3] ARM: dts: stm32: Add new stm32f469 dtsi file with mipi dsi

2018-02-15 Thread Philippe Cornu
In the stm32f4 family, mipi dsi is only supported on stm32f469. So add a new stm32f469 dtsi file & add mipi dsi support inside. Signed-off-by: Philippe Cornu --- arch/arm/boot/dts/stm32f469.dtsi | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 arch/arm/boot

[PATCH 1/3] ARM: dts: stm32: Add dt-bindings gpio.h include on stm32f469-disco

2018-02-15 Thread Philippe Cornu
Add dt-bindings/gpio/gpio.h include and use it on vcc5v_otg. Signed-off-by: Philippe Cornu --- arch/arm/boot/dts/stm32f469-disco.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/stm32f469-disco.dts b/arch/arm/boot/dts/stm32f469-disco.dts index

Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

2018-02-08 Thread Philippe CORNU
0:32 GMT+01:00 Laurent Pinchart >> : >>> Hi Philippe, >>> >>> On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote: >>>> On 01/23/2018 12:30 AM, Laurent Pinchart wrote: >>>>> On Monday, 22 January 2018 12:26:08 EET Philippe Cornu

Re: [PATCH v1 1/2] drm/stm: ltdc: add non-alpha color formats

2018-02-08 Thread Philippe CORNU
Hi Benjamin, and many thanks for having applied the 2 patches. Philippe :-) On 02/08/2018 10:40 AM, Benjamin Gaignard wrote: > 2018-02-06 10:12 GMT+01:00 Yannick FERTRE : >> Reviewed-by: Yannick Fertré >> >> >> On 02/01/2018 11:42 AM, Philippe Cornu wrote: >>&g

[PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

2018-02-08 Thread Philippe Cornu
Add SPDX identifiers to the Synopsys DesignWare MIPI DSI host controller driver. Signed-off-by: Philippe Cornu --- Changes in v2: Update to "GPL-2.0+" following comments from Laurent Pinchart, Benjamin Gaignard & Philippe Ombredanne. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c

[PATCH v1 1/2] dt-bindings/display/panel: Add support for Raydium rm68200 dsi panel

2018-02-08 Thread Philippe Cornu
The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD panel connected using a MIPI-DSI video interface. Signed-off-by: Philippe Cornu --- .../bindings/display/panel/raydium,rm68200.txt | 25 ++ 1 file changed, 25 insertions(+) create mode 1

[PATCH v1 0/2] drm/panel: Add support for Raydium rm68200 panel

2018-02-08 Thread Philippe Cornu
The Raydium Semiconductor Corporation RM68200 is a 5.5" 720x1280 TFT LCD panel connected using a MIPI-DSI video interface. Philippe Cornu (2): dt-bindings/display/panel: Add support for Raydium rm68200 dsi panel drm/panel: Add support for Raydium rm68200 panel driver .../bindings/di

[PATCH v1 2/2] drm/panel: Add support for Raydium rm68200 panel driver

2018-02-08 Thread Philippe Cornu
This patch adds Raydium Semiconductor Corporation rm68200 5.5" 720x1280 TFT LCD panel driver (MIPI-DSI video mode). Signed-off-by: Philippe Cornu --- drivers/gpu/drm/panel/Kconfig | 8 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-ra

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-08 Thread Philippe CORNU
Many thanks Philippe :-) On 02/08/2018 08:39 AM, Andrzej Hajda wrote: > On 04.02.2018 22:31, Philippe Cornu wrote: >> This patch adds the DCS/GENERIC DSI read feature. >> >> Signed-off-by: Philippe Cornu >> --- > Queued to drm-misc-next. > -- > Regards > Andrzej >

Re: [PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-08 Thread Philippe CORNU
Many thanks Philippe :-) On 02/08/2018 08:39 AM, Andrzej Hajda wrote: > On 06.02.2018 09:42, Philippe Cornu wrote: >> Add support for the Synopsys DesignWare MIPI DSI version 1.31 >> Two registers need to be updated/added for supporting 1.31: >> * PHY_TMR_CFG 0x9c (updat

[PATCH v2] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-06 Thread Philippe Cornu
* PHY_TMR_RD_CFG 0xf4 (new) 1.31 [14: 0] max_rd_time Signed-off-by: Philippe Cornu --- Modified in v2: Simplify the code thanks to comments from Andrzej Hajda & Archit Taneja. drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 23 --- 1 file changed, 20 insertions(+

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-05 Thread Philippe CORNU
Hi Andrzej, And many thanks for your good comments On 02/05/2018 02:03 PM, Andrzej Hajda wrote: > On 22.01.2018 16:08, Philippe Cornu wrote: >> From: Philippe CORNU >> >> Add support for the Synopsys DesignWare MIPI DSI version 1.31 >> Two registers need to be update

Re: [PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-05 Thread Philippe CORNU
Hi Andrzej, And many thanks Philippe :-) On 02/05/2018 11:07 AM, Andrzej Hajda wrote: > On 04.02.2018 22:31, Philippe Cornu wrote: >> This patch adds the DCS/GENERIC DSI read feature. >> >> Signed-off-by: Philippe Cornu > > Reviewed-by: Andrzej Hajda > > If t

[PATCH v1 1/2] dt-bindings/display/panel: otm8009a: Add optional power-supply property

2018-02-05 Thread Philippe Cornu
Some boards use a dedicated voltage regulator for this panel. Add & document this related optional power-supply property. Signed-off-by: Philippe Cornu --- Documentation/devicetree/bindings/display/panel/orisetech,otm8009a.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documenta

[PATCH v1 2/2] drm/panel: otm8009a: Add support for the optional power-supply

2018-02-05 Thread Philippe Cornu
Add support for the optional power-supply. Note: A "dummy regulator" is returned by devm_regulator_get() if the optional regulator is not present in the device tree, simplifying the source code when enabling/disabling the regulator. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/p

[PATCH v1 0/2] drm/panel: otm8009a: Add support for the optional power-supply

2018-02-05 Thread Philippe Cornu
Some boards use a dedicated voltage regulator for this panel. Add & Document this related optional power-supply property and add its support in the driver. Philippe Cornu (2): dt-bindings/display/panel: otm8009a: Add optional power-supply property drm/panel: otm8009a: Add support for

[PATCH] drm/bridge/synopsys: dsi: readl_poll_timeout return value clean up

2018-02-04 Thread Philippe Cornu
The readl_poll_timeout() return value is 0 in case of success so it is better to detect errors without taking care of the return value sign. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH] drm/bridge/synopsys: dsi: Add read feature

2018-02-04 Thread Philippe Cornu
This patch adds the DCS/GENERIC DSI read feature. Signed-off-by: Philippe Cornu --- Extra notes: DSI read tests have been performed with DCS & GENERIC, short & long commands, on two different panels. The maximum fifo size (32*32-bit = 128 bytes on stm32) has been verified too. drivers

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-04 Thread Philippe CORNU
Hi Archit, and many thanks for your comments On 02/04/2018 04:13 PM, Archit wrote: > Hi Phillipe, > > On Saturday 03 February 2018 03:49 AM, Philippe CORNU wrote: >> Hi Archit, Andrzej, Laurent & Brian, >> >> What is your opinion regarding this patch? Do you hav

Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

2018-02-02 Thread Philippe CORNU
Hi Laurent & Daniel :-) On 01/29/2018 11:40 AM, Laurent Pinchart wrote: > Hi Philippe, > > On Monday, 29 January 2018 12:17:37 EET Philippe CORNU wrote: >> On 01/29/2018 10:46 AM, Laurent Pinchart wrote: >>> On Thursday, 25 January 2018 17:55:04 EET Philip

Re: [PATCH] drm/bridge/synopsys: dsi: Add 1.31 version support

2018-02-02 Thread Philippe CORNU
Hi Archit, Andrzej, Laurent & Brian, What is your opinion regarding this patch? Do you have any advice for handling hw versions? Do not hesitate to comment. Many thanks, Philippe :-) On 01/22/2018 04:08 PM, Philippe Cornu wrote: > From: Philippe CORNU > > Add support for

[PATCH v1 2/2] drm/stm: ltdc: remove non-alpha color formats on layer 2 for older hw

2018-02-01 Thread Philippe Cornu
Hw older versions support non-alpha color formats derived from native alpha color formats only on the primary layer. For instance, RG16 native format without alpha works fine on 2nd layer but XR24 (derived color format from AR24) does not work on 2nd layer. Signed-off-by: Philippe Cornu

[PATCH v1 0/2] drm/stm: ltdc: add non-alpha color formats

2018-02-01 Thread Philippe Cornu
This patchset adds non-alpha color format support taking into account older hw versions. Philippe Cornu (2): drm/stm: ltdc: add non-alpha color formats drm/stm: ltdc: remove non-alpha color formats on layer 2 for older hw drivers/gpu/drm/stm/ltdc.c | 53

[PATCH v1 1/2] drm/stm: ltdc: add non-alpha color formats

2018-02-01 Thread Philippe Cornu
format. Signed-off-by: Philippe Cornu --- drivers/gpu/drm/stm/ltdc.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 90b3de516c91..f6f26fc0ae9e 100644 --- a/drivers/gpu/drm/stm/ltdc.c

Re: [PATCH v2] drm/stm: check pitch and size calculations even if !CONFIG_MMU

2018-01-31 Thread Philippe CORNU
Hi Benjamin, Great, Many thanks, Tested-by: Philippe Cornu Philippe :-) On 01/31/2018 09:05 AM, Benjamin Gaignard wrote: > In all cases we have to check pitch and size calculations to speed up > data transfer. > > Fixes: 21f815bf773c ("drm/stm: drv: Improve data transfers&

Re: [PATCH] drm/stm: check pitch and size calculations even if !CONFIG_MMU

2018-01-30 Thread Philippe CORNU
Hi Benjamin, Working on a coming patch (based on the new has_alpha field in fourcc), I realized that in particular cases (2 layers + "odd" layer sizes) memory transfers on MCU are greatly improved too if drm buffers are aligned on 128 bytes : ) So I suggest to cancel this patch. Then you can

Re: [PATCH v2 1/2] drm/bridge/synopsys: dsi: Add a warning msg on dsi read requests

2018-01-30 Thread Philippe CORNU
Hi Archit, And many thanks, Philippe :-) On 01/30/2018 03:09 PM, Archit Taneja wrote: > > > On 01/26/2018 06:14 AM, Brian Norris wrote: >> On Thu, Jan 25, 2018 at 11:37:59AM +0100, Philippe Cornu wrote: >>> The dcs/generic dsi read feature is not yet implemented so it

Re: [PATCH] drm/stm: dsi: Add 1.31 version support

2018-01-30 Thread Philippe CORNU
Hi Benjamin, and many thanks Philippe :-) On 01/30/2018 11:52 AM, Benjamin Gaignard wrote: > 2018-01-22 17:46 GMT+01:00 Philippe Cornu : >> Add support for the stm dsi phy/wrapper version 1.31. >> Only lane capabilities need to be modified. >> >> Signed-off-by: Phil

[PATCH v2] drm/stm: drv: Improve data transfers

2018-01-30 Thread Philippe Cornu
To optimize data transfers, align pitch on 128 bytes & height on 4 bytes. This optimization is not applicable on hw without MMU. Signed-off-by: Yannick Fertre Signed-off-by: Vincent Abriou Signed-off-by: Philippe Cornu --- Changes in v2: Rename stm_dumb_create() to stm_gem_cma_dumb_cr

Re: [PATCH] drm/bridge/synopsys: dsi: use adjusted_mode in mode_set

2018-01-29 Thread Philippe CORNU
Hi Laurent, And many thanks for your comments :) On 01/29/2018 10:46 AM, Laurent Pinchart wrote: > Hi Philippe, > > (CC'ing Daniel Vetter) > > Thank you for the patch. > > On Thursday, 25 January 2018 17:55:04 EET Philippe Cornu wrote: >> The "adjusted

  1   2   3   >