On Fri, Dec 29, 2017 at 02:19:56AM +0300, Ozgur wrote:
> I think this patch is not good, the code will not work. Please should
> understand in && operator and () why used with C.
hi,
this patch should work, since it compiles and passes checkpatch.
the reason why i removed the () is because of th
Fixes checkpatch coding style issues.
Philippe Loctaux (2):
Staging: most: aim-sound: sound.c: fixed an alignment issue
Staging: most: aim-sound: sound.c: removed unnecessary parentheses
drivers/staging/most/aim-sound/sound.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions
Removed unnecessary parentheses in a if statement.
Signed-off-by: Philippe Loctaux
---
drivers/staging/most/aim-sound/sound.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/aim-sound/sound.c
b/drivers/staging/most/aim-sound/sound.c
index ab2b0d833
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/most/aim-sound/sound.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/aim-sound/sound.c
b/drivers/staging/most/aim-sound/sound.c
index ea1366a44..ab2b0d833
Removed unnecessary parentheses in the if statement.
Signed-off-by: Philippe Loctaux
---
drivers/staging/vme/devices/vme_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
index 41a5b32e0
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/vme/devices/vme_user.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b/drivers/staging/vme/devices/vme_user.c
index a3d4610fb..41a5b32e0
cleaned up the file with checkpatch
Signed-off-by: Philippe Loctaux
---
fs/btrfs/file.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index 3a14c87..d131b8d 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
On Thu, Mar 10, 2016 at 09:55:25PM -0700, Jonathan Corbet wrote:
> Not on kernel.org. From MAINTAINERS:
>
> T: git git://git.lwn.net/linux.git docs-next
Allright thanks :)
--
Philippe Loctaux
On Wed, Mar 09, 2016 at 03:30:15PM -0700, Jonathan Corbet wrote:
> Applied to the docs tree, thanks.
Where can I find the docs tree on kernel.org?
Thanks
--
Philippe Loctaux
Removed a * in the beginning of the block, and removed an unnecessary space.
Signed-off-by: Philippe Loctaux
---
kernel/power/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/power/main.c b/kernel/power/main.c
index 2794697..d7386cb 100644
--- a/kernel/power
Fixed subtitles style, aligned them with their header.
Signed-off-by: Philippe Loctaux
---
Documentation/HOWTO | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/HOWTO b/Documentation/HOWTO
index d5a699d..109ec84 100644
--- a/Documentation/HOWTO
+++ b
'll end up resending another patch without
changing this line, to avoid any bugs or breaking some style rules.
--
Philippe Loctaux
p...@philippeloctaux.com
On Tue, Feb 23, 2016 at 11:07:15AM +, Ian Abbott wrote:
> Even better: just remove the macro, as it isn't used.
How can I do that? I'm asking that because my C knowledge
isn't very good :P
--
Philippe Loctaux
p...@philippeloctaux.com
On Tue, Feb 23, 2016 at 10:58:03AM +, Ian Abbott wrote:
> Thanks!
Sweet! Does that means my patch is accepted and maybe will be applied? :)
--
Philippe Loctaux
p...@philippeloctaux.com
Makes the comment blocks start with /* on separate lines, and end
with */ on separate lines as well,
starting with * for each comment lines.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/contec_pci_dio.c | 47 +
1 file changed, 24 insertions(+), 23
Added spaces around | and *, fixing 2 checkpatch checks.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/mite.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/drivers/staging/comedi/drivers/mite.c
index 8f24702
Makes the comment block start with /* on a separate line, and end
with */ on a separate line as well.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/disk-io.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index f642b30..2545d01
Added spaces required around the equal sign, fixing a checkpatch error.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/disk-io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 84cbf16..f642b30 100644
--- a/fs/btrfs/disk-io.c
+++ b
Added line after variable declaration, fixing checkpatch warning.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/dir-item.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c
index 1752625..70c39a3 100644
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/disk-io.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 4545e2e..84cbf16 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -1908,11
Oh, I see now :)
I'll try your changes and tell if they work or not :)
--
Philippe Loctaux
p...@philippeloctaux.com
On Sun, Feb 21, 2016 at 04:37:54PM -0800, Joe Perches wrote:
> On Mon, 2016-02-22 at 00:26 +0100, Philippe Loctaux wrote:
> > Added line after variable decla
Use tabs instead of spaces, fixing checkpatch error.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/delayed-inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index b57daa8..2e25aa54 100644
--- a/fs/btrfs/delayed-inode.c
Makes the comment blocks start with /* on separate lines, and end
with */ on separate lines as well.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/dev-replace.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index
Hi,
I'm really sorry, but I don't understand what you're trying to mean.
Could you simplify your sentence please (since I'm not english native)?
I'd really apreciate that, thanks :)
--
Philippe Loctaux
p...@philippeloctaux.com
On Sun, Feb 21, 2016 at 04:06:03PM -0800, Jo
Use tabs instead of spaces, fixing 3 checkpatch errors.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/dev-replace.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs/btrfs/dev-replace.c
index cbb7dbf..b89a8c6 100644
--- a/fs/btrfs/dev-replace.c
Is there no need of additional blank line here particulary
or in all lines that I changed?
--
Philippe Loctaux
p...@philippeloctaux.com
On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote:
> On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote:
> > Added lines after
Added lines after variable declarations, fixing 22 checkpatch warnings.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/ctree.c | 23 +++
1 file changed, 23 insertions(+)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 769e0ff..c9fd42d 100644
--- a/fs/btrfs/ctree.c
Makes the comment blocks start with /* on separate lines, and end
with */ on separate lines as well.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/check-integrity.c | 30 ++
1 file changed, 22 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/check-integrity.c b/fs
Added line after variable declaration, fixing checkpatch warning.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/compression.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index 3346cd8..5194b6f 100644
--- a/fs/btrfs/compression.c
+++ b/fs
Makes the comment block start with /* on a separate line, and end
with */ on a separate line as well.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/check-integrity.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
On Sun, Feb 21, 2016 at 03:08:02PM -0600, Simon Quigley wrote:
> I thought I proposed this exact patch...hmm...
Yes you're right, I wasn't subscribed at the mailing list yet.
The maintainer will probably see it's a duplicate and he'll just ignore
that patch.
Fixed a coding style issue.
Signed-off-by: Philippe Loctaux
---
fs/btrfs/async-thread.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index 5fb60ea..7914dd2 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async
Sorry I didn't read the doc correctly!
--
Philippe Loctaux
p...@philippeloctaux.com
On Fri, Dec 18, 2015 at 03:00:42PM -0800, Greg KH wrote:
> On Sun, Dec 13, 2015 at 05:40:34PM +0100, Philippe Loctaux wrote:
> > This patch fixes the checkpatch.pl warning:
> >
>
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/comedi_pcmcia.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_pcmcia.h
b/drivers/staging/comedi
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 44 ++--
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci_dio.c
b/drivers/staging/comedi/drivers/adv_pci_dio.c
Fixed a comment issue.
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging/comedi/drivers/ssv_dnp.c
index acc7f34..c28b6cb 100644
--- a
>From 16dae6c28a46ae257dcedd51d973aee7821053f3 Mon Sep 17 00:00:00 2001
From: Philippe Loctaux
Date: Thu, 29 Oct 2015 22:45:16 +0100
Subject: [PATCH] Staging: comedi: fixed comment, added a new line
Signed-off-by: Philippe Loctaux
---
drivers/staging/comedi/drivers/ssv_dnp.c | 3 ++-
1 f
37 matches
Mail list logo