Re: [PATCH] LICENSES: Replace HTTP links with HTTPS ones

DUCTION, AND DISTRIBUTION > > > > -- > > 2.27.0 > > > > You can't change the text of a license that comes from elsewhere. This > file is fine as-is. It is so fine that -FWIW- even the Apache folks toyed with the idea of updating their license text to switch to HTTPS there and decided not to [1] which is IMHO a sane thing. [1] https://issues.apache.org/jira/browse/LEGAL-457 -- Cordially Philippe Ombredanne

Re: [PATCH v2] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

defined, distinction between "GPL" > and "GPL v2" and document that: > > - "GPL" and "GPL v2" both express that the module is licensed under GPLv2 > (without a distinction of 'only' and 'or later') and is therefore kernel > license comp

Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

e or > not. > > Add a MODULE_LICENSE subsection to the license rule documentation as well. > > Signed-off-by: Thomas Gleixner Thank you ++ for documenting all this : this is a small change but a big step towards licensing clarity! Great that you found the commit that introduced

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5 -- Cordially Philippe Ombredanne

Re: [PATCH 2/3] ARM: tegra: apalis-tk1: Add SPDX license (GPL-2.0 OR X11) identifiers

git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/other/X11?h=v4.18-rc5 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred/MIT?h=v4.18-rc5 -- Cordially Philippe Ombredanne

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

(C) 2006-2007 Pavel Pisa (pp...@pikron.com) >> +// Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de) > > Hi Philippe, > > I went through the code and didn't find any information about the format > of the lines following the SPDX, it seems it is relatively free. > >

Re: [PATCH 2/4] clocksource: timer-imx-gpt: Switch to SPDX identifier

(C) 2006-2007 Pavel Pisa (pp...@pikron.com) >> +// Copyright (C) 2008 Juergen Beisert (ker...@pengutronix.de) > > Hi Philippe, > > I went through the code and didn't find any information about the format > of the lines following the SPDX, it seems it is relatively free. > >

Re: [patch V2 7/7] scripts: Add SPDX checker script

ull kernel tree. > > It checks whether the license expression syntax is correct and also > validates whether the license identifiers used in the expressions are > available in the LICENSES files. Looking good to me! And the use of ply is sleek. -- Cordially Philippe Ombredanne

Re: [patch V2 7/7] scripts: Add SPDX checker script

It checks whether the license expression syntax is correct and also > validates whether the license identifiers used in the expressions are > available in the LICENSES files. Looking good to me! And the use of ply is sleek. -- Cordially Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

Tejun, On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo <t...@kernel.org> wrote: > Hello, > > On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote: >> > v2: >> > - clarify license version (it should be GPL 2.0) >> > - use SPDX header >> &g

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

Tejun, On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo wrote: > Hello, > > On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote: >> > v2: >> > - clarify license version (it should be GPL 2.0) >> > - use SPDX header >> >> For the use o

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

d mean GPL-2.0+ (e.g. or any later version) and this would not match your top level license tag. I know this may seem confusing, but there is little hope we can change the MODULE_LICENSE tags that are used by many external module loaders. Comments in module.h explain it all. -- Cordially Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

d mean GPL-2.0+ (e.g. or any later version) and this would not match your top level license tag. I know this may seem confusing, but there is little hope we can change the MODULE_LICENSE tags that are used by many external module loaders. Comments in module.h explain it all. -- Cordially Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

ame thing in the MODULE_LICENSE and your SPDX tags. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175 -- Cordially Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

ame thing in the MODULE_LICENSE and your SPDX tags. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175 -- Cordially Philippe Ombredanne

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

il.com> > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > Cc: Philippe Ombredanne <pombreda...@nexb.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com> > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > --- > v3: > - fix minor is

Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver

ech E-Matrix 530 expansion card). > > Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help > with testing the driver. > > Tested-by: John Paul Adrian Glaubitz > Cc: Michael Schmitz > Cc: Geert Uytterhoeven > Cc: Philippe Ombredanne > Cc: Andy Shevchenko >

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

Miroslav, On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes <mbe...@suse.cz> wrote: > On Sat, 24 Feb 2018, Philippe Ombredanne wrote: > >> Joe, >> >> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence <joe.lawre...@redhat.com> >> wrote: >> > Add a s

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

Miroslav, On Tue, Feb 27, 2018 at 3:54 AM, Miroslav Benes wrote: > On Sat, 24 Feb 2018, Philippe Ombredanne wrote: > >> Joe, >> >> On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence >> wrote: >> > Add a simple atomic replace / cumulative livepatch example

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

ore details. > + * > + * You should have received a copy of the GNU General Public License along > + * with this program. If not, see <http://www.gnu.org/licenses/>. > + */ Would you consider using the SPDX tags [1] instead of this legalese? Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v6 03/20] firmware: arm_scmi: add basic driver infrastructure for SCMI

with this program. If not, see <http://www.gnu.org/licenses/>. > + */ Would you consider using the SPDX tags [1] instead of this legalese? Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

Joe, On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence wrote: > Add a simple atomic replace / cumulative livepatch example. > > Signed-off-by: Joe Lawrence > --- > samples/livepatch/Makefile | 1 + >

Re: [PATCH v0 1/3] livepatch: add sample cumulative patch

Joe, On Fri, Feb 23, 2018 at 1:33 PM, Joe Lawrence wrote: > Add a simple atomic replace / cumulative livepatch example. > > Signed-off-by: Joe Lawrence > --- > samples/livepatch/Makefile | 1 + > samples/livepatch/livepatch-cumulative.c | 216 > +++

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

E_LICENSE("GPL v2"); Please sync this with your SPDX id above. nodule.h has the doc on the meaning of MODULE_LICENSE macros. Here you have stated a combo of GPL-2.0 and GPL-2.0 or later -- Cordially Philippe Ombredanne

Re: [PATCH 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

h has the doc on the meaning of MODULE_LICENSE macros. Here you have stated a combo of GPL-2.0 and GPL-2.0 or later -- Cordially Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

ll > +++ b/drivers/pinctrl/actions/pinctrl-s900.c > @@ -0,0 +1,2536 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +MODULE_LICENSE("GPL v2"); This does not match your license above. Per module.h "GPL v2" means GPL-2.0 where you license above GPL-2.0+ means or later -- Cordially Philippe Ombredanne

Re: [PATCH 04/10] pinctrl: actions: Add Actions S900 pinctrl driver

t; +// SPDX-License-Identifier: GPL-2.0+ > +MODULE_LICENSE("GPL v2"); This does not match your license above. Per module.h "GPL v2" means GPL-2.0 where you license above GPL-2.0+ means or later -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

/dev/null > +++ b/drivers/net/ethernet/ni/nixge.c > @@ -0,0 +1,1352 @@ > +// SPDX-License-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+" Can you use one or the other an\d ensure both of these are in sync? -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

e.c > @@ -0,0 +1,1352 @@ > +// SPDX-License-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+" Can you use one or the other an\d ensure both of these are in sync? -- Cordially Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches <j...@perches.com> wrote: > On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >> Hi Philippe, >> >> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >> <pombreda...@nexb.com> wrote: >> &g

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

On Sun, Feb 18, 2018 at 9:18 PM, Joe Perches wrote: > On Sun, 2018-02-18 at 20:37 +0100, Geert Uytterhoeven wrote: >> Hi Philippe, >> >> On Sun, Feb 18, 2018 at 8:04 PM, Philippe Ombredanne >> wrote: >> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda &

Re: [RFCv4 09/21] v4l2: add request API support

/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [RFCv4 09/21] v4l2: add request API support

ICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ Do you mind using SPDX tags per [1] rather that this fine but long legalese. (Here and in the whole patch series) [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

our group! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v7 15/61] xarray: Add xa_load

nd using SPDX tags per [1] rather that this fine but long legalese? Unless you are a legalese lover of course. You will also get bonus karma points if you can spread the word within your group! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

you can redistribute it and/or >> * modify it under the terms of the GNU General Public License It would be awesome if you could adopt SPDX ids here and in all HPE existing and future contributions [1] rather than this fine legalese. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [v3,04/11] watchdog/hpwdt: white space changes

awesome if you could adopt SPDX ids here and in all HPE existing and future contributions [1] rather than this fine legalese. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

+:Author: Steven Rostedt <srost...@redhat.com> > +:License: The GNU Free Documentation License, Version 1.2 > + (dual licensed under the GPL v2) Do you mind using an SPDX id per [1] rather that this? Steven, are you OK with this? Can you ack? [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 05/17] trace doc: convert trace/ftrace.txt to rst format

nder the GPL v2) Do you mind using an SPDX id per [1] rather that this? Steven, are you OK with this? Can you ack? [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

Do you mind using SPDX tags per [1] rather that this fine but long legalese here and in the whole patch set? Unless you are a legalese lover of course! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/4] ARM: OMAP2+: Introduce low-level suspend code for AM43XX

ine but long legalese here and in the whole patch set? Unless you are a legalese lover of course! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH] auxdisplay: Replace licenses with SPDX identifiers

+1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 Same comment as above. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

icense-Identifier: GPL-2.0 > +MODULE_LICENSE("GPL"); Your MODULE_LICENSE does not match your SPDX tag. Per module.h, GPL would mean GPL-2.0+ not GPL-2.0 It would be best if you can sync the two. -- Cordially Philippe Ombredanne

Re: [PATCH v4] rtc: isl12026: Add driver.

atch your SPDX tag. Per module.h, GPL would mean GPL-2.0+ not GPL-2.0 It would be best if you can sync the two. -- Cordially Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

tegra194-reset.h > @@ -0,0 +1,155 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ Same as above -- Cordially Philippe Ombredanne

Re: [PATCH v3 6/7] arm64: tegra: Add Tegra194 chip device tree

h > @@ -0,0 +1,38 @@ > +/* > + * Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved. > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ Same as above > --- /dev/null > +++ b/include/dt-bindings/reset/tegra194-reset.h > @@ -0,0 +1,155 @@ > +/* > + * C

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

s... This has been discussed on list and is what Linus prefers. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v2 1/1] clk: npcm7xx: add clock controler. fixed clock at DT

what Linus prefers. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

ou notice above is GPL-2.0, not "or later" [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCHv4 2/4] ASoC: codec: cpcap: new codec

CPCAP codec driver"); > +MODULE_AUTHOR("Sebastian Reichel"); > +MODULE_LICENSE("GPL"); This does not match your license: per module.h, GPL means GPL-2.0 or later. You notice above is GPL-2.0, not "or later" [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v5 10/12] drm/sun4i: Implement A83T HDMI driver

ree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

repeats the SPDX-License-Identifier: (GPL-2.0 OR MIT) line in a less clear and precise way. The whole purpose of the SPDX things is to make licensing eventually as clear ass possible Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v3 4/8] MIPS: mscc: Add initial support for Microsemi MIPS SoCs

nse-Identifier: (GPL-2.0 OR MIT) line in a less clear and precise way. The whole purpose of the SPDX things is to make licensing eventually as clear ass possible Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

codecs/ak4458.h b/sound/soc/codecs/ak4458.h > new file mode 100644 > index 000..16d9d22 > --- /dev/null > +++ b/sound/soc/codecs/ak4458.h > @@ -0,0 +1,86 @@ > +// SPDX-License-Identifier: GPL-2.0 As weird as it sounds the style should be plain /* SPDX-License-Identifier: GPL-2.0 /* here per [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK4458 DAC driver

ounds the style should be plain /* SPDX-License-Identifier: GPL-2.0 /* here per [1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

option) >> + * any later version. >> + */ Rodrigo, Since you used the proper SPDX tag (in the proper style as explained in the doc), you can remove this boilerplate alright as it does double duty with the tag. -- Cordially Philippe Ombredanne

Re: [PATCH 1/3] HID: add driver for Valve Steam Controller

tag (in the proper style as explained in the doc), you can remove this boilerplate alright as it does double duty with the tag. -- Cordially Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

- /dev/null >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -0,0 +1,495 @@ >> +// SPDX-License-Identifier: GPL-2. This should be GPL-2.0 too. -- Cordially Philippe Ombredanne

Re: [PATCH 05/15] ARM64: dts: Add R-Car Salvator-x M3-N support

arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -0,0 +1,495 @@ >> +// SPDX-License-Identifier: GPL-2. This should be GPL-2.0 too. -- Cordially Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha <himanshujha199...@gmail.com> wrote: > On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote: >> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha >> <himanshujha199...@gmail.com> wrote: >> > Move

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha wrote: > On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote: >> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha >> wrote: >> > Move the adis16201 driver out of staging directory and merge to the >

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

ENSE("GPL"); > +MODULE_ALIAS("platform:amiga-gayle-ide"); > +MODULE_VERSION(DRV_VERSION); > and while doing it please make sure your MODULE_LICENSE matches the license. Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+ Thanks! [1] https://gi

Re: [PATCH] ata: add Amiga Gayle PATA controller driver

make sure your MODULE_LICENSE matches the license. Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+ Thanks! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne +1 650 799 0949

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

of the licensing > agreement. Also, please grep for "SPDX". You can check the doc for the (fairly new) way to remove legalese boilerplate at Documentation/process/license-rules.rst or [1] It helps keep the focus on the code and less on licensing! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/6] mfd: Add ST Multi-Function eXpander core driver

the doc for the (fairly new) way to remove legalese boilerplate at Documentation/process/license-rules.rst or [1] It helps keep the focus on the code and less on licensing! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("spi:adis16201"); Your MODULE_LICENSE does not match your SPDX license id. MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0 MODULE_LICENSE("GPL"); means SPDX GPL-2.0+ -- Cordially Philippe Ombredanne

Re: [PATCH 4/4] staging: iio: accel: Move adis16201 driver out of staging

quot;); Your MODULE_LICENSE does not match your SPDX license id. MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0 MODULE_LICENSE("GPL"); means SPDX GPL-2.0+ -- Cordially Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

icenses/>. > + */ Dear Manish, Why not using the SPDX ids there too and elsewhere? You are using them alright in many other places in this patch. See Documentation/process/license-rules.rst for details -- Cordially Philippe Ombredanne

Re: [RFC PATCH] soc: zynqmp: Add support for tap delay settings

SPDX ids there too and elsewhere? You are using them alright in many other places in this patch. See Documentation/process/license-rules.rst for details -- Cordially Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

-2.0 See Documentation/process/license-rules.rst for why. -- Cordially Philippe Ombredanne

Re: [PATCH 14/17] s390/kexec_file: Add kexec_file_load system call

> --- /dev/null > +++ b/arch/s390/kernel/machine_kexec_file.c > @@ -0,0 +1,174 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ I know this may sound weird but in .c files this should be instead: // SPDX-License-Identifier: GPL-2.0 See Documentation/process/license-rules.rst for why. -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

Linux Foundation. All rights reserved. > + */ This is more cosmetic, but since there is only a single line of copyright statement and no other comments, it would make sense to use C++ style // for that line too IMHO (and other similar cases) -- Cordially Philippe Ombredanne

Re: [PATCH v3 2/3] arm64: dts: sdm845: Add minimal dts files for sdm845 SoC/MTP

metic, but since there is only a single line of copyright statement and no other comments, it would make sense to use C++ style // for that line too IMHO (and other similar cases) -- Cordially Philippe Ombredanne

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

updating the licensing to use the new concise SPDX ids instead? [1] And you get a big good karma bonus if you can also do the same for all HPE-copyrighted files, tree-wide ;) and/or spread the word inside your team. Thank you for your kind consideration! [1] https://git.kernel.org/pub/sc

Re: [PATCH v2 04/11] watchdog/hpwdt: white space changes

do the same for all HPE-copyrighted files, tree-wide ;) and/or spread the word inside your team. Thank you for your kind consideration! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst Cordially Philippe Ombredanne

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

then we can fix it with a patch ;) CC: Russell King <r...@armlinux.org.uk> CC: Christoph Hellwig <h...@infradead.org> CC: Thomas Gleixner <t...@linutronix.de> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH v5 01/11] scsi: ufs: sysfs: attribute group for existing sysfs entries.

omas Gleixner [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

* SPDX-License-Identifier: (GPL-2.0+ or MIT) >> + */ Thank you for using SPDX ids: this needs to be on the first line though! [1] and eventually some special comments style. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [linux-sunxi] [PATCH v2 5/6] arm64: allwinner: h6: add the basical Allwinner H6 DTSI file

be on the first line though! [1] and eventually some special comments style. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst -- Cordially Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

00 @@ > +/* SPDX-License-Identifier: GPL-2.0 And for a comment in .c this line should use C++ style as the first line: > +// SPDX-License-Identifier: GPL-2.0 Please check the docs for this (I know this can feel surprising but this has been debated at great length on list) Thank you! -- Cordially Philippe Ombredanne

Re: [PATCH 2/6] genalloc: selftest

mment in .c this line should use C++ style as the first line: > +// SPDX-License-Identifier: GPL-2.0 Please check the docs for this (I know this can feel surprising but this has been debated at great length on list) Thank you! -- Cordially Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

<linus.wall...@stericsson.com> > */ > @@ -420,5 +420,5 @@ MODULE_DESCRIPTION("COH 901 327 Watchdog"); > module_param(margin, uint, 0); > MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)"); > > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:coh901327-watchdog"); Thank you! Reviewed-by: Philippe Ombredanne <pombreda...@nexb.com> -- Cordially Philippe Ombredanne

Re: [PATCH] watchdog: coh901327: make license text and module licence match

"); > module_param(margin, uint, 0); > MODULE_PARM_DESC(margin, "Watchdog margin in seconds (default 60s)"); > > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); > MODULE_ALIAS("platform:coh901327-watchdog"); Thank you! Reviewed-by: Philippe Ombredanne -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

proper. That's the way to go and thank you for this. Do not hesitate to ping here or privately if there is any legal concern that comes up. -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

and thank you for this. Do not hesitate to ping here or privately if there is any legal concern that comes up. -- Cordially Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

el code: incredible, right? Thank you for helping make the kernel a mostly legalese-free codebase and saving trees at the same time! [1] https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce -- Cordially Philippe Ombredanne

Re: [PATCH v3 01/11] dt-bindings: clock: Add Actions S900 clock bindings

aving trees at the same time! [1] https://www.sierraclub.org/sierra/2014-4-july-august/green-life/how-much-paper-does-one-tree-produce -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

And you will get extra good karma point if you feel like doing the same for every Toradex-copyrighted files ;) The (still new and fresh) license documentation contributed by tglx --the only real-time docu-mentalist-- is in: Documentation/process/license-rules.rst Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH 5/6] ARM: dts: tegra: apalis-tk1: copyright period, spurious newlines

ed files ;) The (still new and fresh) license documentation contributed by tglx --the only real-time docu-mentalist-- is in: Documentation/process/license-rules.rst Thanks! -- Cordially Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

fier: (GPL-2.0+ OR BSD) */ nit... BSD is not a valid license id as documented in LICENSES [1] : please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne

Re: [PATCH 1/2] dt-bindings: clock: reset: Add AXG AO Clock and Reset Bindings

please use one of these: BSD-2-Clause or BSD-3-Clause Thank you! [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/preferred -- Cordially Philippe Ombredanne

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

} >> > + >> > + if ($comment !~ /^$/ && >> > + $rawline !~ /^\+\Q$comment\E >> > SPDX-License-Identifier: /) { >> > + WARN("SPDX_LICENSE_TAG", >> > +"Missing or malformed >> > SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr); >> > + } >> > + } >> > + } >> > + >> > # check we are in a valid source file if not then ignore this hunk >> > next if ($realfile !~ /\.(h|c|s|S|sh|dtsi|dts)$/); >> > BTW I forgot this if you like to add it: Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

les.rst. To summarize, SPDX license tags >> > should be on the 1st line (or 2nd line in scripts) using the appropriate >> > comment style for the file type. >> > >> > Cc: Andy Whitcroft >> > Cc: Joe Perches >> > Cc: Thomas Gleixner >> > C

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

Joe, On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches <j...@perches.com> wrote: > On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: >> However checking that licenses ids are known and listed in the kernel >> doc is essential IMHO to avoid drift and insulate the kernel

Re: [PATCH v6] checkpatch.pl: Add SPDX license tag check

Joe, On Thu, Feb 8, 2018 at 6:24 PM, Joe Perches wrote: > On Thu, 2018-02-08 at 15:35 +0100, Philippe Ombredanne wrote: >> However checking that licenses ids are known and listed in the kernel >> doc is essential IMHO to avoid drift and insulate the kernel from SPDX >> u

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

0+" following comments from Laurent > Pinchart, Benjamin Gaignard & Philippe Ombredanne. > > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c > b/d

Re: [PATCH v2] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

tion) any later version. > - * > * Modified by Philippe Cornu > * This generic Synopsys DesignWare MIPI DSI host driver is based on the > * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. > -- > 2.15.1 > Thank you. Acked-by: Philippe Ombredanne

Re: [PATCH v2 05/16] arm64: dts: mt7622: add PMIC MT6380 related nodes

to resue the configuration. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Matthias Brugger <matthias@gmail.com> > Cc: Philippe Ombredanne <pombreda...@nexb.com> Thank you for the use of SPDX licenses ids! Acked-by: Philippe Ombredanne <pombreda...@nexb.com>

  1   2   3   4   5   6   >