BAYTRAIL (legacy) and SKYLAKE options
Made top level machine driver selection dependent on INTEL_SST_TOPLEVEL.
Added help text for PCI and HIFI2 platforms
Replaced X86_INTEL_LPSS by MFD_INTEL_LPSS for Skylake+ devices
Fixed a couple of indentation issues
Pierre-Louis Bossart (8):
ASoC: acpi: add
On 1/1/18 10:08 PM, Wei Yongjun wrote:
Fix the typo, 'status' should be instead of 'status2'.
well spotted, thanks!
Acked-by: Pierre-Louis Bossart
Fixes: b0a9c37b0178 ("soundwire: Add slave status handling")
Signed-off-by: Wei Yongjun
---
drivers/sound
On 1/2/18 12:21 PM, Richard Cochran wrote:
On Tue, Jan 02, 2018 at 11:15:45AM -0600, Pierre-Louis Bossart wrote:
I wrote the code for HDaudio and I remember wasting time trying to figure
out the gory details of the cycle counter stuff when all I wanted was a
conversion from a 24MHz counter to
On 1/2/18 12:03 AM, Sagar Arun Kamble wrote:
On 12/28/2017 10:19 PM, Richard Cochran wrote:
On Tue, Dec 26, 2017 at 01:07:35PM +0530, Sagar Arun Kamble wrote:
Or can we provide simpler versions for covering some defaults? At
least reducing the number of arguments would make things easier.
Th
- depends on SND_DMA_SGBUF
+ depends on SND_DMA_SGBUF && ACPI
depends on DMADEVICES
Perhaps
depends on DMADEVICES && ACPI
to be in align with below?
config SND_SOC_INTEL_BAYTRAIL
tristate "Intel ASoC SST driver for Baytrail (legacy)"
- depends on DMADEV
On 12/15/17 4:58 AM, Andy Shevchenko wrote:
On Thu, 2017-12-14 at 18:44 -0600, Pierre-Louis Bossart wrote:
PCI/ACPI selections should not happen in Kconfig for machine drivers,
move to SOC selections.
Add distinction between PCI and ACPI HiFi2 platforms and help text.
There should be no
On 12/15/17 5:07 AM, Takashi Iwai wrote:
On Fri, 15 Dec 2017 01:44:43 +0100,
Pierre-Louis Bossart wrote:
+config SND_SOC_ACPI_INTEL_MATCH
+ tristate
+ depends on X86 && ACPI
+ select SND_SOC_ACPI
An item that is selected by others can only select, not depend.
The
ested with each of Haswell, Baytrail legacy, HiFi2, SKL cases
selected independently. 0-day and explicit randconfig tests did not report
additional issues and no functionality loss was observed in Intel tests on
HIFI2 and SKYLAKE platforms
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kc
("ASoC: Intel: clarify Kconfig dependencies")
Reported-by: Linus Torvalds
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Vinod Koul
---
sound/soc/intel/Kconfig| 71 +--
sound/soc/intel/Makefile | 2 +-
sound/soc/intel/boards/Kc
Removed default n
Added help text for HASWELL, BAYTRAIL (legacy) and SKYLAKE options
Made top level machine driver selection dependent on INTEL_SST_TOPLEVEL.
Added help text for PCI and HIFI2 platforms
Replaced X86_INTEL_LPSS by MFD_INTEL_LPSS for Skylake+ devices
Fixed a couple of indentation i
Make sure all the configs are aligned
Also add the missing dependencies on SOC_ACPI stuff used to fix
DAI names based on HID and fix a couple of indentation issues
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 33 +++--
1 file changed, 19
Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected.
The latter might actually need to be moved to the SOC side of things,
it really has no place in a machine driver dependency
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 2 +-
1 file changed, 1
by anyone, and with Edison now defunct support for
Merrifield/Edison is to be determined.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 27 +++
sound/soc/intel/boards/Kconfig | 14 --
2 files changed, 27 insertions(+), 14 deletions
From: Vinod Koul
Drop "Intel ASoC SST driver for " platforms and "SOC Machine Audio driver
for Intel" for machines..
Signed-off-by: Vinod Koul
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 10 +-
sound/soc/intel
Document in comments what the options are supposed to mean, before
clean-up in next patch.
No functionality change here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/sound/soc/intel/Kconfig
From: Vinod Koul
Helps in find if endings
Signed-off-by: Vinod Koul
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index
No reason why SND_SOC_INTEL_SST should be set here.
Also make sure same dependencies are used everywhere (only last one has SPI
in addition). Replace X86_INTEL_LPSS by MFD_INTEL_LPSS since the former
makes no sense for Skylake+ devices
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel
On 12/13/2017 03:54 AM, Vinod Koul wrote:
+ * Base file is:
+ * properties
+ * | interface-revision
+ * | master-count
+ * | link-N
+ * | clock-stop-modes
+ * | max-clock-frequency
+ *
ing still stand,
but given that this part will have to be optimized anyway when we have
actual systems (BER should be extremely low and typically limited to
single-bit errors), this patch series is a good starting point. So...
Acked-By: Pierre-Louis Bossart
This patch series is also a
On 12/5/17 11:58 PM, Vinod Koul wrote:
On Tue, Dec 05, 2017 at 08:48:03AM -0600, Pierre-Louis Bossart wrote:
On 12/5/17 7:43 AM, Pierre-Louis Bossart wrote:
On 12/5/17 12:31 AM, Vinod Koul wrote:
On Sun, Dec 03, 2017 at 09:01:41PM -0600, Pierre-Louis Bossart wrote:
+static inline int
On 12/5/17 7:43 AM, Pierre-Louis Bossart wrote:
On 12/5/17 12:31 AM, Vinod Koul wrote:
On Sun, Dec 03, 2017 at 09:01:41PM -0600, Pierre-Louis Bossart wrote:
On 12/3/17 11:04 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:27:31PM -0600, Pierre-Louis Bossart wrote:
Sorry looks like I missed
On 12/5/17 12:31 AM, Vinod Koul wrote:
On Sun, Dec 03, 2017 at 09:01:41PM -0600, Pierre-Louis Bossart wrote:
On 12/3/17 11:04 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:27:31PM -0600, Pierre-Louis Bossart wrote:
Sorry looks like I missed replying to this one earlier.
+static inline
On 12/3/17 9:21 PM, Vinod Koul wrote:
On Sun, Dec 03, 2017 at 09:11:39PM -0600, Pierre-Louis Bossart wrote:
On 12/3/17 11:11 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:52:03PM -0600, Pierre-Louis Bossart wrote:
+ status = sdw_read(slave, SDW_DP0_INT);
+ if
On 12/3/17 11:11 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:52:03PM -0600, Pierre-Louis Bossart wrote:
+ status = sdw_read(slave, SDW_DP0_INT);
+ if (status < 0) {
+ dev_err(slave->bus->dev,
+ &qu
On 12/3/17 11:08 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:36:47PM -0600, Pierre-Louis Bossart wrote:
+/* called with bus_lock held */
+static int sdw_get_device_num(struct sdw_slave *slave)
+{
+ int bit;
+
+ bit = find_first_zero_bit(slave->bus->assigned, SDW_MAX_D
On 12/3/17 11:04 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 05:27:31PM -0600, Pierre-Louis Bossart wrote:
+static inline int find_response_code(enum sdw_command_response resp)
+{
+ switch (resp) {
+ case SDW_CMD_OK:
+ return 0;
+
+ case SDW_CMD_IGNORED
On 12/3/17 10:52 AM, Vinod Koul wrote:
On Fri, Dec 01, 2017 at 04:49:01PM -0600, Pierre-Louis Bossart wrote:
+int sdw_master_read_prop(struct sdw_bus *bus)
+{
+ struct sdw_master_prop *prop = &bus->prop;
+ struct fwnode_handle *link;
+ unsigned int count = 0;
+
+/* SDW Enumeration Device Number */
+#define SDW_ENUM_DEV_NUM 0
add
SDW_GROUP12_DEV_NUM 12
SDW_GROUP12_DEV_NUM 13
you mean SDW_GROUP13_DEV_NUM :D
SDW_MASTER_DEV_NUM 14 /* not supported in these patches */
These dont help now as we dont
On 12/1/17 3:56 AM, Vinod Koul wrote:
This patch series adds a new SoundWire subsystem which implements a
new MIPI bus protocol 'SoundWire'.
Sorry for the late feedback Vinod and team.
Overall the code looks very good to me and aligned with the MIPI specs,
there are only a couple of points th
struct sdw_cdns {
struct device *dev;
struct sdw_bus bus;
unsigned int instance;
+ u32 response_buf[0x80];
last nit-pick: use a #define for the size.
Also are you sure about the value? I vaguely recall that the FIFO was
32-deep, you are confusing bytes and words h
On 12/1/17 3:56 AM, Vinod Koul wrote:
Add status handling API sdw_handle_slave_status() to handle
Slave status changes.
Signed-off-by: Hardik T Shah
Signed-off-by: Sanyog Kale
Signed-off-by: Vinod Koul
---
drivers/soundwire/bus.c | 351 ++
driv
On 12/1/17 3:56 AM, Vinod Koul wrote:
From: Sanyog Kale
SoundWire Slaves report status to bus. Add helpers to handle
the status changes.
Signed-off-by: Hardik T Shah
Signed-off-by: Sanyog Kale
Signed-off-by: Vinod Koul
---
drivers/soundwire/bus.c | 202 ++
On 12/1/17 3:56 AM, Vinod Koul wrote:
SoundWire bus supports read or write register(s) for SoundWire Slave
device. sdw_read() and sdw_write() APIs are provided for single
register read/write. sdw_nread() and sdw_nwrite() for operations on
contiguous registers.
Signed-off-by: Sanyog Kale
Signed-
On 12/1/17 3:56 AM, Vinod Koul wrote:
MIPI Discovery And Configuration (DisCo) Specification for SoundWire
specifies properties to be implemented for SoundWire Masters and
Slaves. The DisCo spec doesn't mandate these properties. However,
SDW bus cannot work without knowing these values.
The help
On 12/1/17 3:56 AM, Vinod Koul wrote:
A Master registers with SoundWire bus and scans the firmware provided
nitpick: is the 'register' correct? You create a bus instance for each
hardware master interface. Or is my brain fried?
for device description. In this patch we scan the ACPI namespac
On 11/30/17 6:24 AM, Vinod Koul wrote:
On Wed, Nov 29, 2017 at 08:52:58AM -0600, Pierre-Louis Bossart wrote:
On 11/29/17 4:27 AM, Vinod Koul wrote:
On Tue, Nov 28, 2017 at 07:45:45PM -0600, Pierre-Louis Bossart wrote:
I am not sure about top level being default to Y...
It's sta
On 11/29/17 4:27 AM, Vinod Koul wrote:
On Tue, Nov 28, 2017 at 07:45:45PM -0600, Pierre-Louis Bossart wrote:
I am not sure about top level being default to Y...
It's standard procedure apparently, see Linus/Mark/Takashi's emails.
config SND_SST_ATOM_HIFI2_PLATFORM
by anyone, and with Edison now defunct support for
Merrifield/Edison is to be determined.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 27 +++
sound/soc/intel/boards/Kconfig | 14 --
2 files changed, 27 insertions(+), 14 deletions
-level selector which will allow for selection/reuse
of the same machine driver with existing SST or SOF-based platform
drivers.
Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies")
Reported-by: Linus Torvalds
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/int
Document in comments what the options are supposed to mean, before
clean-up in next patch.
No functionality change here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/sound/soc/intel/Kconfig
ested with each of Haswell, Baytrail legacy, HiFi2, SKL cases
selected independently. 0-day and explicit randconfig tests did not report
additional issues and no functionality loss was observed in Intel tests on
HIFI2 and SKYLAKE platforms
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kc
Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected.
The latter might actually need to be moved to the SOC side of things,
it really has no place in a machine driver dependency
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 2 +-
1 file changed, 1
Make sure all the configs are aligned
Also add the missing dependencies on SOC_ACPI stuff used to fix
DAI names based on HID and fix a couple of indentation issues
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 33 +++--
1 file changed, 19
No reason why SND_SOC_INTEL_SST should be set here.
Also make sure same dependencies are used everywhere (only last one has SPI
in addition). Replace X86_INTEL_LPSS by MFD_INTEL_LPSS since the former
makes no sense for Skylake+ devices
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel
TEL_LPSS for Skylake+ devices
Fixed a couple of indentation issues
Pierre-Louis Bossart (7):
ASoC: Intel: Fix Kconfig with top-level selector
ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies
ASoC: Intel: document what Kconfig options do
ASoC: Intel: Fix nested/unnecessary Kconfig
On 11/22/17 5:54 AM, Mark Brown wrote:
On Tue, Nov 21, 2017 at 06:10:52PM +0100, Takashi Iwai wrote:
Takashi Iwai wrote:
FYI, I've put these to a test branch, test/asoc-intel-kconfig, so that
0day bot can catch issues. Let's see.
No news is a good news, it seems that your patchset doesn't
On 11/21/17 11:10 AM, Takashi Iwai wrote:
On Sat, 18 Nov 2017 10:25:28 +0100,
Takashi Iwai wrote:
On Sat, 18 Nov 2017 01:01:55 +0100,
Pierre-Louis Bossart wrote:
At the risk of being scolded for the third time in two days by
Linux overlords (no hard feelings), here's an attempt to
On 11/21/17 11:09 AM, Takashi Iwai wrote:
On Sat, 18 Nov 2017 01:01:58 +0100,
Pierre-Louis Bossart wrote:
Document what the options are supposed to mean, before clean-up in
next patch.
No functionality change here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 20
On 11/21/17 11:07 AM, Takashi Iwai wrote:
On Sat, 18 Nov 2017 01:01:56 +0100,
Pierre-Louis Bossart wrote:
Follow network example suggested by Linus, move Intel definitions
in if/endif block and clarify which options distro configurations
should enable - everything except legacy Baytrail stuff
On 11/21/17 3:30 AM, Carlo Caione wrote:
On Thu, Nov 16, 2017 at 1:53 PM, Carlo Caione wrote:
On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart
wrote:
On 10/18/17 11:49 AM, Carlo Caione wrote:
From: Carlo Caione
Introduce a new custom dapm routes map to quirk platforms with the
On 11/19/2017 03:00 AM, SF Markus Elfring wrote:
From: Markus Elfring
Date: Sun, 19 Nov 2017 09:53:56 +0100
* Add a jump target so that a specific error message is stored only once
at the end of this function implementation.
* Replace two calls of the function "dev_err" by goto statements
On 11/18/2017 11:08 AM, Andy Shevchenko wrote:
On Fri, 2017-11-17 at 18:02 -0600, Pierre-Louis Bossart wrote:
Make sure all the configs are aligned
Also add the missing dependencies on SOC_ACPI stuff used to fix
DAI names based on HID.
FIXME: not sure why X86_INTEL_LPSS is needed in a
On 11/18/2017 10:53 AM, Andy Shevchenko wrote:
On Fri, 2017-11-17 at 18:01 -0600, Pierre-Louis Bossart wrote:
PCI/ACPI selections should not happen in Kconfig for machine drivers,
move to SOC selections.
Add distinction between PCI and ACPI HiFi2 platforms.
The PCI-based
platforms may
On 11/18/2017 10:49 AM, Takashi Iwai wrote:
On Sat, 18 Nov 2017 01:01:56 +0100,
Pierre-Louis Bossart wrote:
+if SND_SOC_INTEL_BAYTRAIL
config SND_SOC_INTEL_BYT_MAX98090_MACH
tristate "ASoC Audio driver for Intel Baytrail with MAX98090 codec"
+ default n
de
Make sure all the configs are aligned
Also add the missing dependencies on SOC_ACPI stuff used to fix
DAI names based on HID.
FIXME: not sure why X86_INTEL_LPSS is needed in a machine
driver config, should it be back to X86 everywhere?
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel
ested with each of Haswell, Baytrail legacy, HiFi2, SKL cases
selected independently, no obvious issue detected but this needs to
be validated for functionality and may expose randconfig issues
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 6 +++---
1 file changed, 3 insertions(
Make sure that the same I2C/I2C_DESIGNWARE_PLATFORM are selected.
The latter might actually need to be moved to the SOC side of things,
it really has no place in a machine driver dependency
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 2 +-
1 file changed, 1
No reason why SND_SOC_INTEL_SST should be set here.
Also make sure same dependencies are used everywhere (only last one has SPI
in addition)
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/boards/Kconfig | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git
Document what the options are supposed to mean, before clean-up in
next patch.
No functionality change here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/sound/soc/intel/Kconfig b/sound
e more testing on my side but I could use feedback. Thanks!
Pierre-Louis Bossart (7):
ASoC: Intel: Fix Kconfig
ASoC: Intel: Kconfig: Simplify-clarify ACPI/PCI dependencies
ASoC: Intel: document what Kconfig options do
ASoC: Intel: Fix nested/unnecessary Kconfig dependencies
ASoC: Int
when using older configs without any user selection.
Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies")
Reported-by: Linus Torvalds
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 57 +++--
sound/soc/intel/boards/Kc
Merrifield.
There should be no functionality change.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 16
sound/soc/intel/boards/Kconfig | 14 --
2 files changed, 16 insertions(+), 14 deletions(-)
diff --git a/sound/soc/intel/Kconfig b/sound
On 11/16/2017 04:24 PM, Linus Torvalds wrote:
On Thu, Nov 16, 2017 at 2:16 PM, Pierre-Louis Bossart
wrote:
Add 'default m' when sensible
No.
This is not sensible, and is not at all what I suggested.
Actual new code should *never* be default 'm' or 'y'.
ity change.
Fixes: f6a118a800e3 ("ASoC: Intel: clarify Kconfig dependencies")
Reported-by: Linus Torvalds
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/intel/Kconfig| 5
sound/soc/intel/boards/Kconfig | 60 ++
2 files changed,
On 11/16/2017 09:10 AM, Takashi Iwai wrote:
On Thu, 16 Nov 2017 15:55:35 +0100,
Pierre-Louis Bossart wrote:
On 11/15/17 1:34 AM, Takashi Iwai wrote:
[Adding more people and alsa-devel to Cc]
On Wed, 15 Nov 2017 03:40:09 +0100,
Linus Torvalds wrote:
On Tue, Nov 14, 2017 at 6:51 AM, Takashi
On 11/15/17 1:34 AM, Takashi Iwai wrote:
[Adding more people and alsa-devel to Cc]
On Wed, 15 Nov 2017 03:40:09 +0100,
Linus Torvalds wrote:
On Tue, Nov 14, 2017 at 6:51 AM, Takashi Iwai wrote:
please pull sound updates for v4.15-rc1 from:
Hmm. Making "oldconfig" on my laptop with this, m
On 11/15/17 9:24 AM, Vinod Koul wrote:
On Wed, Nov 15, 2017 at 12:58:40PM +0100, Takashi Iwai wrote:
On Wed, 15 Nov 2017 12:37:42 +0100,
Mark Brown wrote:
On Wed, Nov 15, 2017 at 08:34:09AM +0100, Takashi Iwai wrote:
And I believe there are a few more possible cleanups / fixes in the
messy I
On 11/14/2017 01:12 PM, Jeremy Cline wrote:
On Mon, Nov 13, 2017 at 01:43:57PM -0600, Pierre-Louis Bossart wrote:
On 11/10/2017 12:36 PM, Jeremy Cline wrote:
Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
and remove the now unused snd_soc_acpi_check_hid function. This
On 11/10/2017 12:36 PM, Jeremy Cline wrote:
Replace snd_soc_acpi_check_hid() with the generic acpi_dev_present()
and remove the now unused snd_soc_acpi_check_hid function. This should
have no functional change.
The code looks ok, but I'd like to first add the fix for the quirk
handling regre
On 11/10/17 8:48 PM, Ruslan Bilovol wrote:
On Wed, Nov 8, 2017 at 9:38 PM, Pierre-Louis Bossart
wrote:
Nice work, thanks! I double-checked all the descriptors and values and
didn't find anything problematic, the main comment I have is that the clock
source/selection could probab
On 11/10/2017 05:33 AM, Hans de Goede wrote:
Hi,
On 09-11-17 22:07, Jeremy Cline wrote:
Replace the sst_acpi_check_hid helper function added in
commit 915ae2b9f0fe ("ASoC: Intel: Create a helper to search for
matching machine") with the generic acpi_dev_present helper function
and remove the
Nice work, thanks! I double-checked all the descriptors and values and
didn't find anything problematic, the main comment I have is that the
clock source/selection could probably be refactored since the
differences are really minor with UAC2, and there is work to do to
select the right Audio In
sure the configuration stays sane.
Makes sense, thanks for the cleanup.
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Arnd Bergmann
---
sound/soc/intel/boards/Kconfig | 26 +-
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/sound/soc/intel/boards
datasheet on hand CherryTrail has them, though they both
provide 19.2MHz frequency.
Fixes: 282a4e4ce5f9 ("platform/x86: Enable Atom PMC platform clocks")
Cc: Pierre-Louis Bossart
Signed-off-by: Andy Shevchenko
---
drivers/platform/x86/pmc_atom.c | 7 ++-
1 file changed, 6 insert
On 11/2/17 6:07 AM, Arnd Bergmann wrote:
I ran into multiple problems during randconfig builds of the
recently changed Kconfig logic for Intel ASoC drivers:
we did quite a bit of testing on this change, looks like we missed a
number of cases. Gah.
- Building without DMADEVICES doesn't work
On 11/1/17 4:08 AM, Vinod Koul wrote:
On Wed, Nov 01, 2017 at 02:49:15AM +0530, Pierre-Louis Bossart wrote:
+ if (found == false) {
+ /* TODO: Park this device in Group 13 */
+ dev_err(bus->dev, "Slave Entry not found"
+ if (found == false) {
+ /* TODO: Park this device in Group 13 */
+ dev_err(bus->dev, "Slave Entry not found");
No break here? Otherwise...
Thats intentional. We want to still read next device that show up
+ }
+
On 10/21/17 5:07 PM, Vinod Koul wrote:
On Sat, Oct 21, 2017 at 10:20:46AM +0100, Mark Brown wrote:
On Thu, Oct 19, 2017 at 08:33:20AM +0530, Vinod Koul wrote:
+ /* device is probed so let's read the properties now */
+ if (slave->ops && slave->ops->read_prop)
+ slave-
On 10/21/17 4:58 PM, Vinod Koul wrote:
On Sat, Oct 21, 2017 at 09:57:44AM +0100, Mark Brown wrote:
On Thu, Oct 19, 2017 at 08:33:17AM +0530, Vinod Koul wrote:
+The SoundWire protocol supports up to eleven Slave interfaces. All the
There's lots of perfectly normal nouns in this document like
never read
Signed-off-by: Colin Ian King
Indeed this has been unused since at least 2015...
FWIW
Acked-by: Pierre-Louis Bossart
---
sound/soc/intel/common/sst-firmware.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/intel/common/sst-firmware.c
b/sound/soc/intel/common/sst-
On 10/19/17 6:03 AM, Carlo Caione wrote:
From: Carlo Caione
Introduce an headset jack in the machine driver and register it to the
codec driver.
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 24
1 file changed, 24 insertions(+)
diff --git
On 10/19/17 6:03 AM, Carlo Caione wrote:
From: Carlo Caione
Enable jack detection or the RT5651 codec on the JD1_1 pin.
Nice, but the codec supports a second jack detection on JD1 and has a
second JD2 pin. I will bet that some devices will have a different
routing and I wonder if we could j
line or with
modprobe (as done in other machine drivers).
Reviewed-by: Pierre-Louis Bossart
Signed-off-by: Carlo Caione
---
sound/soc/intel/boards/bytcr_rt5651.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcr_rt5651.c
b
On 10/18/17 11:07 AM, Carlo Caione wrote:
From: Carlo Caione
While working on enabling a cherry-trail laptop shipping the rt5651
codec I realized that the machine driver needed some fixup.
In particular the laptop I'm working on (KIANO SlimNote 14.2) has the
internal mic connected to the IN2 p
On 10/12/17 2:28 PM, Guenter Roeck wrote:
From: Guenter Roeck
Commit f2ed6b07645e ("ASoC: Make aux_dev more like a generic component")
caused a regression on this driver, since now a kernel oops is seen
when the driver is loaded, or more specifically when
ts3a227e_enable_jack_detect() is called
aging/atomisp: Add support for the Intel IPU v2")
Tested-by: Carlo Caione
Reviewed-by: Andy Shevchenko
Signed-off-by: Pierre-Louis Bossart
---
v2: added Andy's Reviewed-by and Fixes tag
drivers/staging/media/atomisp/Kconfig | 1 +
drivers/staging/media/atomisp/pl
On 09/20/2017 04:12 AM, Andy Shevchenko wrote:
On Tue, 2017-09-19 at 15:45 -0500, Pierre-Louis Bossart wrote:
The Atom ISP driver initializes and configures PMC clocks which are
already handled by the clock framework.
Remove all legacy vlv2_platform_clock stuff and move to the clk API to
Signed-off-by: Pierre-Louis Bossart
---
drivers/staging/media/atomisp/Kconfig | 1 +
drivers/staging/media/atomisp/platform/Makefile| 1 -
.../staging/media/atomisp/platform/clock/Makefile | 6 -
.../platform/clock/platform_vlv2_plat_clk.c| 40
.../platform/clock
On 08/20/2017 12:22 AM, Peng Donglin wrote:
First of all,the address of pdev->dev is assigned to card->dev, when
calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card)
copies the value the variable card to card->dev->driver_data.After
that,the function platform_set_drvdata d
On 5/23/17 12:32 PM, Matthias Kaehlcke wrote:
Hi Pierre-Louis,
El Tue, May 23, 2017 at 12:25:17PM -0700 Pierre-Louis Bossart ha dit:
On 5/23/17 12:05 PM, Matthias Kaehlcke wrote:
Looks like the function has never been used since it was added by commit
17119a465706 ("ASoC: Intel
On 5/23/17 12:05 PM, Matthias Kaehlcke wrote:
Looks like the function has never been used since it was added by commit
17119a465706 ("ASoC: Intel: Add Cherrytrail & Braswell machine driver
cht_bsw_max98090_ti"). Removing it fixes the following warning when
building with clang:
sound/soc/intel/bo
On 5/5/17 7:37 AM, Thierry Escande wrote:
Hi,
On 04/05/2017 19:01, Pierre-Louis Bossart wrote:
On 05/02/2017 05:11 AM, Thierry Escande wrote:
If the ts3a227e audio accessory detection hardware is present and its
driver probed, the jack needs to be created before enabling jack
detection in
On 05/02/2017 05:11 AM, Thierry Escande wrote:
If the ts3a227e audio accessory detection hardware is present and its
driver probed, the jack needs to be created before enabling jack
detection in the ts3a227e driver. With this patch, the jack is
instantiated in the max98090 headset init function
Fix Makefile for x86 support, dependency on CONFIG_COMMON_CLK
was not explicit
Fixes: 701190fd7419 ('clk: x86: add support for Lynxpoint LPSS clocks')
Signed-off-by: Pierre-Louis Bossart
---
drivers/clk/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clk/
CherryTrail. These clocks
are available for general system use, where appropriate, and each
have Control & Frequency register fields associated with them.
Port from legacy by Pierre Bossart, integration in clock framework
by Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: I
s/Acumulate/Accumulate/
Signed-off-by: Pierre-Louis Bossart
---
include/linux/platform_data/x86/pmc_atom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/platform_data/x86/pmc_atom.h
b/include/linux/platform_data/x86/pmc_atom.h
index aa8744c..e4905fe 100644
CherryTrail. These clocks
are available for general system use, where appropriate. For example,
the usage for platform clocks suggested in the datasheet is the
following:
PLT_CLK[0..2] - Camera
PLT_CLK[3] - Audio Codec
PLT_CLK[4] -
PLT_CLK[5] - COMMs
Signed-off-by: Pierre-Louis Bossart
include files by
alphabetical order in pmc_atom.h
Signed-off-by: Irina Tirdea
Signed-off-by: Pierre-Louis Bossart
---
arch/x86/Kconfig | 4
arch/x86/platform/atom/Makefile | 1 -
drivers/acpi/acpi_lpss.c
atform/x86
platform/x86: Enable Atom PMC platform clocks
Pierre-Louis Bossart (2):
clk: Make x86/ conditional on CONFIG_COMMON_CLK
platform/x86: fix typo in comment
arch/x86/Kconfig | 4 -
arch/x86/platform/atom/Makefile| 1 -
dr
Thanks for the review Stephen.
On 1/20/17 5:58 PM, Stephen Boyd wrote:
On 01/17, Pierre-Louis Bossart wrote:
diff --git a/drivers/clk/x86/clk-pmc-atom.c b/drivers/clk/x86/clk-pmc-atom.c
new file mode 100644
index 000..312d4e9
--- /dev/null
+++ b/drivers/clk/x86/clk-pmc-atom.c
1101 - 1200 of 1233 matches
Mail list logo
