On 8/6/20 11:41 AM, Lu, Brent wrote:
I don't get this. If the platform driver already stated 240 and 960 samples why
would 432 be chosen? Doesn't this mean the constraint is not applied?
Hi Pierre,
Sorry for late reply. I used following constraints in V3 patch so any period
which
aligns
On 8/7/20 8:21 PM, Randy Dunlap wrote:
Drop the repeated words {that, the} in comments.
Signed-off-by: Randy Dunlap
Cc: Liam Girdwood
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Acked-by: Pierre-Louis Bossart
Thanks Randy.
---
sound/soc/sof/intel/cnl.c |2 +-
sound/soc/sof
On 8/9/20 3:56 AM, Dinghao Liu wrote:
When power_up_sst() fails, stream needs to be freed
just like when try_module_get() fails. However, current
code is returning directly and ends up leaking memory.
Fixes: 0121327c1a68b ("ASoC: Intel: mfld-pcm: add control for powering up/down
dsp")
On 8/3/20 11:33 PM, Lu, Brent wrote:
For avoid further misunderstanding: it's fine that CRAS *uses* such a short
period. It's often required for achieving a short latency.
However, the question is whether the driver can set *only* this value for
making it working. IOW, if we don't have
On 8/3/20 8:00 AM, Lu, Brent wrote:
Again, is this fixed 240 is a must? Or is this also an alignment issue?
Hi Takashi,
I think it's a must for Chromebooks. Google found this value works
best with their CRAS server running on their BSW products. They
offered this patch for their own
On 7/30/20 4:04 AM, Jerome Brunet wrote:
On Wed 29 Jul 2020 at 17:56, Pierre-Louis Bossart
wrote:
On 7/29/20 10:46 AM, Jerome Brunet wrote:
commit b73287f0b0745 ('ASoC: soc-pcm: dpcm: fix playback/capture checks')
changed dpcm_playback and dpcm_capture semantic by throwing an error
On 7/30/20 10:27 AM, Pierre-Louis Bossart wrote:
Is this patch required if you've already constrained the period sizes
for the
platform driver in patch1?
Yes or alsa will select 320 as default period size for it.
ok, then that's a miss in your patch1. 320 samples is a multiple of 1ms
Is this patch required if you've already constrained the period sizes for the
platform driver in patch1?
Yes or alsa will select 320 as default period size for it.
ok, then that's a miss in your patch1. 320 samples is a multiple of 1ms
for 48kHz rates. I think it was valid only for the
On 7/29/20 6:03 AM, Brent Lu wrote:
From: Yu-Hsuan Hsu
The CRAS server does not set the period size in hw_param so ALSA will
calculate a value for period size which is based on the buffer size
and other parameters. The value may not always be aligned with Atom's
dsp design so a constraint
at we have to reach a point where configurations make sense
before we can clean them up. If we implicitly push issues under the rug
by not even being aware of them we'll never make progress.
Cc: Pierre-Louis Bossart
Signed-off-by: Jerome Brunet
---
Hi Mark,
Because b73287f0b0745 ('ASo
On 7/28/20 12:02 PM, Lu, Brent wrote:
So if there are already quirks in atom machine drivers to change the period
size, why is this patch necessary?
The story is: google implemented the constraint but doesn't know why it works
so asked us to explain. After checking the two counters I
y Dunlap
Signed-off-by: Pierre-Louis Bossart
---
v2: reworded ChangeLog as suggested by Jonathan Corbet.
scripts/kernel-doc | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/scripts/kernel-doc b/scripts/kernel-doc
index e991d7f961e9..d1b445665ad6 100755
---
On 7/28/20 7:07 AM, Mark Brown wrote:
On Tue, Jul 28, 2020 at 06:59:50AM +, RAVULAPATI, VISHNU VARDHAN RAO wrote:
So Actually for rt5682 codec Now in 5.8 there are three flags :
SND_SOC_RT5682
SND_SOC_RT5682_I2C
SND_SOC_RT5682_SDW
But till 5.7.8 we have
SND_SOC_RT5682
On 7/27/20 9:28 PM, Lu, Brent wrote:
All the Atom firmware assumes data chunks in multiples of 1ms (typically 5,
10 or 20ms). I have never seen anyone use 256 frames, that's asking for
trouble really.
it's actually the same with Skylake and SOF in most cases.
Is this a 'real' problem or a
On 7/27/20 6:15 PM, Jonathan Corbet wrote:
On Mon, 27 Jul 2020 18:09:21 -0500
Pierre-Louis Bossart wrote:
Both points were covered by the sentence "A command-line option is
provided to the kernel-doc script, as well as a check on environment
variables to turn this optional beh
Thank Jon for the feedback,
The kbuild bot recently added the W=1 option, which triggered
documentation cleanups to squelch hundreds of kernel-doc warnings.
To make sure new kernel contributions don't add regressions to
kernel-doc descriptors, this patch suggests an option to treat
warnings as
on a single stream. Patches to support such feature
are send in different patchset which involves adding generic interfaces.
Thanks,
srini
I've run out of comments :-)
Reviewed-by: Pierre-Louis Bossart
Changes since v2:(mostly suggested by Pierre)
- removed unnessary kernel style comments,
- moved
On 7/27/20 9:58 AM, Ravulapati Vishnu vardhan rao wrote:
changing SND_SOC_RT5682_I2C to SND_SOC_RT5682 because,
This flag which was previously set as SND_SOC_RT5682
used to build rt5682 codec driver but by changing into
SND_SOC_RT5682_I2C is preventing to build rt5682 codec
driver and machine
On 7/26/20 11:08 AM, Brent Lu wrote:
The ring buffer counter runs faster than hardware counter if the
period size in hw_param is larger than 240. Although the differce is
not much (around 2k frames), it causes false underrun in CRAS
sometimes because it's using 256 frames as period size in
/
Randy Dunlap also suggested adding a log for when generating
documentation. The documentation build is however not stopped for now.
KDOC_WERROR=1 make htmldocs
Suggested-by: Randy Dunlap
Signed-off-by: Pierre-Louis Bossart
---
scripts/kernel-doc | 23 ++-
1 file changed,
On 7/22/20 11:47 PM, Vinod Koul wrote:
On 22-07-20, 10:36, Pierre-Louis Bossart wrote:
* and the stream properties
+ * @set_codec_params: Sets the compressed stream codec
parameters, Optional
+ * This can be called in during gapless next track codec change
only to set
+ * codec params
@@ -917,6 +1018,14 @@ static int q6asm_dai_compr_trigger(struct
snd_soc_component *component,
ret = q6asm_cmd_nowait(prtd->audio_client, prtd->stream_id,
CMD_PAUSE);
break;
+ case SND_COMPR_TRIGGER_NEXT_TRACK:
+ prtd->next_track = true;
* and the stream properties
+ * @set_codec_params: Sets the compressed stream codec parameters,
Optional
+ * This can be called in during gapless next track codec change only
to set
+ * codec params
Would it be clearer if this was called set_next_codec_params()? or
On 7/21/20 12:00 PM, Srinivas Kandagatla wrote:
Move codec parameter checking to dedicated function so that other
callers do not duplicate it. This is in preparedness for adding
preparation?
snd_compr_set_codec_params() support.
+static int q6asm_compr_copy(struct snd_soc_component *component,
+ struct snd_compr_stream *stream, char __user *buf,
+ size_t count)
{
struct snd_compr_runtime *runtime = stream->runtime;
struct q6asm_dai_rtd *prtd =
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index 941f3216399c..fb0488e7beb9 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -67,6 +67,8 @@ struct q6asm_dai_rtd {
uint16_t bits_per_sample;
uint16_t
case ASM_CLIENT_EVENT_CMD_EOS_DONE:
- prtd->state = Q6ASM_STREAM_STOPPED;
+ spin_lock_irqsave(>lock, flags);
+ if (prtd->notify_on_drain) {
+ if (substream->partial_drain) {
+ /**
why the
On 7/21/20 12:00 PM, Srinivas Kandagatla wrote:
For gapless playback it is possible that each track can have different
codec profile with same decoder, for example we have WMA album,
we may have different tracks as WMA v9, WMA v10 and so on
Or if DSP's like QDSP have abililty to switch
On 7/21/20 12:00 PM, Srinivas Kandagatla wrote:
Make use of new set_codec_params callback to allow decoder switching
during gapless playback.
Signed-off-by: Srinivas Kandagatla
---
sound/soc/qcom/qdsp6/q6asm-dai.c | 33
1 file changed, 33 insertions(+)
Hi Harsha,
this looks mostly good to me, only have a couple of nit-picks below.
Thanks!
kabylake_ssp_fixup function uses snd_soc_dpcm to identify the codecs DAIs.
The hw parameters are changed based on the codec DAI,
the stream is intended for. The earlier approach to get
snd_soc_dpcm was using
diff --git a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
index 584e4f9cedc2..b261b1c466a8 100644
--- a/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
+++ b/sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
@@ -379,22
comes
from the earlier:
codec_dev = bus_find_device_by_name(_bus_type, NULL, codec_name);
call.
I probably needed more coffee when I wrote this, indeed this is fine...
Acked-by: Pierre-Louis Bossart
On 7/14/20 11:50 PM, Vinod Koul wrote:
On 01-07-20, 10:25, Pierre-Louis Bossart wrote:
+* wake up master and slave so that slave can notify master
+* the wakeen event and let codec driver check codec status
+*/
+ list_for_each_entry(slave, >slaves, n
On 7/14/20 11:54 PM, Vinod Koul wrote:
On 02-07-20, 10:01, Pierre-Louis Bossart wrote:
Sounds good. Now that you are already in irq thread, does it make sense
to spawn a worker thread for this and handle it there? Why not do in the
irq thread itself. Using a thread kind of defeats
On 7/14/20 8:33 AM, Hans de Goede wrote:
Hi,
On 7/14/20 10:09 AM, Jing Xiangfeng wrote:
snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error
path. Add the missed function call to fix it.
Fixes: ba49cf6f8e4a ("ASoC: Intel: bytcht_es8316: Add quirk for
inverted jack
On 7/9/20 10:25 AM, vamshi.krishna.go...@intel.com wrote:
From: Brent Lu
Add a dapm route to provide ssp mclk/sclk early
for DMIC on SSP0(rt5514) and Headset on SSP1(rt5663)
since sclk for both codecs are different the
struct now defines SSP0 and SSP1 mclk , sclk separately
This change
’
1207 | static SOC_VALUE_ENUM_SINGLE_DECL(
| ^~
Cc: Oder Chiou
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5659.c | 37 -
1 file changed, 37 deletions(-)
diff --git a/sound/soc/codecs/rt5659.c
-but-set-variable]
Cc: Kuninori Morimoto
Cc: Junichi Wakasugi
Cc: Mihai Serban
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/ak4458.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/ux500/ux500_msp_i2s.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a16..fd0b88bb7921 100644
--- a/sound/soc/ux500/ux500_msp_i2s.c
:443: warning: Function parameter or member
'component' not described in 'depop_seq_power_stage'
sound/soc/codecs/rt5631.c:515: warning: Function parameter or member
'component' not described in 'depop_seq_mute_stage'
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5631.c | 8
Fixes the following W=1 kernel build warning(s):
sound/soc/qcom/qdsp6/q6asm.c:924: warning: Function parameter or
member 'codec_profile' not described in 'q6asm_open_write'
Cc: Patrick Lai
Cc: Banajit Goswami
Cc: Srinivas Kandagatla
Cc: Vinod Koul
Signed-off-by: Pierre-Louis Bossart
Zabel
Cc: Andrea Venturi
Cc: Marcus Cooper
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 86779a99df75
:138: warning: Function parameter or
member 'mute' not described in 'aic26_mute'
Cc: Kuninori Morimoto
Cc: Grant Likely
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc
: Philipp Zabel
Cc: Andrea Venturi
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-i2s.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index d0a8d5810c0a..f23ff29e7c1d 100644
--- a/sound/soc/sunxi
but
not used [-Wunused-const-variable=]
1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
| ^~
Acked-by: Arnaud Pouliquen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sti/uniperif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Zhuang
Cc: Robert Jarzmik
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/pxa/pxa-ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 6a72cc1665b7..d1e09ade0190 100644
--- a/sound/soc/pxa
right, but the key point is 'switch between streams'. That means a
more complex/capable implementation that should be advertised as such
to applications. This is not the default behavior assumed initially:
to allow for minimal implementations in memory-constrained devices, we
assumed
Add support to gapless playback by implementing metadata,
next_track, drain and partial drain support.
Gapless on Q6ASM is implemented by opening 2 streams in a single asm
stream
What does 'in a single asm stream' means?
So in QDSP6 ASM (Audio Stream Manager) terminology we have
On 7/8/20 2:14 AM, Greg Kroah-Hartman wrote:
On Tue, Jul 07, 2020 at 03:26:28PM -0500, Pierre-Louis Bossart wrote:
CONFIG_REGMAP is not selected when no other serial bus is supported.
It's largely academic since CONFIG_I2C is usually selected e.g. by
DRM, but still this can break randconfig
On 7/8/20 4:11 AM, Arnaud POULIQUEN wrote:
Hi Pierre-Louis,
On 7/7/20 9:16 PM, Pierre-Louis Bossart wrote:
Fix W=1 warning. The table uni_tdm_hw is declared in a header included
by multiple C file. This isn't really a good practice but for now
using __maybe_unused makes the following
CONFIG_REGMAP is not selected when no other serial bus is supported.
It's largely academic since CONFIG_I2C is usually selected e.g. by
DRM, but still this can break randconfig so let's be explicit.
Signed-off-by: Pierre-Louis Bossart
---
drivers/base/regmap/Kconfig | 2 +-
1 file changed, 1
+int q6asm_stream_remove_initial_silence(struct audio_client *ac,
+ uint32_t stream_id,
+ uint32_t initial_samples)
+{
+ return q6asm_stream_remove_silence(ac, stream_id,
+
On 7/7/20 11:36 AM, Srinivas Kandagatla wrote:
Add support to gapless playback by implementing metadata,
next_track, drain and partial drain support.
Gapless on Q6ASM is implemented by opening 2 streams in a single asm stream
What does 'in a single asm stream' means?
and toggling them on
diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
index c3558288242a..8c214436a2c2 100644
--- a/sound/soc/qcom/qdsp6/q6asm-dai.c
+++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
@@ -258,7 +258,7 @@ static int q6asm_dai_prepare(struct snd_soc_component
*component,
@@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
switch (opcode) {
case ASM_CLIENT_EVENT_CMD_RUN_DONE:
if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
- q6asm_write_async(prtd->audio_client,
-
rre-Louis Bossart
---
sound/soc/intel/skylake/skl-sst-dsp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/skylake/skl-sst-dsp.c
b/sound/soc/intel/skylake/skl-sst-dsp.c
index 225706d148d8..cb83b395f210 100644
--- a/sound/soc/intel/skylake/skl-sst-dsp.c
+++ b/so
off-by: Pierre-Louis Bossart
---
sound/soc/meson/axg-pdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/meson/axg-pdm.c b/sound/soc/meson/axg-pdm.c
index bfd37d49a73e..8fe5b2563619 100644
--- a/sound/soc/meson/axg-pdm.c
+++ b/sound/soc/meson/axg-pdm.c
@@ -206,7 +20
off-by: Pierre-Louis Bossart
---
sound/soc/meson/axg-spdifin.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/meson/axg-spdifin.c b/sound/soc/meson/axg-spdifin.c
index d0d09f945b48..5fa411d4e985 100644
--- a/sound/soc/meson/axg-spdifin.c
+++ b/sound/soc/meson/axg-spdifi
Fix W=1 warning - typo in field description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 86779a99df75..326dd45e39da 100644
--- a/sound
Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/ux500/ux500_msp_i2s.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/ux500/ux500_msp_i2s.c b/sound/soc/ux500/ux500_msp_i2s.c
index 394d8b2a4a16..fd0b88bb7921 100644
--- a/sound/soc/ux500
but
not used [-Wunused-const-variable=]
1351 | static const struct snd_pcm_hardware uni_tdm_hw = {
| ^~
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sti/uniperif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sti
Fix W=1 warning, spurious kernel-doc start and missing arguments
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5631.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc
comment in this file.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
: Haojian Zhuang
Cc: Robert Jarzmik
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/pxa/pxa-ssp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
index 6a72cc1665b7..d1e09ade0190 100644
--- a/sound/soc/pxa
-but-set-variable]
Cc: Kuninori Morimoto
Cc: Junichi Wakasugi
Cc: Mihai Serban
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/ak4458.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c
Fix W=1 warnings - missing fields in description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-i2s.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index d0a8d5810c0a..f23ff29e7c1d 100644
’
1207 | static SOC_VALUE_ENUM_SINGLE_DECL(
| ^~
Cc: Oder Chiou
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5659.c | 37 -
1 file changed, 37 deletions(-)
diff --git a/sound/soc/codecs/rt5659.c
Fix W=1 warning - missing parameter description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/qcom/qdsp6/q6asm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
index ae4b2cabdf2d..d67b23a5f397 100644
Fix W=1 warnings - missing fields in structure
Credits to Sylwester Nawrocki for the pclk and cclk descriptions.
Reviewed-by: Sylwester Nawrocki
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/samsung/pcm.c b
Fix W=1 warning
sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined
but not used [-Wunused-const-variable=]
842 | static const struct acpi_device_id es8316_acpi_match[] = {
|^
Signed-off-by: Pierre-Louis Bossart
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
Acked-by: Adam Thomson
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7210.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
Fix W=1 warning when ACPI is not defined
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt274.c | 2 ++
sound/soc/codecs/rt286.c | 2 ++
sound/soc/codecs/rt298.c | 2 ++
sound/soc/codecs/rt5660.c | 2 ++
sound/soc/codecs/rt5677-spi.c | 2 ++
5 files changed, 10
Fix W=1 warnings - typos with structure fields
Reviewed-by: Sylwester Nawrocki
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/spdif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c
index 759fc6644329
Fix W=1 warning
Kernel-doc is not used in one file and missing argument in the second.
Acked-by: Alexandre Belloni
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/atmel/atmel-pcm-dma.c | 2 +-
sound/soc/atmel/atmel_ssc_dai.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git
-Louis Bossart
---
sound/soc/codecs/cros_ec_codec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 8d45c628e988..f23956cf4ed8 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
Fix W=1 warning:
sound/soc//tegra/tegra20_das.c:101:11: warning:
comparison of unsigned expression >= 0 is always true [-Wtype-limits]
101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) &&
| ^~
Reviewed-by: Jon Hunter
Signed-off-by: Pierre-Louis Bossart
---
s
by: Pierre-Louis Bossart
---
sound/soc/codecs/max98390.c | 8
1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index b345e626956d..3e8094241645 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -944,14 +944,6
Fix W=1 warning - wrong parameter description and bad format
Reviewed-by: Masahiro Yamada
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/uniphier/aio-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio
-variable]
Peter suggested that the whole read can be removed, so that's
been done too.
Cc: Peter Ujfalusi
Cc: Jarkko Nikula
Cc: Samuel Ortiz
Cc: linux-o...@vger.kernel.org
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/ti/omap-mcbsp-st.c | 3 ---
1 file changed
-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7219.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index f2520a6c7875..153ea30b5a8f 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -1708,11 +1708,13 @@ static
DECLARE_TLV_DB_SCALE(mic_boost_tlv, 0, 400, 0);
| ^~~~
Cc: ter Huurne
Reviewed-by: Paul Cercueil
Signed-off-by: Lee Jones
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/jz4770.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/jz4770.c b/sound/soc/codecs
ajczak
Signed-off-by: Harsha Priya
Acked-by: Pierre-Louis Bossart
---
v1 -> v2:
- Extract dmic from SSP0 as every BE should have own fixup function.
v2 -> v3:
- Restore naming in the dapm route table to not confuse with other
drivers
- Fixed indentations
v3 -> v4:
- Updated
On 7/7/20 5:40 AM, Mark Brown wrote:
On Tue, Jul 07, 2020 at 11:37:35AM +0100, Lee Jones wrote:
Some of these issues have been present for years. It's quite the
coincidence that we both submitted these this week!
I'm guessing you've both been inspired by the 0day bot turning W=1
warnings
On 7/3/20 7:16 AM, Lukasz Majczak wrote:
Fix kabylake_ssp_fixup function to distinguish codecs DAIs by names,
as current approach, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
On 7/3/20 4:47 AM, Srinivas Kandagatla wrote:
Thanks Pierre for the comments,
+Adding Patric Lai into loop,
On 02/07/2020 16:00, Pierre-Louis Bossart wrote:
On 7/2/20 6:11 AM, Srinivas Kandagatla wrote:
For gapless playback its possible that each track can have different
codec profile
On 7/3/20 1:47 PM, Sylwester Nawrocki wrote:
On 02.07.2020 18:58, Pierre-Louis Bossart wrote:
Fix W=1 warnings - missing fields in structure
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/samsung/pcm.c b
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl
Fix W=1 warnings. kernel-doc syntax was not followed and missing parameter
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_spdif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
Fix W=1 warnings. fix kernel doc and describe arguments.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_asrc.c | 57 +++-
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc
Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_esai.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound
Fix W=1 warnings. The kernel-doc support is partial, add more
descriptions and follow proper syntax
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi.c | 70 ++---
1 file changed, 44 insertions(+), 26 deletions(-)
diff
Fix W=1 warnings. There is no kernel-doc here.
Acked-by: Nicolin Chen
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi_dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c
index 2a20ee23dc52
On 7/2/20 1:55 PM, Nicolin Chen wrote:
On Thu, Jul 02, 2020 at 12:22:27PM -0500, Pierre-Louis Bossart wrote:
Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Signed-off-by: Pierre-Louis Bossart
+ * fsl_esai_set_dai_sysclk - This function mainly configures the clock
On 7/2/20 1:47 PM, Nicolin Chen wrote:
On Thu, Jul 02, 2020 at 12:22:24PM -0500, Pierre-Louis Bossart wrote:
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9
Fix W=1 warnings. Kernel-doc syntax was not properly used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl-asoc-card.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index
Fix W=1 warnings. Fix kernel-doc syntax and add missing parameters.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_esai.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index
Fix W=1 warnings. kernel-doc syntax was not followed and missing parameter
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_spdif.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 5b2689ae63d4
Fix W=1 warnings. The kernel-doc support is partial, add more
descriptions and follow proper syntax
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi.c | 70 ++---
1 file changed, 44 insertions(+), 26 deletions(-)
diff --git a/sound/soc/fsl
Fix W=1 warnings. There is no kernel-doc here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_ssi_dbg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/fsl/fsl_ssi_dbg.c b/sound/soc/fsl/fsl_ssi_dbg.c
index 2a20ee23dc52..2c46c55f0a88 100644
Fix W=1 warnings. fix kernel doc and describe arguments.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/fsl/fsl_asrc.c | 57 +++-
1 file changed, 39 insertions(+), 18 deletions(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index
301 - 400 of 1453 matches
Mail list logo
