Fix W=1 warning - typo in field description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c
index 86779a99df75..326dd45e39da 100644
--- a/sound
Fix W=1 warning - missing parameter description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/qcom/qdsp6/q6asm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
index ae4b2cabdf2d..d67b23a5f397 100644
Fix W=1 warning:
sound/soc//tegra/tegra20_das.c:101:11: warning:
comparison of unsigned expression >= 0 is always true [-Wtype-limits]
101 | if ((reg >= TEGRA20_DAS_DAP_CTRL_SEL) &&
| ^~
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/tegra/tegra20_das.c |
Fix W=1 warning - wrong parameter description and bad format
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/uniphier/aio-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/sound/soc/uniphier/aio-core.c b/sound/soc/uniphier/aio-core.c
index 9bcba06ba52e
Fix W=1 warnings - missing fields in description
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/sunxi/sun4i-i2s.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index d0a8d5810c0a..f23ff29e7c1d 100644
Fix W=1 warnings - missing fields in structure
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/pcm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c
index a5b1a12b3496..86eefbc89e9e 100644
--- a/sound/soc/samsung/pcm.c
+++ b
Fix W=1 warnings - typos with structure fields
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/samsung/spdif.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/samsung/spdif.c b/sound/soc/samsung/spdif.c
index 759fc6644329..4ae7ff623b82 100644
--- a/sound
Fix W=1 warning
Kernel-doc is not used in one file and missing argument in the second.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/atmel/atmel-pcm-dma.c | 2 +-
sound/soc/atmel/atmel_ssc_dai.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/atmel/atmel-pcm
Fix W=1 warning. the card variable is useless here
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-i2s.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index 14607563abd2..a0e14cc91d95 100644
--- a/sound
Fix W=1 warning. The variable prtd is not used, remove.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 1f0fe5aaab1d..17290c829c4b
Fix W=1 warning. The variable prtd is set but not used.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-i2s.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
index a0e14cc91d95..c3eb9b347eaa 100644
Fix W=1 warning. the card variable is useless here.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/raven/acp3x-pcm-dma.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c
b/sound/soc/amd/raven/acp3x-pcm-dma.c
index 5bd458e0fe31..1f0fe5aaab1d 100644
Fix W=1 warning
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/acp-rt5645.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/amd/acp-rt5645.c b/sound/soc/amd/acp-rt5645.c
index 73b31f88a6b5..87f0060e771f 100644
--- a/sound/soc/amd/acp-rt5645.c
+++ b/sound/soc/amd/acp
Fix W=1 warning
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/amd/acp-da7219-max98357a.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/amd/acp-da7219-max98357a.c
b/sound/soc/amd/acp-da7219-max98357a.c
index 9414d7269c4f..7d8986379d80 100644
--- a/sound/soc/amd/acp-da7219
On 7/2/20 6:18 AM, Mark Brown wrote:
On Wed, Jul 01, 2020 at 09:21:24PM -0400, Sasha Levin wrote:
From: Pierre-Louis Bossart
[ Upstream commit c8d2e2bfaeffa0f914330e8b4e45b986c8d30b58 ]
Usually the DSP is not traditionally enabled on H skews but this might
be used moving forward
On 7/2/20 6:11 AM, Srinivas Kandagatla wrote:
For gapless playback its possible that each track can have different
codec profile with same decoder, for example we have WMA album,
we may have different tracks as WMA v9, WMA v10 and so on
Existing code does not allow to change this profile
On 7/2/20 2:35 AM, Liao, Bard wrote:
-Original Message-
From: Vinod Koul
Sent: Wednesday, July 1, 2020 1:42 PM
To: Pierre-Louis Bossart
Cc: Bard Liao ; alsa-de...@alsa-project.org;
ti...@suse.de; gre...@linuxfoundation.org; linux-kernel@vger.kernel.org;
ranjani.sridha
On 7/1/20 9:04 PM, Vincent Chen wrote:
On Thu, Jul 2, 2020 at 2:48 AM Pierre-Louis Bossart
wrote:
0day/kbuild reports warnings with the ASoC codecs compiled with W=1.
In file included from arch/riscv/include/asm/kgdb.h:109,
from include/linux/kgdb.h:20
zed speaker amplifier types.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: e1435a1feb18 ("ASoC: Intel: bxt-da7219-max98357a: support MAX98390 speaker
amp")
Signed-off-by: Colin Ian King
Sounds good, thanks Colin.
Acked-by: Pierre-Louis Bossart
---
Reported-by: kernel test robot
Signed-off-by: Pierre-Louis Bossart
---
I don't know if this is the right way of solving this issue but this
error is now consistently thrown in kbuild compile-test reports w/
W=1.
arch/riscv/include/asm/gdb_xml.h | 10 +-
1 file changed, 5 insert
Fix W=1 warning, spurious kernel-doc start and missing arguments
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5631.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
index b5184f0e10e3..653da3eaf355
Fix W=1 warning. Remove spurious /** since there isn't any kernel-doc
comment in this file.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/tlv320aic26.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt5659.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs
Fix W=1 warning, the kernel-doc syntax was probably from Doxygen?
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/da7210.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/da7210.c b/sound/soc/codecs/da7210.c
index 0c99dcf242e4
by: Pierre-Louis Bossart
---
sound/soc/codecs/max98390.c | 8
1 file changed, 8 deletions(-)
diff --git a/sound/soc/codecs/max98390.c b/sound/soc/codecs/max98390.c
index b345e626956d..3e8094241645 100644
--- a/sound/soc/codecs/max98390.c
+++ b/sound/soc/codecs/max98390.c
@@ -944,14 +944,6
Fix W=1 warning by adding __maybe_unused. Maintainers for this file
may want to double-check if those definitions are necessary.
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/jz4770.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/jz4770.c b
Fix W=1 warning
sound/soc/codecs/es8316.c:842:36: warning: 'es8316_acpi_match' defined
but not used [-Wunused-const-variable=]
842 | static const struct acpi_device_id es8316_acpi_match[] = {
|^
Signed-off-by: Pierre-Louis Bossart
Fix W=1 warning when ACPI is not defined
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/rt274.c | 2 ++
sound/soc/codecs/rt286.c | 2 ++
sound/soc/codecs/rt298.c | 2 ++
sound/soc/codecs/rt5660.c | 2 ++
sound/soc/codecs/rt5677-spi.c | 2 ++
5 files changed, 10
fix warning with W=1
sound/soc/codecs/ak4458.c:408:16: warning: variable 'ret' set but not
used [-Wunused-but-set-variable]
408 | int nfs, ndt, ret, reg;
|^~~
Signed-off-by: Pierre-Louis Bossart
---
sound/soc/codecs/ak4458.c | 2 +-
1 file changed, 1 insertion(+), 1
fix W=1 warning
sound/soc/codecs/da7219.c:1711:36: warning: 'da7219_acpi_match'
defined but not used [-Wunused-const-variable=]
1711 | static const struct acpi_device_id da7219_acpi_match[] = {
|^
Signed-off-by: Pierre-Louis Bossart
-Louis Bossart
---
sound/soc/codecs/cros_ec_codec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index 8d45c628e988..f23956cf4ed8 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
Tested and the following is something we can use without creating a new
dailink.
struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
if (!strcmp(codec_dai->name, KBL_REALTEK_DMIC_CODEC_DAI)) {
if (params_channels(params) == 2 ||
, thanks Brent
Acked-by: Pierre-Louis Bossart
+* wake up master and slave so that slave can notify master
+* the wakeen event and let codec driver check codec status
+*/
+ list_for_each_entry(slave, >slaves, node) {
+ /*
+* discard devices that are defined in ACPI tables but
+
On 7/1/20 11:37 AM, N, Harshapriya wrote:
For speakers and headsets its 48Khz, 2 ch and 24 bit and this
setting is done based on the front-end dai For speakers, however
support only
16 bit, so we set it back to 16 bit If the front end dai is dmic,
then the channel
is set to either 2 or 4
has been attached to a bus, the slave->dev_num_sticky
should be non-zero, so we can check this value to skip the
ghost devices defined in ACPI table but not populated in hardware.
Signed-off-by: Rander Wang
Signed-off-by: Pierre-Louis Bossart
Signed-off-by: Bard Liao
---
drivers/soundw
Thanks Vinod for the review.
--- a/drivers/soundwire/stream.c
+++ b/drivers/soundwire/stream.c
@@ -13,6 +13,9 @@
#include
#include
#include
+#include
Do we really need core header?
No we don't, the only thing needed in sound/soc.h it seems.
+#include
+#include
#include
+irqreturn_t sdw_intel_thread(int irq, void *dev_id)
+{
+ struct sdw_intel_ctx *ctx = dev_id;
+ struct sdw_intel_link_res *link;
+
+ list_for_each_entry(link, >link_list, list)
+ sdw_cdns_irq(irq, link->cdns);
+
+ sdw_intel_enable_irq(ctx->mmio_base,
diff --git a/sound/soc/intel/boards/Kconfig
b/sound/soc/intel/boards/Kconfig index 3d820e1..b3b863e 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -291,9 +291,17 @@ config
SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
select SND_SOC_DMIC
select
On 6/22/20 12:34 AM, Vinod Koul wrote:
On 19-06-20, 09:27, Pierre-Louis Bossart wrote:
+For Gapless, we move from running state to partial drain and back, along
+with setting of meta_data and signalling for next track
On 6/22/20 1:58 AM, Vinod Koul wrote:
So we had some discussions of the stream states, so I thought it is a
good idea to document the state transitions, so add it documentation
Signed-off-by: Vinod Koul
---
.../sound/designs/compress-offload.rst| 52 +++
1 file
+
++--+
+| |
+| OPEN |
+| |
++--+
+
+For Gapless, we move from running state to partial drain and back, along
+with setting of meta_data and signalling for next track ::
+
+
++--+
+compr_drain_notify()| |
+ +>|
On 6/16/20 9:18 PM, JaeHun Jung wrote:
In mobile, a co-processor is used when using USB audio
to improve power consumption.
hooking is required for sync-up when operating
the co-processor. So register call-back function.
The main operation of the call-back function is as follows:
- Initialize
On 6/18/20 6:44 AM, Daniel Baluta wrote:
On 6/18/20 2:01 PM, Mark Brown wrote:
On Wed, Jun 17, 2020 at 09:02:32PM -0400, Sasha Levin wrote:
From: Daniel Baluta
[ Upstream commit c26fde3b15ed41f5f452f1da727795f787833287 ]
This provides a better separation between runtime and PM sleep
t;] i2c_register_driver+0x6b/0xd0
[<bf84b954>] do_one_initcall+0x86/0x2a0
[<1d939871>] do_init_module+0xf8/0x350
[<267b474f>] load_module+0x41a9/0x44c0
[<7d8014dc>] __do_sys_finit_module+0x121/0x1b0
Signed-off-by: Pierre-Louis Bossart
Review
ted by Kai don't show any regression and change looks
good so:
Reviewed-by: Pierre-Louis Bossart
Thanks Brent!
On 6/12/20 9:46 AM, Mark Brown wrote:
On Fri, Jun 12, 2020 at 08:54:11AM -0500, Pierre-Louis Bossart wrote:
I think that those configuration errors are the problem and should be fixed
as a prerequisite to the removal of the duplication between
dpcm_playback/dpcm_capture/playback_only
On 6/12/20 7:19 AM, Mark Brown wrote:
On Thu, Jun 11, 2020 at 05:49:29PM -0700, John Stultz wrote:
On Thu, Jun 11, 2020 at 5:13 PM John Stultz wrote:
I've bisected it down to the following commit from this pull req:
I added debug messages to print the RIRBWP register and realize
that
response could come between the read of RIRBWP in the
snd_hdac_bus_update_rirb() function and the interrupt clear in the
hda_dsp_stream_interrupt() function. The response is not handled
but
the interrupt is already cleared.
On 6/11/20 12:09 PM, Lu, Brent wrote:
Hi Brent,
Thanks for the patch. Is this fix for a specific issue you're seeing?
If so, could you please give us some details about it?
Thanks,
Ranjani
Hi Ranjani,
It's reported to happen on GLK Chromebook 'Fleex' that sometimes it
cannot output the
On 6/10/20 5:07 AM, Srinivas Kandagatla wrote:
For gapless playback call to snd_compr_drain_notify() after
partial drain should put the state to SNDRV_PCM_STATE_RUNNING
rather than SNDRV_PCM_STATE_SETUP as the driver is ready to
process the buffers for new track.
With existing code, if we
On 6/8/20 3:43 PM, Jonathan Marek wrote:
Adds support for qcom soundwire devices with memory mapped IO registers.
'device' is an ambiguous term for SoundWire.
Seems to me this is a SoundWire Master device directly accessed with
mmio registers instead of over a SLIMbus link?
On 6/8/20 3:43 PM, Jonathan Marek wrote:
The driver may be used without slimbus, so don't depend on slimbus.
Signed-off-by: Jonathan Marek
---
drivers/soundwire/Kconfig | 1 -
drivers/soundwire/qcom.c | 5 +
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
nge is quite hard to review, this error handling can be called
from multiple places.
I *think* it's correct because in all cases where the
disconnect/close/hw_free labels are reached, the non-shared BEs either
remain or are put in the DPCM_STATE_CLOSE state before doing this test.
Review
On 6/1/20 12:38 AM, Greg KH wrote:
On Mon, Jun 01, 2020 at 01:28:07AM +0800, Bard Liao wrote:
From: Pierre-Louis Bossart
Change SPDX from GPL-2.0 to GPL-2.0-only for Intel-contributed
code. This was explicit before the transition to SPDX and lost in
translation.
It is also explicit
On 5/29/20 8:55 AM, Pierre-Louis Bossart wrote:
On 5/29/20 8:30 AM, Mark Brown wrote:
On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
sound/soc/sof/intel
On 5/29/20 8:30 AM, Mark Brown wrote:
On Thu, May 28, 2020 at 01:57:17PM +1000, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
sound/soc/sof/intel/byt.c:464:12: warning: 'byt_remove' defined but not
ated feedback).
Thanks for your work Michael, really nice and useful, feel free to add
the following tag:
Tested-by: Pierre-Louis Bossart
Hi Michael,
+struct gpio_regmap_config {
+ struct device *parent;
+ struct regmap *regmap;
+
+ const char *label;
+ int ngpio;
could we add a .names field for the gpio_chip, I found this useful for
PCM512x GPIO support, e.g.
Sure, I have the names in the device tree.
But I'd
nges.
Fixes: 6b8e4e7db3cd ("ASoC: amd: Add machine driver for Raven based platform")
Fixes: fd443a20c2f0 ("ASoC: rt5682: fix I2C/Soundwire dependencies")
Signed-off-by: Arnd Bergmann
Reviewed-by: Pierre-Louis Bossart
Thanks for this cleanup.
On 5/25/20 2:06 AM, Dinghao Liu wrote:
When sst_load_fw() returns an error code, a pairing runtime
PM usage counter decrement is needed to keep the counter
balanced.
Signed-off-by: Dinghao Liu
---
sound/soc/intel/atom/sst/sst_drv_interface.c | 1 +
1 file changed, 1 insertion(+)
diff
for SSP0, we have RT5514 for capture and max98927 for playback, but the
existing code does not explicitly deal with rate/channels/format for all
cases, so it's not clear what should happen.
Harsha, can you help here?
Best regards,
Lukasz
czw., 21 maj 2020 o 19:17 Pierre-Louis Bossart
napisał(a):
On 5/21/20 12:08 PM, Łukasz Majczak wrote:
don't add a new dailink, this is not right.
Can you advise a better solution how to assign different fixup
functions to mic and to speakers? I was looking at "dmic01" dailink in
skl_nau88l25_max98357a.c as an example.
I am not sure I follow. the
On 5/21/20 11:25 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
specific fixup for itself.
Best regards,
Lukasz
czw., 21 maj 2020 o 16:25 Pierre-Louis Bossart
napisał(a):
On 5/21/20 8:47 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
conta
On 5/21/20 8:47 AM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
On 5/13/20 2:20 PM, Lukasz Majczak wrote:
Split be_hw_params_fixup function for different codecs as current common
function, leads to crash while trying to get snd_soc_dpcm with
container_of() macro in kabylake_ssp_fixup().
The crash call path looks as below:
soc_pcm_hw_params()
On 5/12/20 11:08 AM, Pierre-Louis Bossart wrote:
On 5/12/20 10:59 AM, Vinod Koul wrote:
On 12-05-20, 09:36, Pierre-Louis Bossart wrote:
On 5/11/20 10:30 PM, Vinod Koul wrote:
On 11-05-20, 14:00, Pierre-Louis Bossart wrote:
+ md = >md;
+ md->dev.bus = _bus_type;
+ md->
On 5/12/20 10:59 AM, Vinod Koul wrote:
On 12-05-20, 09:36, Pierre-Louis Bossart wrote:
On 5/11/20 10:30 PM, Vinod Koul wrote:
On 11-05-20, 14:00, Pierre-Louis Bossart wrote:
+ md = >md;
+ md->dev.bus = _bus_type;
+ md->dev.type = _master_type;
+ md-&g
On 5/11/20 10:30 PM, Vinod Koul wrote:
On 11-05-20, 14:00, Pierre-Louis Bossart wrote:
+ md = >md;
+ md->dev.bus = _bus_type;
+ md->dev.type = _master_type;
+ md->dev.parent = parent;
+ md->dev.of_node = parent->of_node;
+ md-&g
+ md = >md;
+ md->dev.bus = _bus_type;
+ md->dev.type = _master_type;
+ md->dev.parent = parent;
+ md->dev.of_node = parent->of_node;
+ md->dev.fwnode = fwnode;
+ md->dev.dma_mask = parent->dma_mask;
+
+ dev_set_name(>dev, "sdw-master-%d",
Biernacki
Acked-by: Pierre-Louis Bossart
[] = {
^~~
Move the variable inside #ifdef
Reported-by: Hulk Robot
Suggested-by: Joe Perches
Signed-off-by: YueHaibing
Thanks for the patch.
Acked-by: Pierre-Louis Bossart
This single fix address two issues on machines with nau88125:
1) Audio distortion, due to lack of required clock rate on MCLK line
2) Loud audible "pops" on headphones if there is no sysclk during nau8825
playback power up sequence
Explanation for:
1) Due to Skylake HW limitation, MCLK
On 5/1/20 2:31 PM, Radoslaw Biernacki wrote:
This single fix address two issues on machines with nau88125:
1) Audio distortion, due to lack of required clock rate on MCLK line
2) Loud audible "pops" on headphones if there is no sysclk during nau8825
playback power up sequence
Explanation
rom 208e61ae18d3a4aa93ffa73db01c4e3c24a4979f Mon Sep 17 00:00:00 2001
From: Pierre-Louis Bossart
Date: Wed, 22 Apr 2020 06:21:56 -0500
Subject: [PATCH] ASoC: SOF: imx: fix depends/select IMX_DSP confusion
The two IMX targets don't use depends/select in a consistent way and
there's a potent
Thanks Arnd, do you mind sharing your config?
https://pastebin.com/HRX5xi3R
will give it a try, thanks!
We noticed last week that
there's a depend/select confusion might be simpler to fix, see
https://github.com/thesofproject/linux/pull/2047/commits
If I look at the first line I see a
On 4/28/20 4:27 PM, Arnd Bergmann wrote:
The imx8 config keeps causing issues:
WARNING: unmet direct dependencies detected for SND_SOC_SOF_IMX8M
Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && SND_SOC_SOF_TOPLEVEL [=y]
&& SND_SOC_SOF_IMX_TOPLEVEL [=y] && IMX_DSP [=n]
On 10/21/19 11:55 PM, Vinod Koul wrote:
On 21-10-19, 05:26, Pierre-Louis Bossart wrote:
On 10/20/19 11:14 PM, Vinod Koul wrote:
On 16-09-19, 14:09, Pierre-Louis Bossart wrote:
Prepare for future PM support and fix error handling by disabling
interrupts as needed.
Signed-off-by: Pierre
On 10/23/19 10:16 AM, Brent Lu wrote:
The first DMIC capture always fail (zero sequence data from PCM port)
after using DSP hotwording function (i.e. Google assistant). The DMIC
is attached to rt5514 which also require eaily mclk/sclk like rt5663.
Therefore we add a dapm route to provide ssp
Move code to helper for reuse in power management routines
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 748f832e14f6
Prepare for future PM support and fix error handling by disabling
interrupts as needed.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 18 --
drivers/soundwire/cadence_master.h | 2 +-
drivers/soundwire/intel.c | 13 +++--
3 files
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really useful when some
devices are no longer responsive and/or to check the software handling
of resynchronization.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
iate variable
disable interrupts when exit_reset fails, updated error handling
returned -EINVAL on debugfs invalid parameter
Pierre-Louis Bossart (5):
soundwire: intel/cadence: fix startup sequence
soundwire: cadence_master: add hw_reset capability in debugfs
soundwire: intel: add he
. flush command FIFOs
Better error handling will be provided after interrupt disable is
provided in follow-up patches.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 80 +-
drivers/soundwire/cadence_master.h | 1 +
drivers/soundwire/intel.c
-Louis Bossart
---
drivers/soundwire/cadence_master.c | 15 ---
drivers/soundwire/cadence_master.h | 2 +-
drivers/soundwire/intel.c | 2 +-
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
Simplify the loop with a helper. The only functionality change is that
we continue the loop even with an ACPI error.
Follow-up patches will build on this change.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/slave.c | 50 ---
1 file changed, 31
, or differences between devID registers and ACPI _ADR
fields.
This patch suggests a filter on startup to identify 'single' devices
and tag them accordingly. The uniqueID is then not used for the probe,
and the device name omits the uniqueID as well.
Signed-off-by: Pierre-Louis Bossart
---
drivers
uot; value to account for firmware/BIOS creativity.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index 688b40e65c89..28745b9ba279 100644
--- a/inc
type are detected. The loop to detect multiple identical
devices is not super efficient but with typically fewer than 4 devices
per link there's no real incentive to be smarter.
This change is only implemented for ACPI platforms, for DeviceTree
there is no change.
Pierre-Louis Bossart (3
fix cppcheck warning:
[drivers/soundwire/slave.c:145]: (warning) %x in format string (no. 1)
requires 'unsigned int *' but the argument type is 'signed int *'.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/slave.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
The previous formula is incorrect for PDI0/1, the mapping is not
linear but has a discontinuity between PDI1 and PDI2.
This change has no effect on PCM PDIs (same mapping).
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 10 --
1 file changed, 8 insertions(+), 2
On 10/20/19 11:14 PM, Vinod Koul wrote:
On 16-09-19, 14:09, Pierre-Louis Bossart wrote:
Prepare for future PM support and fix error handling by disabling
interrupts as needed.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 18 --
drivers
On 10/20/19 11:04 PM, Vinod Koul wrote:
On 16-09-19, 14:09, Pierre-Louis Bossart wrote:
Provide debugfs capability to kick link and devices into hard-reset
(as defined by MIPI). This capability is really useful when some
devices are no longer responsive and/or to check the software handling
In the DAI link "Capture PCM", the FE DAI "Capture Pin" supports 4-channel
capture but the BE DAI supports only 2-channel capture. To fix the channel
mismatch, we need to enable the runtime channel merge for this DAI link.
Hi Pierre,
This patch is for the same issue discussed in the
On 10/17/19 10:22 AM, Randy Dunlap wrote:
On 10/16/19 9:26 PM, Stephen Rothwell wrote:
Hi all,
Changes since 20191016:
on x86_64:
# CONFIG_BLOCK is not set
CC [M] drivers/soundwire/intel_init.o
In file included from ../drivers/soundwire/intel_init.c:12:0:
../include/linux/iomap.h: In
On 10/16/19 9:50 PM, Chuhong Yuan wrote:
sof_audio_probe misses a check for devm_clk_get and may cause problems.
Add a check for it to fix the bug.
Indeed this is a miss, we have this test in all machine drivers except
this one. Thanks for the patch!
Acked-by: Pierre-Louis Bossart
On 9/16/19 2:09 PM, Pierre-Louis Bossart wrote:
V2 of the original series 'soundwire: inits and PM additions for 5.4',
with PM additions removed since more tests on hardware are required.
Vinod, if you are back at your desk, those patches are almost a month
old. thanks!
Changes since
On 9/16/19 1:57 PM, Pierre-Louis Bossart wrote:
The Intel kbuild test reported issues with COMPILE_TEST or
cross-compilation when SOF is enabled, fix. This has no functional
impact.
Vinod, if you are back at your desk, those patches are almost a month
old. thanks!
Pierre-Louis Bossart
401 - 500 of 1453 matches
Mail list logo
