On 6/7/19 3:56 AM, Srinivas Kandagatla wrote:
This patch adds SDW_MAX_PORT so that other driver can use it.
Signed-off-by: Srinivas Kandagatla
---
include/linux/soundwire/sdw.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
i
On 6/6/19 9:58 AM, Srinivas Kandagatla wrote:
On 06/06/2019 15:28, Pierre-Louis Bossart wrote:
On 6/6/19 6:22 AM, Srinivas Kandagatla wrote:
multi bank switching code takes lock on condition but releases without
any check resulting in below warning.
This patch fixes this.
Question to make
On 6/6/19 6:22 AM, Srinivas Kandagatla wrote:
multi bank switching code takes lock on condition but releases without
any check resulting in below warning.
This patch fixes this.
Question to make sure we are talking about the same thing: multi-link
bank switching is a capability beyond the sco
On 6/5/19 8:45 AM, Amadeusz Sławiński wrote:
From: Amadeusz Sławiński
This resets internal index used for enumarating codecs. This will only
work on assumption that platform has one codec. Anyway if there is more,
it won't work with current machine drivers, because we can't guarantee
order in w
Signed-off-by: Pierre-Louis Bossart
---
sound/hda/ext/hdac_ext_bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/hda/ext/hdac_ext_bus.c b/sound/hda/ext/hdac_ext_bus.c
index c203af71a099..f33ba58b753c 100644
--- a/sound/hda/ext/hdac_ext_bus.c
+++ b/sound/hda/ext/hdac_ext_bus.c
@@ -17
On 6/4/19 5:49 AM, Yu-Hsuan Hsu wrote:
The supported formats are S16_LE and S24_LE now. However, by datasheet
of max98090, S24_LE is only supported when it is in the right justified
mode. We should remove 24-bit format if it is not in that mode to avoid
triggering error.
Signed-off-by: Yu-Hsuan
On 5/31/19 9:34 AM, Takashi Iwai wrote:
On Fri, 31 May 2019 16:25:26 +0200,
YueHaibing wrote:
while building without PCI:
sound/soc/sof/intel/hda.o: In function `hda_dsp_probe':
hda.c:(.text+0x79c): undefined reference to `pci_ioremap_bar'
hda.c:(.text+0x79c): relocation truncated to fit: R
;)
Signed-off-by: YueHaibing
Gah, my bad. My cross-compilation script assumed sound was enabled with
defconfig but it's not in all cases, thanks for the fix.
Acked-by: Pierre-Louis Bossart
---
sound/soc/sof/intel/hda.c | 4
1 file changed, 4 insertions(+)
diff --git a/sound/s
On 5/29/19 12:54 PM, Randy Dunlap wrote:
On 5/28/19 2:54 AM, kbuild test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: cd6c84d8f0cdc911df435bb075ba22ce3c605b07
commit: f70abd75b7c6c04d3219d0b3a0f3f15411b042fb ASoC: Intel: add sof-rt5682
On 5/28/19 4:56 PM, Stephen Rothwell wrote:
Hi all,
In commit
be1b577d0178 ("ASoC: SOF: Intel: hda: fix the hda init chip")
Fixes tag
Fixes: 8a300c8fb17 ("ASoC: SOF: Intel: Add HDA controller for Intel DSP")
Sorry about that, not sure how I managed to add an off-by-one in all
these t
(or use an existing one?). IIRC the dependency
on asm/cpu_device_id is just to find out if the device is baytrail or
cherrytrail.
Fixes: 164a263bf8d0 ("ASoC: Intel: Make boards more available for compile test")
Signed-off-by: Randy Dunlap
Cc: Mark Brown
Cc: Pierre-Louis Bossart
C
On 5/23/19 9:59 PM, Randy Dunlap wrote:
On 5/23/19 4:28 AM, Pierre-Louis Bossart wrote:
On 5/22/19 10:58 PM, Randy Dunlap wrote:
From: Randy Dunlap
skl-ssp-clk.c does not build on IA64 because the driver
uses the common clock interface, so make the driver depend
on COMMON_CLK.
Fixes
' has
incomplete type
struct clk_hw hw;
^~
Reported-by: kbuild test robot
Signed-off-by: Randy Dunlap
Cc: Mark Brown
Cc: Pierre-Louis Bossart
Cc: Liam Girdwood
Cc: Jie Yang
Cc: alsa-de...@alsa-project.org
---
sound/soc/intel/Kconfig|3 ++-
sound/soc/in
r_rt5651.c:#include
cht_bsw_rt5645.c:#include
sof_rt5682.c:#include
and
grep "include.*asm.platform_sst_audio.h" *.c
bytcht_da7213.c:#include
bytcht_es8316.c:#include
Signed-off-by: Randy Dunlap
Cc: Mark Brown
Cc: Pierre-Louis Bossart
Cc: Liam Girdwood
Cc: Jie Yang
Cc: alsa-de
represent the link type, with SoundWire assigned the value 4.
Add a filter and terminate early when a valid _ADR is provided,
otherwise keep iterating to find the next child.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 21 -
1 file changed, 20
patches.
Changes since v2:
Feedback from Vinod:
1. improve the SoundWire controller search without magic values
2. split patches as needed
Other additions
rate-limiting to avoid flooding dmesg logs
provide better Slave status on errors
more checks on links and PDIs
Pierre-Louis Bossart (15
Somehow previous header files did not include definition for
sink/source, flow and grouping.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 53 +++
1 file changed, 53 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include
Fix support for clock_stop_mode0 and 1. The existing code uses a
bitmask between enums, one of which being zero. Or-ing with zero is
not very useful in general...Fix by or-ing with a BIT dependent on the
enum value.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 4
The MIPI DisCo spec refers to dynamic frame shape, not to dynamic
shape. Clarify.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index
When commands start failing, e.g. due to a bad electrical connection
or bus conflicts, the dmesg log is flooded. This should not happen for
production devices but it's quite frequent when bringing-up a new
platform.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c
Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index 69ae680a5a21..831a370eaedd 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux
e MIPI spec
will be updated to deprecate "mipi-sdw-master-N-subproperties"
Fix to parse firmware information on existing devices. If we ever see
a system with 'master-N-subproperties' I guess we'll have to try both.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire
Rename all fields with 'freq' as 'clk_freq' to follow the MIPI
specification and avoid confusion between bus clock and audio clocks.
No functionality change.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 4 ++--
drivers/soundwi
The master_count is only defined for a Controller or a Slave in the
MIPI DisCo for SoundWire document.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index
.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index 771a53a5c033..70637a0383d2 100644
--- a/drivers/soundwire/intel_init.c
+++ b/drivers/soundwire
There is an assumption that the first two PDIs are reserved for Bulk,
so we need to make sure the number of bidir PDIs is indeed larger than
two. If the configuration provided is incorrect, this could lead to
allocating a huge amount of memory.
Signed-off-by: Pierre-Louis Bossart
---
drivers
Copy/paste of sdw_intel_res
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel.h b/drivers/soundwire/intel.h
index 71050e5f643d..d923b6262330 100644
--- a/drivers/soundwire/intel.h
+++ b
This information will be reflected in debugfs but it's easier to see
as a dmesg log.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 4ac141730b13..92be6ad
s not needed
when you need 4.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/cadence_master.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/cadence_master.c
b/drivers/soundwire/cadence_master.c
index 6f4184f5256c..a505d74ab461 100644
--- a/dr
nd DPn levels. Rename
to follow the MIPI definitions, no need to be creative here.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 2 +-
drivers/soundwire/mipi_disco.c | 6 +++---
drivers/soundwire/stream.c | 6 +++---
include/linux/soundwire/sdw.h | 13 +++-
On 5/22/19 11:25 AM, Srinivas Kandagatla wrote:
This patch fixes below warning due to unlocking without locking.
=
WARNING: bad unlock balance detected!
5.1.0-16506-gc1c383a6f0a2-dirty #1523 Tainted: GW
-
as is. I
vaguely recall providing this feedback as well in an earlier version.
Acked-by: Pierre-Louis Bossart
Signed-off-by: Srinivas Kandagatla
---
drivers/soundwire/stream.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/soundwire/stream.c b/drivers
On 5/20/19 3:37 AM, Hans de Goede wrote:
Hi all,
On 19-05-19 19:57, nariman wrote:
From: Nariman Etemadi
in function snd_byt_rt5640_mc_probe and removed buffer
yt_rt5640_codec_aif_name & byt_rt5640_cpu_dai_name
Signed-off-by: Nariman Etemadi
Series (all 4 patches) look good to me:
R
diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
index 8940054d6250..7dda0ee05cd1 100644
--- a/drivers/acpi/device_sysfs.c
+++ b/drivers/acpi/device_sysfs.c
@@ -428,8 +428,10 @@ static ssize_t acpi_device_adr_show(struct device *dev,
{
struct acpi_device *acpi_dev
On 5/10/19 5:25 AM, Yu-Hsuan Hsu wrote:
Remove 24-bit format support because it doesn't work now. We can revert
this change after it really supports.
(https://patchwork.kernel.org/patch/10783561/)
Signed-off-by: Yu-Hsuan Hsu
As discussed in the previous thread, the data sheet explicitly me
On 5/10/19 5:39 PM, Evan Green wrote:
This small series adds PCI IDs for Cometlake platforms, for a
dazzling audio experience.
This is based on linux-next's next-20190510.
Thank you Evan, looks good. For the series
Acked-by: Pierre-Louis Bossart
Changes in v3:
- Copy cnl_desc t
Yes, that would work. OTOH, I see no merit to build an extra module
for nocodec. nocodec.c can be built together with sof-core stuff.
the module has its benefits. Today nocodec includes all possible DAIs,
I wanted to add module parameters to restrict things a bit for
tests/debug. It'll be e
On 5/10/19 8:50 AM, YueHaibing wrote:
On 2019/5/10 21:36, Pierre-Louis Bossart wrote:
On 5/10/19 8:29 AM, YueHaibing wrote:
Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
sound/soc/sof/core.o: In function `snd_sof_device_probe':
core.c:(.text+0x4af): undefined referen
On 5/10/19 8:56 AM, Takashi Iwai wrote:
On Fri, 10 May 2019 15:41:10 +0200,
Takashi Iwai wrote:
On Fri, 10 May 2019 15:34:03 +0200,
Pierre-Louis Bossart wrote:
On 5/10/19 8:04 AM, Takashi Iwai wrote:
On Fri, 10 May 2019 14:56:29 +0200,
Pierre-Louis Bossart wrote:
On 5/10/19 2:12 AM
On 5/10/19 8:29 AM, YueHaibing wrote:
Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
sound/soc/sof/core.o: In function `snd_sof_device_probe':
core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup'
Change IS_ENABLED to IS_REACHABLE to fix this.
this just hides the issue inst
On 5/10/19 8:04 AM, Takashi Iwai wrote:
On Fri, 10 May 2019 14:56:29 +0200,
Pierre-Louis Bossart wrote:
On 5/10/19 2:12 AM, Takashi Iwai wrote:
On Fri, 10 May 2019 04:36:57 +0200,
YueHaibing wrote:
Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
sound/soc/sof/core.o: In function
On 5/10/19 2:12 AM, Takashi Iwai wrote:
On Fri, 10 May 2019 04:36:57 +0200,
YueHaibing wrote:
Fix gcc build error while CONFIG_SND_SOC_SOF_NOCODEC=m
sound/soc/sof/core.o: In function `snd_sof_device_probe':
core.c:(.text+0x4af): undefined reference to `sof_nocodec_setup'
Change SND_SOC_SOF_NO
On 5/8/19 11:51 AM, Evan Green wrote:
On Tue, May 7, 2019 at 3:31 PM Pierre-Louis Bossart
wrote:
On 5/7/19 4:53 PM, Evan Green wrote:
Add PCI IDs for Intel CometLake platforms, which from a software
point of view are extremely similar to Cannonlake platforms.
Humm, I have mixed feelings
On 5/8/19 11:42 AM, Evan Green wrote:
On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart
wrote:
Minor nit-picks below. The Kconfig would work but select CANNONLAKE even
if you don't want it.
+config SND_SOC_SOF_COMETLAKE_LP
+ tristate
+ select SND_SOC_SOF_CANNONLAKE
Vinod, the question was not for dp0 and dpN, it's fine to have
subdirectories there, but rather why we need separate devices for the master
and slave properties.
Slave does not have a separate device. IIRC the properties for Slave are
in /sys/bus/soundwire/device//...
I am not sure this is
On 5/8/19 4:16 AM, Greg KH wrote:
On Wed, May 08, 2019 at 01:16:06PM +0530, Vinod Koul wrote:
On 07-05-19, 17:49, Pierre-Louis Bossart wrote:
The model here is that Master device is PCI or Platform device and then
creates a bus instance which has soundwire slave devices.
So for any
+ /*
+* On some Intel platforms, multiple children of the HDAS
+* device can be found, but only one of them is the SoundWire
+* controller. The SNDW device is always exposed with
+* Name(_ADR, 0x4000) so filter accordingly
+*/
+ if (adr !=
The model here is that Master device is PCI or Platform device and then
creates a bus instance which has soundwire slave devices.
So for any attribute on Master device (which has properties as well and
representation in sysfs), device specfic struct (PCI/platfrom doesn't
help). For slave that
On 5/7/19 4:53 PM, Evan Green wrote:
Add PCI IDs for Intel CometLake platforms, which from a software
point of view are extremely similar to Cannonlake platforms.
Humm, I have mixed feelings here.
Yes the hardware is nearly identical, with the exception of one detail
that's not visible to the
Minor nit-picks below. The Kconfig would work but select CANNONLAKE even
if you don't want it.
+config SND_SOC_SOF_COMETLAKE_LP
+ tristate
+ select SND_SOC_SOF_CANNONLAKE
This should be
select SND_SOF_SOF_HDA_COMMON
+ help
+ This option is not user-selectable bu
What we are missing are the PCI IDs for CML PCH-LP (0x02C8) and CML
PCH-H (0x06C8).
Can we respin this patchset to add support for those last two instead of
just the -LP case?
Sure. So just to clarify, you want the entry for 0x02c8, and you want
an additional entry for 0x06c8 under the same
On 5/6/19 5:53 PM, Evan Green wrote:
Add support for Intel Comet Lake platforms by adding a new Kconfig for
CometLake and the appropriate PCI ID.
This is odd. I checked internally a few weeks back and the CML PCI ID was 9dc8,
same as WHL and CNL, so we did not add a PCI ID on purpose. To
On 5/7/19 7:26 AM, Vinod Koul wrote:
On 03-05-19, 19:29, Pierre-Louis Bossart wrote:
The convention is that the SoundWire controller device is a child of
the HDAudio controller. However there can be more than one child
exposed in the DSDT table, and the current namespace walk returns the
On 5/7/19 12:19 AM, Vinod Koul wrote:
On 06-05-19, 11:46, Pierre-Louis Bossart wrote:
On 5/6/19 11:22 AM, Vinod Koul wrote:
On 06-05-19, 17:19, Greg KH wrote:
On Mon, May 06, 2019 at 09:42:35AM -0500, Pierre-Louis Bossart wrote:
+
+int sdw_sysfs_slave_init(struct sdw_slave *slave
On 5/6/19 10:34 PM, M R, Sathya Prakash wrote:
-Original Message-
From: Pierre-Louis Bossart [mailto:pierre-louis.boss...@linux.intel.com]
Sent: Tuesday, May 7, 2019 7:11 AM
To: Evan Green ; Liam Girdwood
; Mark Brown
Cc: M, Naveen ; M R, Sathya Prakash ; Ben Zhang
; Rajat Jain
+int sdw_sysfs_bus_init(struct sdw_bus *bus)
+{
+ struct sdw_master_sysfs *master;
+ int err;
+
+ if (bus->sysfs) {
+ dev_err(bus->dev, "SDW sysfs is already initialized\n");
+ return -EIO;
+ }
+
+ master = kzalloc(sizeof(*master), GFP_K
On 5/3/19 7:29 PM, Pierre-Louis Bossart wrote:
The MIPI DisCo specification for SoundWire defines the
"mipi-sdw-link-N-subproperties", not the master-N properties. Fix to
parse firmware information.
Please ignore this patch for now, there is a confusion in the spec
itself that n
On 5/6/19 5:53 PM, Evan Green wrote:
Add support for Intel Comet Lake platforms by adding a new Kconfig
for CometLake and the appropriate PCI ID.
This is odd. I checked internally a few weeks back and the CML PCI ID
was 9dc8, same as WHL and CNL, so we did not add a PCI ID on purpose. To
t
[=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
SND_SOC_SOF_TOPLEVEL [=y] && (ACPI [=y] || COMPILE_TEST [=n]) && X86 [=y]
Signed-off-by: Randy Dunlap
Cc: Liam Girdwood
Cc: Mark Brown
Cc: alsa-de...@alsa-project.org
Acked-by:
On 5/6/19 11:38 AM, Vinod Koul wrote:
On 06-05-19, 09:48, Pierre-Louis Bossart wrote:
+struct dentry *sdw_bus_debugfs_get_root(struct sdw_bus_debugfs *d)
+{
+ if (d)
+ return d->fs;
+ return NULL;
+}
+EXPORT_SYMBOL(sdw_bus_debugfs_get_root);
_GPL()?
Oops, that&
Thanks for the quick feedback Greg!
+static const struct attribute_group sdw_master_node_group = {
+ .attrs = master_node_attrs,
+};
+
+static const struct attribute_group *sdw_master_node_groups[] = {
+ &sdw_master_node_group,
+ NULL
+};
Minor nit, you can use the ATTRIBUTE_
On 5/6/19 11:22 AM, Vinod Koul wrote:
On 06-05-19, 17:19, Greg KH wrote:
On Mon, May 06, 2019 at 09:42:35AM -0500, Pierre-Louis Bossart wrote:
+
+int sdw_sysfs_slave_init(struct sdw_slave *slave)
+{
+ struct sdw_slave_sysfs *sysfs;
+ unsigned int src_dpns, sink_dpns, i, j
On 5/6/19 10:40 AM, Hans de Goede wrote:
Hi,
On 05-05-19 09:51, Takashi Iwai wrote:
On Sat, 04 May 2019 17:16:52 +0200,
Nariman wrote:
From: Jordy Ubink
The snprintf calls filling byt_rt5651_cpu_dai_name /
byt_rt5651_cpu_dai_name always fill them with the same string
(ssp0-port" resp "rt5
On 5/6/19 10:43 AM, Hans de Goede wrote:
Hi Pierre-Louis,
Nariman and the author authors of these patches are a group of students
doing
some kernel work for me and this is a warm-up assignment for them to get
used
to the kernel development process.
On 06-05-19 17:21, Pierre-Louis Bossart
On 5/5/19 11:40 PM, Mark Brown wrote:
On Fri, May 03, 2019 at 09:32:53AM -0500, Pierre-Louis Bossart wrote:
As I mentioned it'll compile the bus even if there is no user for it, but
it's your call: alignment or optimization.
You can have both. Alignment is a requirement. If y
On 5/4/19 10:16 AM, Nariman wrote:
From: Jordy Ubink
The snprintf calls filling byt_rt5651_cpu_dai_name / byt_rt5651_cpu_dai_name always fill them
with the same string (ssp0-port" resp "rt5651-aif2"). So instead of keeping
these buffers around and making the cpu_dai_name / codec_dai_name poin
On 5/4/19 10:16 AM, Nariman wrote:
From: Damian van Soelen
The snprintf calls filling cht_rt5645_cpu_dai_name / cht_rt5645_codec_aif_name
always fill them with the same string ("ssp0-port" resp "rt5645-aif2") so
instead of keeping these buffers around and making the cpu_dai_name /
codec_aif_nam
static int byt_rt5640_suspend(struct snd_soc_card *card)
@@ -1268,28 +1266,12 @@ static int snd_byt_rt5640_mc_probe(struct
platform_device *pdev)
log_quirks(&pdev->dev);
if ((byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) ||
- (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) {
-
+static struct attribute_group sdw_slave_dev_attr_group = {
+ .attrs = slave_dev_attrs,
+};
+
+const struct attribute_group *sdw_slave_dev_attr_groups[] = {
+ &sdw_slave_dev_attr_group,
+ NULL
+};
ATTRIBUTE_GROUP()?
yes.
+
+int sdw_sysfs_slave_init(struct sdw_slave *
@@ -136,6 +139,8 @@ static int sdw_delete_slave(struct device *dev, void *data)
void sdw_delete_bus_master(struct sdw_bus *bus)
{
sdw_sysfs_bus_exit(bus);
+ if (bus->debugfs)
+ sdw_bus_debugfs_exit(bus->debugfs);
No need to check, just call it.
That was on my
+static void intel_debugfs_init(struct sdw_intel *sdw)
+{
+ struct dentry *root = sdw_bus_debugfs_get_root(sdw->cdns.bus.debugfs);
+
+ if (!root)
+ return;
+
+ sdw->fs = debugfs_create_dir("intel-sdw", root);
+ if (IS_ERR_OR_NULL(sdw->fs)) {
Again, you do
+void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root)
+{
+ debugfs_create_file("cdns-registers", 0400, root, cdns, &cdns_reg_fops);
+}
+EXPORT_SYMBOL(sdw_cdns_debugfs_init);
Don't wrap debugfs calls with export symbol without using
EXPORT_SYMBOL_GPL() or you will get g
Add debugfs file to dump the Cadence master registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
Kale, Shreyas Nc and Hardik Shah
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile | 2 +-
drivers/soundwire/bus.c | 2 +
drivers/soundwire/bus.h | 2 +
drivers/soundwire/bus_type.c| 5 +
drivers/soundwire/slave.c | 1
ump the Master and Slave registers, as
well as the Intel-specific parts. One of the main changes from the
previous code was to harden the code with scnprintf
Feedback welcome.
~Pierre
Pierre-Louis Bossart (7):
soundwire: Add sysfs support for master(s)
soundwire: add Slave sysfs support
ABI:
The description is directly derived from the MIPI DisCo specification.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
.../ABI/testing/sysfs-bus-soundwire-master| 21
The description is directly derived from the MIPI DisCo specification.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah
Signed-off-by: Pierre-Louis Bossart
---
.../ABI/testing/sysfs-bus-soundwire-slave | 85
Add debugfs file to dump the Intel SoundWire registers
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
For each master N, add a device sdw-master:N and add the
master properties as attributes.
Credits: this patch is based on an earlier internal contribution by
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 3
Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. The main change
is the use of scnprintf to avoid known issues with snprintf.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/Makefile| 3 +-
drivers/soundwire/bus.c | 5 +
drivers/soundwire/bus.h | 28 +
drivers
iterating to find the next child.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index d3d6b54c5791..f85db67d05f0 100644
avoid email bounces and avoid spamming them forever with SoundWire
patches.
Pierre-Louis Bossart (8):
soundwire: intel: filter SoundWire controller device search
soundwire: mipi_disco: fix master/link error
soundwire: mipi_disco: expose sdw_slave_read_dpn as symbol
soundwire: mipi_disco: e
Somehow previous header files did not include definition for
sink/source, flow and grouping.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 53 +++
1 file changed, 53 insertions(+)
diff --git a/include/linux/soundwire/sdw.h b/include
sdw_slave_read_dpn was so far a static function, which prevented
codec drivers from using it. Expose as non-static function and add symbol
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 7 ---
include/linux/soundwire/sdw.h | 3 +++
2 files changed, 7 insertions
The MIPI DisCo specification for SoundWire defines the
"mipi-sdw-link-N-subproperties", not the master-N properties. Fix to
parse firmware information.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
nd DPn levels. Rename
to follow the MIPI definitions, no need to be creative here.
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c| 2 +-
drivers/soundwire/mipi_disco.c | 6 +++---
drivers/soundwire/stream.c | 6 +++---
include/linux/soundwire/sdw.h | 13 +++-
1. The existing code uses a
bitmask between enums, one of which being zero. Or'ing with zero is
not very useful in general...Fix by or-ing with a BIT dependent on the
enum value.
Fix additional comments to align with MIPI spec
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c
sdw_slave_read_dp0 was so far a static function, which prevented codec
drivers from using it. Expose as non-static function and add symbol
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 7 ---
include/linux/soundwire/sdw.h | 3 +++
2 files changed, 7 insertions
Hardik Shah.
Signed-off-by: Pierre-Louis Bossart
---
include/linux/soundwire/sdw.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
index bd05a85d345c..80584e9d5970 100644
--- a/include/linux/soundwire/sdw.h
+++ b/include/linux
On 5/2/19 11:39 PM, Mark Brown wrote:
On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote:
config REGMAP_SOUNDWIRE
tristate
- depends on SOUNDWIRE_BUS
+ select SOUNDWIRE_BUS
This now makes _SOUNDWIRE different to all the other bus types; if this
is a
On 5/2/19 1:32 AM, Greg KH wrote:
On Thu, May 02, 2019 at 11:07:46AM +0530, Vinod Koul wrote:
On 01-05-19, 10:57, Pierre-Louis Bossart wrote:
For some reason the newlines are not used everywhere. Fix as needed.
Reported-by: Joe Perches
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre
Use Linux style. In some cases parenthesis alignment is modified to
keep the code readable.
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/mipi_disco.c | 112 ++---
1 file changed, 62 insertions(+), 50 deletions(-)
diff --git a
spelling mistakes
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 74e04caa811b..efdcefc62e1a 100644
--- a/drivers/soundwire
use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.h| 12 ++--
drivers/soundwire/cadence_master.h | 18 +-
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/soundwire/bus.h b/drivers
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus_type.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/bus_type.c b/drivers/soundwire/bus_type.c
index 283b2832728e..2655602f0cfb 100644
--- a
no need for an explicit test against false
reported by Coccinelle
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 423dc6d17999
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/stream.c | 161 +++--
1 file changed, 84 insertions(+), 77 deletions(-)
diff --git a/drivers/soundwire/stream.c b/drivers/soundwire/stream.c
index 63b162feecfc
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel_init.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index e0f2903101c7..9ad6045720c4
Extra parentheses required here
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/intel.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
index 56d6c1dda0ff
Use Linux style
Reviewed-by: Takashi Iwai
Signed-off-by: Pierre-Louis Bossart
---
drivers/soundwire/slave.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c
index ac103bd0c176..f39a5815e25d 100644
--- a/drivers
801 - 900 of 1129 matches
Mail list logo
