The SPI clocks were being turned on every suspend/resume cycle.
This was increamenting the prepare/enable count after every resume.
Fix the same.
Signed-off-by: Pramod Gurav
---
Tested on db410c
drivers/spi/spi-qup.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Reviewed-by: Ritesh Harjani
Reviewed-by: Georgi Djakov
Tested-by: Ritesh Harjani
Signed-off-by: Pramod Gurav
---
Tested on DB410C
Hi Ritesh,
On 20 October 2016 at 20:20, Ritesh Harjani wrote:
> Hi Pramod,
>
> Thanks for this patch. Few minor comments.
>
> I have tested your patch on db410c and 8996 based internal platform and it
> works fine.
Thanks for the review and testing.
>
>
>
> On 10
Thanks Georgi for the review.
On 20 October 2016 at 18:38, Georgi Djakov wrote:
> Hi Pramod,
>
> Thanks for the patch!
>
> On 10/18/2016 01:16 PM, Pramod Gurav wrote:
>>
>> Provides runtime PM callbacks to enable and disable clock resources
>> when idle. Also
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Signed-off-by: Pramod Gurav
---
Tested on DB410C.
Changes in v4:
- Remove calls to sdhci_runtime_resume_host/sdhci_runtime_suspend_host
Hi Ritesh,
Thanks for the inputs.
On 22 September 2016 at 20:02, Ritesh Harjani wrote:
> Hi Pramod,
>> Thanks Ulf for the comments. Will check this and see if there is
>> something of this sort we have to do to achieve auto tuning.
>> Adding Ritesh who has been posting some SDHCI MSM patches
On 15 September 2016 at 15:49, Ulf Hansson wrote:
> On 15 September 2016 at 09:59, Pramod Gurav wrote:
>> On 9 September 2016 at 15:48, Georgi Djakov wrote:
>>> On 09/08/2016 11:02 AM, Adrian Hunter wrote:
>>>>
>>>> On 01/09/16 17:23, Pramod Gu
On 9 September 2016 at 15:48, Georgi Djakov wrote:
> On 09/08/2016 11:02 AM, Adrian Hunter wrote:
>>
>> On 01/09/16 17:23, Pramod Gurav wrote:
>>>
>>> Provides runtime PM callbacks to enable and disable clock resources
>>> when idle. Also support syst
On 9 September 2016 at 15:30, Tummala, Sahitya wrote:
> Hi Pramod,
>> + ret = clk_prepare_enable(msm_host->clk);
>> + if (ret) {
>> + dev_err(dev, "clk_enable failed: %d\n", ret);
>
> A minor comment - Both error prints related to clock enable are same. Better
> to print
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Signed-off-by: Pramod Gurav
---
Changes in v1:
- Added CONFIG_PM around runtime pm function.
- Replaced msm suspend/resume with generic
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Signed-off-by: Pramod Gurav
---
Changes in v3:
- Added CONFIG_PM around runtime pm function.
- Replaced msm suspend/resume with generic
On 1 September 2016 at 19:38, Ulf Hansson wrote:
> [...]
>
>>> +
>>> +static const struct dev_pm_ops sdhci_msm_pm_ops = {
>>> + SET_LATE_SYSTEM_SLEEP_PM_OPS(sdhci_msm_suspend, sdhci_msm_resume)
>
> One more thing. Why do you need the late versions of the system PM callbacks?
>
> I think it's
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Signed-off-by: Pramod Gurav
---
Changes in v2:
- Moved pm_rutime enabling before adding host
- Handled pm_rutime in remove
- Changed
Thanks Ulf for the review.
On 29 August 2016 at 19:50, Ulf Hansson wrote:
> On 16 June 2016 at 14:35, Pramod Gurav wrote:
>> + platform_set_drvdata(pdev, msm_host);
>> +
>> + pm_runtime_set_active(&pdev->dev);
>> + pm_runtime_enable(&pd
Hi Stephen,
Thanks for having a look.
On 26 August 2016 at 04:20, Stephen Boyd wrote:
> On 06/17, Pramod Gurav wrote:
>> @@ -1220,12 +1293,26 @@ static void msm_power(struct uart_port *port,
>> unsigned int state,
>>
>> switc
Hi Ulf,
On 16 June 2016 at 18:05, Pramod Gurav wrote:
> Provides runtime PM callbacks to enable and disable clock resources
> when idle. Also support system PM callbacks to be called during system
> suspend and resume.
>
> Signed-off-by: Pramod Gurav
Any comment
Hi,
On 17 June 2016 at 15:46, Pramod Gurav wrote:
> Add runtime pm and suspend/resume callback support to serial msm
> driver so that clock resources are managed runtime to save power.
>
Any comments on this patch?
> Signed-off-by: Pramod Gurav
> ---
> drivers/tty/serial/
On 25 August 2016 at 10:05, Andy Gross wrote:
> On 17 June 2016 at 05:16, Pramod Gurav wrote:
>
>> + if (msm_port->is_uartdm) {
>> + ret = clk_enable(msm_port->pclk);
>
> Ditto here.
Thanks Andy, will include these two changes in v2.
>
>> + if (ret)
Adds pm_runtime support for BAM DMA so that clock is enabled only
when there is a transaction going on to help save power.
Signed-off-by: Pramod Gurav
---
Changes in v3:
- pm_runtime_get_sync returns < 0 on error hence chech for return < 0
- Move pm_runtime_get_sync/put in bam_start_dma
-
Add runtime pm and suspend/resume callback support to serial msm
driver so that clock resources are managed runtime to save power.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.c | 183
1 file changed, 168 insertions(+), 15 deletions
Provides runtime PM callbacks to enable and disable clock resources
when idle. Also support system PM callbacks to be called during system
suspend and resume.
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/sdhci-msm.c | 57
1 file changed, 57
uptions with this patch. This is what I used
to see on my DB410C with debain FS:
http://paste.ubuntu.com/17319106/
Tested-by: Pramod Gurav
Regards,
Pramod
Hi Peter,
On 8 June 2016 at 22:17, Peter Hurley wrote:
> Hi Pramod,
>
> On 05/06/2016 02:46 AM, Pramod Gurav wrote:
>> uart_change_pm is used to turn on the UART controller resources and
>> change UART's PM status. On failure to allocate pages the controller
>>
On 6 May 2016 at 15:16, Pramod Gurav wrote:
> uart_change_pm is used to turn on the UART controller resources and
> change UART's PM status. On failure to allocate pages the controller
> be left in ON state. This will change the state to OFF on failure.
>
> Signed-
On 19 May 2016 at 15:42, Srinivas Kandagatla
wrote:
> Fixes 4bb3cad7125b ("usb: host: ehci-msm: Register usb shutdown function")
> Signed-off-by: Srinivas Kandagatla
Was seeing this crash while doing a reboot on db410c which is fixed
with this patch:
Tested-by: Pramod Gurav
sk.ti:
80003928c000
[ 22.556870] PC is at ehci_suspend+0x34/0xe4
[ 22.564240] LR is at ehci_msm_pm_suspend+0x2c/0x34
[ 22.568232] pc : [] lr : []
pstate: a0000145
Tested-by: Pramod Gurav
> ---
> drivers/usb/host/ehci-msm.c | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
Regards,
Pramod
On 11 May 2016 at 14:30, Pramod Gurav wrote:
> msm_serial driver provides a .pm callback to the serial core to enable
> and disable clock resource in suspend/resume path. This function is
> also called before msm_startup. msm_startup also enables the clocks which
> is not needed. Henc
On 12 May 2016 at 05:48, Stephen Boyd wrote:
> On 05/11, Pramod Gurav wrote:
>> msm_serial driver provides a .pm callback to the serial core to enable
>> and disable clock resource in suspend/resume path. This function is
>> also called before msm_startup. msm_startup al
msm_shutdown. Same is done in console setup to get rid of duplicate
clock operation.
Tested on DB410C console.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers
uart_change_pm is used to turn on the UART controller resources and
change UART's PM status. On failure to allocate pages the controller
be left in ON state. This will change the state to OFF on failure.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/serial_core.c | 5 +++--
1 file ch
Recently all qcom dma drivers were moved a separate directory. Update
the files to include the same
Signed-off-by: Pramod Gurav
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d826f1b..2327f92 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Adds pm_runtime support for BAM DMA so that clock
is enabled only when there is a transaction going on to help
save power.
Signed-off-by: Pramod Gurav
---
Changes in v2:
- Handled return values of pm_runtime_get_sync to return error
- Rework remove function
drivers/dma/qcom/bam_dma.c | 98
Hi Manish,
Thanks for review.
On 3 May 2016 at 15:21, Manish Badarkhe wrote:
> Hi Pramod
>
>> @@ -715,10 +724,13 @@ static int bam_resume(struct dma_chan *chan)
>> struct bam_device *bdev = bchan->bdev;
>> unsigned long flag;
>>
>> + pm_runtime_get_sync(bdev->dev);
>>
Adds pm_runtime support for BAM DMA so that clock
is enabled only when there is a transaction going on to help
save power.
Signed-off-by: Pramod Gurav
---
Changes since v1:
- Removed unnecessary extra line additions and remavals
drivers/dma/qcom/bam_dma.c | 86
Recently all qcom dma drivers were moved a separate directory. Update
the files to include the same
Signed-off-by: Pramod Gurav
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d826f1b..2327f92 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hi Kedar,
Thanks for having a look and comments.
On 2 May 2016 at 17:58, Appana Durga Kedareswara Rao
wrote:
>
> Hi,
>
> > -Original Message-
> > From: dmaengine-ow...@vger.kernel.org [mailto:dmaengine-
> > ow...@vger.kernel.org] On Behalf Of Pramod Gurav
>
Recently all qcom dma drivers were moved a separate directory. Update
the files to include the same
Signed-off-by: Pramod Gurav
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d826f1b..2327f92 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Adds pm_runtime support for BAM DMA so that clock
is enabled only when there is a transaction going on to help
save power.
Signed-off-by: Pramod Gurav
---
drivers/dma/qcom/bam_dma.c | 88 +-
1 file changed, 87 insertions(+), 1 deletion(-)
diff --git
Clocks must ne disabled in pm_runtime to achieve some power saving.
Enable the clocks when the device is runtime resumed during a transfer.
Signed-off-by: Pramod Gurav
---
drivers/spi/spi-qup.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/spi/spi-qup.c b/drivers
Release memory allocated for spi master by calling spi_master_put in
.remove function.
Signed-off-by: Pramod Gurav
---
drivers/spi/spi-qup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index e42ff61..c338ef1 100644
--- a/drivers/spi/spi
for all platforms.
Signed-off-by: Pramod Gurav
---
Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 3 +++
drivers/dma/qcom/bam_dma.c | 18 +++---
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/Documentation/devicetree/bindings/dma
Clear the BAM IRQ bit only if there is a BAM interrupt.
Signed-off-by: Pramod Gurav
---
drivers/dma/qcom/bam_dma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index d5e0a9c..0880345 100644
--- a/drivers/dma/qcom
on these targets which uses BAM as DMA controller.
Pramod Gurav (2):
dmaengine: qcom_bam_dma: Clear IRQ only if its set
dmaengine: qcom_bam_dma: Bypass BAM init if not managed locally
.../devicetree/bindings/dma/qcom_bam_dma.txt| 3 +++
drivers/dma/qcom/bam_dma.c
to be put in to 'PAUSE' state and data has to written to fifo. Then
> should be put in to 'RUN' state separately.
>
> Signed-off-by: Sricharan R
Tested-by: Pramod Gurav
Regards,
Pramod
> ---
> drivers/i2c/busses/i2c-qup.c | 46
> +++
Thanks Stephen for review.
On Fri, April 10, 2015 11:33 pm, Stephen Boyd wrote:
> On 04/10/15 05:19, Pramod Gurav wrote:
>> @@ -683,8 +679,7 @@ static void msm_power(struct uart_port *port,
>> unsigned int state,
>>
>> switch (state) {
>> case 0:
&
On Thu, April 9, 2015 5:21 am, Stephen Boyd wrote:
> On 04/08/15 06:28, Pramod Gurav wrote:
>> Disable the pclk when tty port is closed by user space.
>>
>> Signed-off-by: Pramod Gurav
>> ---
>> drivers/tty/serial/msm_serial.c | 1 +
>> 1 file changed, 1
Disable the pclk when tty port is closed by user space.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 4c1e9ea..f38565c 100644
--- a/drivers/tty/serial
so do
it only for UART core.
Signed-off-by: Pramod Gurav
---
Changes since last version:
- Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing.
- Added a new macro for IPR register as it is also different in UART_DM
- Changed subject line
- Removed change log from
Disable the pclk when tty port is closed by user space.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 4c1e9ea..f38565c 100644
--- a/drivers/tty/serial
so do
it only for UART core.
Signed-off-by: Pramod Gurav
--
Changes since last version:
- Added new macro fo UART_DM_MR1_AUTO_RFR_LEVEL1 instead of modifying existing.
- Added a new macro for IPR register as it is also different in UART_DM
- Changed subject line
---
drivers/tty/serial
According to documents The RFR_LEVEL1 in UART_DM_MR1 can be
programmed in bits 31:8 but the masks only bits 17:8.
Correct the same.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/msm_serial.h
Calls tasklet_kill() in error path of the probe function were missing.
Add the same in error path.
Signed-off-by: Pramod Gurav
---
Resending it with linux-arm-msm in cc.
drivers/dma/qcom_bam_dma.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers
Calls tasklet_kill() in error path of the probe function were missing.
Add the same in error path.
Signed-off-by: Pramod Gurav
---
Resending it with linux-arm-msm in cc.
drivers/dma/qcom_bam_dma.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers
Calls tasklet_kill() in error path of the probe function were missing.
Add the same in error path.
Signed-off-by: Pramod Gurav
---
drivers/dma/qcom_bam_dma.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma
Hi Andy,
A minor doubt.
On Thursday 08 January 2015 08:56 AM, Andy Gross wrote:
> Signed-off-by: Andy Gross
> ---
> drivers/dma/Kconfig| 10 +
> drivers/dma/Makefile |1 +
> drivers/dma/qcom_adm.c | 899
>
> +
> + return ret;
>
This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?
Acked-by: Michael Buesch
Signed-off-by: Pramod Gurav
---
drivers/ssb/main.c | 19 ---
1 file changed, 19 deletions(-)
di
This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?
Acked-by: Michael Buesch
Signed-off-by: Pramod Gurav
---
drivers/ssb/main.c | 19 ---
1 file changed, 19 deletions(-)
di
DMA configuration has been removed from function mmci_dma_setup but the
local mask variable was not removed. This remains unused hence remove
it from the function and operations on it
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/mmci.c |5 -
1 file changed, 5 deletions(-)
diff
unregister_console() will be called from uart_remove_one_port() while
removing the platform driver. So not necessary to call it in driver
exit path.
Signed-off-by: Pramod Gurav
---
drivers/tty/serial/msm_serial.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/tty/serial
msm_set_termios(). msm_reset() is called when we change the baud rate.
Hence doing away with both of these calls.
- CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate.
So do away with this here.
Signed-off-by: Pramod Gurav
---
Changes since v2:
- initialize
Hi Stephen,
On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote:
> On 01/08/2015 01:15 AM, Pramod Gurav wrote:
>> drivers/tty/serial/msm_serial.c | 15 ---
>> 1 file changed, 15 deletions(-)
>>
>> diff --git a/drivers/tty/serial/msm_serial.c
>>
Hi Stephen,
On Friday 09 January 2015 03:16 AM, Stephen Boyd wrote:
> On 01/08/2015 01:15 AM, Pramod Gurav wrote:
>> drivers/tty/serial/msm_serial.c | 15 ---
>> 1 file changed, 15 deletions(-)
>>
>> diff --git a/drivers/tty/serial/msm_serial.c
>>
baud rate.
Hence doing away with both of these calls.
- CR_CMD_PROTECTION_EN and CR_TX_ENABLE settings are done in msm_set_baud_rate.
So do away with this here.
Signed-off-by: Pramod Gurav
---
Changes since v1:
- v1 was just removing call to msm_set_baud_rate(). Other code is removed on
Hi Ulf,
Any comment on this change?
Thanks
Pramod
On Tuesday 16 December 2014 07:21 PM, Pramod Gurav wrote:
> DMA configuration has been removed from function mmci_dma_setup but the
> local mask variable was not removed. This remains unused hence remove
> it from the function and oper
The function 'msm_set_baud_rate' is called twice while setting up
msm console. Once in msm_console_setup and next when uart_set_options
calls port->ops->set_termios ie. msm_set_termios().
Remove the duplicate call in msm_console_setup. Tested on IFC6410
console.
Signed-off-
DMA configuration has been removed from function mmci_dma_setup but the
local mask variable was not removed. This remains unused hence remove
it from the function and operations on it
Signed-off-by: Pramod Gurav
---
drivers/mmc/host/mmci.c |5 -
1 file changed, 5 deletions(-)
diff
Thanks. :-)
On Mon, Dec 8, 2014 at 7:08 PM, Tobias Klauser wrote:
> On 2014-12-08 at 14:36:24 +0100, Pramod Gurav
> wrote:
>> Folder soc/ was sourced twice somehow. Remove duplicate entry.
>
> I already sent a patch for this a while ago [1], though it wasn't
>
Folder soc/ was sourced twice somehow. Remove duplicate entry.
Signed-off-by: Pramod Gurav
---
drivers/Kconfig |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/Kconfig b/drivers/Kconfig
index 1a693d3..5add358 100644
--- a/drivers/Kconfig
+++ b/drivers/Kconfig
@@ -132,8 +132,6
On Tuesday 25 November 2014 04:27 PM, Lucas Stach wrote:
> Am Dienstag, den 25.11.2014, 16:23 +0530 schrieb Pramod Gurav:
>> Currently the regulator core disables the regulators which are unused
>> or whose reference count is zero or if they are configured always_on.
>> This c
Hi Mark,
On Tuesday 25 November 2014 04:35 PM, Mark Brown wrote:
> On Tue, Nov 25, 2014 at 04:23:23PM +0530, Pramod Gurav wrote:
>> Currently the regulator core disables the regulators which are unused
>> or whose reference count is zero or if they are configured always_on.
>
Currently the regulator core disables the regulators which are unused
or whose reference count is zero or if they are configured always_on.
This change adds a check in this logic to see if a regulator is
configured as boot_on and does not disable it if found true.
Signed-off-by: Pramod Gurav
Thanks Ulf,
On Thu, Oct 30, 2014 at 4:38 PM, Ulf Hansson wrote:
> On 30 October 2014 08:46, Pramod Gurav wrote:
>> The sequence of resource release in probe failure path in this
>> driver was wrong and needed fixes to cleanly unload the driver.
>> This changes does the
Error check around return value of devm_ioremap is missing. Add the same
to avoid NULL pointer dereference.
Cc: Linus Walleij
Cc: Samuel Ortiz
Cc: Lee Jones
Signed-off-by: Pramod Gurav
---
drivers/mfd/db8500-prcmu.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/mfd
-...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1:
- Dropped IS_ERR check on devm_ioremap() return.
- Fixed sequence on mmc_remove_host in fail as well as in remove function
drivers/mmc/host/davinci_mmc.c | 91 +++-
1 file changed, 33
Hi Dmitry,
Is this change okey?
On Wed, Oct 8, 2014 at 4:20 PM, Pramod Gurav
wrote:
> This change switches to using devm_* APIs to allocate resources.
> This helps to simplify failure path in probe function as well as
> remove function.
>
> Cc: Dmitry Torokhov
> Cc: linux-in.
Hi Ulf,
Is this good to go?
On Mon, Sep 29, 2014 at 6:55 PM, Pramod Gurav
wrote:
> This fixes below sparse warning:
> drivers/mmc/host/sdhci-pxav3.c:227:10: warning: Initializer entry defined
> twice
> drivers/mmc/host/sdhci-pxav3.c:232:10: also defined here
>
> by
Michael had suggested to do away with this function if not being used.
Good to go?
Michale can you provide acked-by?
On Wed, Oct 1, 2014 at 10:58 PM, Pramod Gurav
wrote:
> This change fixes below sparse error:
> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
&g
On Tue, Oct 21, 2014 at 2:22 PM, Linus Walleij wrote:
> On Wed, Oct 1, 2014 at 12:46 PM, Pramod Gurav
> wrote:
>
>> This change switches to devm_request_region to request region
>> and hence simplifies the module unload and does away with
>> release_region in remov
This changes muxes in gpio26 pin to function as gpio and adds support
for sd card detect for apq8064 based IFC6410 board.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Cc: Russell King
Cc: Srinivas Kandagatla
Signed-off-by: Pramod Gurav
---
Changes
+linux-arm-msm
On Monday 20 October 2014 05:09 PM, Pramod Gurav wrote:
> This changes muxes in gpio26 pin to function as gpio and adds support
> for sd card detect for apq8064 based IFC6410 board.
>
> Cc: Rob Herring
> Cc: Pawel Moll
> Cc: Mark Rutland
> Cc: Ian Campb
This changes muxes in gpio26 pin to function as gpio and adds support
for sd card detect for apq8064 based IFC6410 board.
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Cc: Russell King
Cc: Srinivas Kandagatla
Signed-off-by: Pramod Gurav
---
arch/arm
This change switches to managed resource APIs to allocated resources
such as irq, clock. Hence does away with release statements of the
same resorces in error lables and remove function.
Cc: Eduardo Valentin
Cc: Zhang Rui
Cc: linux...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes
This change switches to managed resource APIs to allocated resources
such as irq, clock. Hence does away with release statements of the
same resorces in error lables and remove function.
Cc: Eduardo Valentin
Cc: Zhang Rui
Cc: linux...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes
On Thu, Oct 9, 2014 at 2:50 AM, Vladimir Zapolskiy wrote:
> On 07.10.2014 10:11, Pramod Gurav wrote:
>>
>> This change switches to managed resource APIs to allocated resources
>> such as irq, clock. Hence does away with release statements of the
>> same resorces
This change switches to using devm_* APIs to allocate resources.
This helps to simplify failure path in probe function as well as
remove function.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard/nomadik-ske-keypad.c | 63
This change switches to using devm_* APIs to allocate resources.
This helps to simplify failure path in probe function and module
unloading and does away with remove function.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard
On Wed, Oct 8, 2014 at 3:48 PM, Pramod Gurav wrote:
> Hi Dmitry,
>
> On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov
>
..
> Thanks. I saw the change in your tree. Shouldn't
> cancel_delayed_work_sync(&kpad->work) be called under label
> err_free_mem
Hi Dmitry,
On Tue, Oct 7, 2014 at 10:08 PM, Dmitry Torokhov
wrote:
> On Tue, Oct 07, 2014 at 01:00:49PM +0530, Pramod Gurav wrote:
>> This change introduces a label to call cancel_delayed_work_sync in
>> failure path.
>>
>> Cc: Michael Hennerich
>> Cc:
This change switches to using devm_* managed resources APIs to
request the resources in probe to simplify probe error path and
module unloading and does away with remove function.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard
This change switches to using devm_* managed resources APIs to
request the resources in probe to simplify probe error path and
module unloading.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard/lpc32xx-keys.c | 86
This change switch to managed resources to simplifies error handling
and module unloading and does away with platform_driver remove function.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard/opencores-kbd.c | 54
This change switches to using devm_* APIs to allocate resources.
This helps to simplify failure path in probe function as well as
remove function.
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard/lm8323.c | 39
This change introduces a label to call cancel_delayed_work_sync in
failure path.
Cc: Michael Hennerich
Cc: Dmitry Torokhov
Cc: linux-in...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/input/keyboard/adp5588-keys.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
This change switches to managed resource APIs to allocated resources
such as irq, clock. Hence does away with release statements of the
same resorces in error lables and remove function.
Cc: Eduardo Valentin
Cc: Zhang Rui
Cc: linux...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Change
This change switches to devm_request_region to request region
and hence simplifies the module unload and does away with
release_region in remove function.
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
Signed-off-by: Pramod Gurav
Reviewed-by: Alexandre Courbot
Call irq_domain_remove when gpiochip_add fails to release irq_domain
resources.
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/gpio/gpio-grgpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-grgpio.c b
This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?
Cc: Michael Buesch
Cc: net...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
Changes since v1:
Removed the function as it is not called anywh
On Wednesday 01 October 2014 05:08 PM, Mark Brown wrote:
> On Wed, Oct 01, 2014 at 11:17:46AM +0530, Pramod Gurav wrote:
>> Get rid of using return value from gpiochip_remove() as it returns
>> void with a new change in kernel.
>
> Applied, I'm assuming that the
This change switches to devm_request_region to request region
and hence simplifies the module unload and does away with
release_region in remove function.
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/gpio/gpio-cs5535.c | 11
This change unmaps ioport when gpiochip_add fails
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
Signed-off-by: Pramod Gurav
---
drivers/gpio/gpio-amd8111.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c
1 - 100 of 264 matches
Mail list logo
