Re: [PATCH v4 0/4] percpu: partial chunk depopulation

2021-04-20 Thread Pratik Sampat
Hello Dennis, On 20/04/21 8:09 pm, Dennis Zhou wrote: On Tue, Apr 20, 2021 at 04:37:02PM +0530, Pratik Sampat wrote: On 20/04/21 4:27 am, Dennis Zhou wrote: On Mon, Apr 19, 2021 at 10:50:43PM +, Dennis Zhou wrote: Hello, This series is a continuation of Roman's series in [1]. It aims

Re: [PATCH v4 0/4] percpu: partial chunk depopulation

2021-04-20 Thread Pratik Sampat
On 20/04/21 4:27 am, Dennis Zhou wrote: On Mon, Apr 19, 2021 at 10:50:43PM +, Dennis Zhou wrote: Hello, This series is a continuation of Roman's series in [1]. It aims to solve chunks holding onto free pages by adding a reclaim process to the percpu balance work item. The main

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-17 Thread Pratik Sampat
On 17/04/21 3:17 am, Dennis Zhou wrote: Hello, On Sat, Apr 17, 2021 at 01:14:03AM +0530, Pratik Sampat wrote: On 17/04/21 12:39 am, Roman Gushchin wrote: On Sat, Apr 17, 2021 at 12:11:37AM +0530, Pratik Sampat wrote: On 17/04/21 12:04 am, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 11

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-17 Thread Pratik Sampat
On 17/04/21 1:33 am, Roman Gushchin wrote: On Sat, Apr 17, 2021 at 01:14:03AM +0530, Pratik Sampat wrote: On 17/04/21 12:39 am, Roman Gushchin wrote: On Sat, Apr 17, 2021 at 12:11:37AM +0530, Pratik Sampat wrote: On 17/04/21 12:04 am, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 11:57

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-16 Thread Pratik Sampat
On 17/04/21 12:39 am, Roman Gushchin wrote: On Sat, Apr 17, 2021 at 12:11:37AM +0530, Pratik Sampat wrote: On 17/04/21 12:04 am, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 11:57:03PM +0530, Pratik Sampat wrote: On 16/04/21 10:43 pm, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 08:58

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-16 Thread Pratik Sampat
On 17/04/21 12:04 am, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 11:57:03PM +0530, Pratik Sampat wrote: On 16/04/21 10:43 pm, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 08:58:33PM +0530, Pratik Sampat wrote: Hello Dennis, I apologize for the clutter of logs before, I'm pasting

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-16 Thread Pratik Sampat
On 16/04/21 10:43 pm, Roman Gushchin wrote: On Fri, Apr 16, 2021 at 08:58:33PM +0530, Pratik Sampat wrote: Hello Dennis, I apologize for the clutter of logs before, I'm pasting the logs of before and after the percpu test in the case of the patchset being applied on 5.12-rc6 and the vanilla

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-16 Thread Pratik Sampat
, Pratik Sampat wrote: Hello Roman, I've tried the v3 patch series on a POWER9 and an x86 KVM setup. My results of the percpu_test are as follows: Intel KVM 4CPU:4G Vanilla 5.12-rc6 # ./percpu_test.sh Percpu: 1952 kB Percpu:   219648 kB Percpu:   219648 kB 5.12-rc6

Re: [PATCH v3 0/6] percpu: partial chunk depopulation

2021-04-16 Thread Pratik Sampat
Hello Roman, I've tried the v3 patch series on a POWER9 and an x86 KVM setup. My results of the percpu_test are as follows: Intel KVM 4CPU:4G Vanilla 5.12-rc6 # ./percpu_test.sh Percpu: 1952 kB Percpu:   219648 kB Percpu:   219648 kB 5.12-rc6 + with patchset applied

Re: [RFC v3 0/2] CPU-Idle latency selftest framework

2021-04-09 Thread Pratik Sampat
Hello Doug, On 09/04/21 10:53 am, Doug Smythies wrote: Hi Pratik, I tried V3 on a Intel i5-10600K processor with 6 cores and 12 CPUs. The core to cpu mappings are: core 0 has cpus 0 and 6 core 1 has cpus 1 and 7 core 2 has cpus 2 and 8 core 3 has cpus 3 and 9 core 4 has cpus 4 and 10 core 5

Re: [RFC v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-04-04 Thread Pratik Sampat
Hello Doug, Thanks for your review. On 02/04/21 4:57 am, Doug Smythies wrote: Hi Pratik, On Thu, Apr 1, 2021 at 4:45 AM Pratik Rajesh Sampat wrote: ... To run this test specifically: $ make -C tools/testing/selftests TARGETS="cpuidle" run_tests I have not become any smarter than I was

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-22 Thread Pratik Sampat
Hi Doug, On 20/03/21 8:34 pm, Doug Smythies wrote: On Wed, Mar 17, 2021 at 11:44 PM Pratik Sampat wrote: Hi Doug, Thanks for trying these patches out. On 18/03/21 2:30 am, Doug Smythies wrote: Hi Pratik, It just so happens that I have been trying Artem's version this last week, so I tried

Re: [RFC 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2021-03-18 Thread Pratik Sampat
Hi Doug, Thanks for trying these patches out. On 18/03/21 2:30 am, Doug Smythies wrote: Hi Pratik, It just so happens that I have been trying Artem's version this last week, so I tried yours. On Mon, Mar 15, 2021 at 4:49 AM Pratik Rajesh Sampat wrote: ... To run this test specifically: $

Re: [RFC v4 1/1] selftests/cpuidle: Add support for cpuidle latency measurement

2020-09-14 Thread Pratik Sampat
On 03/09/20 8:20 pm, Artem Bityutskiy wrote: On Thu, 2020-09-03 at 17:30 +0530, Pratik Sampat wrote: I certainly did not know about that the Intel architecture being aware of timers and pre-wakes the CPUs which makes the timer experiment observations void. Well, things depend on platform

Re: [RFC v4 1/1] selftests/cpuidle: Add support for cpuidle latency measurement

2020-09-03 Thread Pratik Sampat
Hello Artem, On 02/09/20 8:55 pm, Artem Bityutskiy wrote: On Wed, 2020-09-02 at 17:15 +0530, Pratik Rajesh Sampat wrote: Measure cpuidle latencies on wakeup to determine and compare with the advertsied wakeup latencies for each idle state. Thank you for pointing me to your talk. It was very

Re: [PATCH] Revert "powerpc/powernv/idle: Replace CPU feature check with PVR check"

2020-08-26 Thread Pratik Sampat
On 26/08/20 2:07 pm, Christophe Leroy wrote: Le 26/08/2020 à 10:29, Pratik Rajesh Sampat a écrit : Cpuidle stop state implementation has minor optimizations for P10 where hardware preserves more SPR registers compared to P9. The current P9 driver works for P10, although does few extra

Re: [PATCH v3 1/2] cpuidle: Trace IPI based and timer based wakeup latency from idle states

2020-07-28 Thread Pratik Sampat
Hello Rafael, On 27/07/20 7:12 pm, Rafael J. Wysocki wrote: On Tue, Jul 21, 2020 at 2:43 PM Pratik Rajesh Sampat wrote: Fire directed smp_call_function_single IPIs from a specified source CPU to the specified target CPU to reduce the noise we have to wade through in the trace log. And

Re: [PATCH v2 2/3] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10

2020-07-24 Thread Pratik Sampat
On 24/07/20 6:55 am, Michael Neuling wrote: On Fri, 2020-07-10 at 10:52 +0530, Pratik Rajesh Sampat wrote: Additional registers DAWR0, DAWRX0 may be lost on Power 10 for stop levels < 4. Therefore save the values of these SPRs before entering a "stop" state and restore their values on

Re: [PATCH v3 0/2] Selftest for cpuidle latency measurement

2020-07-22 Thread Pratik Sampat
Hello Daniel, On 21/07/20 8:27 pm, Daniel Lezcano wrote: On 21/07/2020 14:42, Pratik Rajesh Sampat wrote: v2: https://lkml.org/lkml/2020/7/17/369 Changelog v2-->v3 Based on comments from Gautham R. Shenoy adding the following in the selftest, 1. Grepping modules to determine if already loaded

Re: [PATCH v2 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2020-07-21 Thread Pratik Sampat
Hi Gautham, Thanks for the review. On 20/07/20 11:22 am, Gautham R Shenoy wrote: Hi Pratik, On Fri, Jul 17, 2020 at 02:48:01PM +0530, Pratik Rajesh Sampat wrote: This patch adds support to trace IPI based and timer based wakeup latency from idle states Latches onto the test-cpuidle_latency

Re: [PATCH v3 2/3] powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable

2020-07-21 Thread Pratik Sampat
On 20/07/20 5:27 am, Nicholas Piggin wrote: Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am: Replace the variable name from using "pnv_first_spr_loss_level" to "pnv_first_fullstate_loss_level". As pnv_first_spr_loss_level is supposed to be the earliest state that has

Re: [PATCH v3 1/3] powerpc/powernv/idle: Replace CPU features checks with PVR checks

2020-07-21 Thread Pratik Sampat
On 20/07/20 5:30 am, Nicholas Piggin wrote: Excerpts from Pratik Rajesh Sampat's message of July 18, 2020 4:53 am: As the idle framework's architecture is incomplete, hence instead of checking for just the processor type advertised in the device tree CPU features; check for the Processor

Re: [PATCH v2 0/3] Power10 basic energy management

2020-07-13 Thread Pratik Sampat
On 13/07/20 10:20 pm, Nicholas Piggin wrote: Excerpts from Pratik Sampat's message of July 13, 2020 8:02 pm: Thank you for your comments, On 13/07/20 10:53 am, Nicholas Piggin wrote: Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm: Changelog v1 --> v2: 1.

Re: [PATCH v2 0/3] Power10 basic energy management

2020-07-13 Thread Pratik Sampat
Thank you for your comments, On 13/07/20 10:53 am, Nicholas Piggin wrote: Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm: Changelog v1 --> v2: 1. Save-restore DAWR and DAWRX unconditionally as they are lost in shallow idle states too 2. Rename pnv_first_spr_loss_level to

Re: [PATCH 2/2] powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10

2020-07-09 Thread Pratik Sampat
On 09/07/20 2:39 pm, Gautham R Shenoy wrote: On Fri, Jul 03, 2020 at 06:16:40PM +0530, Pratik Rajesh Sampat wrote: Additional registers DAWR0, DAWRX0 may be lost on Power 10 for stop levels < 4. Adding Ravi Bangoria to the cc. Therefore save the values of these SPRs before entering a

Re: [PATCH 2/2] selftest/cpuidle: Add support for cpuidle latency measurement

2020-07-07 Thread Pratik Sampat
[..snip..] + +ins_mod() +{ +    if [ ! -f "$MODULE" ]; then +    printf "$MODULE module does not exist. Exitting\n" +    exit 2 Please use ksft_skip code to indicate the test is being skipped. Sure thing I'll use ksft_skip exit code instead. +    fi +    printf "Inserting $MODULE

Re: [RFC 0/1] Alternate history mechanism for the TEO governor

2020-05-21 Thread Pratik Sampat
Hello Doug, Thanks a lot for running these benchmarks on an Intel box. On 17/05/20 11:41 pm, Doug Smythies wrote: On 2020.05.11 Pratik Rajesh Sampat wrote: First RFC posting:https://lkml.org/lkml/2020/2/22/27 Summary: On that thread I wrote: > I have done a couple of other tests with

Re: [RFC 1/1] Weighted approach to gather and use history in TEO governor

2020-05-14 Thread Pratik Sampat
On 13/05/20 8:19 pm, Rafael J. Wysocki wrote: On Wed, May 13, 2020 at 7:31 AM Pratik Sampat wrote: Thanks for your comment. On 12/05/20 11:07 pm, Peter Zijlstra wrote: Just a quick note.. On Mon, May 11, 2020 at 07:40:55PM +0530, Pratik Rajesh Sampat wrote: +/* + * Rearrange

Re: [RFC 1/1] Weighted approach to gather and use history in TEO governor

2020-05-12 Thread Pratik Sampat
Thanks for your comment. On 12/05/20 11:07 pm, Peter Zijlstra wrote: Just a quick note.. On Mon, May 11, 2020 at 07:40:55PM +0530, Pratik Rajesh Sampat wrote: + /* +* Rearrange the weight distribution of the state, increase the weight +* by the LEARNING RATE % for the