[PATCH v2] staging: lustre: Fix variable type declaration after refactoring

eanup lustre_lib.h") Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- v2: fixes the referenced sha drivers/staging/lustre/lustre/include/obd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/lustre/lustre/include/obd.h +++ b/drivers/staging/lustr

[PATCH v2] staging: lustre: Fix variable type declaration after refactoring

eanup lustre_lib.h") Signed-off-by: Quentin Lambert --- v2: fixes the referenced sha drivers/staging/lustre/lustre/include/obd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/lustre/lustre/include/obd.h +++ b/drivers/staging/lustre/lustre/include/obd.h @@ -88

[PATCH] staging: lustre: Fix variable type declaration after refactoring

eanup lustre_lib.h") Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/staging/lustre/lustre/include/obd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/lustre/lustre/include/obd.h +++ b/drivers/staging/lustre/lustre/include/obd.h @@ -889,7

[PATCH] staging: lustre: Fix variable type declaration after refactoring

eanup lustre_lib.h") Signed-off-by: Quentin Lambert --- drivers/staging/lustre/lustre/include/obd.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/lustre/lustre/include/obd.h +++ b/drivers/staging/lustre/lustre/include/obd.h @@ -889,7 +889,7 @@ struct obd_cli

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On 12/07/2016 04:33 PM, Dan Carpenter wrote: Lustre is kind of a mess with regards to keeping user and kernel pointers separate. It's not going to be easy to fix. Fair enough. I am trying to make a contribution to drivers/staging using sparse. With that in mind, do you still fill I should

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On 12/07/2016 04:33 PM, Dan Carpenter wrote: Lustre is kind of a mess with regards to keeping user and kernel pointers separate. It's not going to be easy to fix. Fair enough. I am trying to make a contribution to drivers/staging using sparse. With that in mind, do you still fill I should

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

Hi all, I am looking at the drivers/staging/lustre/lustre/llite/dir.c: 1469 /* Call mdc_iocontrol */ 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), , 1471); 1472 if (rc) and sparse says:

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

Hi all, I am looking at the drivers/staging/lustre/lustre/llite/dir.c: 1469 /* Call mdc_iocontrol */ 1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp, sizeof(fid), , 1471); 1472 if (rc) and sparse says:

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On 12/05/2016 11:58 PM, Oleg Drokin wrote: I guess it's a false positive? Yes, probably. Thank you for the explanation though, I don't fully understand all this yet, I am still learning. Sorry for the noise. Quentin

Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

On 12/05/2016 11:58 PM, Oleg Drokin wrote: I guess it's a false positive? Yes, probably. Thank you for the explanation though, I don't fully understand all this yet, I am still learning. Sorry for the noise. Quentin

[PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

lnet_ipif_enumerate was assigning a pointer from kernel space to user space. This patch uses copy_to_user to properly do that assignment. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- shouldn't we be using ifc_req instead of ifc_buf? drivers/staging/lustre/lnet/ln

[PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space

lnet_ipif_enumerate was assigning a pointer from kernel space to user space. This patch uses copy_to_user to properly do that assignment. Signed-off-by: Quentin Lambert --- shouldn't we be using ifc_req instead of ifc_buf? drivers/staging/lustre/lnet/lnet/lib-socket.c |8 +++- 1 file

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

n.ga...@huawei.com> Reviewed-by: Quentin Lambert <lambert.quen...@gmail.com> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c index 6d6f150..d50e9cf 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_main.c +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c @@ -1412,

Re: [PATCH] scsi: hisi_sas: fix free'ing in probe and remove

the HBA memories, we should also free the HBA memories. - We should free shost memory at the end of hisi_sas_remove(). - sha->core.shost is set twice, so remove extra set. Signed-off-by: Xiaofei Tan Signed-off-by: John Garry Reviewed-by: Quentin Lambert diff --git a/drivers/scsi/hisi_

[PATCH v2] scsi: aic94xx: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing and set the relevant pointers to NULL. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- v2: set the point to NULL

[PATCH v2] scsi: aic94xx: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing and set the relevant pointers to NULL. This issue was found with Hector. Signed-off-by: Quentin Lambert --- v2: set the point to NULL after having freed it drivers

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

On 11/21/2016 03:16 PM, John Garry wrote: On 21/11/2016 13:20, Quentin Lambert wrote: On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

On 11/21/2016 03:16 PM, John Garry wrote: On 21/11/2016 13:20, Quentin Lambert wrote: On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome the opportunity to learn something. Quentin

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome the opportunity to learn something. Quentin

Re: [PATCH] stm class: Add a missing call to put_device

On 11/21/2016 08:32 AM, Alexander Shishkin wrote: Quentin Lambert <lambert.quen...@gmail.com> writes: Most error branches following the call to class_find_device contain a call to put_device. This patch add calls to put_device where they are missing. This issue was found with

Re: [PATCH] stm class: Add a missing call to put_device

On 11/21/2016 08:32 AM, Alexander Shishkin wrote: Quentin Lambert writes: Most error branches following the call to class_find_device contain a call to put_device. This patch add calls to put_device where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert

Re: [PATCH] coresight: perf: Add a missing call to etm_free_aux

On 11/19/2016 07:22 PM, Quentin Lambert wrote: On 11/19/2016 06:41 PM, Quentin Lambert wrote: Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found

Re: [PATCH] coresight: perf: Add a missing call to etm_free_aux

On 11/19/2016 07:22 PM, Quentin Lambert wrote: On 11/19/2016 06:41 PM, Quentin Lambert wrote: Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found

Re: [PATCH] coresight: perf: Add a missing call to etm_free_aux

On 11/19/2016 06:41 PM, Quentin Lambert wrote: Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH] xen-scsifront: Add a missing call to kfree

Most error branches following the call to kmalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/xen-scsifront.c |1 + 1 file changed, 1 ins

Re: [PATCH] coresight: perf: Add a missing call to etm_free_aux

On 11/19/2016 06:41 PM, Quentin Lambert wrote: Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH] xen-scsifront: Add a missing call to kfree

Most error branches following the call to kmalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/xen-scsifront.c |1 + 1 file changed, 1 insertion(+) --- a/drivers/scsi/xen

[PATCH] stm class: Add a missing call to put_device

Most error branches following the call to class_find_device contain a call to put_device. This patch add calls to put_device where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/hwtracing/stm/core.c |4 +++-

[PATCH] stm class: Add a missing call to put_device

Most error branches following the call to class_find_device contain a call to put_device. This patch add calls to put_device where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/hwtracing/stm/core.c |4 +++- 1 file changed, 3 insertions

[PATCH] [SCSI] dpt_i2o: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/dpt_i2o.c |4 +++- 1 file changed, 3 insertions

[PATCH] coresight: perf: Add a missing call to etm_free_aux

Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/hwtracing/cor

[PATCH] [SCSI] dpt_i2o: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/dpt_i2o.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers

[PATCH] coresight: perf: Add a missing call to etm_free_aux

Most error branches following the call to alloc_event_data contain a call to etm_free_aux. This patch add a call to etm_free_aux to an error branch that does not call it. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/hwtracing/coresight/coresight-etm-perf.c

[PATCH] isci: Add a missing call to pci_unmap_biosrom

Most error branches following the call to pci_map_biosrom contain a call to pci_unmap_biosrom. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/isci/probe_roms.c |1 +

[PATCH] isci: Add a missing call to pci_unmap_biosrom

Most error branches following the call to pci_map_biosrom contain a call to pci_unmap_biosrom. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/isci/probe_roms.c |1 + 1 file changed, 1 insertion

[PATCH] scsi: pmcraid: Add missing resource releases

they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/pmcraid.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3787,11 +3787,11 @@ stati

[PATCH] scsi: pmcraid: Add missing resource releases

they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/pmcraid.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3787,11 +3787,11 @@ static long pmcraid_ioctl_passthrough

[PATCH] scsi: hisi_sas: Add a missing call to kfree

Most error branches following the call to hisi_sas_shost_alloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/hisi_sas/hisi_sas_main.c |6 +++

[PATCH] scsi: hisi_sas: Add a missing call to kfree

Most error branches following the call to hisi_sas_shost_alloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/hisi_sas/hisi_sas_main.c |6 -- 1 file changed, 4 insertions

[PATCH] cxgb4i: Add a missing call to neigh_release

Most error branches following the call to dst_neigh_lookup contain a call to neigh_release. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |2 +-

[PATCH] cxgb4i: Add a missing call to neigh_release

Most error branches following the call to dst_neigh_lookup contain a call to neigh_release. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH] PCI Hotplug: cpqphp: Add missing call to pci_disable_device

Most error branches following the call to pci_enable_device contain a call to pci_disable_device. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/pci/hotplug/cpqphp_core.c |3

[PATCH] PCI Hotplug: cpqphp: Add missing call to pci_disable_device

Most error branches following the call to pci_enable_device contain a call to pci_disable_device. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/pci/hotplug/cpqphp_core.c |3 ++- 1 file changed, 2 insertions

[PATCH] scsi: aic94xx: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/scsi/aic94xx/aic94xx_hwi.c |4 +++- 1 file chan

[PATCH] scsi: aic94xx: Add a missing call to kfree

Most error branches following the call to kzalloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/aic94xx/aic94xx_hwi.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH v2] greybus: manifest: style fix missing space before '('

Checkpatch printed a style ERROR concerning a missing space before '('. This patch fixes this issue. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> Acked-by: Viresh Kumar <viresh.ku...@linaro.org> --- v2: fixes typos in commit message drivers/staging/greybus/manif

[PATCH v2] greybus: manifest: style fix missing space before '('

Checkpatch printed a style ERROR concerning a missing space before '('. This patch fixes this issue. Signed-off-by: Quentin Lambert Acked-by: Viresh Kumar --- v2: fixes typos in commit message drivers/staging/greybus/manifest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] greybus: manifest: style fix missing space before '('

On 27/09/2016 11:31, Viresh Kumar wrote: On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert <lambert.quen...@gmail.com> wrote: Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue. Signed-off-by: Quentin Lambert <lambert.quen...@

Re: [PATCH] greybus: manifest: style fix missing space before '('

On 27/09/2016 11:31, Viresh Kumar wrote: On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert wrote: Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue. Signed-off-by: Quentin Lambert --- drivers/staging/greybus/manifest.c |2 +- 1 file

[PATCH] greybus: manifest: style fix missing space before '('

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/staging/greybus/manifest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/greybus/mani

[PATCH] greybus: manifest: style fix missing space before '('

Checkpatch printed a style ERROR concerning a missing space befire '('. This patch fix this issue. Signed-off-by: Quentin Lambert --- drivers/staging/greybus/manifest.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/greybus/manifest.c +++ b/drivers/staging

Re: [PATCH v2 2/2] crypto: qat - fix resource release omissions

On 13/09/2016 14:40, Herbert Xu wrote: On Tue, Sep 06, 2016 at 11:18:51AM +0100, Giovanni Cabiddu wrote: ---8<--- Subject: [PATCH] crypto: qat - fix leak on error path Fix a memory leak in an error path in uc loader. Signed-off-by: Giovanni Cabiddu Patch

Re: [PATCH v2 2/2] crypto: qat - fix resource release omissions

On 13/09/2016 14:40, Herbert Xu wrote: On Tue, Sep 06, 2016 at 11:18:51AM +0100, Giovanni Cabiddu wrote: ---8<--- Subject: [PATCH] crypto: qat - fix leak on error path Fix a memory leak in an error path in uc loader. Signed-off-by: Giovanni Cabiddu Patch applied. Thanks. Sorry, I

Re: Unable to boot linux-next build

On 09/09/2016 10:31, Quentin Lambert wrote: I have been trying to build and boot the last version available on linux-next. During the build I am being prompted with "has no CRC!" warnings for a bunch of modules. Has a result I get the following lines in the Modu

Re: Unable to boot linux-next build

On 09/09/2016 10:31, Quentin Lambert wrote: I have been trying to build and boot the last version available on linux-next. During the build I am being prompted with "has no CRC!" warnings for a bunch of modules. Has a result I get the following lines in the Modu

Unable to boot linux-next build

I have been trying to build and boot the last version available on linux-next. During the build I am being prompted with "has no CRC!" warnings for a bunch of modules. Has a result I get the following lines in the Module.symvers: [qlambert@sloth linux-next]$ grep 0x0 Module.symvers

Unable to boot linux-next build

I have been trying to build and boot the last version available on linux-next. During the build I am being prompted with "has no CRC!" warnings for a bunch of modules. Has a result I get the following lines in the Module.symvers: [qlambert@sloth linux-next]$ grep 0x0 Module.symvers

[PATCH v2 2/2] crypto: qat - fix resource release omissions

In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH v2 2/2] crypto: qat - fix resource release omissions

In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH v2 1/2] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- dr

[PATCH v2 1/2] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_ucl

[PATCH v2 0/2] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. -changes since v1 I failed to send the first version properly

[PATCH v2 0/2] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. -changes since v1 I failed to send the first version properly

[PATCH 1/2] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- dr

[PATCH 1/2] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_ucl

[PATCH 2/2] crypto: qat - fix resource release omissions

This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/crypto/qat/qat_common/qat_uclo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/crypto/qat/qat_common/qat_uclo.c +++ b/drivers/crypto/qat/qat_common/qat_

[PATCH 2/2] crypto: qat - fix resource release omissions

This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_uclo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/crypto/qat/qat_common/qat_uclo.c +++ b/drivers/crypto/qat/qat_common/qat_uclo.c @@ -981,7 +981,8 @@ static int

[PATCH 1/2][RESEND] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- dr

[PATCH 0/2][RESEND] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16

[PATCH 2/2] crypto: qat - fix resource release omissions

In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH 1/2][RESEND] crypto: qat - introduces a variable to handle error codes

Most error code used to jump to a label that lead to a "return -EFAULT" statement. This patch introduces a variable that stores the error code so that other error branches can use the same label to exit. Signed-off-by: Quentin Lambert --- drivers/crypto/qat/qat_common/qat_ucl

[PATCH 0/2][RESEND] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16

[PATCH 2/2] crypto: qat - fix resource release omissions

In certain cases qat_uclo_parse_uof_obj used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert

[PATCH 0/2] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16

[PATCH 0/2] add omitted release in qat_common

The first patch introduces a variable to handle different error codes and be able to reuse the same clean up code. The second add an omitted release by jumping to the clean code having set the returned value to the proper error code. --- drivers/crypto/qat/qat_common/qat_uclo.c | 16

[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register

ccp_dmaengine_register used to return with an error code before releasing all resource. This patch adds a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.

[PATCH] crypto: ccp - add missing release in ccp_dmaengine_register

ccp_dmaengine_register used to return with an error code before releasing all resource. This patch adds a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/crypto/ccp

[PATCH v2 2/2] staging: rts5208/ms.c: add missing releases in mg_get_local_EKB and mg_get_ICV

mg_get_local_EKB and mg_get_ICV used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.q

[PATCH v2 2/2] staging: rts5208/ms.c: add missing releases in mg_get_local_EKB and mg_get_ICV

mg_get_local_EKB and mg_get_ICV used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers

[PATCH v2 1/2] staging: rts5208/ms.c: change the label name to respect the coding style

This patch changes label names using camel case to snake case as well as giving a new name representing what will be done after the label. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- v2: add a commit message drivers/staging/rts5208/ms.c | 12 ++-- 1 file chan

[PATCH v2 1/2] staging: rts5208/ms.c: change the label name to respect the coding style

This patch changes label names using camel case to snake case as well as giving a new name representing what will be done after the label. Signed-off-by: Quentin Lambert --- v2: add a commit message drivers/staging/rts5208/ms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions

[PATCH v2 0/2] add missing calls to kfree

The first patch is a style fix, the second add calls to kfree. The reason for me thinking that they are necessary is that every other branches leading to an error return are jumping to the same destination. v2: add a commit message to the first patch --- drivers/staging/rts5208/ms.c | 18

[PATCH v2 0/2] add missing calls to kfree

The first patch is a style fix, the second add calls to kfree. The reason for me thinking that they are necessary is that every other branches leading to an error return are jumping to the same destination. v2: add a commit message to the first patch --- drivers/staging/rts5208/ms.c | 18

[PATCH 2/2] staging: rts5208/ms.c: add missing releases in mg_get_local_EKB and mg_get_ICV

mg_get_local_EKB and mg_get_ICV used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.q

[PATCH 0/2] add missing calls to kfree

The first patch is a style fix, the second add calls to kfree. The reason for me thinking that they are necessary is that every other branches leading to an error return are jumping to the same destination. --- drivers/staging/rts5208/ms.c | 18 ++ 1 file changed, 10

[PATCH 2/2] staging: rts5208/ms.c: add missing releases in mg_get_local_EKB and mg_get_ICV

mg_get_local_EKB and mg_get_ICV used to return with an error code before releasing all resources. This patch add a jump to the appropriate label ensuring that the resources are properly released before returning. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers

[PATCH 0/2] add missing calls to kfree

The first patch is a style fix, the second add calls to kfree. The reason for me thinking that they are necessary is that every other branches leading to an error return are jumping to the same destination. --- drivers/staging/rts5208/ms.c | 18 ++ 1 file changed, 10

[PATCH 1/2] staging: rts5208/ms.c: change the label name to respect the coding style

Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/staging/rts5208/ms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- a/drivers/staging/rts5208/ms.c +++ b/drivers/staging/rts5208/ms.c @@ -4313,7 +4313,7 @@ int mg_get_local_EKB(struct scsi_c

[PATCH 1/2] staging: rts5208/ms.c: change the label name to respect the coding style

Signed-off-by: Quentin Lambert --- drivers/staging/rts5208/ms.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- a/drivers/staging/rts5208/ms.c +++ b/drivers/staging/rts5208/ms.c @@ -4313,7 +4313,7 @@ int mg_get_local_EKB(struct scsi_cmnd *s if (retval

[PATCH 2/2] crypto: ixp4xx - Add missing npe_c release in error branches

Most error branches following the call to npe_request contain a call to npe_request. This patch add a call to npe_release to error branches following the call to npe_request that do not have it. This issue was found with Hector. Signed-off-by: Quentin Lambert <lambert.quen...@gmail.

[PATCH 1/2] crypto: ixp4xx - Fix a "simple if" coding style warning

Signed-off-by: Quentin Lambert <lambert.quen...@gmail.com> --- drivers/crypto/ixp4xx_crypto.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/crypto/ixp4xx_crypto.c +++ b/drivers/crypto/ixp4xx_crypto.c @@ -447,9 +447,8 @@ static int init_ixp_crypto(struct

[PATCH 2/2] crypto: ixp4xx - Add missing npe_c release in error branches

Most error branches following the call to npe_request contain a call to npe_request. This patch add a call to npe_release to error branches following the call to npe_request that do not have it. This issue was found with Hector. Signed-off-by: Quentin Lambert --- If I am right in thinking

[PATCH 1/2] crypto: ixp4xx - Fix a "simple if" coding style warning

Signed-off-by: Quentin Lambert --- drivers/crypto/ixp4xx_crypto.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/crypto/ixp4xx_crypto.c +++ b/drivers/crypto/ixp4xx_crypto.c @@ -447,9 +447,8 @@ static int init_ixp_crypto(struct device if (!npe_running(npe_c

[PATCH 0/2] Fix a resource release omission in error handling code

The first patch is a style fix, the second add calls to npe_release. The reason for me thinking that they are necessary is that every other branches leading to an error return are calling this function. --- drivers/crypto/ixp4xx_crypto.c |9 + 1 file changed, 5 insertions(+), 4

[PATCH 0/2] Fix a resource release omission in error handling code

The first patch is a style fix, the second add calls to npe_release. The reason for me thinking that they are necessary is that every other branches leading to an error return are calling this function. --- drivers/crypto/ixp4xx_crypto.c |9 + 1 file changed, 5 insertions(+), 4

Re: [PATCH v3] ALSA: aoa: convert bus code to use dev_groups

On 12/06/2015 11:59, Andreas Schwab wrote: Quentin Lambert writes: The dev_attrs field of struct bus_type is going away, sue dev_groups instead. s/sue/use/ I meant use do you need to fix something else or should I resend with the typo correction ? Quentin -- To unsubscribe from

[PATCH] superhyway: convert code to use dev_groups

The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- drivers/sh/superhyway/superhyway-sysfs.c | 26

[PATCH v3] ALSA: aoa: convert bus code to use dev_groups

The dev_attrs field of struct bus_type is going away, sue dev_groups instead. This converts the soundbus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- Changes since v2: - Revert to the version of the patch where the files

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

On 11/06/2015 14:25, Takashi Iwai wrote: At Thu, 11 Jun 2015 14:04:45 +0200, Quentin Lambert wrote: On 11/06/2015 12:02, Takashi Iwai wrote: At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead

  1   2   3   4   >