The dev section was opening curly bracket, but not adding ident, which
resulted in two times "}," after each other with same indentation. Add
ident at the right place fixes this problem.
This formatting issue is not detectable by checkpatch.pl
Signed-off-by: Radek Dostál
---
Cha
The dev section was opening curly bracket, but not adding ident, which
resulted in two times "}," after each other with same indentation. Add
ident at the right place fixes this problem.
This formatting issue is not detectable by checkpatch.pl
Signed-off-by: Radek Dostál
---
Cha
Signed-off-by: Radek Dostál
---
drivers/staging/fbtft/fbtft_device.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index 4a54b46..cad244c 100644
--- a/drivers/staging/fbtft
Signed-off-by: Radek Dostál
---
drivers/staging/fbtft/fbtft_device.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index 4a54b46..cad244c 100644
--- a/drivers/staging/fbtft
Hi Chris,
On 04/20/2015 01:44 PM, Chris Wilson wrote:
> Ah, maybe this on top of the previous try:
>
> diff --git a/drivers/gpu/drm/drm_probe_helper.c
> b/drivers/gpu/drm/drm_probe_helper.c
> index 88f5a74..5d22ca0 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++
Hi Chris,
On 04/20/2015 01:00 PM, Chris Wilson wrote:
> Can you do a WARN_ON(list_empty(>modes)) here to see at what
> point we set up the invalid GTF mode?
sure please see attached patch adding WARN_ON and corresponding output
of dmesg. As mentioned in the original commit, the mode is indeed
Hi Chris,
On 04/20/2015 12:48 PM, Chris Wilson wrote:
>> Unfortunately you can not do that. I already tried. At the time when
>> > drm_helper_probe_add_cmdline_mode is called EDID informations are not
>> > yet available.
> My understanding is that it should be. fb_helper.initial_config does a
>
Hi Chris,
On 04/20/2015 11:58 AM, Chris Wilson wrote:
> Hmm, so that should be before the clock comparison as well to fix your
> example. Not as neat.
indeed that is required.
> The other idea I was considering was not adding the GTF cmdline mode if
> the probed modes already contain one of a
Hi Chris,
On 04/20/2015 11:09 AM, Chris Wilson wrote:
> The EDID modes should be earlier in the list, and so higher priority
> than the cmdline mode. The only instance I see that breaking down is if
> the mode gets created by drm_pick_cmdline_mode, i.e.
indeed at the beginning the command line
Hi Chris,
On 04/20/2015 01:44 PM, Chris Wilson wrote:
Ah, maybe this on top of the previous try:
diff --git a/drivers/gpu/drm/drm_probe_helper.c
b/drivers/gpu/drm/drm_probe_helper.c
index 88f5a74..5d22ca0 100644
--- a/drivers/gpu/drm/drm_probe_helper.c
+++
Hi Chris,
On 04/20/2015 01:00 PM, Chris Wilson wrote:
Can you do a WARN_ON(list_empty(connector-modes)) here to see at what
point we set up the invalid GTF mode?
sure please see attached patch adding WARN_ON and corresponding output
of dmesg. As mentioned in the original commit, the mode is
Hi Chris,
On 04/20/2015 11:09 AM, Chris Wilson wrote:
The EDID modes should be earlier in the list, and so higher priority
than the cmdline mode. The only instance I see that breaking down is if
the mode gets created by drm_pick_cmdline_mode, i.e.
indeed at the beginning the command line mode
Hi Chris,
On 04/20/2015 12:48 PM, Chris Wilson wrote:
Unfortunately you can not do that. I already tried. At the time when
drm_helper_probe_add_cmdline_mode is called EDID informations are not
yet available.
My understanding is that it should be. fb_helper.initial_config does a
probe
Hi Chris,
On 04/20/2015 11:58 AM, Chris Wilson wrote:
Hmm, so that should be before the clock comparison as well to fix your
example. Not as neat.
indeed that is required.
The other idea I was considering was not adding the GTF cmdline mode if
the probed modes already contain one of a
14 matches
Mail list logo
