RE: [PATCH][scsi-next] scsi: aacraid: remove redundant setting of variable c

2018-01-05 Thread Raghava Aditya Renukunta
d: Fix udev inquiry race condition") > Signed-off-by: Colin Ian King > --- Reviewed-by :Raghava Aditya Renukunta

RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

2017-08-29 Thread Raghava Aditya Renukunta
so with > this change, -ENOMEM is propagated to upper layer. > > Signed-off-by: Nikola Pajkovsky > --- [.] Reviewed-by: Raghava Aditya Renukunta

RE: [PATCH 2/3] scsi: aacraid: get rid of one level of indentation

2017-08-29 Thread Raghava Aditya Renukunta
} > return byte_count; > > is equal to > > unsigned long byte_count = 0; > nseg = scsi_dma_map(scsicmd); > if (nseg <= 0) > return nseg; > ... > return byte_count; > > No other code has changed. > > Signed-off-by: Nikola Pajkovsky > --- [.] Reviewed-by: Raghava Aditya Renukunta

RE: [PATCH 1/3] scsi: aacraid: fix indentation errors

2017-08-29 Thread Raghava Aditya Renukunta
; ker...@vger.kernel.org > Subject: [PATCH 1/3] scsi: aacraid: fix indentation errors > > EXTERNAL EMAIL > > > fix stupid indent error, no rocket science here. > > Signed-off-by: Nikola Pajkovsky > --- [.] Reviewed-by: Raghava Aditya Renukunta

RE: [PATCH] scsi: aacraid: fix information leak on hbainfo.driver_name

2017-02-13 Thread Raghava Aditya Renukunta
Hello Colin, > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, February 7, 2017 5:55 AM > To: dl-esc-Aacraid Linux Driver ; James E . J . > Bottomley ; Martin K . Petersen > ; linux-s...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-

RE: [PATCH] scsi: aacraid: avoid open-coded upper_32_bits

2017-02-07 Thread Raghava Aditya Renukunta
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Tuesday, February 7, 2017 5:00 AM > To: dl-esc-Aacraid Linux Driver ; James E.J. > Bottomley ; Martin K. Petersen > > Cc: Arnd Bergmann ; Johannes Thumshirn > ; Raghava Aditya Renukunta &g

RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

2017-02-07 Thread Raghava Aditya Renukunta
t;= 0 check is always true and -ve > errors are not being checked. > > Thanks to Dan Carpenter for spotting my original broken fix to this > issue. > > Signed-off-by: Colin Ian King > --- Reviewed-by: Raghava Aditya Renukunta

RE: [PATCH] [SCSI] aacraid: use kmemdup

2016-05-19 Thread Raghava Aditya Renukunta
= -ENOMEM; > goto cleanup; > } > - memcpy (usg, upsg, actual_fibsize - sizeof(struct > aac_srb) > - + sizeof(struct sgmap)); > actual_fibsize = actual_fibsize64; > > for (i = 0; i < usg->count; i++) { Reviewed-by: Raghava Aditya Renukunta

RE: [PATCH 4.5 036/238] aacraid: Set correct msix count for EEH recovery

2016-04-12 Thread Raghava Aditya Renukunta
Hello Ben, > -Original Message- > From: Ben Hutchings [mailto:b...@decadent.org.uk] > Sent: Monday, April 11, 2016 5:29 PM > To: Raghava Aditya Renukunta > Cc: sta...@vger.kernel.org; Shane Seymour; Johannes Thumshirn; Martin K. > Petersen; Greg Kroah-Hartman; LKML >

RE: [PATCH 1/3] aacraid: add missing curly braces

2016-03-19 Thread Raghava Aditya Renukunta
nel.org; linux-kernel@vger.kernel.org; Arnd > Bergmann; Johannes Thumshirn; Tomas Henzl; Mahesh Rajashekhara; > Raghava Aditya Renukunta; Fengguang Wu > Subject: [PATCH 1/3] aacraid: add missing curly braces > > gcc-6 warns about obviously wrong indentation for newly added > code in aac_slave