Re: [PATCH 4.19 17/36] cxgb4: use correct type for all-mask IP address comparison

2020-07-08 Thread Rahul Lakkireddy
On Tuesday, July 07/07/20, 2020 at 23:33:26 +0200, Pavel Machek wrote: > Hi! > > > From: Rahul Lakkireddy > > > > [ Upstream commit f286dd8eaad5a2758750f407ab079298e0bcc8a5 ] > > > > Use correct type to check for all-mask exact match IP addresses. > >

[PATCH net-next] vmcore: move get_vmcore_size out of __init

2018-05-21 Thread Rahul Lakkireddy
(). This is often because vmcore_add_device_dump lacks a __init annotation or the annotation of get_vmcore_size.constprop.5 is wrong. Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes") Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Gane

[PATCH net-next] vmcore: move get_vmcore_size out of __init

2018-05-21 Thread Rahul Lakkireddy
(). This is often because vmcore_add_device_dump lacks a __init annotation or the annotation of get_vmcore_size.constprop.5 is wrong. Fixes: 7efe48df8a3d ("vmcore: append device dumps to vmcore as elf notes") Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- fs/proc/vmcore.c |

[PATCH net-next v8 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-02 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v8 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-02 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - No changes. v7: - No changes. v6: - No changes. v5

[PATCH net-next v8 3/3] cxgb4: collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v8 3/3] cxgb4: collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - No changes. v7

[PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-02 Thread Rahul Lakkireddy
e/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel

[PATCH net-next v8 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-02 Thread Rahul Lakkireddy
ted by Eric Biederman . - Added new crashdd module that exports /proc/crashdd/ containing driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 t

[PATCH net-next v8 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v8: - Added missing linux/types.h header include. - Removed __vmcore_add_device_dump(). v7: - Removed "CHELSIO" vendor identifi

[PATCH net-next v8 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-02 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v8: - Added missing linux/types.h header include. - Removed __vmcore_add_device_dump(). v7: - Removed "CHELSIO" vendor identifier in Elf Note name. Instead, writing "LINUX". - Moved vmcoredd_header to new fil

[PATCH net-next v7 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-01 Thread Rahul Lakkireddy
t;ebied...@xmission.com>. - Added new crashdd module that exports /proc/crashdd/ containing driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to

[PATCH net-next v7 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-05-01 Thread Rahul Lakkireddy
ining driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware d

[PATCH net-next v7 3/3] cxgb4: collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v7 3/3] cxgb4: collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - Removed "CH

[PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v7: - Removed "CHELSIO" vendor identifier in Elf Note name. Instead, writing "LINUX". - Moved vmcoredd_header t

[PATCH net-next v7 1/3] vmcore: add API to collect hardware dump in second kernel

2018-05-01 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - Removed "CHELSIO" vendor identifier in Elf Note name. Instead, writing "LINUX". - Moved vmcoredd_header to new file include/uapi/linux/vmcore.h - Reworked vmcoredd_header to include Elf Note as part of

[PATCH net-next v7 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-01 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v7 2/3] vmcore: append device dumps to vmcore as elf notes

2018-05-01 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v7: - No changes. v6: - No changes. v5: - No changes. v4

[PATCH net-next v6 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-30 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v6 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-30 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - No changes. v5: - No changes. v4: - No changes. v3

[PATCH net-next v6 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-30 Thread Rahul Lakkireddy
rmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel

[PATCH net-next v6 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-30 Thread Rahul Lakkireddy
he new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/net/ethernet/che

[PATCH net-next v6 3/3] cxgb4: collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v6 3/3] cxgb4: collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - Added "CHELSIO&qu

[PATCH net-next v6 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v6: - Reworked device dump elf note name to contain vendor identifier. - Added vmcoredd_header that precedes actual dump in the Elf Not

[PATCH net-next v6 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-30 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v6: - Reworked device dump elf note name to contain vendor identifier. - Added vmcoredd_header that precedes actual dump in the Elf Note. - Device dump's name is moved inside vmcoredd_header. v5: - Removed enabling

[PATCH net-next v5 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-21 Thread Rahul Lakkireddy
ter their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dum

[PATCH net-next v5 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-21 Thread Rahul Lakkireddy
. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/net

[PATCH net-next v5 3/3] cxgb4: collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v5 3/3] cxgb4: collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - No changes. v4

[PATCH net-next v5 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v5: - Removed enabling CONFIG_PROC_VMCORE_DEVICE_DUMP by default and updated help message to indicate that the driver must be present

[PATCH net-next v5 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-21 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - Removed enabling CONFIG_PROC_VMCORE_DEVICE_DUMP by default and updated help message to indicate that the driver must be present in second kernel's initramfs to collect the underlying device snapshot. v4: - Made

[PATCH net-next v5 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-21 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v5 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-21 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v5: - No changes. v4: - No changes. v3: - Patch added

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Friday, April 04/20/18, 2018 at 19:06:09 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman > > wrote: > >> Rahul Lakkireddy <

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Friday, April 04/20/18, 2018 at 19:06:09 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman > > wrote: > >> Rahul Lakkireddy writes: > >> > >> > On Thursd

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > >> On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: &g

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-20 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 20:23:37 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > >> On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > >> > On Wednesday, April

Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 13:54:56 +0530, Greg KH wrote: > On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > > +config PROC_VMCORE_DEVICE_DUMP > > + bool "Device Hardware/Firmware Log Collection" > > + depends on PROC_VMCORE >

Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 13:54:56 +0530, Greg KH wrote: > On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > > +config PROC_VMCORE_DEVICE_DUMP > > + bool "Device Hardware/Firmware Log Collection" > > + depends on PROC_VMCORE >

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > > > Hi Rahul, > > > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: &g

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-19 Thread Rahul Lakkireddy
On Thursday, April 04/19/18, 2018 at 07:10:30 +0530, Dave Young wrote: > On 04/18/18 at 06:01pm, Rahul Lakkireddy wrote: > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > > > Hi Rahul, > > > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: &g

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 19:58:01 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > >> Hi Rahul, > >> On 04/17/1

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 19:58:01 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > >> Hi Rahul, > >> On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > >>

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > Hi Rahul, > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even months. It is > &

Re: [PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-18 Thread Rahul Lakkireddy
On Wednesday, April 04/18/18, 2018 at 11:45:46 +0530, Dave Young wrote: > Hi Rahul, > On 04/17/18 at 01:14pm, Rahul Lakkireddy wrote: > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even months. It is > &

[PATCH net-next v4 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-17 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v4 2/3] vmcore: append device dumps to vmcore as elf notes

2018-04-17 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - No changes. v3: - Patch added in this version

[PATCH net-next v4 3/3] cxgb4: collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v4 3/3] cxgb4: collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - No changes. v3

[PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-17 Thread Rahul Lakkireddy
ter their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dum

[PATCH net-next v4 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-04-17 Thread Rahul Lakkireddy
patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/net/ethernet

[PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v4: - Made __vmcore_add_device_dump() static. - Moved compile check to define vmcore_add_device_dump() to crash_dump.h to fix compila

[PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-17 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v4: - Made __vmcore_add_device_dump() static. - Moved compile check to define vmcore_add_device_dump() to crash_dump.h to fix compilation when vmcore.c is not compiled in. - Convert ---help--- to help in Kconfig as indicated

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-02 Thread Rahul Lakkireddy
On Monday, April 04/02/18, 2018 at 14:41:43 +0530, Jiri Pirko wrote: > Fri, Mar 30, 2018 at 08:42:00PM CEST, ebied...@xmission.com wrote: > >Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > >> On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-04-02 Thread Rahul Lakkireddy
On Monday, April 04/02/18, 2018 at 14:41:43 +0530, Jiri Pirko wrote: > Fri, Mar 30, 2018 at 08:42:00PM CEST, ebied...@xmission.com wrote: > >Rahul Lakkireddy writes: > > > >> On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote: > >>>

[PATCH net-next v3 1/3] vmcore: add API to collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
<ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v3: - Dropped sysfs crashdd module. - Added CONFIG_PROC_VMCORE_DEVICE_DUMP to allow configuring device dump support. - Moved logic relat

[PATCH net-next v3 1/3] vmcore: add API to collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Dropped sysfs crashdd module. - Added CONFIG_PROC_VMCORE_DEVICE_DUMP to allow configuring device dump support. - Moved logic related to adding dumps from crashdd to vmcore module. - Rename all crashdd* to vmcoredd*. v2

[PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh

[PATCH net-next v3 3/3] cxgb4: collect hardware dump in second kernel

2018-03-31 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available as elf notes in /proc/vmcore in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Replaced all crashdd

[PATCH net-next v3 2/3] vmcore: append device dumps to vmcore as elf notes

2018-03-31 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman <ebied...@xmission.com>. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh G

[PATCH net-next v3 2/3] vmcore: append device dumps to vmcore as elf notes

2018-03-31 Thread Rahul Lakkireddy
address. Incorporate device dump size into the total vmcore size. Also update offsets for other program headers after the device dumps are added. Suggested-by: Eric Biederman . Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v3: - Patch added in this version. - Exported dumps as elf

[PATCH net-next v3 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-31 Thread Rahul Lakkireddy
d the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as

[PATCH net-next v3 0/3] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-31 Thread Rahul Lakkireddy
recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (3): vmcore: add API to collect hardware dump in second kernel vmcore: append device dumps to vmcore as elf notes cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-30 Thread Rahul Lakkireddy
On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote: > Sat, Mar 24, 2018 at 11:56:33AM CET, rahul.lakkire...@chelsio.com wrote: > >Add a new module crashdd that exports the /sys/kernel/crashdd/ > >directory in second kernel, containing collected hardware/firmware > >dumps. > > >

Re: [PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-30 Thread Rahul Lakkireddy
On Friday, March 03/30/18, 2018 at 16:09:07 +0530, Jiri Pirko wrote: > Sat, Mar 24, 2018 at 11:56:33AM CET, rahul.lakkire...@chelsio.com wrote: > >Add a new module crashdd that exports the /sys/kernel/crashdd/ > >directory in second kernel, containing collected hardware/firmware > >dumps. > > >

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-27 Thread Rahul Lakkireddy
On Tuesday, March 03/27/18, 2018 at 18:47:34 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman > > wrote: > >> > >> Rahul Lakkir

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-27 Thread Rahul Lakkireddy
On Tuesday, March 03/27/18, 2018 at 18:47:34 +0530, Eric W. Biederman wrote: > Rahul Lakkireddy writes: > > > On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman > > wrote: > >> > >> Rahul Lakkireddy writes: > >> > >>

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-26 Thread Rahul Lakkireddy
On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman wrote: > > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> writes: > > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even

Re: [PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-26 Thread Rahul Lakkireddy
On Saturday, March 03/24/18, 2018 at 20:50:52 +0530, Eric W. Biederman wrote: > > Rahul Lakkireddy writes: > > > On production servers running variety of workloads over time, kernel > > panic can happen sporadically after days or even months. It is > > important to

[PATCH net-next v2 2/2] cxgb4: collect hardware dump in second kernel

2018-03-24 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available under /sys/kernel/crashdd/cxgb4/ directory in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Sign

[PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-24 Thread Rahul Lakkireddy
-by: Eric Biederman <ebied...@xmission.com>. Suggested-by: Stephen Hemminger <step...@networkplumber.org> Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- v2: - Added ABI Documentation for crashdd. - Directly use

[PATCH net-next v2 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-24 Thread Rahul Lakkireddy
-by: Eric Biederman . Suggested-by: Stephen Hemminger Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Added ABI Documentation for crashdd. - Directly use octal permission instead of macro. Changes since rfc v2: - Moved exporting crashdd from procfs to sysfs. Suggested

[PATCH net-next v2 2/2] cxgb4: collect hardware dump in second kernel

2018-03-24 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available under /sys/kernel/crashdd/cxgb4/ directory in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2

[PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-24 Thread Rahul Lakkireddy
log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (2): fs/crashdd: add API to collect hardware dump in second kernel cxgb4: collect hardware dump in second kernel Documentation/ABI/testing/sysfs-kernel-crashdd | 34 +

[PATCH net-next v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-24 Thread Rahul Lakkireddy
patch 2 to use the new API in patch 1. Rahul Lakkireddy (2): fs/crashdd: add API to collect hardware dump in second kernel cxgb4: collect hardware dump in second kernel Documentation/ABI/testing/sysfs-kernel-crashdd | 34 drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4

[PATCH net-next 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-23 Thread Rahul Lakkireddy
-by: Eric Biederman <ebied...@xmission.com>. Suggested-by: Stephen Hemminger <step...@networkplumber.org> Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- Changes since rfc v2: - Moved exporting crashdd from pro

[PATCH net-next 1/2] fs/crashdd: add API to collect hardware dump in second kernel

2018-03-23 Thread Rahul Lakkireddy
-by: Eric Biederman . Suggested-by: Stephen Hemminger Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- Changes since rfc v2: - Moved exporting crashdd from procfs to sysfs. Suggested by Stephen Hemminger - Moved code from fs/proc/crashdd.c to fs/crashdd/ directory. - Replaced all

[PATCH net-next 2/2] cxgb4: collect hardware dump in second kernel

2018-03-23 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available under /sys/kernel/crashdd/cxgb4/ directory in second kernel. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Sign

[PATCH net-next 2/2] cxgb4: collect hardware dump in second kernel

2018-03-23 Thread Rahul Lakkireddy
Register callback to collect hardware/firmware dumps in second kernel before hardware/firmware is initialized. The dumps for each device will be available under /sys/kernel/crashdd/cxgb4/ directory in second kernel. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- Changes since

[PATCH net-next 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-23 Thread Rahul Lakkireddy
I in patch 1. Rahul Lakkireddy (2): fs/crashdd: add API to collect hardware dump in second kernel cxgb4: collect hardware dump in second kernel drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 4 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_cudbg.c | 25 +++ drivers/net/ethernet/c

[PATCH net-next 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-23 Thread Rahul Lakkireddy
/ containing driver's registered hardware/firmware logs in patch 1. - Replaced the API to allow drivers to register their hardware/firmware log collect routine in crash recovery kernel in patch 1. - Updated patch 2 to use the new API in patch 1. Rahul Lakkireddy (2): fs/crashdd: add API

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:12:15 +0530, Alexander Duyck wrote: > On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy > <rahul.lakkire...@chelsio.com> wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:12:15 +0530, Alexander Duyck wrote: > On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy > wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > >&

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:10:19 +0530, David Laight wrote: > From: Rahul Lakkireddy > > Sent: 20 March 2018 13:32 > ... > > On High Availability Server, the logs of the failing system must be > > collected as quickly as possible. So, we're concerned with the

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 20:10:19 +0530, David Laight wrote: > From: Rahul Lakkireddy > > Sent: 20 March 2018 13:32 > ... > > On High Availability Server, the logs of the failing system must be > > collected as quickly as possible. So, we're concerned with the

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 19:14:46 +0530, Andy Shevchenko wrote: > On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy > <rahul.lakkire...@chelsio.com> wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-21 Thread Rahul Lakkireddy
On Tuesday, March 03/20/18, 2018 at 19:14:46 +0530, Andy Shevchenko wrote: > On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy > wrote: > > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > &

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:57:22 +0530, Christoph Hellwig wrote: > On Mon, Mar 19, 2018 at 07:50:33PM +0530, Rahul Lakkireddy wrote: > > This series of patches add support for 256-bit IO read and write. > > The APIs are readqq and writeqq (quad quadword - 4 x

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:57:22 +0530, Christoph Hellwig wrote: > On Mon, Mar 19, 2018 at 07:50:33PM +0530, Rahul Lakkireddy wrote: > > This series of patches add support for 256-bit IO read and write. > > The APIs are readqq and writeqq (quad quadword - 4 x

Re: [RFC v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:52:11 +0530, Stephen Hemminger wrote: > On Mon, 19 Mar 2018 13:25:56 +0530 > Rahul Lakkireddy <rahul.lakkire...@chelsio.com> wrote: > > > On Friday, March 03/16/18, 2018 at 16:42:03 +0530, Rahul Lakkireddy wrote: > > > On prod

Re: [RFC v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:52:11 +0530, Stephen Hemminger wrote: > On Mon, 19 Mar 2018 13:25:56 +0530 > Rahul Lakkireddy wrote: > > > On Friday, March 03/16/18, 2018 at 16:42:03 +0530, Rahul Lakkireddy wrote: > > > On production servers running variety of wor

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > > Use VMOVDQU AVX CPU instruction when available to do 256-bit > > IO read and write. > > That's not what the patch does. See below. > > >

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > > Use VMOVDQU AVX CPU instruction when available to do 256-bit > > IO read and write. > > That's not what the patch does. See below. > > >

[RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-19 Thread Rahul Lakkireddy
adds 256-bit read and write to x86 via VMOVDQU AVX CPU instructions. Patch 3 updates cxgb4 driver to use the readqq API to speed up reading on-chip memory 256-bits at a time. Feedback and suggestions will be much appreciated. Thanks, Rahul Rahul Lakkireddy (3): include/linux: add 256-bit IO

[RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-19 Thread Rahul Lakkireddy
adds 256-bit read and write to x86 via VMOVDQU AVX CPU instructions. Patch 3 updates cxgb4 driver to use the readqq API to speed up reading on-chip memory 256-bits at a time. Feedback and suggestions will be much appreciated. Thanks, Rahul Rahul Lakkireddy (3): include/linux: add 256-bit IO

[RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-19 Thread Rahul Lakkireddy
Use VMOVDQU AVX CPU instruction when available to do 256-bit IO read and write. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- arch/x86/include/asm/io.h | 57 ++- 1

[RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-19 Thread Rahul Lakkireddy
Use VMOVDQU AVX CPU instruction when available to do 256-bit IO read and write. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- arch/x86/include/asm/io.h | 57 ++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/arch

[RFC PATCH 1/3] include/linux: add 256-bit IO accessors

2018-03-19 Thread Rahul Lakkireddy
Add readqq and writeqq (quad quadword - 4 x 64) IO non-atomic accessors. Also add byteorder conversions for 256-bit. Signed-off-by: Rahul Lakkireddy <rahul.lakkire...@chelsio.com> Signed-off-by: Ganesh Goudar <ganes...@chelsio.com> --- include/linux/byteorder/generi

  1   2   >