Re: [PATCH v19 RESEND 4/5] Documentation: tracing: Add ring-buffer mapping

2024-03-27 Thread Randy Dunlap
ping: > + > +.. code-block:: c > + > +reader_id = meta->reader->id; > +reader_offset = meta->meta_page_size + reader_id * meta->subbuf_size; > + > +When the application is done with the current reader, it can get a new one > using > +the trace_pipe_raw ioctl() TRACE_MMAP_IOCTL_GET_READER. This ioctl also > updates > +the meta-page fields. [snip] Thanks. -- #Randy

Re: [PATCH v2] arch/riscv: Enable kprobes when CONFIG_MODULES=n

2024-03-23 Thread Randy Dunlap
On 3/23/24 16:29, Jarkko Sakkinen wrote: > +config HAVE_KPROBES_ALLOC > + bool > + help > + Architectures that select this option are capable of allocating memory > + for kprobes withou the kernel module allocator. without -- #Randy

Re: [PATCH] ftrace: fix FTRACE_RECORD_RECURSION_SIZE Kconfig entry

2024-03-22 Thread Randy Dunlap
Parsers should accept either tab or space but this is a reasonable change. > Fixes: 773c16705058 ("ftrace: Add recording of functions that caused > recursion") > Signed-off-by: Prasad Pandit Reviewed-by: Randy Dunlap Thanks. > --- > kernel/trace/Kconfig | 2 +- >

Re: [PATCH] tracing: Have trace_marker writes be just half of TRACE_SEQ_SIZE

2024-03-04 Thread Randy Dunlap
TRACE_SEQ_SIZE / 2; > + > meta_size = sizeof(*entry) + 2; /* add '\0' and possible '\n' */ > again: > size = cnt + meta_size; -- #Randy

[PATCH -next] VDUSE: fix another doc underline warning

2024-02-22 Thread Randy Dunlap
umentation: Add reconnect process for VDUSE") Signed-off-by: Randy Dunlap Cc: Cindy Lu Cc: Michael S. Tsirkin Cc: Jason Wang Cc: Xuan Zhuo Cc: virtualizat...@lists.linux.dev Cc: Jonathan Corbet --- Documentation/userspace-api/vduse.rst |4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH] ftrace: fix most kernel-doc warnings

2024-02-22 Thread Randy Dunlap
atted correctly when rendered for output. Spell "non-zero" with a hyphen in several places. Signed-off-by: Randy Dunlap Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202312180518.x6frydsn-...@intel.com/ Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathi

[PATCH v2] x86/sgx: fix kernel-doc comment misuse

2024-02-10 Thread Randy Dunlap
Cc: Dave Hansen Cc: linux-...@vger.kernel.org Cc: x...@kernel.org Reviewed-by: Kai Huang Signed-off-by: Randy Dunlap --- v2: add Rev-by: Kai Huang arch/x86/kernel/cpu/sgx/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -- a/arch/x86/kernel/cpu/sgx/main.c b/arch/x86/kernel

Re: [PATCH] lib/test_kmod: fix kernel-doc warnings

2024-01-31 Thread Randy Dunlap
Hi, Any comments on this patch? Thanks. On 11/3/23 21:20, Randy Dunlap wrote: > Fix all kernel-doc warnings in test_kmod.c: > - Mark some enum values as private so that kernel-doc is not needed > for them > - s/thread_mutex/thread_lock/ in a struct's kernel-doc comments &

Re: linux-next: Tree for Jan 8 (drivers/vfio/pci/virtio/main.o)

2024-01-08 Thread Randy Dunlap
ference to `virtio_pci_admin_legacy_device_io_write' Also, it is not a good idea to have a driver depend on a hidden (not visible) Kconfig symbol, like this: config VIRTIO_VFIO_PCI tristate "VFIO support for VIRTIO NET PCI devices" depends on VIRTIO_PCI_ADMIN_LEGA

Re: [PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params

2023-12-21 Thread Randy Dunlap
Hi Ira, On 12/21/23 14:34, Ira Weiny wrote: > Ira Weiny wrote: >> Randy Dunlap wrote: > > [snip] > >>> diff -- a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c >>> --- a/drivers/nvdimm/dimm_devs.c >>> +++ b/drivers/nvdimm/dimm_devs.c &g

Re: [PATCH 3/3] nvdimm/namespace: fix kernel-doc for function params

2023-12-21 Thread Randy Dunlap
On 12/21/23 14:32, Ira Weiny wrote: > Randy Dunlap wrote: > > [snip] > >> @@ -1656,8 +1664,10 @@ static int select_pmem_id(struct nd_regi >> /** >> * create_namespace_pmem - validate interleave set labelling, retrieve >> label0 >> * @n

[PATCH] tracing/synthetic: fix kernel-doc warnings

2023-12-19 Thread Randy Dunlap
parameter 'args' description in '__synth_event_gen_cmd_start' trace_events_synth.c:1714: warning: Excess function parameter 'args' description in 'synth_event_trace' Signed-off-by: Randy Dunlap Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathieu Desnoyers

[PATCH] x86/sgx: fix kernel-doc comment misuse

2023-12-16 Thread Randy Dunlap
Don't use "/**" for a non-kernel-doc comment. This prevents a warning from scripts/kernel-doc: main.c:740: warning: expecting prototype for A section metric is concatenated in a way that @low bits 12(). Prototype was for sgx_calc_section_metric() instead Signed-off-by: Randy Dun

[PATCH 1/3] nvdimm/btt: fix btt_blk_cleanup() kernel-doc

2023-12-07 Thread Randy Dunlap
Correct the function parameters to prevent kernel-doc warnings: btt.c:1567: warning: Function parameter or member 'nd_region' not described in 'btt_init' btt.c:1567: warning: Excess function parameter 'maxlane' description in 'btt_init' Signed-off-by:

[PATCH 3/3] nvdimm/namespace: fix kernel-doc for function params

2023-12-07 Thread Randy Dunlap
7;create_namespace_pmem' namespace_devs.c:1665: warning: Excess function parameter 'nspm' description in 'create_namespace_pmem' namespace_devs.c:1665: warning: No description found for return value of 'create_namespace_pmem' Signed-off-by: Randy Dunlap Cc:

[PATCH 2/3] nvdimm/dimm_devs: fix kernel-doc for function params

2023-12-07 Thread Randy Dunlap
_dpa' dimm_devs.c:844: warning: Function parameter or member 'ndd' not described in 'nvdimm_allocated_dpa' dimm_devs.c:844: warning: Excess function parameter 'nvdimm' description in 'nvdimm_allocated_dpa' dimm_devs.c:844: warning: No description foun

[PATCH] hwspinlock/core: fix kernel-doc warnings

2023-12-05 Thread Randy Dunlap
arameter 'bank' description in 'of_hwspin_lock_simple_xlate' hwspinlock_core.c:647: warning: Function parameter or member 'hwlock' not described in '__hwspin_lock_request' and 17 warnings like: hwspinlock_core.c:487: warning: No description found for return value of 'hwspin

[PATCH] lib/test_kmod: fix kernel-doc warnings

2023-11-03 Thread Randy Dunlap
t_kmod.c:134: warning: Function parameter or member 'thread_mutex' not described in 'kmod_test_device' Signed-off-by: Randy Dunlap Cc: Luis Chamberlain Cc: linux-modu...@vger.kernel.org --- lib/test_kmod.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) di

Re: [PATCH 1/1] rpmsg: virtio: Make buffer size and number configurable

2023-09-28 Thread Randy Dunlap
supports up to a > maximum > + of 512 buffers (256 in each direction). Please note that this value > + should be an even number, as it accounts for both transmit (TX) and > + receive (Rx) buffers. > endmenu -- ~Randy

[PATCH] dax: super.c: fix kernel-doc bad line warning

2023-01-16 Thread Randy Dunlap
Convert an empty line to " *" to avoid a kernel-doc warning: drivers/dax/super.c:478: warning: bad line: Signed-off-by: Randy Dunlap Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: nvd...@lists.linux.dev --- drivers/dax/super.c |2 +- 1 file changed, 1 insertion(+),

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-20 Thread Randy Dunlap
On 4/20/21 6:15 AM, Michael Ellerman wrote: > Christophe Leroy writes: >> Le 19/04/2021 à 23:39, Randy Dunlap a écrit : >>> On 4/19/21 6:16 AM, Michael Ellerman wrote: >>>> Randy Dunlap writes: >>> >>>>> Sure. I'll post them later t

Re: [PATCH 2/5] misc: zynq: Add afi config driver

2021-04-20 Thread Randy Dunlap
data path should be configured > + with the proper Bus-width values End that last sentence with a period ('.'). thanks. -- ~Randy

Re: [PATCH 5/5] misc: zynqmp: Add afi config driver

2021-04-20 Thread Randy Dunlap
tyle for Kconfig files: from Documentation/process/coding-style.rst, section 10): For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. thanks. -- ~Randy

Re: (.text.ks8851_probe_common+0x370): undefined reference to `__this_module'

2021-04-20 Thread Randy Dunlap
On 2/24/21 12:38 AM, Arnd Bergmann wrote: > On Wed, Feb 24, 2021 at 3:38 AM Randy Dunlap wrote: >> >> On 2/21/21 10:12 PM, kernel test robot wrote: >>> Hi Marek, >>> >>> FYI, the error/warning still remains. >>> >>> tree: https:

Re: [PATCH 2/2] USB: misc: Add driver for the WCH CH341 in I2C/GPIO mode

2021-04-19 Thread Randy Dunlap
onfig > new file mode 100644 > index ..e69de29bb2d1 Is that file (above) empty on purpose? > diff --git a/drivers/usb/misc/ch341/Makefile b/drivers/usb/misc/ch341/Makefile > new file mode 100644 > index ..7c6429e7a46e > --- /dev/null > +++ b/drivers/usb/misc/ch341/Makefile > @@ -0,0 +1,3 @@ > +obj-$(CONFIG_USB_CH341_CORE) := ch341-buses.o > + > +ch341-buses-objs := ch341-core.o ch341-i2c.o ch341-gpio.o -- ~Randy

Re: [PATCH] afs: fix no return statement in function returning non-void

2021-04-19 Thread Randy Dunlap
marked as 'no return' to the > compiler. What arch and compiler are you using? How do mark a #define BUG() as __noreturn? Several arch-es use #define for BUG() instead of using a function. -- ~Randy

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-19 Thread Randy Dunlap
On 4/19/21 6:16 AM, Michael Ellerman wrote: > Randy Dunlap writes: >> Sure. I'll post them later today. >> They keep FPU and ALTIVEC as independent (build) features. > > Those patches look OK. > > But I don't think it makes sense to support that configurat

Re: [PATCH] smp: add a best_effort version of smp_call_function_many()

2021-04-19 Thread Randy Dunlap
> + */ > +int __smp_call_function_many(struct cpumask *mask, smp_call_func_t func, > + void *info, int mode) > +{ thanks. -- ~Randy

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-19 Thread Randy Dunlap
On 4/19/21 6:16 AM, Michael Ellerman wrote: > Randy Dunlap writes: >> On 4/18/21 10:46 AM, Segher Boessenkool wrote: >>> On Sun, Apr 18, 2021 at 06:24:29PM +0200, Christophe Leroy wrote: >>>> Le 17/04/2021 à 22:17, Randy Dunlap a écrit : >>>>> Should t

Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon

2021-04-19 Thread Randy Dunlap
On 4/19/21 10:10 AM, Randy Dunlap wrote: > On 4/19/21 2:01 AM, Robert Foss wrote: >> The DRM_SIL_SII8620 kconfig has a weak `imply` dependency >> on EXTCON, which causes issues when sii8620 is built >> as a builtin and EXTCON is built as a module. >> >> The

Re: [PATCH v3] drm/bridge/sii8620: fix dependency on extcon

2021-04-19 Thread Randy Dunlap
gt; https://lore.kernel.org/lkml/202104040604.sste2cxf-...@intel.com/ > > > Changes since v1: > - Fix typo on comment > > Changes since v2: > - Randy: Changed from `depends` to `select` I don't know why my name is on that. I didn't suggest any change -- I just re

Re: linux-next: Tree for Apr 19 (bcache)

2021-04-19 Thread Randy Dunlap
LK_DEV [=n] Selected by [y]: - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y] Full randconfig file is attached. -- ~Randy Reported-by: Randy Dunlap config-r8861.gz Description: application/gzip

[PATCH] watchdog: clean up the Kconfig file

2021-04-18 Thread Randy Dunlap
Change a non-working ftp: URL to https:. Wrap long lines earlier. Spell "IP" with capital letters. Change "it`s" to "it's". The backtick (grave accent) is not an apostrophe. Signed-off-by: Randy Dunlap Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc: linux-wa

[PATCH] scsi: fusion: documentation cleanup

2021-04-18 Thread Randy Dunlap
ng: missing initial short description on line: * csmisas_find_vtarget mptsas.c:993: warning: expecting prototype for csmisas_find_vtarget(). Prototype was for mptsas_find_vtarget() instead mptsas.c:1053: warning: missing initial short description on line: * mptsas_target_reset mptsas.c:1057: warni

[PATCH] scsi: mpt3sas: documentation cleanup

2021-04-18 Thread Randy Dunlap
'ctr' description in '_base_allocate_chain_dma_pool' mpt3sas_base.c:1362: warning: missing initial short description on line: * _base_display_reply_info - mpt3sas_base.c:2151: warning: contents before sections mpt3sas_base.c:2314: warning: missing initial short description on line: * base_make_prp

[PATCH 2/2] powerpc: add ALTIVEC support to lib/ when PPC_FPU not set

2021-04-18 Thread Randy Dunlap
fferent build issue (for pmac32-cpufreq.c). Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org Cc: Christophe Leroy Cc: Segher Boessenkool Cc: l...@intel.com --- arch/powerpc/lib/Makefile |1 + arch/powerpc/lib/sstep.c |5 + 2 files changed, 6 in

[PATCH 1/2] powerpc: add enable_kernel_fp() stub for ALTIVEC without PPC_FPU

2021-04-18 Thread Randy Dunlap
that when PPC_FPU is not set. Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Michael Ellerman Cc: linuxppc-...@lists.ozlabs.org Cc: Christophe Leroy Cc: Segher Boessenkool Cc: l...@intel.com --- arch/powerpc/include/asm/switch_to.h |1 + 1 file changed, 1 insertion(+)

Re: PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-18 Thread Randy Dunlap
On 4/18/21 10:46 AM, Segher Boessenkool wrote: > On Sun, Apr 18, 2021 at 06:24:29PM +0200, Christophe Leroy wrote: >> Le 17/04/2021 à 22:17, Randy Dunlap a écrit : >>> Should the code + Kconfigs/Makefiles handle that kind of >>> kernel config or should ALTIVEC always mea

Re: mmu.c:undefined reference to `patch__hash_page_A0'

2021-04-18 Thread Randy Dunlap
On 4/18/21 3:43 AM, Christophe Leroy wrote: > > > Le 18/04/2021 à 02:02, Randy Dunlap a écrit : >> HI-- >> >> I no longer see this build error. > > Fixed by > https://github.com/torvalds/linux/commit/acdad8fb4a1574323db88f98a38b630691574e16 > >> H

[PATCH 2/2] kconfig: highlight xconfig 'comment' lines with '***'

2021-04-17 Thread Randy Dunlap
akes the comments be presented in a way that is similar to menuconfig and nconfig. Signed-off-by: Randy Dunlap Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org --- scripts/kconfig/qconf.cc |1 + 1 file changed, 1 insertion(+) --- linux-next-20210416.orig/scripts/kconfig/qconf.cc +

[PATCH 1/2] kconfig: highlight gconfig 'comment' lines with '***'

2021-04-17 Thread Randy Dunlap
akes the comments be presented in a way that is similar to menuconfig and nconfig. Signed-off-by: Randy Dunlap Cc: Masahiro Yamada Cc: linux-kbu...@vger.kernel.org --- scripts/kconfig/gconf.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- linux-next-20210416.orig/scripts/

[PATCH] crypto: camellia: drop duplicate "depends on CRYPTO"

2021-04-17 Thread Randy Dunlap
ellia - add AVX2/AES-NI/x86_64 assembler implementation of camellia cipher") Fixes: c5aac2df6577 ("sparc64: Add DES driver making use of the new des opcodes.") Signed-off-by: Randy Dunlap Cc: Sebastian Siewior Cc: Jussi Kivilinna Cc: Herbert Xu Cc: "David S. Miller" Cc: linu

Re: mmu.c:undefined reference to `patch__hash_page_A0'

2021-04-17 Thread Randy Dunlap
.a(decompress.o): in function `partial_decompress': decompress.c:(.text+0x1f0): undefined reference to `__decompress' when either CONFIG_KERNEL_LZO=y or CONFIG_KERNEL_LZMA=y but the build succeeds when either CONFIG_KERNEL_GZIP=y or CONFIG_KERNEL_XZ=y I guess that is due to arch/powerpc/boot/decompress.c doing this: #ifdef CONFIG_KERNEL_GZIP # include "decompress_inflate.c" #endif #ifdef CONFIG_KERNEL_XZ # include "xz_config.h" # include "../../../lib/decompress_unxz.c" #endif It would be nice to require one of KERNEL_GZIP or KERNEL_XZ to be set/enabled (maybe unless a uImage is being built?). ta. -- ~Randy

PPC_FPU, ALTIVEC: enable_kernel_fp, put_vr, get_vr

2021-04-17 Thread Randy Dunlap
.v); | ^~ Should the code + Kconfigs/Makefiles handle that kind of kernel config or should ALTIVEC always mean PPC_FPU as well? I have patches to fix the build errors with the config as reported but I don't know if that's the right thing to do... thanks. -- ~Randy

[PATCH net-next] net: xilinx: drivers need/depend on HAS_IOMEM

2021-04-16 Thread Randy Dunlap
ext+0x162e): undefined reference to `devm_platform_ioremap_resource' Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Radhey Shyam Pandey Cc: Gary Guo Cc: Zhang Changzhong Cc: And

[PATCH] of: linux/of.h: fix kernel-doc warnings

2021-04-16 Thread Randy Dunlap
perty_read_string_index' ../include/linux/of.h:1477: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * Overlay support Signed-off-by: Randy Dunlap Cc: Rob Herring Cc: Greg Kroah-Hartman --- include/lin

[PATCH -next] cfg80211: fix a few kernel-doc warnings

2021-04-16 Thread Randy Dunlap
cfg80211.h:6743: warning: missing initial short description on line: * cfg80211_vendor_cmd_get_sender Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: linux-wirel...@vger.kernel.org --- include/net/cfg80211.h | 11 +-- 1 file changed, 5

Re: linux-next: Tree for Apr 16 (IMA appraise causing build error)

2021-04-16 Thread Randy Dunlap
Hi, On 4/16/21 1:25 PM, Nayna wrote: > > On 4/16/21 2:53 PM, Randy Dunlap wrote: >> On 4/16/21 4:36 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20210415: >>> >> I noticed this build error message (on an i386 build): >

Re: linux-next: Tree for Apr 16 (IMA appraise causing build error)

2021-04-16 Thread Randy Dunlap
n do (or recommend) to prevent the build error? BTW, it looks like this: config IMA_APPRAISE_REQUIRE_MODULE_SIGS bool "Appraise kernel modules signatures" depends on IMA_APPRAISE_BUILD_POLICY could also depend on MODULES. Full i386 randconfig file is attached. thank

Re: linux-next: Tree for Apr 16 (objtool: warnings)

2021-04-16 Thread Randy Dunlap
h/x86/lib/retpoline.o: warning: objtool: __x86_indirect_alt_call_r15()+0x0: call without frame pointer save/setup = Enter/Return to continue; 'r' to remove = thanks. -- ~Randy Reported-by: Randy Dunlap

Re: Page BUGs

2021-04-16 Thread Randy Dunlap
On 4/16/21 10:29 AM, Randy Dunlap wrote: > On 4/16/21 10:20 AM, Drew Abbott wrote: >> Hello, >> >> I have been troubleshooting problems with the vanilla and lts linux kernels >> for a couple of weeks now and saw this mailing list in MAINTAINERS for >> problems wi

Re: Page BUGs

2021-04-16 Thread Randy Dunlap
JVueE3m > [7] http://0x0.st/-ATM.log [7] tells me: SyntaxError: JSON.parse: unexpected non-whitespace character after JSON data at line 1 column 16 of the JSON data -- ~Randy

[PATCH -next] drm: bridge: fix LONTIUM use of mipi_dsi_() functions

2021-04-15 Thread Randy Dunlap
] undefined! WARNING: modpost: suppressed 5 unresolved symbol warnings because there were too many) Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Fixes: 30e2ae943c26 (&qu

[PATCH -next] drm: bridge: fix ANX7625 use of mipi_dsi_() functions

2021-04-15 Thread Randy Dunlap
quot;mipi_dsi_detach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Xin Ji Cc: Sam Ravnborg Cc: dri-de...@lists.freedesktop.org Cc:

[PATCH v2] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Randy Dunlap
nd put one Kbuild file into it (since git does not track empty subdirs). Signed-off-by: Randy Dunlap Cc: Masahiro Yamada Cc: Michal Marek Cc: linux-kbu...@vger.kernel.org Cc: Jeff Dike Cc: Richard Weinberger Cc: Anton Ivanov Cc: linux...@lists.infradead.org --- v2: use Option 4 from v1: a

Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Randy Dunlap
On 4/15/21 12:04 AM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:02 PM Randy Dunlap wrote: >> >> On 4/14/21 11:52 PM, Masahiro Yamada wrote: >>> On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: >>>> >>>> Currently when using "W=1&qu

Re: [PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-15 Thread Randy Dunlap
On 4/14/21 11:52 PM, Masahiro Yamada wrote: > On Thu, Apr 15, 2021 at 4:27 AM Randy Dunlap wrote: >> >> Currently when using "W=1" with UML builds, there are over 700 warnings >> like so: >> >> CC arch/um/drivers/stderr_console.o >> cc1:

[PATCH] greybus: es2: fix kernel-doc warnings

2021-04-14 Thread Randy Dunlap
Fix these kernel-doc complaints: ../drivers/greybus/es2.c:79: warning: bad line: ../drivers/greybus/es2.c:100: warning: cannot understand function prototype: 'struct es2_ap_dev ' es2.c:126: warning: Function parameter or member 'cdsi1_in_use' not described in 'es2_ap_d

[PATCH] sound: virtio: correct the function name in kernel-doc comment

2021-04-14 Thread Randy Dunlap
Fix kernel-doc warning that the wrong function name is used in a kernel-doc comment: ../sound/virtio/virtio_ctl_msg.c:70: warning: expecting prototype for virtsnd_ctl_msg_request(). Prototype was for virtsnd_ctl_msg_response() instead Signed-off-by: Randy Dunlap Cc: Anton Yakovlev Cc

[PATCH] uml: fix W=1 missing-include-dirs warnings

2021-04-14 Thread Randy Dunlap
arch/um/include/uapi/ in USERINCLUDE for UML. Signed-off-by: Randy Dunlap Cc: Masahiro Yamada Cc: Michal Marek Cc: linux-kbu...@vger.kernel.org Cc: Jeff Dike Cc: Richard Weinberger Cc: Anton Ivanov Cc: linux...@lists.infradead.org --- Makefile | 10 ++ 1 file changed, 10 insertio

[PATCH 3/3] um: stub_32.h: move 'inline' before 'void' to fix W=1 warning

2021-04-13 Thread Randy Dunlap
Use the expected ordering of function modifier keywords. arch/x86/um/shared/sysdep/stub_32.h:80:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration] static void inline remap_stack_and_trap(void) ^~ Signed-off-by: Randy Dunlap Reported-by: kernel test robot

[PATCH 2/3] um: elf.h: fix W=1 warning for empty body in 'do' statement

2021-04-13 Thread Randy Dunlap
Use the common kernel style to eliminate a warning: ./arch/x86/um/asm/elf.h:215:32: warning: suggest braces around empty body in ‘do’ statement [-Wempty-body] #define SET_PERSONALITY(ex) do ; while(0) ^ Signed-off-by: Randy Dunlap Cc: Jeff Dike Cc: Richard

[PATCH 0/3] um: headers: fix various W=1 warnings

2021-04-13 Thread Randy Dunlap
Fix a few W=1 warnings in arch/um/. Prompted by the "kernel test robot". Cc: Jeff Dike Cc: Richard Weinberger Cc: Anton Ivanov Cc: linux...@lists.infradead.org [PATCH 1/3] um: pgtable.h: fix W=1 warning for empty body in 'do' statement [PATCH 2/3] um: elf.h: fix W=1 warning for empty body in

[PATCH 1/3] um: pgtable.h: fix W=1 warning for empty body in 'do' statement

2021-04-13 Thread Randy Dunlap
: note: in expansion of macro ‘update_mmu_cache’ update_mmu_cache(vma, addr, vmf->pte); ^~~~ Signed-off-by: Randy Dunlap Cc: Jeff Dike Cc: Richard Weinberger Cc: Anton Ivanov Cc: linux...@lists.infradead.org --- arch/um/include/asm/pgtable.h |2 +- 1 file changed

Re: mmotm 2021-04-11-20-47 uploaded (bpf: xsk.c)

2021-04-13 Thread Randy Dunlap
On 4/13/21 3:18 PM, Andrii Nakryiko wrote: > On Mon, Apr 12, 2021 at 9:38 AM Randy Dunlap wrote: >> >> On 4/11/21 8:48 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2021-04-11-20-47 has been uploaded to >>> >>>https:/

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-13 Thread Randy Dunlap
On 4/13/21 11:23 AM, Mike Rapoport wrote: > On Tue, Apr 13, 2021 at 10:34:25AM -0700, Randy Dunlap wrote: >> On 4/13/21 9:58 AM, Mike Rapoport wrote: >> >> Mike, >> That works. >> >> Please send the next test. > > I think I've found the r

Re: [PATCH] lib: remove "expecting prototype" kernel-doc warnings

2021-04-13 Thread Randy Dunlap
On 4/13/21 11:18 AM, Andrew Morton wrote: > On Sun, 11 Apr 2021 15:17:56 -0700 Randy Dunlap wrote: > >> Fix various kernel-doc warnings in lib/ due to missing or >> erroneous function names. >> Add kernel-doc for some function parameters that was missing. >> Use ke

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-13 Thread Randy Dunlap
On 4/13/21 9:58 AM, Mike Rapoport wrote: > On Mon, Apr 12, 2021 at 11:21:48PM -0700, Randy Dunlap wrote: >> On 4/12/21 11:06 PM, Mike Rapoport wrote: >>> Hi Randy, >>> >>> On Mon, Apr 12, 2021 at 01:53:34PM -0700, Randy Dunlap wrote: >>>> On 4/12/21

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-12 Thread Randy Dunlap
On 4/12/21 11:06 PM, Mike Rapoport wrote: > Hi Randy, > > On Mon, Apr 12, 2021 at 01:53:34PM -0700, Randy Dunlap wrote: >> On 4/12/21 10:01 AM, Mike Rapoport wrote: >>> On Mon, Apr 12, 2021 at 08:49:49AM -0700, Randy Dunlap wrote: >>> >>> I thought abou

x86: report: write to unrecognized MSR

2021-04-12 Thread Randy Dunlap
[ 27.075563] msr: Write to unrecognized MSR 0x1b0 by x86_energy_perf (pid: 1223). [ 27.078979] msr: See https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/about for details. (aka x86_energy_perf_policy) on linux-next-20210409 / x86_64. -- ~Randy

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-12 Thread Randy Dunlap
On 4/12/21 10:01 AM, Mike Rapoport wrote: > On Mon, Apr 12, 2021 at 08:49:49AM -0700, Randy Dunlap wrote: >> On 4/11/21 11:14 PM, Mike Rapoport wrote: >>> Hi Randy, >>> >>> On Sun, Apr 11, 2021 at 07:41:37PM -0700, Randy Dunlap wrote: >>>> On 4/9/

Re: /usr/bin/ld: atomic64_test.c:undefined reference to `atomic64_add_unless_386'

2021-04-12 Thread Randy Dunlap
6' >/usr/bin/ld: > kernel/time/posix-cpu-timers.o:posix-cpu-timers.c:(.text+0x239a): more > undefined references to `atomic64_read_386' follow >/usr/bin/ld: kernel/trace/trace_clock.o: in function `trace_clock_counter': >trace_clock.c:(.text+0x102): undefined reference to > `atomic64_add_return_386' >/usr/bin/ld: kernel/bpf/core.o: in function `___bpf_prog_run': >core.c:(.text+0x2691): undefined reference to `atomic64_add_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function > `__bpf_prog_get.constprop.0': >syscall.c:(.text+0x1028): undefined reference to `atomic64_inc_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function > `__bpf_prog_put.constprop.0': >syscall.c:(.text+0x108c): undefined reference to `atomic64_dec_return_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `__bpf_map_put.constprop.0': >syscall.c:(.text+0x55a9): undefined reference to `atomic64_dec_return_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_map_put_with_uref': >syscall.c:(.text+0x566e): undefined reference to `atomic64_dec_return_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `map_create': >syscall.c:(.text+0x59c6): undefined reference to `atomic64_set_386' >/usr/bin/ld: syscall.c:(.text+0x59d1): undefined reference to > `atomic64_set_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_prog_load': >syscall.c:(.text+0x65f6): undefined reference to `atomic64_set_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_map_inc': >syscall.c:(.text+0x6e47): undefined reference to `atomic64_inc_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_map_inc_with_uref': >syscall.c:(.text+0x6e61): undefined reference to `atomic64_inc_386' >/usr/bin/ld: syscall.c:(.text+0x6e69): undefined reference to > `atomic64_inc_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_map_get': >syscall.c:(.text+0x6f1e): undefined reference to `atomic64_inc_386' >/usr/bin/ld: kernel/bpf/syscall.o: in function `bpf_map_get_with_uref': This patch fixes it for me: https://lore.kernel.org/lkml/9f7eeb70-8ddc-fb04-a378-5f1e80d48...@infradead.org/ -- ~Randy

Re: mmotm 2021-04-11-20-47 uploaded (ni_routes_test.c)

2021-04-12 Thread Randy Dunlap
drivers/staging/comedi/drivers/tests/ni_routes_test.o: in function `test_route_register_is_valid': ni_routes_test.c:(.text+0x115a): undefined reference to `ni_find_route_source' ld: ni_routes_test.c:(.text+0x118e): undefined reference to `ni_find_route_source' ld: ni_routes_test.c:(

Re: mmotm 2021-04-11-20-47 uploaded (bpf: xsk.c)

2021-04-12 Thread Randy Dunlap
alse; ^ xsk.c:1028:30: error: redefinition of ‘tx_setup_done’ bool rx_setup_done = false, tx_setup_done = false; ^ xsk.c:1020:37: note: previous definition of ‘tx_setup_done’ was here bool unmap, rx_setup_done = false, tx_setup_done = false;

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-12 Thread Randy Dunlap
On 4/11/21 11:14 PM, Mike Rapoport wrote: > Hi Randy, > > On Sun, Apr 11, 2021 at 07:41:37PM -0700, Randy Dunlap wrote: >> On 4/9/21 4:51 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20210408: >>> >> >> Hi, >

Re: mmotm 2021-04-11-20-47 uploaded (fs/io_uring.c)

2021-04-12 Thread Randy Dunlap
On 4/12/21 5:39 AM, Jens Axboe wrote: > On 4/12/21 1:21 AM, Randy Dunlap wrote: >> On 4/11/21 8:48 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2021-04-11-20-47 has been uploaded to >>> >>>https://www.ozlabs.org/~akpm/

Re: mmotm 2021-04-11-20-47 uploaded (fs/io_uring.c)

2021-04-12 Thread Randy Dunlap
tion ‘kiocb_done’: ../fs/io_uring.c:2766:7: error: implicit declaration of function ‘io_resubmit_prep’; did you mean ‘io_put_req’? [-Werror=implicit-function-declaration] if (io_resubmit_prep(req)) { -- ~Randy Reported-by: Randy Dunlap

Re: linux-next: Tree for Apr 9 (x86 boot problem)

2021-04-11 Thread Randy Dunlap
everal reservations of start of memory There is no (zero, nil) console display when I try to boot next 0408 or 0409. I connected a USB serial debug cable and booted with earlyprintk=dbgp,keep and still got nothing. The attached boot log is linux-next 20210409 minus the 2 patches listed above. Mike- what data would you like to see? -- ~Randy Reported-by: Randy Dunlap boot0409-2.log.gz Description: application/gzip

[PATCH] security: commoncap: clean up kernel-doc comments

2021-04-11 Thread Randy Dunlap
c:1206: warning: expecting prototype for cap_task_ioprio(). Prototype was for cap_task_setioprio() instead ../security/commoncap.c:1219: warning: expecting prototype for cap_task_ioprio(). Prototype was for cap_task_setnice() instead Signed-off-by: Randy Dunlap Cc: Serge Hallyn Cc: James Mo

[PATCH] crypto: fix kernel-doc notation in chacha.c and af_alg.c

2021-04-11 Thread Randy Dunlap
or member 'areqlen' not described in 'af_alg_alloc_areq' af_alg.c:1146: warning: Function parameter or member 'sk' not described in 'af_alg_get_rsgl' af_alg.c:1146: warning: Function parameter or member 'msg' not described in 'af_alg_get_rsgl'

[PATCH] lib: remove "expecting prototype" kernel-doc warnings

2021-04-11 Thread Randy Dunlap
ext_bit' radix-tree.c:931: warning: Function parameter or member 'iter' not described in 'radix_tree_iter_replace' Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Philipp Reisner Cc: Lars Ellenberg Cc: drbd-...@lists.linbit.com Cc: Jiri Pirko Cc: net...@vger.kernel.o

[PATCH v2] mm: eliminate "expecting prototype" kernel-doc warnings

2021-04-11 Thread Randy Dunlap
Check whether unreclaimable slab amount is greater than(). Prototype was for should_dump_unreclaim_slab() instead ../mm/shuffle.c:155: warning: expecting prototype for shuffle_free_memory(). Prototype was for __shuffle_free_memory() instead Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: linux

Re: [PATCH] mm: eliminate "expecting prototype" kernel-doc warnings

2021-04-11 Thread Randy Dunlap
On 4/11/21 11:35 AM, Matthew Wilcox wrote: > On Sun, Apr 11, 2021 at 10:43:21AM -0700, Randy Dunlap wrote: >> +++ linux-next-20210409/mm/mmu_gather.c >> @@ -250,7 +250,7 @@ void tlb_flush_mmu(struct mmu_gather *tl >> } >> >> /** >> - * tlb_gather_mmu -

[PATCH] mm: eliminate "expecting prototype" kernel-doc warnings

2021-04-11 Thread Randy Dunlap
Check whether unreclaimable slab amount is greater than(). Prototype was for should_dump_unreclaim_slab() instead ../mm/shuffle.c:155: warning: expecting prototype for shuffle_free_memory(). Prototype was for __shuffle_free_memory() instead Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: linux

[PATCH] csky: fix syscache.c fallthrough warning

2021-04-11 Thread Randy Dunlap
case DCACHE: | ^~~~ Fixes: 997153b9a75c ("csky: Add flush_icache_mm to defer flush icache all") Signed-off-by: Randy Dunlap Cc: Guo Ren Cc: linux-c...@vger.kernel.org Cc: Arnd Bergmann --- @Guo, should this be a "break" instead of fallthrough? arch/csky/mm/syscache.c |

Re: [PATCH] PCI: endpoint: fix incorrect kernel-doc comment syntax

2021-04-11 Thread Randy Dunlap
ith general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Acked-by: Randy Dunlap Thanks. > --- > include/linux/pci-ep-cfs.h | 2 +- > include/linux/pci-epc.h| 2 +- > include/linux/pci-epf.h| 2

Re: [PATCH 1/1] iommu/vt-d: Fix build error of pasid_enable_wpe() with !X86

2021-04-10 Thread Randy Dunlap
27;unlikely' > 78 | # define unlikely(x) __builtin_expect(!!(x), 0) > | > > Add the missing dependency. > > Cc: Sanjay Kumar > Cc: Jacob Pan > Cc: Randy Dunlap > Reported-by: kernel test robot > Reported-by: Randy Dunlap > Fixes: f68c7f539b6e9 (

[PATCH RESEND] csky: change a Kconfig symbol name to fix e1000 build error

2021-04-10 Thread Randy Dunlap
e1000's #define of CONFIG_RAM_BASE conflicts with a Kconfig symbol in arch/csky/Kconfig. The symbol in e1000 has been around longer, so change arch/csky/ to use DRAM_BASE instead of RAM_BASE to remove the conflict. (although e1000 is also a 2-line change) Now build-tested. Signed-off-by:

Re: arch/csky/mm/tcm.c:9:2: error: #error "You should define ITCM_RAM_BASE"

2021-04-10 Thread Randy Dunlap
t-val ITCM_RAM_BASE 0xe000 if you want to modify some file other than ".config". (0xe00 is an arbitrary value here -- just cannot be 0x.) Then run "make oldconfig" and "make all" or however you normally build a kernel. It looks like the Kconfig file's ITCM_RAM_BASE parameter is expected to be set/modified by the user. The default value of 0x is invalid. -- ~Randy

[PATCH RESENDbis] ia64: remove duplicate entries in generic_defconfig

2021-04-10 Thread Randy Dunlap
value as in the removed lines. Fixes: c331649e6371 ("ia64: Use libata instead of the legacy ide driver in defconfigs") Reported-by: Geert Uytterhoeven Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Christoph Hellwig Cc: Tony Luck Cc: linux-i...@vger.kernel.org Reviewed-by: C

[PATCH] ia64: fix discontig.c section mismatches

2021-04-10 Thread Randy Dunlap
or the annotation of early_nr_cpus_node is wrong. Signed-off-by: Randy Dunlap Cc: Mike Rapoport Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-i...@vger.kernel.org --- arch/ia64/mm/discontig.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- linux-next-20210409.orig/arch

Re: linux-next: Tree for Apr 9 (drivers/iommu/intel/pasid.c)

2021-04-10 Thread Randy Dunlap
unction it appears in 557 | if (unlikely(!(cr0 & X86_CR0_WP))) { | ^~ ../include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ -- ~Randy Reported-by: Randy Dunlap

Re: [PATCH] um: add 2 missing libs to fix various build errors

2021-04-09 Thread Randy Dunlap
On 4/4/21 11:20 AM, Randy Dunlap wrote: > Fix many build errors (at least 18 build error reports) for uml on i386 > by adding 2 more library object files. All missing symbols are > either cmpxchg8b_emu or atomic*386. > > Here are a few examples of the build errors that

Re: [PATCH v2] drm/bridge/sii8620: fix dependency on extcon

2021-04-09 Thread Randy Dunlap
drivers/video/fbdev/Kconfig:63: symbol FB_DDC depends on FB drivers/video/fbdev/Kconfig:12: symbol FB is selected by DRM_KMS_FB_HELPER drivers/gpu/drm/Kconfig:83: symbol DRM_KMS_FB_HELPER depends on DRM_KMS_HELPER For a resolution refer to Documentation/kbuild/kconfig-language.rst subsection "Kconfig recursive dependency limitations" -- ~Randy

Re: [PATCH 5/5] x86/speculation: Add PSF mitigation kernel parameters

2021-04-08 Thread Randy Dunlap
disable PSF unless they opt out. > + > +Default mitigations: > +[X86] If CONFIG_SECCOMP=y "seccomp" else "prctl" > + > psi=[KNL] Enable or disable pressure stall information > tracking. > Format: > -- ~Randy

Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Randy Dunlap
On 4/8/21 3:58 PM, Dexuan Cui wrote: > Changes in v3: > Changed the Kconfig file: > Microsoft Azure Network Device ==> Microsoft Network Devices > Drop the default m > validated ==> supported Hi, I am satisfied with the Kconfig changes. thanks. -- ~Randy

Re: [PATCH v2 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-08 Thread Randy Dunlap
t; + This driver supports Microsoft Azure Network Adapter (MANA). > + So far, the driver is only validated on X86_64. validated how? > + > + To compile this driver as a module, choose M here. > + The module will be called mana. > + > +endif #NET_VENDOR_MICROSOFT thanks. -- ~Randy

Re: undefined reference to `cmpxchg8b_emu'

2021-04-07 Thread Randy Dunlap
> make W=1 ARCH=um > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > Hi robot, Can you test a patch? https://lore.kernel.org/lkml/20210404182044.9918-1-rdun...@infradead.org/ thanks. -- ~Randy

[PATCH] lib: parser: clean up kernel-doc

2021-04-06 Thread Randy Dunlap
Mark match_uint() as kernel-doc notation since it is already fully annotated as such. Use % prefix on constants in kernel-doc comments. Convert function return descriptions to use the "Return:" kernel-doc notation. Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Alexander Viro

[PATCH] vfs: fs_parser: clean up kernel-doc warnings

2021-04-06 Thread Randy Dunlap
27;fs_validate_description' Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: Alexander Viro Cc: David Howells Cc: linux-fsde...@vger.kernel.org --- fs/fs_parser.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20210406.orig/fs/fs_parser.c +++ linux-next-

  1   2   3   4   5   6   7   8   9   10   >