Re: [PATCH] powerpc/asm-offsets: GPR14 is not needed either

2021-03-24 Thread Rashmica Gupta
it was never used either, so remove it as well. > Looks good to me. Reviewed-by: Rashmica Gupta > Fixes: aac6a91fea93 ("powerpc/asm: Remove unused symbols in asm- > offsets.c") > Cc: Rashmica Gupta > Signed-off-by: Christophe Leroy > --- > arch/powerpc/

[PATCH v3 5/5] gpio: Add in ast2600 details to Aspeed driver

2019-09-06 Thread Rashmica Gupta
of the 3.3V GPIOs are all bidirectional, we can use the same configuration struct and use the ngpio property to differentiate between the two sets of GPIOs. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions

[PATCH v3 4/5] gpios: Use ngpio property from device tree if available

2019-09-06 Thread Rashmica Gupta
to different between them as they have different numbers of GPIOs. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 16c6eaf70857

[PATCH v3 2/5] gpio/aspeed: Fix incorrect number of banks

2019-09-06 Thread Rashmica Gupta
The current calculation for the number of GPIO banks is only correct if the number of GPIOs is a multiple of 32 (if there were 31 GPIOs we would currently say there are 0 banks, which is incorrect). Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta Reviewed

[PATCH v3 3/5] gpio/aspeed: Setup irqchip dynamically

2019-09-06 Thread Rashmica Gupta
This is in preparation for adding ast2600 support. The ast2600 SoC requires two instances of the GPIO driver as it has two GPIO controllers. Each instance needs it's own irqchip. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 16 +++- 1 file changed, 7 insertions

[PATCH v3 0/5] Add ast2600 gpio support

2019-09-06 Thread Rashmica Gupta
v3: Different ordering of patches, using ngpio property to distinguish between the two ast2600 gpio controllers, fixed typos of 3.6V. v2: More verbose commit messages, using DIV_ROUND_UP(). Rashmica Gupta (5): dt-bindings: gpio: aspeed: Update documentation with ast2600 controllers gpio

[PATCH v3 1/5] dt-bindings: gpio: aspeed: Update documentation with ast2600 controllers

2019-09-06 Thread Rashmica Gupta
The ast2600 is a new generation of SoC from ASPEED. Similarly to the ast2400 and ast2500, it has a GPIO controller for it's 3.3V GPIO pins. Additionally, it has a GPIO controller for 36 1.8V GPIO pins. We use the ngpio property to differentiate between these controllers. Signed-off-by: Rashmica

Re: [PATCH v2 3/4] gpio: Add in ast2600 details to Aspeed driver

2019-09-05 Thread Rashmica Gupta
On Thu, 2019-09-05 at 13:27 +0930, Andrew Jeffery wrote: > > On Thu, 5 Sep 2019, at 10:47, Rashmica Gupta wrote: > > The ast2600 is a new generation of SoC from ASPEED. Similarly to > > the > > ast2400 and ast2500, it has a GPIO controller for it's 3.6V GPIO > >

[PATCH v2 3/4] gpio: Add in ast2600 details to Aspeed driver

2019-09-04 Thread Rashmica Gupta
for them. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 16c6eaf70857..4723b8780a8c 100644 --- a/drivers/gpio/gpio

[PATCH v2 4/4] gpio: dt-bindings: Update documentation with ast2600 controllers

2019-09-04 Thread Rashmica Gupta
for them. Signed-off-by: Rashmica Gupta --- Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt index

[PATCH v2 2/4] gpio/aspeed: Setup irqchip dynamically

2019-09-04 Thread Rashmica Gupta
This is in preparation for adding ast2600 support. The ast2600 requires two GPIO drivers which each need their own irqchip. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio

[PATCH v2 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-04 Thread Rashmica Gupta
The current calculation for the number of GPIO banks is only correct if the number of GPIOs is a multiple of 32 (if there were 31 GPIOs we would currently say there are 0 banks, which is incorrect). Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta --- drivers/gpio

[PATCH v2 0/4] Add ast2600 gpio support

2019-09-04 Thread Rashmica Gupta
v2: More verbose commit messages, using DIV_ROUND_UP(). Rashmica Gupta (4): gpio/aspeed: Fix incorrect number of banks gpio/aspeed: Setup irqchip dynamically gpio: Add in ast2600 details to Aspeed driver gpio: dt-bindings: Update documentation with ast2600 controllers drivers/gpio/gpio

Re: [PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver

2019-09-04 Thread Rashmica Gupta
On Wed, 2019-09-04 at 19:30 +0300, Andy Shevchenko wrote: > On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta > wrote: > > The ast2600 has two gpio controllers, one for 3.6V GPIOS and one > > for 1.8V GPIOS. > > > > Signed-off-by: Rashmica Gupta > >

Re: [PATCH 4/4] gpio: Update documentation with ast2600 controllers

2019-09-04 Thread Rashmica Gupta
On Wed, 2019-09-04 at 09:02 +0200, Bartosz Golaszewski wrote: > śr., 4 wrz 2019 o 08:13 Rashmica Gupta > napisał(a): > > Again, this needs a proper commit description I figured as similar patches have gone through with just the one line and there isn't anything more to say that

Re: [PATCH 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-04 Thread Rashmica Gupta
On Wed, 2019-09-04 at 19:27 +0300, Andy Shevchenko wrote: > On Wed, Sep 4, 2019 at 9:14 AM Rashmica Gupta > wrote: > > Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') > > > > Signed-off-by: Rashmica Gupta > > /* Allocate a cache of the output registe

[PATCH 1/4] gpio/aspeed: Fix incorrect number of banks

2019-09-04 Thread Rashmica Gupta
Fixes: 361b79119a4b7 ('gpio: Add Aspeed driver') Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 9defe25d4721..77752b2624e8 100644 --- a/drivers/gpio

[PATCH 4/4] gpio: Update documentation with ast2600 controllers

2019-09-04 Thread Rashmica Gupta
Signed-off-by: Rashmica Gupta --- Documentation/devicetree/bindings/gpio/gpio-aspeed.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt b/Documentation/devicetree/bindings/gpio/gpio-aspeed.txt index 7e9b586770b0

[PATCH 3/4] gpio: Add in ast2600 details to Aspeed driver

2019-09-04 Thread Rashmica Gupta
The ast2600 has two gpio controllers, one for 3.6V GPIOS and one for 1.8V GPIOS. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio

[PATCH 2/4] gpio/aspeed: Setup irqchip dynamically

2019-09-04 Thread Rashmica Gupta
This is in preparation for ast2600 as we will have two gpio drivers which need their own irqchip. Signed-off-by: Rashmica Gupta --- drivers/gpio/gpio-aspeed.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-31 Thread Rashmica Gupta
On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: > [...] > > > 2) Why it was designed, what is the goal of the interface? > > > 3) When it is supposed to be used? > > > > > > > > There is a

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-30 Thread Rashmica Gupta
On Mon, 2019-07-29 at 10:06 +0200, David Hildenbrand wrote: > > > Of course, other interfaces might make sense. > > > > > > You can then start using these memory blocks and hinder them from > > > getting onlined (as a safety net) via memory notifiers. > > > > > > That would at least avoid you

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-30 Thread Rashmica Gupta
On Mon, 2019-07-29 at 10:06 +0200, David Hildenbrand wrote: > > > Of course, other interfaces might make sense. > > > > > > You can then start using these memory blocks and hinder them from > > > getting onlined (as a safety net) via memory notifiers. > > > > > > That would at least avoid you

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-28 Thread Rashmica Gupta
On Tue, 2019-07-16 at 14:28 +0200, David Hildenbrand wrote: > On 02.07.19 08:42, Rashmica Gupta wrote: > > Hi David, > > > > Sorry for the late reply. > > Hi, > > sorry I was on PTO :) > > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrot

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-09 Thread Rashmica Gupta
Woops, looks like my phone doesn't send plain text emails :/ On Tue, Jul 2, 2019 at 6:52 PM Rashmica Gupta wrote: > > On Tue, Jul 2, 2019 at 5:48 PM Oscar Salvador wrote: >> >> On Tue, Jul 02, 2019 at 04:42:34PM +1000, Rashmica Gupta wrote: >> > Hi David, >>

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-02 Thread Rashmica Gupta
Hi David, Sorry for the late reply. On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: > On 26.06.19 10:15, Oscar Salvador wrote: > > On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: > > > Back then, I already mentioned that we might have some users that > > >

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > [...] >> Most memory hotplug/hotremove seems to be block or section based, and >> always adds and removes memory at the same place. > > Yes and that is hard wired to

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:00 PM, Michal Hocko wrote: > On Fri 10-08-18 16:55:40, Rashmica Gupta wrote: > [...] >> Most memory hotplug/hotremove seems to be block or section based, and >> always adds and removes memory at the same place. > > Yes and that is hard wired to

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton wrote: > On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta > wrote: > >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-delet

Re: [PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-10 Thread Rashmica Gupta
On Fri, Aug 10, 2018 at 11:12 AM, Andrew Morton wrote: > On Thu, 9 Aug 2018 12:54:09 +1000 Rashmica Gupta > wrote: > >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-delet

[PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-08 Thread Rashmica Gupta
a resource in add_memory(). It calls request_resource_conflict() and if hot-removing is enabled (if it isn't we won't get resource fragmentation) we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- v2->v3: Update Xen balloon, make the commit msg and a comm

[PATCH v3] resource: Merge resources on a node when hot-adding memory

2018-08-08 Thread Rashmica Gupta
a resource in add_memory(). It calls request_resource_conflict() and if hot-removing is enabled (if it isn't we won't get resource fragmentation) we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- v2->v3: Update Xen balloon, make the commit msg and a comm

Re: [PATCH v2] resource: Merge resources on a node when hot-adding memory

2018-08-07 Thread Rashmica Gupta
On Tue, Aug 7, 2018 at 9:52 PM, Vlastimil Babka wrote: > On 08/06/2018 08:52 AM, Rashmica Gupta wrote: >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-deleted. Adding this memo

Re: [PATCH v2] resource: Merge resources on a node when hot-adding memory

2018-08-07 Thread Rashmica Gupta
On Tue, Aug 7, 2018 at 9:52 PM, Vlastimil Babka wrote: > On 08/06/2018 08:52 AM, Rashmica Gupta wrote: >> When hot-removing memory release_mem_region_adjustable() splits >> iomem resources if they are not the exact size of the memory being >> hot-deleted. Adding this memo

[PATCH v2] resource: Merge resources on a node when hot-adding memory

2018-08-06 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if hot-removing is enabled (if it isn't we won't get resource fragmentation) we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- v1->v2: Only attempt to merge resources if hot-rem

[PATCH v2] resource: Merge resources on a node when hot-adding memory

2018-08-06 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if hot-removing is enabled (if it isn't we won't get resource fragmentation) we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- v1->v2: Only attempt to merge resources if hot-rem

[RESEND PATCH] resource: Merge resources on a node when hot-adding memory

2018-08-03 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if there are no conflicts we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- [Resending because there is no second patch. Don't send patches on Friday afternoons...] include/linux

[RESEND PATCH] resource: Merge resources on a node when hot-adding memory

2018-08-03 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if there are no conflicts we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- [Resending because there is no second patch. Don't send patches on Friday afternoons...] include/linux

[PATCH 1/2] resource: Merge resources on a node when hot-adding memory

2018-08-03 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if there are no conflicts we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- include/linux/ioport.h | 2 + include/linux/memory_hotplug.h | 2 +- kernel/resource.c

[PATCH 1/2] resource: Merge resources on a node when hot-adding memory

2018-08-03 Thread Rashmica Gupta
registering a resource in add_memory(). It calls request_resource_conflict() and if there are no conflicts we attempt to merge contiguous resources on the node. Signed-off-by: Rashmica Gupta --- include/linux/ioport.h | 2 + include/linux/memory_hotplug.h | 2 +- kernel/resource.c