Re: [PATCH v11 0/2] Add Intel LGM SoC DMA support

2021-01-19 Thread Reddy, MallikarjunaX
Ok Vinod. Thanks, Mallikarjuna reddy A On 1/17/2021 1:57 PM, Vinod Koul wrote: On 15-01-21, 17:56, Amireddy Mallikarjuna reddy wrote: Add DMA controller driver for Lightning Mountain (LGM) family of SoCs. The main function of the DMA controller is the transfer of data from/to any peripheral t

Re: [RESEND PATCH v10 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2021-01-15 Thread Reddy, MallikarjunaX
Sure Rob. Thanks, Mallikarjuna reddy A On 1/15/2021 4:25 AM, Rob Herring wrote: On Tue, Dec 15, 2020 at 10:08 PM Amireddy Mallikarjuna reddy wrote: Add DT bindings YAML schema for DMA controller driver of Lightning Mountain (LGM) SoC. Signed-off-by: Amireddy Mallikarjuna reddy Reviewed-by:

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-29 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for your valuable comments. My reply inline. On 11/26/2020 12:50 PM, Vinod Koul wrote: On 25-11-20, 18:39, Reddy, MallikarjunaX wrote: desc needs to be configure for each dma channel and the remapped address of the IGP & EGP is desc base adress. Why should this address

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-25 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for your review comments, My comments inline. On 11/25/2020 1:23 AM, Vinod Koul wrote: On 24-11-20, 00:30, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for your valuable review. My comments inline. On 11/21/2020 8:19 PM, Vinod Koul wrote: On 20-11-20, 19:30, Reddy

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-25 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review comments, my comments inline. On 11/25/2020 1:21 AM, Vinod Koul wrote: On 24-11-20, 00:29, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for your valuable review comments. Please see my comments inline. On 11/21/2020 8:17 PM, Vinod Koul wrote: On 20-11-20, 19

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-23 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for your valuable review. My comments inline. On 11/21/2020 8:19 PM, Vinod Koul wrote: On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for the review. My comments inline. On 11/18/2020 11:55 PM, Vinod Koul wrote: On 12-11-20, 13:38, Amireddy Mallikarjuna

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-23 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for your valuable review comments. Please see my comments inline. On 11/21/2020 8:17 PM, Vinod Koul wrote: On 20-11-20, 19:30, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for the review. My comments inline. On 11/19/2020 1:38 AM, Vinod Koul wrote: On 12-11-20, 13:38

Re: [PATCH v9 1/2] dt-bindings: dma: Add bindings for Intel LGM SoC

2020-11-20 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review. My comments inline. On 11/18/2020 11:55 PM, Vinod Koul wrote: On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: Add DT bindings YAML schema for DMA controller driver of Lightning Mountain (LGM) SoC. Signed-off-by: Amireddy Mallikarjuna reddy --- v1: - Ini

Re: [PATCH v9 2/2] Add Intel LGM SoC DMA support.

2020-11-20 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review. My comments inline. On 11/19/2020 1:38 AM, Vinod Koul wrote: On 12-11-20, 13:38, Amireddy Mallikarjuna reddy wrote: Add DMA controller driver for Lightning Mountain (LGM) family of SoCs. The main function of the DMA controller is the transfer of data from/to a

Re: [PATCH v7 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-11-11 Thread Reddy, MallikarjunaX
Hi Thomas, On 11/11/2020 1:39 AM, Thomas Langer wrote: -Original Message- From: Reddy, MallikarjunaX Sent: Montag, 2. November 2020 15:42 To: Thomas Langer ; dmaeng...@vger.kernel.org; vk...@kernel.org; devicet...@vger.kernel.org; robh...@kernel.org Cc: linux-kernel@vger.kernel.org

Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC

2020-11-11 Thread Reddy, MallikarjunaX
Hi Pavel, Thanks for your valuable comments, Please see my comments inline. On 11/5/2020 5:52 PM, Pavel Machek wrote: On Thu 2020-11-05 17:43:50, Amireddy Mallikarjuna reddy wrote: Add DT bindings YAML schema for SSO controller driver of Lightning Mountain(LGM) SoC. intel -> Intel in the tit

Re: [PATCH v1 2/2] leds: lgm: Add LED controller driver for LGM Soc

2020-11-11 Thread Reddy, MallikarjunaX
Hi Pavel, Thanks for your valuable comments. My comments inline. On 11/5/2020 6:11 PM, Pavel Machek wrote: Hi! diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index ed943140e1fd..6445b39fe4fc 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -886,6 +886,16 @@ config LED

Re: [PATCH v7 2/2] Add Intel LGM soc DMA support.

2020-11-02 Thread Reddy, MallikarjunaX
Hi Thomas, Thanks for valuable review, My comments inline. On 10/28/2020 3:24 AM, Thomas Langer wrote: Hello Reddy, some comments below. I only commented regarding some structural things, as I am not so familiar with the functional side of DMA. -Original Message- From: Amireddy Mallik

Re: [PATCH v7 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-11-02 Thread Reddy, MallikarjunaX
Hi Thomas, Thanks for the review, my comments inline. On 10/28/2020 3:24 AM, Thomas Langer wrote: Hello Reddy, I think "Intel" should always be written with a capital "I" (like in the Subject, but except in the binding below) OK. + compatible: + oneOf: + - const: intel,lgm-cdma + - co

Re: [PATCH v6 2/2] Add Intel LGM soc DMA support.

2020-09-21 Thread Reddy, MallikarjunaX
Hi Andy, Thanks for your comments. My comments are in line. On 9/18/2020 8:20 PM, Andy Shevchenko wrote: On Fri, Sep 18, 2020 at 11:42:54AM +0800, Reddy, MallikarjunaX wrote: On 9/9/2020 7:14 PM, Andy Shevchenko wrote: On Wed, Sep 09, 2020 at 07:07:34AM +0800, Amireddy Mallikarjuna reddy

Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

2020-09-07 Thread Reddy, MallikarjunaX
Hi Peter, Thanks for the review, please see my comment inline.. On 9/4/2020 2:31 PM, Peter Ujfalusi wrote: On 31/08/2020 11.07, Reddy, MallikarjunaX wrote: On 8/28/2020 7:17 PM, Peter Ujfalusi wrote: Hi, On 27/08/2020 17.41, Reddy, MallikarjunaX wrote: + +    dma_dev

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-09-07 Thread Reddy, MallikarjunaX
On 9/4/2020 2:31 PM, Peter Ujfalusi wrote: On 18/08/2020 10.00, Reddy, MallikarjunaX wrote: Hi Rob, Thanks for your valuable comments. Please see my comments inline.. On 8/15/2020 4:32 AM, Rob Herring wrote: On Fri, Aug 14, 2020 at 01:26:09PM +0800, Amireddy Mallikarjuna reddy wrote: Add

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-09-01 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review, please see my comments inline. On 8/31/2020 7:00 PM, Vinod Koul wrote: On 31-08-20, 16:06, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for the review. Please see my comment inline. On 8/28/2020 6:45 PM, Vinod Koul wrote: On 27-08-20, 17:54, Reddy

Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

2020-08-31 Thread Reddy, MallikarjunaX
On 8/28/2020 7:17 PM, Peter Ujfalusi wrote: Hi, On 27/08/2020 17.41, Reddy, MallikarjunaX wrote: + +    dma_dev->device_alloc_chan_resources = +    d->inst->ops->device_alloc_chan_resources; +    dma_dev->device_free_chan_resources = +    d->inst->ops->de

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-31 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review. Please see my comment inline. On 8/28/2020 6:45 PM, Vinod Koul wrote: On 27-08-20, 17:54, Reddy, MallikarjunaX wrote: Hi Vinod, Thanks for the review comments. On 8/25/2020 7:21 PM, Vinod Koul wrote: On 18-08-20, 15:00, Reddy, MallikarjunaX wrote

Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

2020-08-27 Thread Reddy, MallikarjunaX
Hi Peter, Thank you very much for the review and detailed explanation, i will take the inputs and update in the next patch. My comments inline.. On 8/24/2020 7:24 PM, Peter Ujfalusi wrote: Hi, On 24/08/2020 5.30, Reddy, MallikarjunaX wrote: +static void dma_free_desc_resource(struct

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-27 Thread Reddy, MallikarjunaX
Hi Vinod, Thanks for the review comments. On 8/25/2020 7:21 PM, Vinod Koul wrote: On 18-08-20, 15:00, Reddy, MallikarjunaX wrote: + +intel,chans: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + The channels included

Re: [PATCH v5 2/2] Add Intel LGM soc DMA support.

2020-08-23 Thread Reddy, MallikarjunaX
Hi Peter, Thanks for the review comments. Please see my comments inline.. On 8/18/2020 6:16 PM, Peter Ujfalusi wrote: Hi, On 14/08/2020 8.26, Amireddy Mallikarjuna reddy wrote: Add DMA controller driver for Lightning Mountain(LGM) family of SoCs. The main function of the DMA controller is the

Re: [PATCH v5 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-08-18 Thread Reddy, MallikarjunaX
Hi Rob, Thanks for your valuable comments. Please see my comments inline.. On 8/15/2020 4:32 AM, Rob Herring wrote: On Fri, Aug 14, 2020 at 01:26:09PM +0800, Amireddy Mallikarjuna reddy wrote: Add DT bindings YAML schema for DMA controller driver of Lightning Mountain(LGM) SoC. Signed-off-by:

Re: [PATCH v4 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-07-20 Thread Reddy, MallikarjunaX
Thanks Rob for the review. Please see my comments inline. On 7/14/2020 1:22 AM, Rob Herring wrote: On Mon, Jul 13, 2020 at 11:39:49AM +0800, Reddy, MallikarjunaX wrote: Hi Thomas, Thanks for the review. My comments inline. On 7/9/2020 3:54 PM, Langer, Thomas wrote: -Original Message

Re: [PATCH v4 2/2] Add Intel LGM soc DMA support.

2020-07-13 Thread Reddy, MallikarjunaX
Thanks for the review Andy. My comments inline. On 7/9/2020 7:09 PM, Andy Shevchenko wrote: On Thu, Jul 09, 2020 at 02:01:06PM +0800, Amireddy Mallikarjuna reddy wrote: Add DMA controller driver for Lightning Mountain(LGM) family of SoCs. The main function of the DMA controller is the transfer

Re: [PATCH v4 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-07-12 Thread Reddy, MallikarjunaX
Hi Thomas, Thanks for the review. My comments inline. On 7/9/2020 3:54 PM, Langer, Thomas wrote: -Original Message- From: devicetree-ow...@vger.kernel.org On Behalf Of Amireddy Mallikarjuna reddy Sent: Donnerstag, 9. Juli 2020 08:01 To: dmaeng...@vger.kernel.org; vk...@kernel.org; de

Re: [PATCH v3 1/2] dt-bindings: dma: Add bindings for intel LGM SOC

2020-06-24 Thread Reddy, MallikarjunaX
Thanks Thomas for the review. My comments inline. On 6/23/2020 6:49 PM, Langer, Thomas wrote: Hi, I have some questions about the binding. Sorry I missed to ask during internal review, as I was busy with other tasks at that time. See my questions below. -Original Message- From: devi