Thanks for the review. I don't believe many devices have this problem
no need to rush it.
On Sun, Jul 19, 2015 at 7:57 AM, Jonathan Cameron wrote:
> On 15/07/15 08:43, Reyad Attiyat wrote:
>> Some devices on a hid sensor hub will not report a measurement unit. This
>> causes th
Thanks for the review. I don't believe many devices have this problem
no need to rush it.
On Sun, Jul 19, 2015 at 7:57 AM, Jonathan Cameron ji...@kernel.org wrote:
On 15/07/15 08:43, Reyad Attiyat wrote:
Some devices on a hid sensor hub will not report a measurement unit. This
causes
Some devices on a hid sensor hub will not report a measurement unit. This
causes the rotation from north channels to have an incorrect scale value.
This patch will set the unit to degrees if the maximum value is 360 when
the unit exponent value is accounted for.
Signed-off-by: Reyad Attiyat
Some devices on a hid sensor hub will not report a measurement unit. This
causes the rotation from north channels to have an incorrect scale value.
This patch will set the unit to degrees if the maximum value is 360 when
the unit exponent value is accounted for.
Signed-off-by: Reyad Attiyat
once as there is a check in finish_td() to
ensure that all td's have been received.
If you think I should change anything else please let me know.
Thank you,
Reyad Attiyat
On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat wrote:
> This commit checks for the URB_ZERO_PACKET flag and creates an ex
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 66 ++--
drivers/usb/host
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/usb/host/xhci-ring.c | 66
once as there is a check in finish_td() to
ensure that all td's have been received.
If you think I should change anything else please let me know.
Thank you,
Reyad Attiyat
On Thu, Jul 2, 2015 at 1:54 PM, Reyad Attiyat reyad.atti...@gmail.com wrote:
This commit checks for the URB_ZERO_PACKET flag
these checks as well to keep in line with the their
implementation.
Do you think this is the best method for creating a zero-length
packet, will every trb convert into at least one endpoint packet?
Thank you,
Reyad Attiyat
On Mon, Jun 29, 2015 at 10:48 AM, Mathias Nyman wrote:
> Hi
>
> On 2
these checks as well to keep in line with the their
implementation.
Do you think this is the best method for creating a zero-length
packet, will every trb convert into at least one endpoint packet?
Thank you,
Reyad Attiyat
On Mon, Jun 29, 2015 at 10:48 AM, Mathias Nyman mathias.ny...@intel.com wrote
]---
Signed-off-by: Reyad Attiyat
---
drivers/net/wireless/mwifiex/usb.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mwifiex/usb.c
b/drivers/net/wireless/mwifiex/usb.c
index fd8027f..cd3ba76 100644
--- a/drivers/net/wireless/mwifiex/usb.c
+++ b
This commmit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 43 +--
1 file changed, 33
Sorry I have forgotten to change the dp loop check line in the bulk_sg
function. Will resubmit.
On Sun, Jun 28, 2015 at 7:36 PM, Reyad Attiyat wrote:
> This commit checks for the URB_ZERO_PACKET flag and creates an extra
> zero-length td if the urb transfer length is a multiple of the en
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint
max packet length.
Signed-off-by: Reyad Attiyat
---
drivers/usb/host/xhci-ring.c | 41 -
1 file changed, 32
The newer firmware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
The quirk HID_QUIRK_NO_INIT_REPORTS allows them to function normally.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-quirks.c | 3 +++
1 file changed, 3 insertions
This is missing a device ID I will need to resubmit
Sorry,
Reyad Attiyat
On Fri, Jun 26, 2015 at 1:00 AM, Reyad Attiyat wrote:
> The newer frimware on MS Surface 2 tablets causes the type and touch cover
> keyboards to timeout when waiting for reports.
>
> Signed-off-by: R
This is missing a device ID I will need to resubmit
Sorry,
Reyad Attiyat
On Fri, Jun 26, 2015 at 1:00 AM, Reyad Attiyat reyad.atti...@gmail.com wrote:
The newer frimware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
Signed-off
The newer firmware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
The quirk HID_QUIRK_NO_INIT_REPORTS allows them to function normally.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/hid/usbhid/hid-quirks.c | 3 +++
1
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint
max packet length.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/usb/host/xhci-ring.c | 41 -
1
Sorry I have forgotten to change the dp loop check line in the bulk_sg
function. Will resubmit.
On Sun, Jun 28, 2015 at 7:36 PM, Reyad Attiyat reyad.atti...@gmail.com wrote:
This commit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length
This commmit checks for the URB_ZERO_PACKET flag and creates an extra
zero-length td if the urb transfer length is a multiple of the endpoint's
max packet length.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/usb/host/xhci-ring.c | 43
] ? kthread_create_on_node+0x230/0x230
[ 84.461586] [817e9662] ret_from_fork+0x42/0x70
[ 84.461590] [810cb070] ? kthread_create_on_node+0x230/0x230
[ 84.461593] ---[ end trace 65103af5e6fb3444 ]---
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/net/wireless/mwifiex/usb.c | 6
The newer frimware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid
The newer frimware on MS Surface 2 tablets causes the type and touch cover
keyboards to timeout when waiting for reports.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/hid/usbhid/hid-quirks.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/usbhid/hid
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Changes from v1
- Fix mistake in varible name
Signed-off-by: Reyad Attiyat
---
drivers/iio
Whoops looks like I typed an extra character, sorry should have caught this.
Thanks Sirinivas will resend.
On Fri, Jul 25, 2014 at 2:52 PM, Srinivas Pandruvada
wrote:
> On 07/25/2014 12:32 PM, Reyad Attiyat wrote:
>>
>> Fix build warning, sizeof() called on dynamically
&
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 7
at 12:13 AM, Reyad Attiyat wrote:
> Set disconnected flag in struct usbhid when a usb device
> is removed. Check for disconnected flag before sending urb
> requests. This prevents a kernel panic when a hid driver calls
> hid_hw_request() after removing a usb device.
>
> Signed-off
at 12:13 AM, Reyad Attiyat reyad.atti...@gmail.com wrote:
Set disconnected flag in struct usbhid when a usb device
is removed. Check for disconnected flag before sending urb
requests. This prevents a kernel panic when a hid driver calls
hid_hw_request() after removing a usb device.
Signed-off
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor
Whoops looks like I typed an extra character, sorry should have caught this.
Thanks Sirinivas will resend.
On Fri, Jul 25, 2014 at 2:52 PM, Srinivas Pandruvada
srinivas.pandruv...@linux.intel.com wrote:
On 07/25/2014 12:32 PM, Reyad Attiyat wrote:
Fix build warning, sizeof() called
Fix build warning, sizeof() called on dynamically
sized pointer, by removing the call and the dependent
function parameter. It is not needed or used in this
driver, when pushing values to an iio buffer.
Changes from v1
- Fix mistake in varible name
Signed-off-by: Reyad Attiyat reyad.atti
Set disconnected flag in struct usbhid when a usb device
is removed. Check for disconnected flag before sending urb
requests. This prevents a kernel panic when a hid driver calls
hid_hw_request() after removing a usb device.
Signed-off-by: Reyad Attiyat
---
drivers/hid/usbhid/hid-core.c | 6
Set disconnected flag in struct usbhid when a usb device
is removed. Check for disconnected flag before sending urb
requests. This prevents a kernel panic when a hid driver calls
hid_hw_request() after removing a usb device.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/hid
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation
to iio_push_to_buffer
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage attributes before setting up
iio channels
iio: hid-sensor-magn
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git
Signed-off-by: Reyad Attiyat
Acked-by: Srinivas Pandruvada
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 152 ++
1 file changed, 105 insertions(+), 47 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
b/drivers/iio/magnetometer/hid-sensor
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
Acked-by: Srinivas Pandruvada srinivas.pandruv...@linux.intel.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 152 ++
1 file changed, 105 insertions(+), 47 deletions(-)
diff --git a/drivers/iio/magnetometer/hid
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
Acked-by: Srinivas Pandruvada srinivas.pandruv...@linux.intel.com
---
drivers/iio/industrialio-core.c | 4
include/linux/iio
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
Acked-by: Srinivas Pandruvada srinivas.pandruv...@linux.intel.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file
to iio_push_to_buffer
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage attributes before setting up
iio channels
iio: hid-sensor-magn
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
Acked-by: Srinivas Pandruvada srinivas.pandruv...@linux.intel.com
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
This series of patches modifies magn-3d driver to handle the rotation
from north usage. This is done by scanning the report and then building
the iio arrays (vals and channels) dynamically.
Changes from V5
- Fix kernel panics from dereference
Reyad Attiyat (4):
iio: Documentation: Add
-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 149 ++
1 file changed, 105 insertions(+), 44 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index b2b0937..d3b9114 100644
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/hid
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52 insertions(+), 1 deletion(-)
diff --git a/drivers
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI
-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 149 ++
1 file changed, 105 insertions(+), 44 deletions(-)
diff --git a/drivers/iio/magnetometer/hid-sensor-magn-3d.c
b/drivers/iio/magnetometer/hid-sensor-magn-3d.c
index b2b0937
This series of patches modifies magn-3d driver to handle the rotation
from north usage. This is done by scanning the report and then building
the iio arrays (vals and channels) dynamically.
Changes from V5
- Fix kernel panics from dereference
Reyad Attiyat (4):
iio: Documentation: Add
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git
tached diff, which will fix this.
>
> Thanks,
> Srinivas
>
>
> On 07/09/2014 03:12 PM, Reyad Attiyat wrote:
>>
>> Hey Srinivas,
>>
>> I did look into the panic you sent. I wasn't sure exactly what caused
>> the NULL pointer.
>> I tested it w
the attached diff, which will fix this.
Thanks,
Srinivas
On 07/09/2014 03:12 PM, Reyad Attiyat wrote:
Hey Srinivas,
I did look into the panic you sent. I wasn't sure exactly what caused
the NULL pointer.
I tested it with out applying the last rotation from north patch, so
no hid usages
parse_report returns (-EINVAL or -ENOMEM) in probe
Thanks,
Reyad Attiyat
On Wed, Jul 9, 2014 at 2:45 PM, Srinivas Pandruvada
wrote:
> On 07/09/2014 12:30 PM, Reyad Attiyat wrote:
>>
>> This series of patches modifies magn-3d driver to handle the rotation
>> from nort
ion and
don't believe it needs any other changes
Thanks.
On Wed, Jul 9, 2014 at 2:30 PM, Reyad Attiyat wrote:
> Scan for and count the HID usage attributes supported by the driver.
> This allows for the driver to only setup the IIO channels for the
> sensor usages present in the HID
attribute. The scan_index field is generated when creating
an iio channel.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
formatting
Added comment about magn_val_addr and iio_vals
Added more debugging information and checks
Removed static initalizing of scan_index, it is now set dynamically
Use struct iio_chan_spec address field to store magn array index (could be set
statically)
Signed-off-by: Reyad Attiyat
---
drivers
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Changes from v4
Removed the scan index as this is set dynamically
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1 file changed, 52
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Changes from v4
Removed the scan index as this is set dynamically
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 53 ++-
1
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI
formatting
Added comment about magn_val_addr and iio_vals
Added more debugging information and checks
Removed static initalizing of scan_index, it is now set dynamically
Use struct iio_chan_spec address field to store magn array index (could be set
statically)
Signed-off-by: Reyad Attiyat reyad.atti
attribute. The scan_index field is generated when creating
an iio channel.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Scan for usage
and
don't believe it needs any other changes
Thanks.
On Wed, Jul 9, 2014 at 2:30 PM, Reyad Attiyat reyad.atti...@gmail.com wrote:
Scan for and count the HID usage attributes supported by the driver.
This allows for the driver to only setup the IIO channels for the
sensor usages present
parse_report returns (-EINVAL or -ENOMEM) in probe
Thanks,
Reyad Attiyat
On Wed, Jul 9, 2014 at 2:45 PM, Srinivas Pandruvada
srinivas.pandruv...@linux.intel.com wrote:
On 07/09/2014 12:30 PM, Reyad Attiyat wrote:
This series of patches modifies magn-3d driver to handle the rotation
from north
ou review your logic?
> It is possible that platforms don't have all attributes, so looks
> like the probe is returnning with error.
>
>
> On 07/07/2014 09:44 AM, Jonathan Cameron wrote:
>>
>> On 30/06/14 03:58, Reyad Attiyat wrote:
>>>
>>> Scan for and
Hey Jonathan,
Thanks for the review. I'll be sure to fix up all the formatting you
mentioned and run it through the checkpatch.pl script.
> There should be an explanation here of what has changed from one version to
> the
> next.
Will include updates in future patch notes.
> The patches should
Hey Jonathan,
Thanks for the review. I'll be sure to fix up all the formatting you
mentioned and run it through the checkpatch.pl script.
There should be an explanation here of what has changed from one version to
the
next.
Will include updates in future patch notes.
The patches should have
in the probe function. Can you review your logic?
It is possible that platforms don't have all attributes, so looks
like the probe is returnning with error.
On 07/07/2014 09:44 AM, Jonathan Cameron wrote:
On 30/06/14 03:58, Reyad Attiyat wrote:
Scan for and count the HID usage attributes supported
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 58 ++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/magnetometer/hid
Scan for and count the HID usage attributes supported by the driver.
This allows for the driver to only setup the IIO channels for the
sensor usages present in the HID USB reports.
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 111 +-
1
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio
b
the values from the static array
of
IIO configurations. There is also an array used to store each channel IIO value
pointer for each HID usage attribute.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support
Added documentation for the sysfs attributes supported by the rotation from
north
sensor.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
Documentation/ABI/testing/sysfs-bus-iio | 82 +
1 file changed, 82 insertions(+)
diff --git a/Documentation/ABI
the values from the static array
of
IIO configurations. There is also an array used to store each channel IIO value
pointer for each HID usage attribute.
Reyad Attiyat (4):
iio: Documentation: Add documentation for rotation from north sensor
usage attributes
iio: types: Added support
Add the HID usage attribute ID's and IIO channel info for rotation
from north support.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 58 ++-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/drivers
Scan for and count the HID usage attributes supported by the driver.
This allows for the driver to only setup the IIO channels for the
sensor usages present in the HID USB reports.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 111
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git
channel and value arrays
Use proper return errors (-EINVAL) and (-ENOMEM)
Reyad Attiyat (3):
iio: documentation: Added documentation for rotation from north usage
attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Add support
Added documentation for the sysfs attributes added by the rotation from north
usage attributes.
Signed-off-by: Reyad Attiyat
---
Documentation/ABI/testing/sysfs-bus-iio | 79 -
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git a/Documentation/ABI
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git a/drivers/iio
Added the ability for this driver to scan for a range of hid usage attributes.
This allows for dynamic creation of iio channels such as rotation from north
and/or magnetic flux axises (X, Y, Z).
Signed-off-by: Reyad Attiyat
---
drivers/iio/magnetometer/hid-sensor-magn-3d.c | 394
Added the rotation from north usage attributes to the iio modifier enum and to
the iio modifier names array.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/industrialio-core.c | 4
include/linux/iio/types.h | 4
2 files changed, 8 insertions(+)
diff --git
Added the ability for this driver to scan for a range of hid usage attributes.
This allows for dynamic creation of iio channels such as rotation from north
and/or magnetic flux axises (X, Y, Z).
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/iio/magnetometer/hid-sensor-magn
channel and value arrays
Use proper return errors (-EINVAL) and (-ENOMEM)
Reyad Attiyat (3):
iio: documentation: Added documentation for rotation from north usage
attributes
iio: types: Added support for rotation from north usage attributes
iio: hid-sensor-magn-3d: Add support
Added documentation for the sysfs attributes added by the rotation from north
usage attributes.
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
Documentation/ABI/testing/sysfs-bus-iio | 79 -
1 file changed, 78 insertions(+), 1 deletion(-)
diff --git
Hey Jiri,
I read your other email and see this is now staged. You can ignore
this sorry for the noise.
On Tue, Jun 10, 2014 at 3:11 PM, Reyad Attiyat wrote:
> The dynamic callback lock (dyn_callback_lock) must not be interrupted
> when locked because the lock is used in the interrupt h
The dynamic callback lock (dyn_callback_lock) must not be interrupted
when locked because the lock is used in the interrupt handler function
sensor_hub_raw_event().
Signed-off-by: Reyad Attiyat
---
drivers/hid/hid-sensor-hub.c | 31 ++-
1 file changed, 18 insertions
Hey Jonathan,
I will make the changes you suggested thanks for reviewing this. Any
conclusions on the naming, did you want me to change the sysfs name to
"in_rot_from_north_true/magnetic"?
On Mon, Jun 9, 2014 at 2:55 PM, Jonathan Cameron wrote:
> On 03/06/14 00:14, Reyad
Hey Jonathan,
I will make the changes you suggested thanks for reviewing this. Any
conclusions on the naming, did you want me to change the sysfs name to
in_rot_from_north_true/magnetic?
On Mon, Jun 9, 2014 at 2:55 PM, Jonathan Cameron ji...@kernel.org wrote:
On 03/06/14 00:14, Reyad Attiyat
The dynamic callback lock (dyn_callback_lock) must not be interrupted
when locked because the lock is used in the interrupt handler function
sensor_hub_raw_event().
Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com
---
drivers/hid/hid-sensor-hub.c | 31 ++-
1 file
Hey Jiri,
I read your other email and see this is now staged. You can ignore
this sorry for the noise.
On Tue, Jun 10, 2014 at 3:11 PM, Reyad Attiyat reyad.atti...@gmail.com wrote:
The dynamic callback lock (dyn_callback_lock) must not be interrupted
when locked because the lock is used
atic channels that are enabled as found.
Thanks,
Reyad Attiyat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
that are enabled as found.
Thanks,
Reyad Attiyat
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
1 - 100 of 156 matches
Mail list logo
