On Wed, Apr 16, 2025 at 5:22 AM André Apitzsch via B4 Relay
wrote:
>
> The imx214 driver currently supports only a 24 MHz external clock. But
> there are devices, like Qualcomm-MSM8916-based phones, which cannot
> provide this frequency. To make the sensor usable by those devices, add
> support fo
On Sat, Mar 8, 2025 at 10:48 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Qualcomm MSM8916 devices only provide an external clock of 23.88MHz.
> Make the sensor usable by those devices by adding support for this
> frequency.
>
Acked-by: Ricardo Ribalda
and after this patch
On Sat, Mar 8, 2025 at 10:48 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Replace the hard coded external clock frequency by the one read from
> device tree.
>
> Signed-off-by: André Apitzsch
> ---
> drivers/media/i2c/imx214.c | 99
> --
On Sat, Mar 8, 2025 at 10:48 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Move clock frequency related parameters out of the constant register
> sequences, such that the hard coded external clock frequency can be
> replaced by a variable in the next commit.
>
Acked-by: Ricar
On Sat, Mar 8, 2025 at 10:48 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Replace the magic link bit rate number (4800) by its calculation based
> on the used parameters and the provided external clock frequency.
>
> The link bit rate is output bitrate multiplied by the numb
On Tue, Dec 17, 2024 at 10:39 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Add vblank control to allow changing the framerate /
> higher exposure values.
>
> The vblank and hblank controls are needed for libcamera support.
>
> While at it, fix the minimal exposure time accor
On Tue, Dec 17, 2024 at 10:40 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The driver should disable or unprepare the clock on probe error and on
> removing the module.
>
> Remove regulator_bulk_disable(), because it is called by
> imx214_power_off().
>
> Signed-off-by: Andr
Hi Andre
On Mon, Dec 16, 2024 at 10:01 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Port the imx214 sensor driver to use the subdev active state.
>
> Move all the format configuration to the subdevice state and simplify
> the format handling, locking and initialization.
>
>
> > Is the handler->lock held when we call this function?
>
> I'm not sure how to test this.
>
> > Can you try
> > running the code with lockdep?
>
> /proc/lockdep contains
>
> > f9299231 FD: 89 BD:6 +.+.: imx214:901:(&imx214->ctrls)->_lock
>
> (no idea how to interpret this line)
>
>
On Sun, Dec 8, 2024 at 10:35 PM André Apitzsch wrote:
>
> Hi Ricardo,
>
> Am Sonntag, dem 08.12.2024 um 21:59 +0100 schrieb Ricardo Ribalda
> Delgado:
> > In general it looks good to me (besides the comments, ignore the nits
> > if you want to).
> >
> > I&#x
On Sun, Dec 8, 2024 at 9:59 PM Ricardo Ribalda Delgado
wrote:
>
> In general it looks good to me (besides the comments, ignore the nits
> if you want to).
>
> I'd recommend that you test with lockdep to make sure that we are not
> missing anything, and I'd like to hea
Acked-by: Ricardo Ribalda
On Sat, Dec 7, 2024 at 9:48 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 camera is capable of either two-lane or four-lane operation.
>
> Currently only the four-lane mode is supported, as proper pixel rates
> and link frequences for the
Acked-by: Ricardo Ribalda
nit: media: i2c: imx214: Fix link frequency validation
On Sat, Dec 7, 2024 at 9:49 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then
> IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_F
In general it looks good to me (besides the comments, ignore the nits
if you want to).
I'd recommend that you test with lockdep to make sure that we are not
missing anything, and I'd like to hear back from Sakari regarding the
get_locked_active
Thanks!
On Sat, Dec 7, 2024 at 9:48 PM André Apitzs
Hi André
On Wed, Nov 20, 2024 at 9:07 PM André Apitzsch wrote:
>
> Hi Ricardo,
>
> Am Mittwoch, dem 30.10.2024 um 13:10 +0100 schrieb Ricardo Ribalda
> Delgado:
> > Hi
> >
> > Aren't you changing the binning mode for 1920x1080 with this patch?
> > I
Hi
It looks good to me, but I would like Sakari to review it. I am not
sure if it is ok to keep the cur_mode variable.
On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Port the imx214 sensor driver to use the subdev active state.
>
> Move all the
On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 sensor supports horizontal and vertical flipping. Add
> appropriate controls to the driver.
>
> Signed-off-by: André Apitzsch
Acked-by: Ricardo Ribalda
> ---
> drivers/media/i2c/imx214.c
Hi
Aren't you changing the binning mode for 1920x1080 with this patch? I
think that could be considered an ABI change.
Also, if we are not letting the user change the value, I do not see
much value in setting the cropping programmatically, I'd rather not
take this change.
On Mon, Oct 21, 2024 a
On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Add vblank control to allow changing the framerate /
> higher exposure values.
>
> The vblank and hblank controls are needed for libcamera support.
>
> While at it, fix the minimal exposure time accor
On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 camera is capable of either two-lane or four-lane operation.
>
> Currently only the four-lane mode is supported, as proper pixel rates
> and link frequences for the two-lane mode are unknow
Hi Andre
On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then
> IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10),
> which works out as 384MPix/s. (The 8 is 4 lanes and DDR
Hi Andre
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Simplify the imx214_start_streaming() by removing unneeded goto
> statements, and the corresponding error label.
Could you squash this patch with the previous one?
Thanks!
>
> Signed-off
Hi Andre
I don't have access to the hardware anymore, so I cannot test this...
but looking at the code I am not sure how it is working...
I would assume that after moving to the subdev active state, you need to remove
struct v4l2_mbus_framefmt fmt;
struct v4l2_rect crop;
for struct imx214.
Aft
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Error handling in probe() can be a bit simpler with dev_err_probe().
>
Acked-by: Ricardo Ribalda
> Signed-off-by: André Apitzsch
> ---
> drivers/media/i2c/imx214.c | 52
> -
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Use the new common CCI register access helpers to replace the private
> register access helpers in the imx214 driver. This simplifies the driver
> by reducing the amount of code.
>
Acked-by: Ricardo Ri
Hi
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Define macros for all the known registers used in the register arrays,
> and use them to replace the numerical addresses. This improves
> readability.
Could you share the documentation?
>
> Signe
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
> in the mode_ registers arrays, and once via v4l2_ctrl_ops. The
> latter is enough, drop the former.
>
> Signed-off-by: André A
Hi
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 camera is capable of either two-lane or four-lane operation.
>
> Currently only the four-lane mode is supported, as proper pixel rates
> and link frequences for the two-lane mode are unk
On Mon, Sep 2, 2024 at 11:54 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Remove format and crop settings from register sequences and set them
> programmatically.
>
> Signed-off-by: André Apitzsch
> ---
> drivers/media/i2c/imx214.c | 137
>
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 sensor supports horizontal and vertical flipping. Add
> appropriate controls to the driver.
>
> Signed-off-by: André Apitzsch
> ---
> drivers/media/i2c/imx214.c | 73
> +++
Hi
Arent you missing some chage in enum_frame_interval?
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Add vblank control to allow changing the framerate /
> higher exposure values.
>
> The vblank and hblank controls are needed for libcamera supp
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> The imx214 sensor supports analogue gain up to 8x and digital gain up to
> 16x. Implement the corresponding controls in the driver. Default gain
> values are not modified by this patch.
>
Acked-by: Ric
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> Check the chip ID and stop probing if it is no imx214 sensor.
>
> Signed-off-by: André Apitzsch
Acked-by: Ricardo Ribalda
> ---
> drivers/media/i2c/imx214.c | 29 +
> 1
On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
wrote:
>
> From: André Apitzsch
>
> This adds V4L2_CID_TEST_PATTERN control support.
>
> Signed-off-by: André Apitzsch
Acked-by: Ricardo Ribalda
> ---
> drivers/media/i2c/imx214.c | 77
> --
Hello Hans
On Fri, Mar 26, 2021 at 11:01 AM Ricardo Ribalda wrote:
>
> From: Hans Verkuil
>
> Check for inactive controls in uvc_ctrl_is_accessible().
> Use the new value for the master_id controls if present,
> otherwise use the existing value to determine if it is OK
> to set the control. Doin
Hello Hans
On Fri, Mar 19, 2021 at 9:35 AM Hans Verkuil wrote:
>
> On 18/03/2021 21:29, Ricardo Ribalda wrote:
> > Take a v4l2_ext_controls instead of an array of controls, this way we
> > can access the error_idx in future changes.
> >
> > Signed-off-by: Ricardo Ribalda
> > ---
> > drivers/me
On Wed, Mar 17, 2021 at 2:34 AM Sergey Senozhatsky
wrote:
>
> On (21/03/16 19:29), Ricardo Ribalda Delgado wrote:
> > > ROI control is a compound data type:
> > > Control Selector CT_REGION_OF_INTEREST_CONTROL
> > > Mandatory Requests SET_CUR, G
Hi
On Wed, Mar 17, 2021 at 2:31 AM Sergey Senozhatsky
wrote:
>
> On (21/03/16 19:19), Ricardo Ribalda Delgado wrote:
> > > +Configuration of Region of Interest (ROI)
> > > +=
> > > +
> > > +The range of coordinate
Hi
On Wed, Mar 17, 2021 at 2:59 AM Sergey Senozhatsky
wrote:
>
> On (21/03/16 19:46), Ricardo Ribalda Delgado wrote:
> > > -static int uvc_ioctl_g_selection(struct file *file, void *fh,
> > > -struct v4l2_selection *sel)
> > > +/*
Hi Sergey
Thanks for the patch
On Mon, Feb 8, 2021 at 6:23 AM Sergey Senozhatsky
wrote:
>
> From: Sergey Senozhatsky
>
> This patch implements parts of UVC 1.5 Region of Interest (ROI)
> control, using the uvcvideo selection API.
>
> There are several things to mention here.
>
> First, UVC 1.5 d
Hi Sergey
Thanks for the patch
On Mon, Feb 8, 2021 at 6:24 AM Sergey Senozhatsky
wrote:
>
> From: Sergey Senozhatsky
>
> This patch adds support for Region of Interest bmAutoControls.
>
> ROI control is a compound data type:
> Control Selector CT_REGION_OF_INTEREST_CONTROL
> Mandatory R
Hi Sergey
Thanks for the patch!
On Mon, Feb 8, 2021 at 6:21 AM Sergey Senozhatsky
wrote:
>
> From: Sergey Senozhatsky
>
> Document new v4l2-selection target which will be used for the
> Region of Interest v4l2 control.
>
> Signed-off-by: Sergey Senozhatsky
> ---
> .../media/v4l/selection-api-
Hi Laurent
Thanks!
On Sat, Mar 13, 2021 at 12:29 AM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> On Sat, Mar 13, 2021 at 12:17:50AM +0100, Ricardo Ribalda Delgado wrote:
> > On Fri, Mar 12, 2021 at 11:30 PM Laurent Pinchart wrote:
> > > On Fri, Mar 12, 2021 at 01:48:
HI Laurent
Thanks for the review
On Fri, Mar 12, 2021 at 11:30 PM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Fri, Mar 12, 2021 at 01:48:29PM +0100, Ricardo Ribalda wrote:
> > All the entities must have a unique name. And now that we are at it, we
> > append the e
Hi Laurent
Thanks a lot for the review
On Fri, Mar 12, 2021 at 10:19 PM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Fri, Mar 12, 2021 at 01:57:09PM +0100, Ricardo Ribalda wrote:
> > On architectures where there is no coherent caching such as ARM use the
> > dma_al
HI Laurent
Thanks for the prompt reply :)
On Fri, Mar 12, 2021 at 2:25 AM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Mar 11, 2021 at 11:19:45PM +0100, Ricardo Ribalda wrote:
> > Create all the class controls for the device defined controls.
> >
> > Fixes v4l
Hi Laurent
On Fri, Mar 12, 2021 at 12:30 AM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> On Thu, Mar 11, 2021 at 11:59:27PM +0100, Ricardo Ribalda Delgado wrote:
> > On Thu, Mar 11, 2021 at 11:53 PM Laurent Pinchart wrote:
> > > On Thu, Mar 11, 2021 at 11:19:43PM +
Hi Laurent
On Thu, Mar 11, 2021 at 11:53 PM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
Thank you :)
>
> On Thu, Mar 11, 2021 at 11:19:43PM +0100, Ricardo Ribalda wrote:
> > The device is doing something unspected with the control. Either because
> > the protocol is not
Hi Laurent
On Thu, Mar 11, 2021 at 4:59 PM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Mar 11, 2021 at 03:08:22PM +0100, Ricardo Ribalda wrote:
> > As discussed in the IRC with Hans
> >
> > We need to specify in the commit message that this is most likely due
Hi Laurent
On Thu, Mar 11, 2021 at 5:20 PM Laurent Pinchart
wrote:
>
> Hi Ricardo,
>
> Thank you for the patch.
Thank you for the review :)
>
> On Thu, Mar 11, 2021 at 01:20:37PM +0100, Ricardo Ribalda wrote:
> > According to the doc:
>
> The previous paragraph states:
>
> This check is done to
Hi Hans
Thanks for your review!
On Thu, Mar 11, 2021 at 3:32 PM Hans Verkuil wrote:
>
> On 11/03/2021 13:20, Ricardo Ribalda wrote:
> > Do not create Control Classes for empty classes.
>
> Shouldn't this be squashed with patch 06/10?
Most of the cameras I have used have the two classes, So I a
HI Mark
On Thu, Sep 17, 2020 at 1:22 PM Mark Brown wrote:
>
> On Thu, Sep 17, 2020 at 08:31:54AM +0200, Ricardo Ribalda Delgado wrote:
> > On Wed, Sep 16, 2020 at 6:29 PM Mark Brown wrote:
>
> > > What exactly is the format you're trying to describe here? It
Hi Mark
On Wed, Sep 16, 2020 at 6:29 PM Mark Brown wrote:
>
> On Wed, Sep 16, 2020 at 06:05:52PM +0200, Ricardo Ribalda wrote:
> > From: Ricardo Ribalda
> >
> > Devices such as the AD5628 require 32 bits of data divided in 12 bits
> > for dummy, command and address, and 20 for data and dummy.
Hi Andy
On Wed, Jun 24, 2020 at 12:46 PM Andy Shevchenko
wrote:
>
> On Wed, Jun 24, 2020 at 11:12:39AM +0200, Ricardo Ribalda wrote:
> > Current AMD's zen-based APUs use this core for some of its i2c-buses.
> >
> > With this patch we re-enable autodetection of hwmon-alike devices, so
> > lm-senso
Hi
This is just a friendly ping after two weeks ;)
On Mon, May 4, 2020 at 10:44 AM Miquel Raynal wrote:
>
> Hi Richard,
>
> Ricardo Ribalda Delgado wrote on Thu, 30 Apr 2020
> 15:17:21 +0200:
>
> > From: Ricardo Ribalda Delgado
> >
> > When the nvmem fra
From: Ricardo Ribalda Delgado
When the nvmem framework is enabled, a nvmem device is created per mtd
device/partition.
It is not uncommon that a device can have multiple mtd devices with
partitions that have the same name. Eg, when there DT overlay is allowed
and the same device with mtd is
Apr 2020 16:22:22 +0200
> > > Miquel Raynal wrote:
> > >
> > > > Hi Ricardo,
> > > >
> > > > Ricardo Ribalda Delgado wrote on Tue, 14 Apr 2020
> > > > 15:47:23 +0200:
> > > >
> > > > > Ping?
> > > > >
&g
This allows setting the default value on compound controls created via
v4l2_ctrl_new_custom.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 3 ++-
include/media/v4l2-ctrls.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a
Hi Hans
On Wed, Oct 16, 2019 at 2:57 PM Hans Verkuil wrote:
>
> On 10/16/19 2:43 PM, Hans Verkuil wrote:
> > On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote:
> >> Hi Hans:
> >>
> >> On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil
> >> wrote:
Hi Hans
On Wed, Oct 16, 2019 at 2:43 PM Hans Verkuil wrote:
>
> On 10/16/19 2:39 PM, Ricardo Ribalda Delgado wrote:
> > Hi Hans:
> >
> > On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil
> > wrote:
> >>
> >> On 10/16/19 2:20 PM, Ricardo Ribalda D
Hi Hans:
On Wed, Oct 16, 2019 at 2:32 PM Hans Verkuil wrote:
>
> On 10/16/19 2:20 PM, Ricardo Ribalda Delgado wrote:
> > Hi Hans
> >
> > Not that awkward, the user has to use the brand new
> > v4l2_ctrl_ptr_create() ;). But if you prefer void * I can make the
Hi Hans
Not that awkward, the user has to use the brand new
v4l2_ctrl_ptr_create() ;). But if you prefer void * I can make the
change.
Regards
On Wed, Oct 16, 2019 at 2:17 PM Hans Verkuil wrote:
>
> On 10/14/19 4:14 PM, Ricardo Ribalda Delgado wrote:
> > This allows setting the d
This allows setting the default value on compound controls created via
v4l2_ctrl_new_custom.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 +-
include/media/v4l2-ctrls.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers
From: Ricardo Ribalda Delgado
This type contains the width and the height of a rectangular area.
Reviewed-by: Jacopo Mondi
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 21 ++
include/media/v4l2-ctrls.h | 42
New control to pass to userspace the width/height of a pixel. Which is
needed for calibration and lens selection.
Reviewed-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
.../media/uapi/v4l/ext-ctrls-image-source.rst | 10 ++
1 file changed, 10 insertions(+)
diff
According to the product brief, the unit cell size is 1120 nanometers^2.
https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 9 +
1 file changed, 9 insertions
This helper function simplifies the code by not needing a union
v4l2_ctrl_ptr and an assignment every time we need to use
a ctrl_ptr.
Suggested-by: Hans Verkuil
Signed-off-by: Ricardo Ribalda Delgado
---
include/media/v4l2-ctrls.h | 12
1 file changed, 12 insertions(+)
diff --git
A struct v4l2_area containing the width and the height of a rectangular
area.
Reviewed-by: Jacopo Mondi
Reviewed-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++
Documentation/media/videodev2.h.rst.exceptions| 1
-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
include/uapi/linux/v4l2-controls.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 96cab2e173d3..bf50d37ef6c1 100644
--- a
From: Ricardo Ribalda Delgado
Function for initializing compound controls with a default value.
Suggested-by: Hans Verkuil
Reviewed-by: Jacopo Mondi
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/kapi/v4l2-controls.rst | 9 +
1 file changed, 9 insertions(+)
diff
From: Ricardo Ribalda Delgado
Currently compound controls do not have a simple way of initializing its
values. This results in ofuscated code with type_ops init.
This patch introduces a new field on the control with the default value
for the compound control that can be set with the brand new
: Add new helper v4l2_ctrl_ptr_from_void
v4, v5 of this patchset never reached the mailing list.
Ricardo Ribalda Delgado (8):
media: v4l2-core: Implement v4l2_ctrl_new_std_compound
Documentation: v4l2_ctrl_new_std_compound
media: add V4L2_CTRL_TYPE_AREA control type
Documentation: media
: Pavel Machek
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
---
drivers/media/i2c/ad5820.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 5651609e5095..19c74db0649f 100644
--- a/drivers
: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Cc: Sakari Ailus
---
drivers/media/i2c/ad5820.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 76aab651f217..5651609e5095 100644
--- a/drivers/media/i2c/ad5820.c
+++ b
Document new enable-gpio field. It can be used to disable the part
without turning down its regulator.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings
very unhappy. I send v8 to make patchwork happy and
hopefuly also the maintainer. Sorry again
v7: Rebase on current media/master
Ricardo Ribalda Delgado (6):
media: ad5820: Define entity function
media: ad5820: DT new optional field enable-gpios
media: ad5820: Add support for enable pin
Document new compatible devices.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Rob Herring
Acked-by: Pavel Machek
---
Documentation/devicetree/bindings/media/i2c/ad5820.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
This patch adds support for a programmable enable pin. It can be used in
situations where the ANA-vcc is not configurable (dummy-regulator), or
just to have a more fine control of the power saving.
The use of the enable pin is optional.
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel
Without this patch, media_device_register_entity throws a warning:
dev_warn(mdev->dev,
"Entity type for entity %s was not initialized!\n",
entity->name);
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
---
drivers/
Document new compatible devices.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Rob Herring
Acked-by: Pavel Machek
---
Documentation/devicetree/bindings/media/i2c/ad5820.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
This patch adds support for a programmable enable pin. It can be used in
situations where the ANA-vcc is not configurable (dummy-regulator), or
just to have a more fine control of the power saving.
The use of the enable pin is optional.
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel
: Pavel Machek
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
---
drivers/media/i2c/ad5820.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 5651609e5095..19c74db0649f 100644
--- a/drivers
: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Cc: Sakari Ailus
---
drivers/media/i2c/ad5820.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 76aab651f217..5651609e5095 100644
--- a/drivers/media/i2c/ad5820.c
+++ b
: Pavel Machek
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
---
drivers/media/i2c/ad5820.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 5651609e5095..19c74db0649f 100644
--- a/drivers
: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Cc: Sakari Ailus
---
drivers/media/i2c/ad5820.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/media/i2c/ad5820.c b/drivers/media/i2c/ad5820.c
index 76aab651f217..5651609e5095 100644
--- a/drivers/media/i2c/ad5820.c
+++ b
Document new enable-gpio field. It can be used to disable the part
without turning down its regulator.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings
Document new enable-gpio field. It can be used to disable the part
without turning down its regulator.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings
Without this patch, media_device_register_entity throws a warning:
dev_warn(mdev->dev,
"Entity type for entity %s was not initialized!\n",
entity->name);
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
---
drivers/
This patch adds support for a programmable enable pin. It can be used in
situations where the ANA-vcc is not configurable (dummy-regulator), or
just to have a more fine control of the power saving.
The use of the enable pin is optional.
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel
Document new compatible devices.
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Rob Herring
Acked-by: Pavel Machek
---
Documentation/devicetree/bindings/media/i2c/ad5820.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a
-Support for enable-pin, of-autoload, enable-gpios and ad5821 and ad5823
For some reason these patchset was lost in translation for a year ;)
v7: Rebase on current media/master
Ricardo Ribalda Delgado (6):
media: ad5820: Define entity function
media: ad5820: DT new optional field enable
Without this patch, media_device_register_entity throws a warning:
dev_warn(mdev->dev,
"Entity type for entity %s was not initialized!\n",
entity->name);
Signed-off-by: Ricardo Ribalda Delgado
Acked-by: Pavel Machek
Reviewed-by: Laurent Pinchart
---
drivers/
New control to pass to userspace the width/height of a pixel. Which is
needed for calibration and lens selection.
Reviewed-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
.../media/uapi/v4l/ext-ctrls-image-source.rst | 10 ++
1 file changed, 10 insertions(+)
diff
Hi Hans
On Mon, Oct 7, 2019 at 2:01 PM Hans Verkuil wrote:
>
> On 10/7/19 1:35 PM, Ricardo Ribalda Delgado wrote:
> > New control to pass to userspace the width/height of a pixel. Which is
> > needed for calibration and lens selection.
> >
> > Reviewed-by: Ph
From: Ricardo Ribalda Delgado
Function for initializing compound controls with a default value.
Suggested-by: Hans Verkuil
Reviewed-by: Jacopo Mondi
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/kapi/v4l2-controls.rst | 9 +
1 file changed, 9 insertions(+)
diff
From: Ricardo Ribalda Delgado
Currently compound controls do not have a simple way of initializing its
values. This results in ofuscated code with type_ops init.
This patch introduces a new field on the control with the default value
for the compound control that can be set with the brand new
This helper function simplifies the code by not needing a union
v4l2_ctrl_ptr and an assignment every time we need to use
a ctrl_ptr.
Suggested-by: Hans Verkuil
Signed-off-by: Ricardo Ribalda Delgado
---
include/media/v4l2-ctrls.h | 12
1 file changed, 12 insertions(+)
diff --git
-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
include/uapi/linux/v4l2-controls.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index 96cab2e173d3..bf50d37ef6c1 100644
--- a
According to the product brief, the unit cell size is 1120 nanometers^2.
https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 9 +
1 file changed, 9 insertions
A struct v4l2_area containing the width and the height of a rectangular
area.
Reviewed-by: Jacopo Mondi
Reviewed-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a
1 - 100 of 1026 matches
Mail list logo
