Re: [PATCH v2 00/10] irqdomain, gic-v3-its: Implement late irq domain initialization

2018-12-05 Thread Richter, Robert
, -Robert On 28.11.18 15:43:02, Richter, Robert wrote: > This patch series is a rework of the gic-v3-its initialization. It is > in preparation of a further series that uses CMA memory allocation for > ITS tables. For this the CMA framework must be available and thus ITS > needs to be initi

Re: [PATCH v2 00/10] irqdomain, gic-v3-its: Implement late irq domain initialization

2018-12-05 Thread Richter, Robert
, -Robert On 28.11.18 15:43:02, Richter, Robert wrote: > This patch series is a rework of the gic-v3-its initialization. It is > in preparation of a further series that uses CMA memory allocation for > ITS tables. For this the CMA framework must be available and thus ITS > needs to be initi

Re: [PATCH 0/2] irqchip/gic-v3-its: Use CMA for its table allocation

2018-11-28 Thread Richter, Robert
On 15.11.18 22:50:57, Richter, Robert wrote: > The gicv3-its device table may have a size of up to 16MB (Cavium > ThunderX). With 4k pagesize the maximum size of memory allocation is > 4MB. This series implements the use of CMA for allocation of large its > tables. To achieve this we

Re: [PATCH 0/2] irqchip/gic-v3-its: Use CMA for its table allocation

2018-11-28 Thread Richter, Robert
On 15.11.18 22:50:57, Richter, Robert wrote: > The gicv3-its device table may have a size of up to 16MB (Cavium > ThunderX). With 4k pagesize the maximum size of memory allocation is > 4MB. This series implements the use of CMA for allocation of large its > tables. To achieve this we

Re: WARN_ON after gic_reserve_range

2018-11-21 Thread Richter, Robert
On 20.11.18 17:37:37, Marc Zyngier wrote: > On 20/11/2018 17:30, John Garry wrote: > > I see it also: > > > > [0.00] Booting Linux on physical CPU 0x01 [0x410fd082] > > [0.00] Linux version 4.20.0-rc3 > > (johnpgarry@johnpgarry-ThinkCentre-M93p) (gcc version 7.3.1 20180425

Re: WARN_ON after gic_reserve_range

2018-11-21 Thread Richter, Robert
On 20.11.18 17:37:37, Marc Zyngier wrote: > On 20/11/2018 17:30, John Garry wrote: > > I see it also: > > > > [0.00] Booting Linux on physical CPU 0x01 [0x410fd082] > > [0.00] Linux version 4.20.0-rc3 > > (johnpgarry@johnpgarry-ThinkCentre-M93p) (gcc version 7.3.1 20180425

Re: [PATCH 01/10] irqdomain: Add interface to request an irq domain

2018-11-12 Thread Richter, Robert
Julien, On 09.11.18 09:05:11, Julien Thierry wrote: > On 08/11/18 15:05, Richter, Robert wrote: > >>>+static void irq_domain_handle_requests(struct fwnode_handle *fwnode, > >>>+enum irq_domain_bus_token bus_token) > >>>

Re: [PATCH 01/10] irqdomain: Add interface to request an irq domain

2018-11-12 Thread Richter, Robert
Julien, On 09.11.18 09:05:11, Julien Thierry wrote: > On 08/11/18 15:05, Richter, Robert wrote: > >>>+static void irq_domain_handle_requests(struct fwnode_handle *fwnode, > >>>+enum irq_domain_bus_token bus_token) > >>>

Re: [PATCH 00/10] irqdomain, gic-v3-its: Implement late irq domain initialization

2018-11-11 Thread Richter, Robert
On 09.11.18 17:19:54, John Garry wrote: > On 07/11/2018 22:03, Robert Richter wrote: > >Patches have been tested with Cavium ThunderX and ThunderX2. I have an > >implementation of CMA ITS table allocation on top of this series > >available, I will send out patches for this in a couple of days. >

Re: [PATCH 00/10] irqdomain, gic-v3-its: Implement late irq domain initialization

2018-11-11 Thread Richter, Robert
On 09.11.18 17:19:54, John Garry wrote: > On 07/11/2018 22:03, Robert Richter wrote: > >Patches have been tested with Cavium ThunderX and ThunderX2. I have an > >implementation of CMA ITS table allocation on top of this series > >available, I will send out patches for this in a couple of days. >

Re: [PATCH 08/10] irqchip/gic-v3-its: Decouple its initialization from gic

2018-11-09 Thread Richter, Robert
On 08.11.18 11:26:02, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >-static int __init its_init(void) > >+int __init its_init(void) > > { > > struct its_node *its; > > bool has_v4 = false; > > int err; > > > >+ if (list_empty(_probed)) > >+

Re: [PATCH 08/10] irqchip/gic-v3-its: Decouple its initialization from gic

2018-11-09 Thread Richter, Robert
On 08.11.18 11:26:02, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >-static int __init its_init(void) > >+int __init its_init(void) > > { > > struct its_node *its; > > bool has_v4 = false; > > int err; > > > >+ if (list_empty(_probed)) > >+

Re: [PATCH 07/10] irqchip/gic-v3-its: Split probing from its node initialization

2018-11-08 Thread Richter, Robert
On 08.11.18 11:25:24, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >-static int its_init_domain(struct fwnode_handle *handle, struct its_node > >*its) > >+static int its_init_domain(struct its_node *its) > > { > > struct irq_domain *inner_domain; > > struct

Re: [PATCH 07/10] irqchip/gic-v3-its: Split probing from its node initialization

2018-11-08 Thread Richter, Robert
On 08.11.18 11:25:24, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >-static int its_init_domain(struct fwnode_handle *handle, struct its_node > >*its) > >+static int its_init_domain(struct its_node *its) > > { > > struct irq_domain *inner_domain; > > struct

Re: [PATCH 01/10] irqdomain: Add interface to request an irq domain

2018-11-08 Thread Richter, Robert
Julien, thanks for your review. See my comments below. On 08.11.18 10:19:52, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >This patch introduces a new interface to allow irq domain > >initialization regardless of order dependencies. This is done by > >requesting a domain

Re: [PATCH 01/10] irqdomain: Add interface to request an irq domain

2018-11-08 Thread Richter, Robert
Julien, thanks for your review. See my comments below. On 08.11.18 10:19:52, Julien Thierry wrote: > On 07/11/18 22:03, Robert Richter wrote: > >This patch introduces a new interface to allow irq domain > >initialization regardless of order dependencies. This is done by > >requesting a domain

Re: [PATCH] irqchip/gic-v3-its: Add early memory allocation errata

2018-10-05 Thread Richter, Robert
On 05.10.18 16:13:48, Matthias Brugger wrote: > On 05/10/2018 15:42, Marc Zyngier wrote: > > On 05/10/18 13:33, Matthias Brugger wrote: > >> With my distribution head on, I would prefer a solution that does not > >> change > >> FORCE_MAX_ZONEORDER. That's how I came to the idea providing a third

Re: [PATCH] irqchip/gic-v3-its: Add early memory allocation errata

2018-10-05 Thread Richter, Robert
On 05.10.18 16:13:48, Matthias Brugger wrote: > On 05/10/2018 15:42, Marc Zyngier wrote: > > On 05/10/18 13:33, Matthias Brugger wrote: > >> With my distribution head on, I would prefer a solution that does not > >> change > >> FORCE_MAX_ZONEORDER. That's how I came to the idea providing a third