Sparse was giving out a warning for symbols
'cc_set_ree_fips_status' and 'fips_handler'
that they were not declared and need to be
made static. This patch makes both the symbols
static inline, to remove the warnings.
Signed-off-by: Rishabh Hardas
---
drivers/staging/ccree/ss
' somewhere in
> it :(
>
> Please fix up and resend.
>
> thanks,
>
> greg k-h
>From 717ec264a6212b8526c381d3673dd0ee45352266 Mon Sep 17 00:00:00 2001
From: Rishabh Hardas
Date: Tue, 22 Aug 2017 18:56:45 +0530
Subject: [PATCH v2] staging/ccree: Declare compiled out fuctions static in
> > that they were not declared and need to be made static. This patch makes
> > both the symbols
> > static inline, to remove the warnings.
> >
> > Signed-off-by: RishabhHardas
>
> I doubt you sign your name on legal documents without a ' ' somewh
On Sat, Aug 19, 2017 at 09:47:28PM -0700, Joe Perches wrote:
> On Wed, 2017-08-16 at 10:31 +0300, Dan Carpenter wrote:
> > On Wed, Aug 16, 2017 at 10:53:18AM +0530, Rishabh Hardas wrote:
> > > @@ -143,10 +142,13 @@ struct pi433_rx_cfg {
> > >
> > > #define
Remove Camel casing by renaming variables.
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/pi433_if.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
Remove camel casing by renaming enums.
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 36
drivers/staging/pi433/rf69.c | 26 +-
drivers/staging/pi433/rf69.h | 26 +-
drivers
Shorten long comments and format them in kernel style comments.
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index
Correct lines above 80 characters in pi433_if.h
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index e6ed3cd
Hi,
This series pf patches solves some of the coding style
issues. I have corrected long lines, changed comment style,
renamed enums and variables that were in camel case.
Tried to get zero erros and warnings on the pi433_if.h file.
Regards,
Rishabh Hardas
Rishabh Hardas (4):
staging: pi433
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index 91e4a01..84032f3 100644
--- a/drivers/staging/pi433/pi433_if.h
+++ b
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 28 +++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
index e6ed3cd..91e4a01 100644
--- a/drivers/staging/pi433
Hi,
This series pf patches solves some of the coding style
issues. I have corrected long lines, changed comment style,
renamed enums and variables that were in camel case.
Tried to get zero erros and warnings on the pi433_if.h file.
Regards,
Rishabh Hardas
Rishabh Hardas (4):
staging: pi433
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 4 ++--
drivers/staging/pi433/pi433_if.h | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4..11c042b 100644
--- a/drivers
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 36
drivers/staging/pi433/rf69.c | 26 +-
drivers/staging/pi433/rf69.h | 26 +-
drivers/staging/pi433/rf69_enum.h | 16
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/rf69.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index f83523e..7fa63e1 100644
--- a/drivers/staging/pi433/rf69.c
+++ b
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index ed737f4..11c042b 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/rf69_enum.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/pi433/rf69_enum.h
b/drivers/staging/pi433/rf69_enum.h
index fbfb59b..f51eec3 100644
--- a/drivers/staging/pi433/rf69_enum.h
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/rf69.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h
index b81e076..e98e24e 100644
--- a/drivers/staging/pi433/rf69.h
+++ b
This is a 5 patch series which solves coding style issues
as marked by checkpatch.pl in the file pi433_if.h and
contains changes that have to be made in other files as a
consequence of the changes made in pi433_if.h
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.h | 81
From: Rishabh Hardas
Solved a few coding style issues, used BIT macro to set MINORBITS.
Signed-off-by: Rishabh Hardas
---
drivers/staging/pi433/pi433_if.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers
20 matches
Mail list logo