a[mcp->gp_idx + 1];
> + mcp->gpio_dir = data[mcp->gp_idx + 1];
> }
> break;
> default:
> @@ -860,7 +890,7 @@ static int mcp2221_probe(struct hid_device *hdev,
> mcp->gc->get_direction = mcp_gpio_get_direction;
> mcp->gc->set = mcp_gpio_set;
> mcp->gc->get = mcp_gpio_get;
> - mcp->gc->ngpio = 4;
> + mcp->gc->ngpio = MCP_NGPIO;
> mcp->gc->base = -1;
> mcp->gc->can_sleep = 1;
> mcp->gc->parent = &hdev->dev;
> --
> 2.25.1
>
Reviewed-by: Rishi Gupta
Regards,
Rishi
Thanks Arnd, How about one liner:
depends on USB_HID && I2C && GPIOLIB
Reviewed-by: Rishi Gupta
On Wed, Apr 29, 2020 at 3:00 AM Arnd Bergmann wrote:
>
> Without gpiolib, this driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/hid/hid-mcp2221.o: in function `m
Forget to capture in change log:
removed PSM sysfs completely.
On Tue, Oct 22, 2019 at 6:41 PM Rishi Gupta wrote:
>
> The driver for veml6030 light sensor provides sysfs
> entries like configuring cutoff for interrupt. This
> commit document them.
>
> Signed-off-by: Rishi Gupt
This commit adds device tree bindings for veml6030 ambient
light sensor.
Signed-off-by: Rishi Gupta
---
Changes in v5:
* None
Changes in v4:
* Added enum in reg property
* Removed maxItems from reg property
Changes in v3:
* None
Changes in v2:
* Corrected grammatical mistake from 'is
The driver for veml6030 light sensor provides sysfs
entries like configuring cutoff for interrupt. This
commit document them.
Signed-off-by: Rishi Gupta
---
Changes in v5:
* Use ABI/testing/sysfs-bus-iio to document sysfs files for veml6030
Changes in v4:
* None
Changes in v3:
* Updated Date
over I2C.
Signed-off-by: Rishi Gupta
---
Changes in v5:
* Removed setting val2 when returning IIO_VAL_INT
* Removed redundant return from veml6030_read_raw()
* Set 4000 as min time in usleep_range(4000, 4002)
Changes in v4:
* None
Changes in v3:
* Added appnote link in topmost comments section
aving, integration time and
> > gain options. Communication with host is over I2C.
> >
> > Signed-off-by: Rishi Gupta
>
> Please avoid this complex nested replies to old patches.
> New version of a series should be a new thread.
>
> It's much easier for mys
The driver for veml6030 light sensor provides custom sysfs entries
used to know parameters supported by the driver and to configure
sensor like setting power saving mode and persistence etc. This
commit document them.
Signed-off-by: Rishi Gupta
---
Changes in v4:
* None
Changes in v3:
* Updated
This commit adds device tree bindings for veml6030 ambient
light sensor.
Signed-off-by: Rishi Gupta
---
Changes in v4:
* Added enum in reg property
* Removed maxItems from reg property
Changes in v3:
* None
Changes in v2:
* Corrected grammatical mistake from 'is' to 'are
over I2C.
Signed-off-by: Rishi Gupta
---
Changes in v4:
* None
Changes in v3:
* Added appnote link in topmost comments section
* Dropped 'return ret' statements wherever not needed
* Removed .scan_index from channel specifications, not needed
* If irq is not enabled, events interfac
My email server returned error so I was confused whether all patches
reached to mailing list intact or not, that is why I resent.
Regards,
Rishi
On Sat, Oct 5, 2019 at 7:38 PM Jonathan Cameron wrote:
>
> On Tue, 24 Sep 2019 16:21:55 +0530
> Rishi Gupta wrote:
>
> When doing a RE
The driver for veml6030 light sensor provides custom sysfs entries
used to know parameters supported by the driver and to configure
sensor like setting power saving mode and persistence etc. This
commit document them.
Signed-off-by: Rishi Gupta
---
Changes in v3:
* Updated Date from September to
This commit adds device tree bindings for veml6030 ambient
light sensor.
Signed-off-by: Rishi Gupta
---
Changes in v3:
* None
Changes in v2:
* Corrected grammatical mistake from 'is' to 'are' in description of bindings
.../devicetree/bindings/iio/light/v
over I2C.
Signed-off-by: Rishi Gupta
---
Changes in v3:
* Added appnote link in topmost comments section
* Dropped 'return ret' statements wherever not needed
* Removed .scan_index from channel specifications, not needed
* If irq is not enabled, events interfaces are not exposed now
* Retur
ght: add veml6030 ALS bindings
[PATCH 3/3] iio: documentation: light: Add veml6030 sysfs documentation
Rishi Gupta (3):
iio: light: add driver for veml6030 ambient light sensor
dt-bindings: iio: light: add veml6030 ALS bindings
iio: documentation: light: Add veml6030 sysfs documentation
.../ABI
The driver for veml6030 light sensor provides custom sysfs entries
used to know parameters supported by the driver and to configure
sensor like setting power saving mode and persistence etc. This
commit document them.
Signed-off-by: Rishi Gupta
---
Changes in v2:
* Nothing has changed in this
over I2C.
Signed-off-by: Rishi Gupta
---
Changes in v2:
* Added comma after CH_WHITE in enum veml6030_chan so it can be extended
* Removed .scan_type as driver doesn't use buffered mode
* Removed iio_device_unregister() as kernel will take care of cleaning
drivers/iio/light/Kconfig
This commit adds device tree bindings for veml6030 ambient
light sensor.
Signed-off-by: Rishi Gupta
---
Changes in v2:
* Corrected grammatical mistake from 'is' to 'are' in description of bindings
.../devicetree/bindings/iio/light/veml6030.yaml| 62 ++
This commit replaces direct invocations of printk with
their appropriate pr_info/warn() variant.
Signed-off-by: Rishi Gupta
---
Changes in v3:
* Use hid_warn() subsystem specific variant instead of pr_warn()
drivers/hid/hidraw.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions
Compiler generates following warning when kernel is built with W=1:
drivers/mtd/ubi/ubi.h:971:1: warning: ‘static’ is not at beginning
of declaration [-Wold-style-declaration]
This commit fixes this by correctly ordering keywords.
Signed-off-by: Rishi Gupta
---
drivers/mtd/ubi/ubi.h | 2 +-
1
This commit replaces direct invocations of printk with
their appropriate pr_info/warn() variant.
Signed-off-by: Rishi Gupta
---
Changes in v2:
- Removed manually adding prefix "hidraw:".
drivers/hid/hidraw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/d
This commit adds device tree bindings for veml6030 ambient
light sensor.
Signed-off-by: Rishi Gupta
---
.../devicetree/bindings/iio/light/veml6030.yaml| 62 ++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml
The veml6030 is an ambient light sensor from vishay and
is a different hardware from an existing hardware for which
driver currently exist, therefore this driver submission.
* All features; ALS, white channel & power management is
supported.
* All configurable parameters are supported through s
over I2C.
Signed-off-by: Rishi Gupta
---
drivers/iio/light/Kconfig| 11 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/veml6030.c | 647 +++
3 files changed, 659 insertions(+)
create mode 100644 drivers/iio/light/veml6030.c
diff --git a
The veml6030 is an ambient light sensor from vishay and
is a different hardware from an existing hardware for which
driver currently exist, therefore this driver submission.
* All features; ALS, white channel and power management is
supported.
* All configurable parameters are supported through
rote:
>
> On Sun, 2019-08-18 at 13:04 +0530, Rishi Gupta wrote:
> > The printk functions are invoked without specifying required
> > log level when printing error messages. This commit replaces
> > all direct uses of printk with their corresponding pr_err/info/debug
> &g
Direct invocation of printk() is not preferred to emit logs.
This commit replaces printk(KERN_WARNING) with corresponding
pr_warn() function call.
Signed-off-by: Rishi Gupta
---
drivers/thermal/intel/int340x_thermal/int3403_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
This commit replaces direct invocations of printk with
their appropriate pr_info/warn() variant.
Signed-off-by: Rishi Gupta
---
drivers/hid/hidraw.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c
index 006bd6f..67b652b
The printk functions are invoked without specifying required
log level when printing error messages. This commit replaces
all direct uses of printk with their corresponding pr_err/info/debug
variant.
Signed-off-by: Rishi Gupta
---
Changes in v2:
- Replaced all printk(KERN_ERR with pr_err
printk function is invoked without specifying KERN_ERR log
level when printing error messages. This commit fixes this.
Signed-off-by: Rishi Gupta
---
drivers/char/toshiba.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/toshiba.c b/drivers/char/toshiba.c
EXPORT_SYMBOL should appear next to the function as it improves
code maintenance. This commit fixes this issue as identified by
checkpatch script.
Signed-off-by: Rishi Gupta
---
drivers/amba/bus.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/amba
Thanks Joe for higlighting this. I am going
to send patches for them as well soon.
An extra 'for' word is grammatically incorrect in the comment
'verifying ops for multi-parent clks'. This commit removes
this extra for word.
Signed-off-by: Rishi Gupta
---
drivers/clk/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk
33 matches
Mail list logo
