Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 8
net/nfc/nci/core.c | 16
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/net/nfc/nci_core.h b/include/net/nfc/nci_core.h
index 530df66..1e3db2b 100644
--- a/include/net/nfc
to get the new connection ID
- nci: Allow the driver to set handler for core nci ops
Robert Dolca (10):
nfc: nci: Export nci data send API
nfc: nci: Add function to get max packet size for conn
nfc: nci: Introduce new core opcodes
nfc: nci: Do not call post_setup when setup fails
nfc:
FDP driver needs to send the firmware as regular packets
(not fragmented). The driver should have a way to
get the max packet size for a given connection.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/data.c | 12
2 files changed, 13
For the firmware update the driver may use nci_send_data.
Signed-off-by: Robert Dolca
---
net/nfc/nci/data.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c
index 566466d..83acd18 100644
--- a/net/nfc/nci/data.c
+++ b/net/nfc/nci/data.c
@@ -203,6
driver needs to take certain actions when a reset
notification arrives (packet also not handled by the nfc core).
The driver handlers do not interfere with the core and they are called
after the core processes the packet.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 11 +--
net
Initially it was used to create hooks in the driver for proprietary
operations. Currently it is being used for hooks for both proprietary
and generic operations.
Signed-off-by: Robert Dolca
---
drivers/nfc/s3fwrn5/nci.c | 4 ++--
drivers/nfc/st-nci/core.c | 2 +-
include/net/nfc/nci_core.h
This allows sending core commands from the driver. The driver should be
able to send NCI core commands like CORE_GET_CONFIG_CMD.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/core.c | 24 +++-
2 files changed, 20 insertions(+), 5
If the number of destination speific parameters supplied is 0 the call
will fail. If the first destination specific parameter does not have a
value, curr_id will be set to 0.
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff
enumerated using ACPI using the id INT339A.
The 1st GPIO is the IRQ and the 2nd is the RESET pin.
Signed-off-by: Robert Dolca
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/Makefile | 1 +
drivers/nfc/fdp/Kconfig | 23 ++
drivers/nfc/fdp/Makefile | 9 +
drivers/nfc/fdp/fdp.c
This functin takes as a parameter a pointer to the nci_dev struct and
the first byte from the values of the first domain specific parameter that
was used for the connection creation.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/core.c | 13
Add NCI_OP_CORE_GET_CONFIG_CMD, NCI_OP_CORE_GET_CONFIG_RSP
and NCI_OP_CORE_RESET_NTF.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/net/nfc/nci.h b/include/net/nfc/nci.h
index 75d2e18..b495825 100644
--- a/include/net
The driver should know that it can continue with post setup where
setup left off. Being able to execute post_setup when setup fails may
force the developer to keep this state in the driver.
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
On Wed, Aug 26, 2015 at 12:32:27AM +0300, Robert Dolca wrote:
> This driver adds support for Silead touchscreens. It has been tested
> with GSL1680 and GSL3680 touch panels.
>
> It supports ACPI and device tree enumeration. Screen resolution,
> the maximum number of fingers support
FDP driver needs to send the firmware as regular packets
(not fragmented). The driver should have a way to
get the max packet size for a given connection.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/data.c | 12
2 files changed, 13
nci_core_conn_create has a new parameter so it can return the id of the
new connection. Also now you can't call nci_core_conn_create
without waiting for the answer from the previous call.
Signed-off-by: Robert Dolca
---
drivers/nfc/st-nci/st-nci_se.c | 2 +-
include/net/nfc/nci_core.h
Add NCI_OP_CORE_GET_CONFIG_CMD, NCI_OP_CORE_GET_CONFIG_RSP
and NCI_OP_CORE_RESET_NTF.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/net/nfc/nci.h b/include/net/nfc/nci.h
index 75d2e18..b495825 100644
--- a/include/net
This allows sending core commands from the driver. The driver should be
able to send NCI core commands like CORE_GET_CONFIG_CMD.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/core.c | 24 +++-
2 files changed, 20 insertions(+), 5
driver needs to take certain actions when a reset
notification arrives (packet also not handled by the nfc core).
The driver handlers do not interfere with the core and they are called
after the core processes the packet.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 13
For the firmware update the driver may use nci_send_data.
Signed-off-by: Robert Dolca
---
net/nfc/nci/data.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/nfc/nci/data.c b/net/nfc/nci/data.c
index 566466d..83acd18 100644
--- a/net/nfc/nci/data.c
+++ b/net/nfc/nci/data.c
@@ -203,6
The driver should know that it can continue with post setup where
setup left off. Being able to execute post_setup when setup fails may
force the developer to keep this state in the driver.
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions
enumerated using ACPI using the id INT339A.
The 1st GPIO is the IRQ and the 2nd is the RESET pin.
Signed-off-by: Robert Dolca
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/Makefile | 1 +
drivers/nfc/fdp/Kconfig | 23 ++
drivers/nfc/fdp/Makefile | 9 +
drivers/nfc/fdp/fdp.c
nci_request to allow calling the function
during setup.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 3 +++
net/nfc/nci/core.c | 30 --
2 files changed, 19 insertions(+), 14 deletions(-)
diff --git a/include/net/nfc/nci_core.h b/include/net/nfc
)
- nci: check the setup return code before callig post_setup
- nci: add function to allow sending core commands from driver
- nci: Use a separate mutex for nci open and close
- nci: mutex for: Adds a way to get the new connection ID
- nci: Allow the driver to set handler for core nci ops
On Sun, May 24, 2015 at 8:07 PM, Samuel Ortiz wrote:
> Hi Robert,
>
> On Tue, Mar 31, 2015 at 05:03:42PM +0300, Robert Dolca wrote:
>> On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
>> > Hi Robert,
>> >
>> > On Tue, Feb 24, 2015 at 12:01:45PM +
dware variants tested report finger id 0 for all fingers so
the finger tracking is done using the input subsystem's slot assignment.
Signed-off-by: Robert Dolca
---
Changes since v2
- removed device properties requirements
- max x and y default to 4095
- max fingers def
On Tue, Jul 28, 2015 at 12:30 AM, Dmitry Torokhov
wrote:
> On Mon, Jul 20, 2015 at 03:05:44PM +0300, Robert Dolca wrote:
>> Hi Dmitry,
>>
>> On Mon, Jul 20, 2015 at 9:51 AM, Dmitry Torokhov
>> wrote:
>> > On Fri, Jul 10, 2015 at 06:11:04PM +0300, Robert
Q.
Screen resolution, the maximum number of fingers supported and firmware
name are configurable using ACPI/DT properties.
Signed-off-by: Robert Dolca
---
Changes since v1
- changed device tree properties names
- removed cast for `void *id`
- removed ifdef from suspend and resume and use __ma
Hi Dmitry,
On Mon, Jul 20, 2015 at 9:51 AM, Dmitry Torokhov
wrote:
> On Fri, Jul 10, 2015 at 06:11:04PM +0300, Robert Dolca wrote:
> > This driver adds support for Silead touchscreens. It has been tested
> > with GSL1680 and GSL3680 touch panels.
> >
> > It su
Q.
Screen resolution, the maximum number of fingers supported and firmware name
are configurable using ACPI/DT properties.
Signed-off-by: Robert Dolca
---
drivers/input/touchscreen/Kconfig | 12 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/sile
On Wed, May 20, 2015 at 4:57 PM, Mika Westerberg wrote:
> On Wed, May 20, 2015 at 04:07:00PM +0300, Robert Dolca wrote:
>> On Wed, May 20, 2015 at 1:57 PM, Mika Westerberg wrote:
>> > On Wed, May 20, 2015 at 01:49:02PM +0300, Robert Dolca wrote:
>> >> On Wed,
On Wed, May 20, 2015 at 1:57 PM, Mika Westerberg
wrote:
> On Wed, May 20, 2015 at 01:49:02PM +0300, Robert Dolca wrote:
>> On Wed, May 20, 2015 at 12:48 PM, Mika Westerberg wrote:
>> > On Wed, May 20, 2015 at 12:39:22PM +0300, Robert Dolca wrote:
>> >> Currently, i
On Wed, May 20, 2015 at 12:48 PM, Mika Westerberg wrote:
> On Wed, May 20, 2015 at 12:39:22PM +0300, Robert Dolca wrote:
>> Currently, if the name used for DT (in dts) matches one of the names
>> specified in the id table you will have a match. Isn't that an
>> intended b
On Wed, May 20, 2015 at 10:47 AM, Mika Westerberg wrote:
> On Tue, May 19, 2015 at 05:03:29PM +0300, Robert Dolca wrote:
>> For i2c devices enumerated with ACPI you need to declare both
>> acpi_match_table and id_table. When using ACPI, the i2c_device_id structure
>> supplied
id and the
driver doesn't have to declare acpi_match_table.
Signed-off-by: Robert Dolca
---
drivers/i2c/i2c-core.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index fec0e0d..c9b30b7 100644
--- a/drivers/i2c/i
> er0
> >>>>>
> >>>>> This should be used for device specific triggers. Doing this the user
> >>>>> space
> >>>>> applications can figure out what if the trigger registered by a
> >>>>> specific device
>
The trigger registered by the driver has the main purpose to be used
with this driver so it should be linked to the IIO device. This
way the user space applications can find the connection between them.
Signed-off-by: Robert Dolca
---
drivers/iio/common/st_sensors/st_sensors_trigger.c | 2 +-
1
tch adds a flag
in the dev_iio struct and checks it when iio_trigger_register_with_dev is
called.
Signed-off-by: Robert Dolca
---
drivers/iio/industrialio-core.c| 4
drivers/iio/industrialio-trigger.c | 6 ++
include/linux/iio/iio.h| 1 +
3 files changed, 11 insertions(+)
di
will work as before.
Signed-off-by: Robert Dolca
---
drivers/iio/industrialio-core.c| 20
drivers/iio/industrialio-trigger.c | 64 ++
include/linux/iio/iio.h| 1 +
include/linux/iio/trigger.h| 24 ++
4 files
er was
registered before the device was registered).
The 2nd patch improves the functionality allowing to register a trigger after
the IIO device was registered and the symlink is being created.
In the final patch there is an example on how to use this new API.
Robert Dolca (3):
iio: Add symlink
On Thu, Mar 26, 2015 at 2:30 AM, Samuel Ortiz wrote:
>> + /* If a patch was applied the new version is checked */
>> + if (patched) {
>> + r = nci_init(ndev);
>> + if (r)
>> + goto error;
>> +
>> + r = fdp_nci_get_versions(ndev);
>> +
On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
> Hi Robert,
>
> On Tue, Feb 24, 2015 at 12:01:45PM +0200, Robert Dolca wrote:
>> By calling __nci_request instead of nci_request allows the driver to use
>> the function while initializing the device (setup stage)
>&g
On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
> Hi Robert,
>
> On Tue, Feb 24, 2015 at 12:01:48PM +0200, Robert Dolca wrote:
>> This patch adds nci_request_driver and nci_req_complete_driver
>> as a wrapper for __nci_request. When nci_req_complete_driver is
>>
On Thu, Mar 26, 2015 at 2:29 AM, Samuel Ortiz wrote:
> Hi Robert,
>
> On Tue, Feb 24, 2015 at 12:01:47PM +0200, Robert Dolca wrote:
>> In order to communicate with the device during the setup
>> phase, the driver may need to initialize the device. After
>> the setu
On Wed, Mar 25, 2015 at 11:12 PM, Octavian Purdila
wrote:
> On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg
> wrote:
>> On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote:
>>> I think we can do the same for ACPI GpioInts so that we introduce
>>> acpi_gpio_irq_get() that translates f
On Wed, Mar 25, 2015 at 3:21 PM, Mika Westerberg
wrote:
> On Wed, Mar 25, 2015 at 02:25:05PM +0200, Mika Westerberg wrote:
>> I think we can do the same for ACPI GpioInts so that we introduce
>> acpi_gpio_irq_get() that translates from GpioInt to Linux IRQ
>> numberspace. Then we can do something
On Tue, Mar 24, 2015 at 2:17 PM, Lars-Peter Clausen wrote:
> [...]
>>
>> +int st_sensors_acpi_i2c_probe(struct i2c_client *client,
>> + const struct acpi_device_id *match)
>> +{
>> + const struct acpi_device_id *id;
>> + struct gpio_desc *gpiod_irq;
>> +
It can be used exactly like L3GD20 but it has a different WhoAmI
register value.
Signed-off-by: Robert Dolca
---
drivers/iio/gyro/st_gyro_core.c | 83 +
1 file changed, 83 insertions(+)
diff --git a/drivers/iio/gyro/st_gyro_core.c b/drivers/iio/gyro
Signed-off-by: Robert Dolca
---
drivers/iio/common/st_sensors/st_sensors_i2c.c | 35 ++
drivers/iio/gyro/st_gyro_i2c.c | 29 -
include/linux/iio/common/st_sensors_i2c.h | 3 +++
3 files changed, 66 insertions(+), 1 deletion
On Tue, Feb 24, 2015 at 11:33:10AM +0100, Johannes Berg wrote:
> > +config NFC_FDP
> > + tristate "Intel FDP NFC driver"
> > + depends on NFC_NCI
> > + select CRC_CCITT
> > + default n
> > + ---help---
> > + Intel FDP core driver.
> > + This is a driver based on the NCI NFC kernel
ction from the driver while
the dev was down.
The max packet size of a connection can be retrieved by the driver.
The init, reset NCI functions can be called from the driver. The driver
can also send command to the device using the NFC subsystem using the
request - response blocking method.
Robert
nci_send_cmd was exported in order to send commands to the device from
the driver. For the firmware update the driver may use nci_send_data.
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 1 +
net/nfc/nci/data.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/net/nfc/nci/core.c b
In order to communicate with the device during the setup
phase, the driver may need to initialize the device. After
the setup is done the driver should reset the device to leave
it in the same state that it was before the setup function
call.
Signed-off-by: Robert Dolca
---
include/net/nfc
If the previous nci_request (NCI reset) failed the setup function
was being called anyway. It shouldn't be called if the reset failed.
The result of the setup function is taken into consideration. If it
fails the init should fail.
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 4 ++
nci_core_conn_create not has a new parameter so it can return
the ID of the new connection. Also not you can't call nci_core_conn_create
without waiting the answer for the previous call.
Signed-off-by: Robert Dolca
---
drivers/nfc/st21nfcb/st21nfcb_se.c | 2 +-
include/net/nfc/nci_c
FDP driver needs to send the firmware as regular packets
(not fragmented). That's whay the driver should have a way to
get the max packet size for a given connection.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 1 +
net/nfc/nci/data.c | 12
2 files ch
The device can be enumerated using ACPI using the id INT339A.
The 1st GPIO is the IRQ and the 2nd is the RESET pin.
I can be also enumerated using platform init.
Signed-off-by: Robert Dolca
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/fdp/Kconfig | 22 ++
drivers/nfc
exported in order to send commands to
the device from the driver. It shouldn't be used without
nci_req_complete_driver because cmd_cnt will have the wrong value.
Signed-off-by: Robert Dolca
---
include/net/nfc/nci_core.h | 4
net/nfc/nci/core.c | 19 +++
2 files ch
By calling __nci_request instead of nci_request allows the driver to use
the function while initializing the device (setup stage)
Signed-off-by: Robert Dolca
---
net/nfc/nci/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index
Hi Uwe,
On Thu, Feb 12, 2015 at 09:14:59AM +0100, Uwe Kleine-König wrote:
> On Mon, Jan 26, 2015 at 01:13:37PM +0200, Robert Dolca wrote:
> > + /* Get EN GPIO from ACPI */
> > + gpiod_en = devm_gpiod_get_index(dev, PN544_GPIO_NAME_EN, 1);
> Actually devm_gpiod_get_index tak
The 2nd parameter of skb_trim is the new length of the skb.
pn544_hci_i2c_remove_len_crc used the tailroom for the 2nd parameter so
the new length was 2 no metter how big the skb was.
Now the length is (skb->len - PN544_I2C_FRAME_TAILROOM)
Signed-off-by: Robert Dolca
---
drivers/nfc/pn
Currently there is no support for ACPI.
This patch uses the following configuration:
- Device id: NXP5440
- Pin mapping:
- 0 IRQ pin
- 1 enable pin
- 2 firmware pin
Signed-off-by: Robert Dolca
---
drivers/nfc/pn544/i2c.c | 115
- Removed debug define and Kconfig include
- Minor fixes to patch subjects
Links to v1:
- http://lkml.iu.edu/hypermail/linux/kernel/1501.1/00943.html
- http://lkml.iu.edu/hypermail/linux/kernel/1501.1/00944.html
Robert Dolca (2):
NFC: PN544: GPIO access that may sleep
NFC
gpio_set_value was replaced with gpio_set_value_cansleep in order
to allow GPIO access that may sleep. This is particularelly useful
when GPIO is accessed using busses like I2C, SPI, USB
Signed-off-by: Robert Dolca
---
drivers/nfc/pn544/i2c.c | 22 --
1 file changed, 12
Device id: NXP5440
Pin mapping:
- 0 IRQ pin
- 1 enable pin
- 2 firmware pin
Signed-off-by: Robert Dolca
---
drivers/nfc/Kconfig | 1 +
drivers/nfc/pn544/i2c.c | 115 ++--
net/nfc/core.c | 1 +
3 files changed, 114 insertions(+), 3
gpio_set_value was replaced with gpio_set_value_cansleep in order
to allow GPIO access that may sleep. This is particularelly useful
when GPIO is accessed using busses like I2C, SPI, USB
Signed-off-by: Robert Dolca
---
drivers/nfc/pn544/i2c.c | 20 ++--
1 file changed, 10
65 matches
Mail list logo
