This patch fixes a few spacing warnings from checkpatch.pl,
as well as an incorrect spacing between a function type and
the function name.
Signed-off-by: Robert Eshleman
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
On Tue, Feb 26, 2019 at 10:09:54PM -0800, Robert Eshleman wrote:
> This patch reduces a call to memset(,0) by replacing
> a kmalloc call with a kzalloc call.
>
> Signed-off-by: Robert Eshleman
> ---
> drivers/net/ethernet/seeq/ether3.c | 3 +--
> 1 file changed, 1 inse
On Tue, Feb 26, 2019 at 10:22:06PM -0800, Joe Perches wrote:
> On Tue, 2019-02-26 at 22:09 -0800, Robert Eshleman wrote:
> > This patch replaces a pci_alloc_consistent and memset(,0) call
> > with a single call to pci_zalloc_consistent.
> []
> > diff --git a/drivers/
This patch reduces a call to memset(,0) by replacing
a kmalloc call with a kzalloc call.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/seeq/ether3.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/seeq/ether3.c
b/drivers/net/ethernet/seeq
This patch removes a call to memset(,0) by replacing the
prior call to dma_pool_alloc with a call to dma_pool_zalloc.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/xscale/ixp4xx_eth.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
This patch replaces a kmalloc/memset(,0) call with a call to kzalloc.
It also removes a memset(,0) call that always follows a *zalloc call.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/mellanox/mlx4/cmd.c | 1 -
drivers/net/ethernet/mellanox/mlx4/en_rx.c | 3 +--
2 files changed, 1
This patch replaces a call to pci_alloc_consistent and then
memset(0,) with a single call to pci_zalloc_consistent.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/mellanox/mlxsw/pci.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
This patch replaces unnecessary memset(,0) calls with
simply assigning structs to zero.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/qlogic/qed/qed_cxt.c | 4 +-
drivers/net/ethernet/qlogic/qed/qed_hw.c | 3 +-
drivers/net/ethernet/qlogic/qed/qed_mcp.c | 70
This patch replaces a pci_alloc_consistent and memset(,0) call
with a single call to pci_zalloc_consistent.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/ti/tlan.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net
This patch replaces a pci_alloc and memset(,0) call
with a single call to pci_zalloc.
Signed-off-by: Robert Eshleman
---
drivers/net/ethernet/atheros/atlx/atl2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/atheros/atlx/atl2.c
b/drivers/net
-by: Robert Eshleman
---
.../ethernet/qlogic/netxen/netxen_nic_ctx.c | 36 +++
1 file changed, 13 insertions(+), 23 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
index 7503aa222392..f2010c032361 100644
This patch series removes calls to memset(,0) that are
redundant when used in conjunction with a zalloc call or
by simple zero-assignment of structs.
Robert Eshleman (8):
net/mlx4: use kzalloc instead of kmalloc
net/mlxsw: use pci_zalloc_consistent instead of pci_alloc_consistent
tlan: use
This patch adds a vendor-prefix for the Lite-On Semiconductor
Corporation.
Signed-off-by: Robert Eshleman
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation
* Calibration bias for proximity
Signed-off-by: Robert Eshleman
---
Changes in v2:
- Add mutex protection in IRQ handler
- Support interrupt clearing for PS and ALS separately
- Mask away reserved bits when reading device registers
- Use regmap_bulk_read and regmap_bulk_write when possible
- Style
Adds device tree bindings for the ap3216c ambient light and proximity
sensor.
Signed-off-by: Robert Eshleman
---
.../devicetree/bindings/iio/light/ap3216c.txt | 22 +++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/ap3216c.txt
Hey Peter,
Thanks for the feedback. I have a question regarding INFO_SCALE and
the calibration scale/bias below.
Thanks for the feedback, it's much appreciated.
On Mon, Feb 11, 2019 at 03:58:27PM +0100, Peter Meerwald-Stadler wrote:
> On Sun, 10 Feb 2019, Robert Eshleman wr
On Tue, Feb 12, 2019 at 08:47:30PM +, Jonathan Cameron wrote:
> On Mon, 11 Feb 2019 17:30:18 -0500
> Sven Van Asbroeck wrote:
>
> > On Mon, Feb 11, 2019 at 4:27 PM Jonathan Cameron wrote:
> > >
> > > Agreed. Or potentially just use regmap_bulk_read and rely on
> > > the regmap internal
On Mon, Feb 11, 2019 at 02:29:58PM -0500, Sven Van Asbroeck wrote:
> On Sun, Feb 10, 2019 at 3:39 PM Robert Eshleman
> wrote:
> >
> > This patch adds support for the ap3216c ambient light and proximity
> > sensor.
>
> PS
>
> Why not use the chip in the mode
This patch adds a vendor-prefix for the Lite-On Semiconductor
Corporation.
Signed-off-by: Robert Eshleman
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation
Adds device tree bindings for the ap3216c ambient light and proximity
sensor.
Signed-off-by: Robert Eshleman
---
.../devicetree/bindings/iio/light/ap3216c.txt | 22 +++
1 file changed, 22 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/ap3216c.txt
-off-by: Robert Eshleman
---
drivers/iio/light/Kconfig | 11 +
drivers/iio/light/Makefile | 1 +
drivers/iio/light/ap3216c.c | 793
3 files changed, 805 insertions(+)
create mode 100644 drivers/iio/light/ap3216c.c
diff --git a/drivers/iio/light/Kconfig b
Adds device tree bindings for the max44009 light sensor.
Signed-off-by: Robert Eshleman
---
Changes to v4:
- Add subsystem to subject line
- Change node name to be 'light-sensor'
- Clean up style
Changes to v3:
- None
Changes to v2:
- Clean up style
.../bindings/iio/light/max44009.txt
Signed-off-by: Robert Eshleman
---
Changes to v4:
- Reformat subject line
- Clean up whitespace
Changes to v3:
- Remove unnecessary mask when setting integration time
- Return IRQ_NONE in IRQ handler when interrupt not from this device
- Fix incorrect register usage when reading lux low byte
- Clean
This patch adds device tree documentation for the max44009 ambient light sensor.
Signed-off-by: Robert Eshleman
---
Changes to v3:
- None
Changes to v2:
- Clean up style
.../bindings/iio/light/max44009.txt | 25 +++
1 file changed, 25 insertions(+)
create mode
Signed-off-by: Robert Eshleman
---
Changes to v3:
- Remove unnecessary mask when setting integration time
- Return IRQ_NONE in IRQ handler when interrupt not from this device
- Fix incorrect register usage when reading lux low byte
- Clean up style
Changes to v2:
- Remove unnecessary mutex locking
Signed-off-by: Robert Eshleman
---
.../bindings/iio/light/max44009.txt | 25 +++
1 file changed, 25 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/light/max44009.txt
diff --git a/Documentation/devicetree/bindings/iio/light/max44009.txt
b
Signed-off-by: Robert Eshleman
---
Changes to v2:
- Remove unnecessary mutex locking
- Remove unnecessary triggered buffer support
- Remove unnecessary wrapper functions for smbus reads and writes
- Remove scale avail support
- Use constant scale to provide processed values instead of raw
- Remove
.
Mostly this email is just an ack that I've started working on the
changes.
Thanks again,
Robert
> On Sat, 19 Jan 2019, Jonathan Cameron wrote:
>
> some more comments from my side below...
>
> > On Wed, 16 Jan 2019 22:56:23 -0800
> > Robert Eshleman wrote:
> >
-by: Robert Eshleman
---
.../bindings/iio/light/max44009.txt | 25 +
drivers/iio/light/Kconfig | 13 +
drivers/iio/light/Makefile| 1 +
drivers/iio/light/max44009.c | 696 ++
4 files changed, 735 insertions
Rename fields in fw_priv struct from CamelCase to snake_case.
Reported by checkpatch.
Signed-off-by: Robert Eshleman
---
drivers/staging/rtl8712/hal_init.c| 10 +-
drivers/staging/rtl8712/rtl8712_hal.h | 8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git
Rename fields in fw_priv struct from CamelCase to snake_case.
Reported by checkpatch.
Signed-off-by: Robert Eshleman
---
drivers/staging/rtl8712/hal_init.c| 10 +-
drivers/staging/rtl8712/rtl8712_hal.h | 8
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git
31 matches
Mail list logo
