Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-21 Thread Robert Jennings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/20/2014 11:41 PM, Michael Ellerman wrote: > On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: >> Continue is not needed at the bottom of a loop. > > True. > > I wonder though, is the code trying to continue to the outer loop? > I st

Re: [PATCH] Update Maintainers for IBM Power 842, vscsi, and vfc drivers

2014-04-11 Thread Robert Jennings
; Signed-off-by: Nathan Fontenot Nathan, sorry I didn't take care of this before I gave up r...@linux.ibm.com. Acked-by: Robert Jennings > --- MAINTAINERS | 16 +++- 1 file changed, 11 > insertions(+), 5 deletions(-) >

[PATCH v2 1/2] vmsplice: unmap gifted pages for recipient

2013-10-25 Thread Robert Jennings
From: Robert C Jennings Introduce use of the unused SPLICE_F_MOVE flag for vmsplice to zap pages. When vmsplice is called with flags (SPLICE_F_GIFT | SPLICE_F_MOVE) the writer's gift'ed pages would be zapped. This patch supports further work to move vmsplice'd pages rather than copying them. T

[PATCH v2 0/2] vmpslice support for zero-copy gifting of pages

2013-10-25 Thread Robert Jennings
From: Robert C Jennings This patch set would add the ability to move anonymous user pages from one process to another through vmsplice without copying data. Moving pages rather than copying is implemented for a narrow case in this RFC to meet the needs of QEMU's usage (below). Among the restric

[PATCH v2 2/2] vmsplice: Add limited zero copy to vmsplice

2013-10-25 Thread Robert Jennings
From: Robert C Jennings It is sometimes useful to move anonymous pages over a pipe rather than save/swap them. Check the SPLICE_F_GIFT and SPLICE_F_MOVE flags to see if userspace would like to move such pages. This differs from plain SPLICE_F_GIFT in that the memory written to the pipe will no lo

Re: [PATCH 2/2] vmsplice: Add limited zero copy to vmsplice

2013-10-17 Thread Robert Jennings
* Vlastimil Babka (vba...@suse.cz) wrote: > On 10/07/2013 10:21 PM, Robert C Jennings wrote: > > From: Matt Helsley > > > > It is sometimes useful to move anonymous pages over a pipe rather than > > save/swap them. Check the SPLICE_F_GIFT and SPLICE_F_MOVE flags to see > > if userspace would like

Re: [PATCH 1/2] vmsplice: unmap gifted pages for recipient

2013-10-17 Thread Robert Jennings
* Dave Hansen (d...@sr71.net) wrote: > On 10/07/2013 01:21 PM, Robert C Jennings wrote: > > spd.partial[page_nr].offset = loff; > > spd.partial[page_nr].len = this_len; > > + spd.partial[page_nr].useraddr = index << PAGE_CACHE_SHIFT; > > len -= this_len

Re: [PATCH 1/2] vmsplice: unmap gifted pages for recipient

2013-10-17 Thread Robert Jennings
* Vlastimil Babka (vba...@suse.cz) wrote: > On 10/07/2013 10:21 PM, Robert C Jennings wrote: > > Introduce use of the unused SPLICE_F_MOVE flag for vmsplice to zap > > pages. > > > > When vmsplice is called with flags (SPLICE_F_GIFT | SPLICE_F_MOVE) the > > writer's gift'ed pages would be zapped.

Re: [PATCH 1/2] vmsplice: unmap gifted pages for recipient

2013-10-08 Thread Robert Jennings
* Dave Hansen (d...@sr71.net) wrote: > On 10/07/2013 01:21 PM, Robert C Jennings wrote: > > + } else { > > + if (vma) > > + zap_page_range(vma, > > +

Re: [PATCH 2/2] vmsplice: Add limited zero copy to vmsplice

2013-10-08 Thread Robert Jennings
* Dave Hansen (d...@sr71.net) wrote: > On 10/07/2013 01:21 PM, Robert C Jennings wrote: > > + if (!buf->offset && (buf->len == PAGE_SIZE) && > > + (buf->flags & PIPE_BUF_FLAG_GIFT) && (sd->flags & SPLICE_F_MOVE)) { > > + struct page *page = buf->page; > > + struct mm_str

Re: [RFC PATCH 1/2] vmsplice unmap gifted pages for recipient

2013-07-26 Thread Robert Jennings
* Dave Hansen (d...@sr71.net) wrote: > On 07/25/2013 10:21 AM, Robert Jennings wrote: > > +static void zap_buf_page(unsigned long useraddr) > > +{ > > + struct vm_area_struct *vma; > > + > > + down_read(¤t->mm->mmap_sem); > > + vma

[RFC PATCH 1/2] vmsplice unmap gifted pages for recipient

2013-07-25 Thread Robert Jennings
ing them. That patch has the restriction that the page must not be mapped by the source for the move, otherwise it will fall back to copying the page. Signed-off-by: Matt Helsley Signed-off-by: Matt Helsley Signed-off-by: Robert Jennings --- fs/splice.c| 25 -

[RFC PATCH 2/2] Add limited zero copy to vmsplice

2013-07-25 Thread Robert Jennings
d. Signed-off-by: Matt Helsley Signed-off-by: Matt Helsley Signed-off-by: Robert Jennings --- fs/splice.c | 63 + 1 file changed, 63 insertions(+) diff --git a/fs/splice.c b/fs/splice.c index 6aa964f..0a715c3 100644 --- a/fs/splice.

[RFC PATCH 0/2] vmpslice support for zero-copy gifting of pages

2013-07-25 Thread Robert Jennings
This patch set would add the ability to move anonymous user pages from one process to another through vmsplice without copying data. Moving pages rather than copying is implemented for a narrow case in this RFC to meet the needs of QEMU's usage (below). Among the restrictions the source address a

Re: zsmalloc limitations and related topics

2013-03-14 Thread Robert Jennings
* Bob (bob@oracle.com) wrote: > On 03/14/2013 06:59 AM, Seth Jennings wrote: > >On 03/13/2013 03:02 PM, Dan Magenheimer wrote: > >>>From: Robert Jennings [mailto:r...@linux.vnet.ibm.com] > >>>Subject: Re: zsmalloc limitations and related topics > >> &

Re: zsmalloc limitations and related topics

2013-03-13 Thread Robert Jennings
* Dan Magenheimer (dan.magenhei...@oracle.com) wrote: > Hi all -- > > I've been doing some experimentation on zsmalloc in preparation > for my topic proposed for LSFMM13 and have run across some > perplexing limitations. Those familiar with the intimate details > of zsmalloc might be well aware o

Re: [PATCHv4 3/7] zswap: add to mm/

2013-01-31 Thread Robert Jennings
* Seth Jennings (sjenn...@linux.vnet.ibm.com) wrote: > On 01/31/2013 01:07 AM, Minchan Kim wrote: > > On Tue, Jan 29, 2013 at 03:40:23PM -0600, Seth Jennings wrote: > >> zswap is a thin compression backend for frontswap. It receives > >> pages from frontswap and attempts to store them in a compress

[PATCH] ibmvscsi: Add maintainer for IBM virtual SCSI/FC drivers

2012-07-31 Thread Robert Jennings
Add a MAINTAINERS entry for the IBM Power Virtual SCSI and FC device drivers. Signed-off-by: Robert Jennings --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index fb036a0..f441c46 100644 --- a/MAINTAINERS +++ b/MAINTAINERS