Re: [PATCH 2/2] HID: redragon Add additional verification to rdesc modification quirk

2018-08-03 Thread Robert Munteanu
7.11 with 85455dd906d5 and cbe7e3ad0eab from Jiri's for-4.19/upstream tree and it works just fine. Feel free to add Acked-By: Robert Munteanu Thanks for looking into this. Robert

Re: [PATCH 1/2] HID: redragon: Fix regression in non-Redragon keyboard due to this new driver

2018-07-30 Thread Robert Munteanu
Hi John, On Sat, 2018-07-28 at 15:53 -0400, John S Gruber wrote: > The Redragon keyboard uses the second device being presented, but > other > devices with the same vendor_id/device_id pair (0x0c45:760b) use the > first. > Don't cause its deletion. Problem introduced in commit 85455dd906d5 > ("HID

[PATCH v5] Fix modifier keys for Redragon Asura Keyboard

2018-04-11 Thread Robert Munteanu
vendor id, update comment style, add SPDX license identifier, rename to hid-redragon, stop registering two input devices, rebased on top of 4.16 Signed-off-by: Robert Munteanu --- drivers/hid/Kconfig| 7 drivers/hid/Makefile | 1 + drivers/hid/hid-ids.h | 1

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

2018-04-16 Thread Robert Munteanu
Hi Benjamin and Jiri, On Mon, 2018-04-16 at 12:02 +0200, Benjamin Tissoires wrote: > Hi Robert, > > On Wed, Apr 11, 2018 at 11:49 AM, Robert Munteanu > wrote: > > Changelog: > > > > - v2: modifier keys work, some combinations are still troublesome > > - v3:

Re: [PATCH v5] Fix modifier keys for Redragon Asura Keyboard

2018-04-16 Thread Robert Munteanu
On Mon, 2018-04-16 at 15:36 +0200, Benjamin Tissoires wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > The SPDX header says GPL-v2. And IIRC if there is the SPDX header > > > you > > > can drop the MODULE_LICENSE (not entirely sure though). > > > > Ack, will adjust and re-test. > > Actually, y

[PATCH v6] Fix modifier keys for Redragon Asura Keyboard

2018-04-16 Thread Robert Munteanu
This adds a new driver for the Redragon Asura keyboard. The Asura keyboard contains an error in the HID descriptor which causes all modifier keys to be mapped to left shift. Additionally, we suppress the creation of a second, not working, keyboard device. Signed-off-by: Robert Munteanu

[PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Robert Munteanu
, rebase on top of 4.14 - v4: remove most debugging calls, make init info useful for user, rebased on top of 4.15 Signed-off-by: Robert Munteanu --- drivers/hid/Kconfig| 9 +++ drivers/hid/Makefile | 2 +- drivers/hid/hid-core.c | 3 + drivers/hid/hid-ids.h | 3

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-21 Thread Robert Munteanu
Hi Benjamin, On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: > Hi Robert, > > First, apologies for not answering to the RFC. I missed it and it > fell > down in my INBOX. > > On Wed, Mar 21, 2018 at 11:43 AM, Robert Munteanu > wrote: > > The microdia

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Wed, 2018-03-21 at 17:51 +0100, Ondrej Zary wrote: > On Wednesday 21 March 2018 11:43:31 Robert Munteanu wrote: > > +#define USB_VENDOR_ID_MICRODIA 0x0c45 > > +#define USB_DEVICE_ID_REDRAGON_ASURA0x760b > > Microdia is most probably an incorrect name.

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Thu, 2018-03-22 at 09:33 +0100, Benjamin Tissoires wrote: > On Wed, Mar 21, 2018 at 5:33 PM, Robert Munteanu > wrote: > > Hi Benjamin, > > > > On Wed, 2018-03-21 at 17:12 +0100, Benjamin Tissoires wrote: > > > Hi Robert, > > > > > > First,

Re: [PATCH v3] Fix modifier keys for Redragon Asura Keyboard

2018-03-22 Thread Robert Munteanu
On Thu, 2018-03-22 at 09:17 +0100, Robert Munteanu wrote: > On Wed, 2018-03-21 at 17:51 +0100, Ondrej Zary wrote: > > On Wednesday 21 March 2018 11:43:31 Robert Munteanu wrote: > > > +#define USB_VENDOR_ID_MICRODIA 0x0c45 > > > +#define USB_DEVICE_

[RFC PATCH] Fix modifier keys for Redragon Asura Keyboard

2018-01-10 Thread Robert Munteanu
- v3: style cleanup, rebase on top of 4.14 Signed-off-by: Robert Munteanu --- drivers/hid/Kconfig| 9 +++ drivers/hid/Makefile | 2 +- drivers/hid/hid-core.c | 3 + drivers/hid/hid-ids.h | 3 + drivers/hid/hid-microdia.c | 178

Redragon Asura Keyboard - All Shift, Ctrl, Alt, Win keys function as left shift

2017-06-12 Thread Robert Munteanu
Hi, I am trying to use the keyboard I mentioned. Most of the keys work fine, except for Shift/Alt/Ctrl/Win. All of them are mapped a left shift. Some notes: 1. dmesg output when plugging in the keyboard [185765.848957] input: USB Keyboard as /devices/pci:00/:00:14.0/usb1/1-3/1-3:1.0/0003