about generally when to use each debug function. If any
> objections let me know.
>
>
>> On Sun, Oct 7, 2018 at 10:21 AM Rodrigo Freire wrote:
>>
>> Hi Steve,
>> From our conversation over v2, I came out with this v3 patch, which I broke
>> in two commits:
about generally when to use each debug function. If any
> objections let me know.
>
>
>> On Sun, Oct 7, 2018 at 10:21 AM Rodrigo Freire wrote:
>>
>> Hi Steve,
>> From our conversation over v2, I came out with this v3 patch, which I broke
>> in two commits:
.
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifs_debug.h | 16
1 file changed, 16 insertions(+)
diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
index f4f3f08..72db298 100644
--- a/fs/cifs/cifs_debug.h
+++ b/fs/cifs/cifs_debug.h
@@ -47,6 +47,17 @@
*/
#ifdef
ario, in order to avoid a
duplicate message or stripping out important information in
debug.
Rodrigo Freire (2):
CIFS: Adds information-level logging function
CIFS: Print message when attempting a mount
fs/cifs/cifs_debug.h | 16
fs/cifs/cifsfs.c | 7 ++-
fs/cifs/
$
[ 456.478186] CIFS VFS: Error connecting to socket. Aborting operation.
[ 456.478381] CIFS VFS: cifs_mount failed w/return code = -113
[ 467.688866] CIFS: Attempting to mount //172.25.250.19/c$
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifsfs.c| 7 ++-
fs/cifs/transport.c | 2 +-
2
$
[ 456.478186] CIFS VFS: Error connecting to socket. Aborting operation.
[ 456.478381] CIFS VFS: cifs_mount failed w/return code = -113
[ 467.688866] CIFS: Attempting to mount //172.25.250.19/c$
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifsfs.c| 7 ++-
fs/cifs/transport.c | 2 +-
2
.
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifs_debug.h | 16
1 file changed, 16 insertions(+)
diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h
index f4f3f08..72db298 100644
--- a/fs/cifs/cifs_debug.h
+++ b/fs/cifs/cifs_debug.h
@@ -47,6 +47,17 @@
*/
#ifdef
ario, in order to avoid a
duplicate message or stripping out important information in
debug.
Rodrigo Freire (2):
CIFS: Adds information-level logging function
CIFS: Print message when attempting a mount
fs/cifs/cifs_debug.h | 16
fs/cifs/cifsfs.c | 7 ++-
fs/cifs/
. Thanks!
---
Rodrigo Freire - Principal Technical Account Manager
GLOBAL CUSTOMER SUCCESS - Partnering with you to help achieve your business
goals
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
- Original Message -
> From: "Steve French"
> To: rfre...@redhat
. Thanks!
---
Rodrigo Freire - Principal Technical Account Manager
GLOBAL CUSTOMER SUCCESS - Partnering with you to help achieve your business
goals
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
- Original Message -
> From: "Steve French"
> To: rfre...@redhat
Note that xfs has more than 570 (!) dynamic
> trace point callouts now vs. fewer than 30 for xfs_notice
> On Tue, Oct 2, 2018 at 4:20 PM Rodrigo Freire wrote:
> >
> > Hi Steve o/
> >
> > I personally like more a pr_info() instead of a cifs_dbg (which wraps to a
>
Note that xfs has more than 570 (!) dynamic
> trace point callouts now vs. fewer than 30 for xfs_notice
> On Tue, Oct 2, 2018 at 4:20 PM Rodrigo Freire wrote:
> >
> > Hi Steve o/
> >
> > I personally like more a pr_info() instead of a cifs_dbg (which wraps to a
>
nt example from ext4) by default
> or the xfs_notice (which is level 5)
> https://elinux.org/Debugging_by_printing
> On Tue, Oct 2, 2018 at 2:28 PM Rodrigo Freire wrote:
> >
> > Hi Steve,
> >
> > - Original Message -
> > > From: "Steve Fre
nt example from ext4) by default
> or the xfs_notice (which is level 5)
> https://elinux.org/Debugging_by_printing
> On Tue, Oct 2, 2018 at 2:28 PM Rodrigo Freire wrote:
> >
> > Hi Steve,
> >
> > - Original Message -
> > > From: "Steve Fre
On the idea of adding cifsFYI logging here - I slightly prefer using
> ftrace (trace-cmd, ie dynamic tracing) so there is less overhead and
> easier to turn on/off following the example of xfs, f2fs, nfs, nfsd
> etc.
Remember that cifsFYI already exists; I just moved it inside a if
On the idea of adding cifsFYI logging here - I slightly prefer using
> ftrace (trace-cmd, ie dynamic tracing) so there is less overhead and
> easier to turn on/off following the example of xfs, f2fs, nfs, nfsd
> etc.
Remember that cifsFYI already exists; I just moved it inside a if
] CIFS VFS: Attempting to mount //172.25.250.19/c$
v2: Created a loop to select the right cifs_dbg message to be printed,
considering the current system's scenario, in order to avoid a
duplicate message or stripping out important information in
debug.
Signed-off-by: Rodrigo Freire
] CIFS VFS: Attempting to mount //172.25.250.19/c$
v2: Created a loop to select the right cifs_dbg message to be printed,
considering the current system's scenario, in order to avoid a
duplicate message or stripping out important information in
debug.
Signed-off-by: Rodrigo Freire
] CIFS VFS: Error connecting to socket. Aborting operation.
[ 456.478381] CIFS VFS: cifs_mount failed w/return code = -113
[ 467.688866] CIFS VFS: Attempting to mount //172.25.250.19/c$
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifsfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs
] CIFS VFS: Error connecting to socket. Aborting operation.
[ 456.478381] CIFS VFS: cifs_mount failed w/return code = -113
[ 467.688866] CIFS VFS: Attempting to mount //172.25.250.19/c$
Signed-off-by: Rodrigo Freire
---
fs/cifs/cifsfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs
PID field to align on up to 7 characters.
References: https://lkml.org/lkml/2018/7/3/1201
Signed-off-by: Rodrigo Freire
Acked-by: David Rientjes
Acked-by: Rafael Aquini
---
mm/oom_kill.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index
PID field to align on up to 7 characters.
References: https://lkml.org/lkml/2018/7/3/1201
Signed-off-by: Rodrigo Freire
Acked-by: David Rientjes
Acked-by: Rafael Aquini
---
mm/oom_kill.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index
Hello Michal!
- Original Message -
> From: "Michal Hocko"
> To: "Rodrigo Freire"
> Cc: linux...@kvack.org, linux-kernel@vger.kernel.org
> Sent: Monday, July 2, 2018 8:29:06 AM
> Subject: Re: [PATCH] mm: be more informative in OOM task list
>
>
Hello Michal!
- Original Message -
> From: "Michal Hocko"
> To: "Rodrigo Freire"
> Cc: linux...@kvack.org, linux-kernel@vger.kernel.org
> Sent: Monday, July 2, 2018 8:29:06 AM
> Subject: Re: [PATCH] mm: be more informative in OOM task list
>
>
Hello Michal,
- Original Message -
> From: "Michal Hocko"
> To: "Rodrigo Freire"
> Cc: linux...@kvack.org, linux-kernel@vger.kernel.org
> Sent: Monday, July 2, 2018 6:30:43 AM
> Subject: Re: [PATCH] mm: be more informative in OOM task list
>
>
Hello Michal,
- Original Message -
> From: "Michal Hocko"
> To: "Rodrigo Freire"
> Cc: linux...@kvack.org, linux-kernel@vger.kernel.org
> Sent: Monday, July 2, 2018 6:30:43 AM
> Subject: Re: [PATCH] mm: be more informative in OOM task list
>
>
The default page memory unit of OOM task dump events might not be
intuitive for the non-initiated when debugging OOM events. Add
a small printk prior to the task dump informing that the memory
units are actually memory _pages_.
Signed-off-by: Rodrigo Freire
---
mm/oom_kill.c | 1 +
1 file
The default page memory unit of OOM task dump events might not be
intuitive for the non-initiated when debugging OOM events. Add
a small printk prior to the task dump informing that the memory
units are actually memory _pages_.
Signed-off-by: Rodrigo Freire
---
mm/oom_kill.c | 1 +
1 file
This patch documents two missing module options in the internal
code comment block.
Signed-off-by: Rodrigo Freire
---
drivers/net/wireless/iwlwifi/iwl-modparams.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-modparams.h
b/drivers
This patch documents two missing module options in the internal
code comment block.
Signed-off-by: Rodrigo Freire <rfre...@redhat.com>
---
drivers/net/wireless/iwlwifi/iwl-modparams.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwi
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in
userland free(1) since 2014. This patch updates the Documentation to
reflect this change.
Signed-off-by: Rodrigo Freire
---
V2: Better wording as per
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in
userland free(1) since 2014. This patch updates the Documentation to
reflect this change.
Signed-off-by: Rodrigo Freire <rfre...@redhat.com>
---
V2
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in userland
free(1) since 2014. This patch updates the Documentation to reflect
this change.
Signed-off-by: Rodrigo Freire
---
--- a/Documentation/f
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in userland
free(1) since 2014. This patch updates the Documentation to reflect
this change.
Signed-off-by: Rodrigo Freire <rfre.
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in userland
free(1) since 2014. This patch updates the Documentation to reflect
this change.
Signed-off-by: Rodrigo Freire
---
--- a/Documentation/f
The Shared Memory accounting support is present in Kernel since
commit 4b02108ac1b3 ("mm: oom analysis: add shmem vmstat") and in userland
free(1) since 2014. This patch updates the Documentation to reflect
this change.
Signed-off-by: Rodrigo Freire <rfre...@redhat.com>
---
---
From: "Brian Norris"
Sent: Wednesday, November 26, 2014 1:33:04 AM
Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time
> On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote:
> > > From: "Brian Norris"
> > > Sen
From: Brian Norris computersforpe...@gmail.com
Sent: Wednesday, November 26, 2014 1:33:04 AM
Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time
On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote:
From: Brian Norris computersforpe...@gmail.com
From: "Brian Norris"
Sent: Wednesday, November 26, 2014 1:33:04 AM
Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time
> On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote:
> > > From: "Brian Norris"
> > > Sen
From: "Brian Norris"
Sent: Wednesday, November 26, 2014 5:21:47 AM
Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to
partition size
> On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote:
> > PAGE_MASK is no longer needed with the new term
From: Brian Norris computersforpe...@gmail.com
Sent: Wednesday, November 26, 2014 5:21:47 AM
Subject: Re: [PATCH v3 3/3] mtd: block2mtd: Removes PAGE_MASK as a index to
partition size
On Sun, Nov 09, 2014 at 07:23:12AM -0500, Rodrigo Freire wrote:
PAGE_MASK is no longer needed with the new
From: Brian Norris computersforpe...@gmail.com
Sent: Wednesday, November 26, 2014 1:33:04 AM
Subject: Re: [PATCH V2] mtd: block2mtd: Present block2mtd timely on boot time
On Sun, Nov 09, 2014 at 07:18:05AM -0500, Rodrigo Freire wrote:
From: Brian Norris computersforpe...@gmail.com
Sent
From: Felix Fietkau
mtd: block2mtd: Removes PAGE_MASK as a index to partition size
PAGE_MASK is no longer needed with the new term.
This patch keeps the device size aligned with the erase_size.
Signed-off-by: Felix Fietkau
Signed-off-by: Rodrigo Freire
Signed-off-by: Herton Krzesinski
:
[root@server01 ~]# cat /proc/mtd
dev:size erasesize name
mtd0: a000 0001 "rootfs"
mtd1: 26508 0001 "anothername"
mtd2: acd0 0001 "/dev/mmcblk0p2"
Notice that the device mtd2 was added without specifying a name.
Signed-off-by: Felix Fietkau
, probably because of the delay on enumerating a USB
MMC card reader.
Signed-off-by: Felix Fietkau
Signed-off-by: Rodrigo Freire
Signed-off-by: Herton Krzesinski
---
V3: Separated on a single patch, fixes a compiling warning, cosmethic changes
V2: Uses kstrdup, removed PAGE_MASK.
--- a/drivers/mtd
From: Felix Fietkau
mtd: block2mtd: wait for device enumeration, add name support
Currently, a block MTD device is not presented timely on boot time, in
order to start mounting the filesystems, causing the system to not boot
or panic because of lack of rootfs. This patch ensures that block2mtd
Hi Brian,
> From: "Brian Norris"
> Sent: Wednesday, November 5, 2014 6:23:03 PM
> On Wed, Sep 17, 2014 at 04:28:03PM -0400, Rodrigo Freire wrote:
> > Currently, a block MTD device is not presented to the system on time, in
> > order to start mounting the
Hi Brian,
From: Brian Norris computersforpe...@gmail.com
Sent: Wednesday, November 5, 2014 6:23:03 PM
On Wed, Sep 17, 2014 at 04:28:03PM -0400, Rodrigo Freire wrote:
Currently, a block MTD device is not presented to the system on time, in
order to start mounting the filesystems
From: Felix Fietkau n...@openwrt.org
mtd: block2mtd: wait for device enumeration, add name support
Currently, a block MTD device is not presented timely on boot time, in
order to start mounting the filesystems, causing the system to not boot
or panic because of lack of rootfs. This patch ensures
filesystems, probably because of the delay on enumerating a USB
MMC card reader.
Signed-off-by: Felix Fietkau n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre...@redhat.com
Signed-off-by: Herton Krzesinski her...@redhat.com
---
V3: Separated on a single patch, fixes a compiling warning
n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre...@redhat.com
Signed-off-by: Herton Krzesinski her...@redhat.com
---
V3: Separated on a single patch
--- a/drivers/mtd/devices/block2mtd.c 2014-11-07 17:16:11.711479312 -0200
+++ b/drivers/mtd/devices/block2mtd.c 2014-11-07 17:15:14.255464054
From: Felix Fietkau n...@openwrt.org
mtd: block2mtd: Removes PAGE_MASK as a index to partition size
PAGE_MASK is no longer needed with the new term.
This patch keeps the device size aligned with the erase_size.
Signed-off-by: Felix Fietkau n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre
/generic/patches-3.12/440-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau
Signed-off-by: Herton Ronaldo Krzesinski
Signed-off-by: Rodrigo Freire
---
V2: Uses kstrdup, removed
-by: Rodrigo Freire rfre...@redhat.com
---
V2: Uses kstrdup, removed PAGE_MASK.
--- a/drivers/mtd/devices/block2mtd.c 2014-09-16 21:38:12.543952627 -0300
+++ b/drivers/mtd/devices/block2mtd.c 2014-09-17 17:43:21.424944394 -0300
@@ -9,7 +9,15 @@
#define pr_fmt(fmt) KBUILD_MODNAME : fmt
-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau
Signed-off-by: Rodrigo Freire
Signed-off-by: Herton Krzesinski
---
V2: Uses kstrdup, removed PAGE_MASK.
--- a/drivers
/patches-3.12/440-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre...@redhat.com
Signed-off-by: Herton Krzesinski her
Holas Ezequiel,
- Original Message -
From: "Ezequiel Garcia"
> On 17 September 2014 21:28, Rodrigo Freire wrote:
>
> Using block2mtd sounds a bit unusual. I see that you are trying to get
> a more robust fs have you tried using f2fs instead of jffs2?
-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau
Signed-off-by: Rodrigo Freire
Signed-off-by: Herton Krzesinski
---
V2: Uses kstrdup, removed PAGE_MASK.
--- a/drivers/mtd/devices
Hi Jörn,
- Original Message -
From: "Jörn Engel"
> On Mon, 8 September 2014 16:04:40 -0400, Rodrigo Freire wrote:
> >
> > @@ -257,13 +281,15 @@ static struct block2mtd_dev *add_device(
> >
> > /* Setup the MTD structure */
> >
Hi Jörn,
- Original Message -
From: Jörn Engel jo...@logfs.org
On Mon, 8 September 2014 16:04:40 -0400, Rodrigo Freire wrote:
@@ -257,13 +281,15 @@ static struct block2mtd_dev *add_device(
/* Setup the MTD structure */
/* make the name contain the block device
-3.12/440-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre...@redhat.com
Signed-off-by: Herton Krzesinski her...@redhat.com
---
V2
Holas Ezequiel,
- Original Message -
From: Ezequiel Garcia ezequ...@vanguardiasur.com.ar
On 17 September 2014 21:28, Rodrigo Freire rfre...@redhat.com wrote:
Using block2mtd sounds a bit unusual. I see that you are trying to get
a more robust fs have you tried using f2fs
-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau
Signed-off-by: Rodrigo Freire
--- a/drivers/mtd/devices/block2mtd.c 2014-09-05 11:13:39.143698413 -0300
+++ b/drivers/mtd/devices
/440-block2mtd_init.patch?rev=40444
https://dev.openwrt.org/browser/trunk/target/linux/generic/patches-3.12/441-block2mtd_probe.patch?rev=40444
Signed-off-by: Felix Fietkau n...@openwrt.org
Signed-off-by: Rodrigo Freire rfre...@redhat.com
--- a/drivers/mtd/devices/block2mtd.c 2014-09-05 11:13
64 matches
Mail list logo
