Re: [PATCH v2] nvmet: fix nvmet_execute_write_zeroes function

2018-04-02 Thread Rodrigo Rosatti Galvao
I'm terribly sorry, but the +1 actually needs to be outside the le16_to_cpu. The above will work on little-endian machines, but not big. No problem at all. Thank you for helping on this. I'm going to send a V3 with this change. -- Rodrigo R. Galvão Intern - Linux Technology Center - IBM

Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

2018-04-02 Thread Rodrigo Rosatti Galvao
Thanks Keith. The patch you proposed worked fine!! I just sent a V2 with that change! On 04/02/2018 11:21 AM, Keith Busch wrote: On Mon, Apr 02, 2018 at 10:47:10AM -0300, Rodrigo Rosatti Galvao wrote: One thing that I just forgot to explain previously, but I think its relevant: 1. The

Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function

2018-04-02 Thread Rodrigo Rosatti Galvao
One thing that I just forgot to explain previously, but I think its relevant: 1. The command is failing with 4k logical block size, but works with 512B 2. With the patch, the command is working for both 512B and 4K. Here are some extra information I could get when executing the command with