Re: 3.6-rc7 boot crash + bisection

2012-09-28 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 04:04:03PM -0600, Alex Williamson wrote: > Here's a lockdep clean version of it: > > amd_iommu: Handle aliases not backed by devices > > Aliases sometimes don't have a struct pci_dev backing them. This breaks > our attempt to figure out the topology and device quirks

Re: 3.6-rc7 boot crash + bisection

2012-09-28 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 04:04:03PM -0600, Alex Williamson wrote: Here's a lockdep clean version of it: amd_iommu: Handle aliases not backed by devices Aliases sometimes don't have a struct pci_dev backing them. This breaks our attempt to figure out the topology and device quirks that may

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 08:35:59AM -0600, Alex Williamson wrote: > Hmm, that throws a kink in iommu groups. So perhaps we need to make an > alias interface to iommu groups. Seems like this could just be an extra > parameter to iommu_group_get and iommu_group_add_device (empty in the > typical

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 08:52:01AM -0600, Alex Williamson wrote: > Assuming this works, it may be ok as a 3.7 fix, but if there was > actually more than one device behind the alias we'd expose them as > separate iommu groups. I don't think that's what we want. Maybe it > should at least get a

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
Florian, On Wed, Sep 26, 2012 at 01:01:54AM +0200, Florian Dazinger wrote: > you're right, either "amd_iommu=off" or removing the audio card makes > the failure disappear. I will test the new BIOS rev. tomorrow. Can you please test this diff and report if it fixes the problem for you? Thanks.

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Tue, Sep 25, 2012 at 01:43:46PM -0600, Alex Williamson wrote: > Joerg, any thoughts on a quirk for this? Unfortunately we can't just > skip IOMMU groups when an alias is broken because it puts the other > IOMMU groups at risk that might not actually be isolated from this > device. It looks

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Tue, Sep 25, 2012 at 01:43:46PM -0600, Alex Williamson wrote: Joerg, any thoughts on a quirk for this? Unfortunately we can't just skip IOMMU groups when an alias is broken because it puts the other IOMMU groups at risk that might not actually be isolated from this device. It looks like

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
Florian, On Wed, Sep 26, 2012 at 01:01:54AM +0200, Florian Dazinger wrote: you're right, either amd_iommu=off or removing the audio card makes the failure disappear. I will test the new BIOS rev. tomorrow. Can you please test this diff and report if it fixes the problem for you? Thanks. diff

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 08:52:01AM -0600, Alex Williamson wrote: Assuming this works, it may be ok as a 3.7 fix, but if there was actually more than one device behind the alias we'd expose them as separate iommu groups. I don't think that's what we want. Maybe it should at least get a

Re: 3.6-rc7 boot crash + bisection

2012-09-26 Thread Roedel, Joerg
On Wed, Sep 26, 2012 at 08:35:59AM -0600, Alex Williamson wrote: Hmm, that throws a kink in iommu groups. So perhaps we need to make an alias interface to iommu groups. Seems like this could just be an extra parameter to iommu_group_get and iommu_group_add_device (empty in the typical case).

Re: linux-next: Tree for Sept 24 (iommu)

2012-09-25 Thread Roedel, Joerg
On Mon, Sep 24, 2012 at 09:23:25PM -0600, Alex Williamson wrote: > On Mon, 2012-09-24 at 15:02 -0700, Randy Dunlap wrote: > > On 09/24/2012 07:53 AM, Stephen Rothwell wrote: > > > > > Hi all, > > > > > > Today was a train wreck, with lots of new conflicts across several trees > > > and a few

Re: linux-next: Tree for Sept 24 (iommu)

2012-09-25 Thread Roedel, Joerg
On Mon, Sep 24, 2012 at 09:23:25PM -0600, Alex Williamson wrote: On Mon, 2012-09-24 at 15:02 -0700, Randy Dunlap wrote: On 09/24/2012 07:53 AM, Stephen Rothwell wrote: Hi all, Today was a train wreck, with lots of new conflicts across several trees and a few build failures as