Re: [PATCH] net: mellanox: mlx5: fix error return code of mlx5e_stats_flower()

2021-03-14 Thread Roi Dayan
On 2021-03-12 12:47 AM, Saeed Mahameed wrote: On Tue, 2021-03-09 at 11:44 +0200, Roi Dayan wrote: On 2021-03-09 10:32 AM, Jia-Ju Bai wrote: On 2021/3/9 16:24, Roi Dayan wrote: On 2021-03-09 10:20 AM, Roi Dayan wrote: On 2021-03-06 3:47 PM, Jia-Ju Bai wrote: When

Re: [PATCH] net: bonding: fix error return code of bond_neigh_init()

2021-03-10 Thread Roi Dayan
On 2021-03-08 5:11 AM, Jia-Ju Bai wrote: When slave is NULL or slave_ops->ndo_neigh_setup is NULL, no error return code of bond_neigh_init() is assigned. To fix this bug, ret is assigned with -EINVAL in these cases. Fixes: 9e99bfefdbce ("bonding: fix bond_neigh_init()") Reported-by: TOTE Robo

Re: [PATCH] net: mellanox: mlx5: fix error return code of mlx5e_stats_flower()

2021-03-09 Thread Roi Dayan
On 2021-03-09 10:32 AM, Jia-Ju Bai wrote: On 2021/3/9 16:24, Roi Dayan wrote: On 2021-03-09 10:20 AM, Roi Dayan wrote: On 2021-03-06 3:47 PM, Jia-Ju Bai wrote: When mlx5e_tc_get_counter() returns NULL to counter or mlx5_devcom_get_peer_data() returns NULL to peer_esw, no error return

Re: [PATCH] net: mellanox: mlx5: fix error return code of mlx5e_stats_flower()

2021-03-09 Thread Roi Dayan
On 2021-03-09 10:20 AM, Roi Dayan wrote: On 2021-03-06 3:47 PM, Jia-Ju Bai wrote: When mlx5e_tc_get_counter() returns NULL to counter or mlx5_devcom_get_peer_data() returns NULL to peer_esw, no error return code of mlx5e_stats_flower() is assigned. To fix this bug, err is assigned with

Re: [PATCH] net: mellanox: mlx5: fix error return code of mlx5e_stats_flower()

2021-03-09 Thread Roi Dayan
On 2021-03-06 3:47 PM, Jia-Ju Bai wrote: When mlx5e_tc_get_counter() returns NULL to counter or mlx5_devcom_get_peer_data() returns NULL to peer_esw, no error return code of mlx5e_stats_flower() is assigned. To fix this bug, err is assigned with -EINVAL in these cases. Reported-by: TOTE Robot

Re: [PATCH] net/mlx5e: include net/nexthop.h where needed

2021-03-08 Thread Roi Dayan
On 2021-03-08 5:31 PM, Arnd Bergmann wrote: From: Arnd Bergmann drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun_encap.c:1510:12: error: implicit declaration of function 'fib_info_nh' [-Werror,-Wimplicit-function-declaration] fib_dev = fib_info_nh(fen_info->fi, 0)->fib_nh_dev;

Re: [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc()

2021-03-03 Thread Roi Dayan
(in); + kvfree(spec); + kvfree(in); return err; } thanks! Reviewed-by: Roi Dayan

Re: [PATCH mlx5-next v1 11/11] RDMA/mlx5: Remove IB representors dead code

2020-11-02 Thread Roi Dayan
struct mlx5_ib_dev *mlx5_ib_rep_to_dev(struct mlx5_eswitch_rep *rep) -{ - return rep->rep_data[REP_IB].priv; -} #endif /* __MLX5_IB_REP_H__ */ -- 2.28.0 Reviewed-by: Roi Dayan

Re: [PATCH mlx5-next v1 10/11] net/mlx5: Simplify eswitch mode check

2020-11-02 Thread Roi Dayan
tic inline bool is_mdev_switchdev_mode(struct mlx5_core_dev *dev) +{ + return mlx5_eswitch_mode(dev) == MLX5_ESWITCH_OFFLOADS; +} #endif -- 2.28.0 Reviewed-by: Roi Dayan

Re: [PATCH mlx5-next v1 02/11] net/mlx5: Properly convey driver version to firmware

2020-11-02 Thread Roi Dayan
g_size, "%u.%u.%u", +(u8)(LINUX_VERSION_CODE >> 16), (u8)(LINUX_VERSION_CODE >> 8), +(u16)(LINUX_VERSION_CODE & 0xff)); /*Send the command*/ MLX5_SET(set_driver_version_in, in, opcode, -- 2.28.0 Reviewed-by: Roi Dayan

Re: [PATCH][next] net/mlx5e: Remove redundant assignment

2019-03-03 Thread Roi Dayan
commit doesn't fix any real issue but is more of a cleanup. so I'm not sure if fixes line is relevant or not. beside that looks ok. Reviewed-by: Roi Dayan > Signed-off-by: Gustavo A. R. Silva > --- > drivers/net/ethernet/mellanox/mlx5/core/lib/port_tun.c | 6 ++ >