Re: [linux-sunxi] [PATCH v2 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-12-02 Thread Roman Byshko
On Tue, Nov 11, 2014 at 10:11 AM, Hans de Goede wrote: > Hi, > > On 11/10/2014 07:55 PM, Roman Byshko wrote: >> Hi, >> >> There is already support for two USB phys, which are used for >> USB host controllers on Allwinner SoC aka sunxi. >> >> This patc

Re: [linux-sunxi] [PATCH v2 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-12-02 Thread Roman Byshko
On Tue, Nov 11, 2014 at 10:11 AM, Hans de Goede hdego...@redhat.com wrote: Hi, On 11/10/2014 07:55 PM, Roman Byshko wrote: Hi, There is already support for two USB phys, which are used for USB host controllers on Allwinner SoC aka sunxi. This patch series add support for the USB OTG phy

[PATCH] usb: musb: replace hard coded registers with defines

2014-11-10 Thread Roman Byshko
-off-by: Roman Byshko --- drivers/usb/musb/musb_debugfs.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c index 4c21679..ad3701a 100644 --- a/drivers/usb/musb

[PATCH v2 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-11-10 Thread Roman Byshko
Until now the regulator nodes for powering USB VBUS existed only for the two host controllers. Now the regulator is added for USB OTG too. Signed-off-by: Roman Byshko --- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch

[PATCH v2 5/5] ARM: dts: sun7i: Cubietruck: add power supply regulator for USB OTG VBUS

2014-11-10 Thread Roman Byshko
Signed-off-by: Roman Byshko --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts index 1682307..a281d25 100644 --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts

[PATCH v2 3/5] ARM: sun7i: dtsi: add support for usbphy0

2014-11-10 Thread Roman Byshko
Signed-off-by: Roman Byshko --- arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 82097c9..f787ccb 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot

[PATCH v2 4/5] ARM: dts: sun7i: Cubietruck: override regulator pin

2014-11-10 Thread Roman Byshko
Cubietruck uses different pin for the USB OTG VBUS that is why we override the one defined in sunxi-common-regulators.dtsi Signed-off-by: Roman Byshko --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20

[PATCH v2 1/5] phy: sun4i: add support for USB phy0

2014-11-10 Thread Roman Byshko
The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host controllers. This patch adds support for USB phy0, which is used by the musb hdrc USB controller. Signed-off-by: Roman Byshko --- drivers/phy/phy-sun4i-usb.c | 9 ++--- 1 file changed, 6

[PATCH v2 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-11-10 Thread Roman Byshko
Hi, There is already support for two USB phys, which are used for USB host controllers on Allwinner SoC aka sunxi. This patch series add support for the USB OTG phy (aka phy0). The code has been tested on Allwinner A20 aka sun7i (Cubietruck). Best regards, Roman Byshko Changes since v1

Re: [PATCH] usb: musb: replace hard coded registers with defines

2014-11-10 Thread Roman Byshko
-off-by: Roman Byshko --- drivers/usb/musb/musb_debugfs.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c index 4c21679..ad3701a 100644 --- a/drivers/usb/musb

Re: [PATCH] usb: musb: replace hard coded registers with defines

2014-11-10 Thread Roman Byshko
-off-by: Roman Byshko rbys...@gmail.com --- drivers/usb/musb/musb_debugfs.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c index 4c21679..ad3701a 100644 --- a/drivers

[PATCH v2 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-11-10 Thread Roman Byshko
Hi, There is already support for two USB phys, which are used for USB host controllers on Allwinner SoC aka sunxi. This patch series add support for the USB OTG phy (aka phy0). The code has been tested on Allwinner A20 aka sun7i (Cubietruck). Best regards, Roman Byshko Changes since v1

[PATCH v2 4/5] ARM: dts: sun7i: Cubietruck: override regulator pin

2014-11-10 Thread Roman Byshko
Cubietruck uses different pin for the USB OTG VBUS that is why we override the one defined in sunxi-common-regulators.dtsi Signed-off-by: Roman Byshko rbys...@gmail.com --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot

[PATCH v2 1/5] phy: sun4i: add support for USB phy0

2014-11-10 Thread Roman Byshko
The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host controllers. This patch adds support for USB phy0, which is used by the musb hdrc USB controller. Signed-off-by: Roman Byshko rbys...@gmail.com --- drivers/phy/phy-sun4i-usb.c | 9 ++--- 1 file

[PATCH v2 3/5] ARM: sun7i: dtsi: add support for usbphy0

2014-11-10 Thread Roman Byshko
Signed-off-by: Roman Byshko rbys...@gmail.com --- arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 82097c9..f787ccb 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b

[PATCH v2 5/5] ARM: dts: sun7i: Cubietruck: add power supply regulator for USB OTG VBUS

2014-11-10 Thread Roman Byshko
Signed-off-by: Roman Byshko rbys...@gmail.com --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts index 1682307..a281d25 100644 --- a/arch/arm/boot/dts/sun7i-a20

[PATCH v2 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-11-10 Thread Roman Byshko
Until now the regulator nodes for powering USB VBUS existed only for the two host controllers. Now the regulator is added for USB OTG too. Signed-off-by: Roman Byshko rbys...@gmail.com --- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 19 +++ 1 file changed, 19 insertions

[PATCH] usb: musb: replace hard coded registers with defines

2014-11-10 Thread Roman Byshko
-off-by: Roman Byshko rbys...@gmail.com --- drivers/usb/musb/musb_debugfs.c | 57 ++--- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c index 4c21679..ad3701a 100644 --- a/drivers

Re: [PATCH 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-10-29 Thread Roman Byshko
Hi Maxime, thank you for the review! On Tue, Oct 28, 2014 at 10:51 PM, Maxime Ripard wrote: > On Mon, Oct 27, 2014 at 10:43:02PM +0100, Roman Byshko wrote: >> Until now the regulator nodes for powering USB VBUS >> existed only for the two host controllers. Now the regulator >

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-29 Thread Roman Byshko
Hi all, sorry for missing Signed-offs, they will be added, of course. >>> + /* Regulation 45 ohms */ >>> + if (phy->index == 0) >>> + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1); >> >> What is this code supposed to do? >> >> Some define for this bit and/or a better

Re: [PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-29 Thread Roman Byshko
Hi all, sorry for missing Signed-offs, they will be added, of course. + /* Regulation 45 ohms */ + if (phy-index == 0) + sun4i_usb_phy_write(phy, PHY_RES45_CAL_EN, 0x01, 1); What is this code supposed to do? Some define for this bit and/or a better comment would be

Re: [PATCH 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-10-29 Thread Roman Byshko
Hi Maxime, thank you for the review! On Tue, Oct 28, 2014 at 10:51 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Mon, Oct 27, 2014 at 10:43:02PM +0100, Roman Byshko wrote: Until now the regulator nodes for powering USB VBUS existed only for the two host controllers. Now

[PATCH 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-10-27 Thread Roman Byshko
Hi, There is already support for two USB phys, which are used for USB host controllers on Allwinner SoC aka sunxi. This patch series add support for the USB OTG phy (aka phy0). The code has been tested on Allwinner A20 aka sun7i (Cubietruck). Best regards, Roman Byshko Roman Byshko (5): phy

[PATCH 3/5] ARM: sun7i: dtsi: add support for usbphy0

2014-10-27 Thread Roman Byshko
--- arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 82097c9..f787ccb 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -552,8

[PATCH 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-10-27 Thread Roman Byshko
Until now the regulator nodes for powering USB VBUS existed only for the two host controllers. Now the regulator is added for USB OTG too. --- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH 4/5] ARM: dts: sun7i: Cubietruck: override regulator pin

2014-10-27 Thread Roman Byshko
Cubietruck uses different pin for the USB OTG VBUS that is why we override the one defined in sunxi-common-regulators.dtsi --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts

[PATCH 5/5] ARM: dts: sun7i: Cubietruck: add power supply regulator for USB OTG VBUS

2014-10-27 Thread Roman Byshko
--- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts index 1682307..a281d25 100644 --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts +++

[PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-27 Thread Roman Byshko
The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host controllers. This patch adds support for USB phy0, which is used by the musb hdrc USB controller. --- drivers/phy/phy-sun4i-usb.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH] usb: musb: replace hard coded registers with defines

2014-10-27 Thread Roman Byshko
musb registers can be dumped using the file regdump which is created in debugfs. Up to now hard coded register addresses are used for that. Different glue layers however have different register addresses. The patch addresses this issue by substituting bare register addresses with defines. ---

[PATCH] usb: musb: replace hard coded registers with defines

2014-10-27 Thread Roman Byshko
musb registers can be dumped using the file regdump which is created in debugfs. Up to now hard coded register addresses are used for that. Different glue layers however have different register addresses. The patch addresses this issue by substituting bare register addresses with defines. ---

[PATCH 1/5] phy: sun4i: add support for USB phy0

2014-10-27 Thread Roman Byshko
The driver for sun4i USB phys currently supports only phy1 and phy2 which are used for USB host controllers. This patch adds support for USB phy0, which is used by the musb hdrc USB controller. --- drivers/phy/phy-sun4i-usb.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff

[PATCH 4/5] ARM: dts: sun7i: Cubietruck: override regulator pin

2014-10-27 Thread Roman Byshko
Cubietruck uses different pin for the USB OTG VBUS that is why we override the one defined in sunxi-common-regulators.dtsi --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 13 + 1 file changed, 13 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts

[PATCH 5/5] ARM: dts: sun7i: Cubietruck: add power supply regulator for USB OTG VBUS

2014-10-27 Thread Roman Byshko
--- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts b/arch/arm/boot/dts/sun7i-a20-cubietruck.dts index 1682307..a281d25 100644 --- a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts +++

[PATCH 3/5] ARM: sun7i: dtsi: add support for usbphy0

2014-10-27 Thread Roman Byshko
--- arch/arm/boot/dts/sun7i-a20.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index 82097c9..f787ccb 100644 --- a/arch/arm/boot/dts/sun7i-a20.dtsi +++ b/arch/arm/boot/dts/sun7i-a20.dtsi @@ -552,8

[PATCH 2/5] ARM: dtsi: sunxi: add common VBUS regulator

2014-10-27 Thread Roman Byshko
Until now the regulator nodes for powering USB VBUS existed only for the two host controllers. Now the regulator is added for USB OTG too. --- arch/arm/boot/dts/sunxi-common-regulators.dtsi | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH 0/5] ARM: sunxi: Add support for USB OTG PHY

2014-10-27 Thread Roman Byshko
Hi, There is already support for two USB phys, which are used for USB host controllers on Allwinner SoC aka sunxi. This patch series add support for the USB OTG phy (aka phy0). The code has been tested on Allwinner A20 aka sun7i (Cubietruck). Best regards, Roman Byshko Roman Byshko (5): phy