Re: [PATCH] tee: optee: remove need_resched() before cond_resched()

2021-01-31 Thread Rouven Czerwinski
_resched(0) tif_need_resched() (+ preempt_count == 0 for current thread) while: need_resched() tif_need_resched() You can add my Reviewed-by: Rouven Czerwinski I also retested on the STM32-DK2 and the problem remains fixed: Tested-by: Rouven Czerwinski Regrads and thanks for the patch, Rouven

[PATCH v2] tee: optee: replace might_sleep with cond_resched

2021-01-05 Thread Rouven Czerwinski
be926918 be9269b0 bffdf0f8 [ 573.222162] ffe0: b6d76fb0 be9268fc b6d66621 b6c7e0d8 seen on STM32 DK2 with CONFIG_PREEMPT_NONE. Signed-off-by: Rouven Czerwinski Tested-by: Sumit Garg --- v2: - Add tested-by from Sumit Garg - Adjust commit message as agreed upon with Lucas Stach drivers/tee/optee

[PATCH v2 1/3] dt-bindings: vendor-prefixes: add Webasto SE

2020-12-16 Thread Rouven Czerwinski
Add "webasto" entry for Webasto SE: https://www.webasto.com Signed-off-by: Rouven Czerwinski --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/

[PATCH v2 3/3] dt-bindings: arm: fsl: add Webasto ccbv2

2020-12-16 Thread Rouven Czerwinski
Add Webasto ccbv2 i.MX6UL based board. Signed-off-by: Rouven Czerwinski --- Documentation/devicetree/bindings/arm/fsl.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 934289446abb

[PATCH v2 2/3] ARM: dts: add Webasto ccbv2

2020-12-16 Thread Rouven Czerwinski
The Webasto Common Communication Board Version 2 is a i.MX6UL based board. Signed-off-by: Rouven Czerwinski --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6ul-webasto-ccbv2.dts | 472 + 2 files changed, 473 insertions(+) create mode 100644 arch

[PATCH v2 0/3] Mainline Webasto ccbv2 board

2020-12-16 Thread Rouven Czerwinski
Add Webasto ccbv2 device tree. v2: - add correct mailing lists to cc - add commit message for vendor-prefix and dt-bindings Rouven Czerwinski (3): dt-bindings: vendor-prefixes: add Webasto SE ARM: dts: add Webasto ccbv2 dt-bindings: arm: fsl: add Webasto ccbv2 .../devicetree/bindings/arm

[PATCH 0/3] Mainline Webasto ccbv2 board

2020-12-16 Thread Rouven Czerwinski
Add Webasto ccbv2 device tree. Rouven Czerwinski (3): dt-bindings: vendor-prefixes: add Webasto SE ARM: dts: add Webasto ccbv2 dt-bindings: arm: fsl: add Webasto ccbv2 .../devicetree/bindings/arm/fsl.yaml | 1 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm

[PATCH] tee: optee: replace might_sleep with cond_resched

2020-09-18 Thread Rouven Czerwinski
: b6d76fb0 be9268fc b6d66621 b6c7e0d8 seen on STM32 DK2. Signed-off-by: Rouven Czerwinski --- drivers/tee/optee/call.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c index 20b6fd7383c5..83b73b1d52f0 100644 --- a/drivers/tee

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Fri, 2020-08-07 at 10:26 +0200, Rouven Czerwinski wrote: > On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > > kernel &g

Re: [PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-07 Thread Rouven Czerwinski
On Thu, 2020-08-06 at 11:46 -0700, Jakub Kicinski wrote: > On Thu, 6 Aug 2020 08:49:06 +0200 Rouven Czerwinski wrote: > > Trying to use ktls on a system with 32-bit userspace and 64-bit > > kernel > > results in a EOPNOTSUPP message during sendmsg: > > > > set

[PATCH v2 net-next] net/tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-06 Thread Rouven Czerwinski
path for the TLS device implementation, however the flag hasn't been added there for lack of testing hardware. Signed-off-by: Rouven Czerwinski --- net/tls/tls_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 24f64bc0de18

Re: [PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-06 Thread Rouven Czerwinski
On Wed, 2020-08-05 at 17:45 -0700, David Miller wrote: > Neither of these patches apply cleanly to net-next. The compat handling > and TLS code has been changed quite a bit lately. Indeed, Patch 1 is no longer required on net-next. I'll drop the patch. > ALso, you must provide a proper header

[PATCH 2/2] net: tls: allow MSG_CMSG_COMPAT in sendmsg

2020-08-05 Thread Rouven Czerwinski
The MSG_CMSG_COMPAT flag is valid if the system has CONFIG_COMPAT enabled and a 32bit userspace. Signed-off-by: Rouven Czerwinski --- net/tls/tls_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 24f64bc0de18..a332ae123bda

[PATCH 1/2] net: tls: add compat for get/setsockopt

2020-08-05 Thread Rouven Czerwinski
If compat_{s,g}etsockopt for TLS are not implemented, the TLS layer will never be called on a system where CONFIG_COMPAT is enabled and userspace is 32bit. Implement both to support CONFIG_COMPAT. Signed-off-by: Rouven Czerwinski --- net/tls/tls_main.c | 28 1 file

[PATCH] tee: optee: add might_sleep for RPC requests

2019-07-03 Thread Rouven Czerwinski
NTR case does not contain an explicit rescheduling point. Add a might_sleep() to the RPC request case to ensure that the kernel can reschedule another task if OP-TEE requests RPC handling. Signed-off-by: Rouven Czerwinski --- drivers/tee/optee/call.c | 1 + 1 file changed, 1 insertion(+) diff --

Re: [Tee-dev] [PATCH] optee: allow to work without static shared memory

2018-06-18 Thread Rouven Czerwinski
Volodymyr Babchuk writes: > From: Volodymyr Babchuk > > On virtualized systems it is possible that OP-TEE will provide > only dynamic shared memory support. So it is fine to boot > without static SHM enabled if dymanic one is supported. > > Signed-off-by: Volodymyr Babchuk > --- >

Re: [Tee-dev] [PATCH] optee: allow to work without static shared memory

2018-06-18 Thread Rouven Czerwinski
Volodymyr Babchuk writes: > From: Volodymyr Babchuk > > On virtualized systems it is possible that OP-TEE will provide > only dynamic shared memory support. So it is fine to boot > without static SHM enabled if dymanic one is supported. > > Signed-off-by: Volodymyr Babchuk > --- >

Re: [PATCH cgroup/for-4.15-fixes] cgroup: fix css_task_iter crash on CSS_TASK_ITER_PROC

2018-01-08 Thread Rouven Czerwinski
Hello, Tejun Heo writes: > Applied the following to cgroup/for-4.15-fixes. Will push out to > linus later this week. [...] I can't find your fixes in master yet, did you perhaps forget to push out? Thanks and a happy new year, Rouven

Re: [PATCH cgroup/for-4.15-fixes] cgroup: fix css_task_iter crash on CSS_TASK_ITER_PROC

2018-01-08 Thread Rouven Czerwinski
Hello, Tejun Heo writes: > Applied the following to cgroup/for-4.15-fixes. Will push out to > linus later this week. [...] I can't find your fixes in master yet, did you perhaps forget to push out? Thanks and a happy new year, Rouven

Re: [PATCH cgroup/for-4.15-fixes] cgroup: fix css_task_iter crash on CSS_TASK_ITER_PROC

2017-12-20 Thread Rouven Czerwinski
Tejun Heo writes: > Hello, > > Applied the following to cgroup/for-4.15-fixes. Will push out to > linus later this week. I could reproduce the problem reliably and am > pretty sure this is the right fix but I'd greatly appreciate if you > guys can confirm the fix too. Fixed

Re: [PATCH cgroup/for-4.15-fixes] cgroup: fix css_task_iter crash on CSS_TASK_ITER_PROC

2017-12-20 Thread Rouven Czerwinski
Tejun Heo writes: > Hello, > > Applied the following to cgroup/for-4.15-fixes. Will push out to > linus later this week. I could reproduce the problem reliably and am > pretty sure this is the right fix but I'd greatly appreciate if you > guys can confirm the fix too. Fixed here as well,