Re: sparc/ppc/arm compat siginfo ABI regressions: sending SIGFPE via kill() returns wrong values in si_pid and si_uid

2018-04-12 Thread Russell King - ARM Linux
On Thu, Apr 12, 2018 at 04:34:35AM +0300, Dmitry V. Levin wrote: > A similar commit v4.16-rc1~159^2~37 > ("signal/arm: Document conflicts with SI_USER and SIGFPE") must have > introduced a similar ABI regression to compat arm. So, could you explain how can this change cause a regression? +#define

Re: [PATCH v2 0/4] ARM: amba: driver_override improvements and fixes

2018-04-10 Thread Russell King - ARM Linux
On Tue, Apr 10, 2018 at 03:21:42PM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > This patch series contains improvements to driver_override handling in > the AMBA bus driver, including two bugfixes that are based on similar > fixes for the PCI and platform buses, and which Todd Kjos would

Re: [PATCH] drm/i2c: tda998x: Remove VLA usage

2018-04-10 Thread Russell King - ARM Linux
On Tue, Apr 10, 2018 at 02:52:35PM -0700, Laura Abbott wrote: > On 04/09/2018 03:21 PM, Russell King - ARM Linux wrote: > >On Mon, Apr 09, 2018 at 02:07:03PM -0700, Laura Abbott wrote: > >>There's an ongoing effort to remove VLAs[1] from the kernel to eventually > &

Re: [PATCH] drm/i2c: tda998x: Remove VLA usage

2018-04-09 Thread Russell King - ARM Linux
On Mon, Apr 09, 2018 at 02:07:03PM -0700, Laura Abbott wrote: > There's an ongoing effort to remove VLAs[1] from the kernel to eventually > turn on -Wvla. The vla in reg_write_range is based on the length of data > passed. The one use of a non-constant size for this range is bounded by > the size b

Re: [PATCH 0/5] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-09 Thread Russell King - ARM Linux
On Mon, Apr 09, 2018 at 01:44:22PM +0200, Peter Rosin wrote: > On 2018-04-09 13:17, Russell King - ARM Linux wrote: > > On Mon, Apr 09, 2018 at 12:59:13PM +0200, Peter Rosin wrote: > >> During this, I found that the tda998x driver never sets the format in > >> the connec

Re: [PATCH 0/5] Add tda998x (HDMI) support to atmel-hlcdc

2018-04-09 Thread Russell King - ARM Linux
On Mon, Apr 09, 2018 at 12:59:13PM +0200, Peter Rosin wrote: > During this, I found that the tda998x driver never sets the format in > the connector display_info. Thus, the atmel-hlcdc driver fails to select > output format. Since I had similar problems with ds90c185 lvds encoder > I added patches

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

2018-04-06 Thread Russell King - ARM Linux
On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: > On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: > > > > > > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: > > > On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > > > > Commit b92df1de5d28 ("mm: page_alloc: skip over re

Re: [PATCH] arm: decompressor: mark error() as __noreturn

2018-04-04 Thread Russell King - ARM Linux
On Wed, Apr 04, 2018 at 03:34:06PM -0700, Kees Cook wrote: > On Wed, Apr 4, 2018 at 5:30 AM, Arnd Bergmann wrote: > > gcc complains about fortify_panic() possibly returning: > > > > arch/arm/boot/compressed/misc.c: In function 'fortify_panic': > > arch/arm/boot/compressed/misc.c:167:1: error: 'nor

Re: [PATCH v3 2/6] Disable instrumentation for some code

2018-04-03 Thread Russell King - ARM Linux
ode won't linkd with kernel image. > > > > Disable kasan check in the function unwind_pop_register > > because it doesn't matter that kasan checks failed when > > unwind_pop_register read stack memory of task. > > > > Reviewed-by: Russell King - ARM Linux >

Re: [PATCH v3 5/6] Initialize the mapping of KASan shadow memory

2018-04-02 Thread Russell King - ARM Linux
On Mon, Apr 02, 2018 at 02:08:13PM -0400, Nicolas Pitre wrote: > On Mon, 2 Apr 2018, Abbott Liu wrote: > > > index c79b829..20161e2 100644 > > --- a/arch/arm/kernel/head-common.S > > +++ b/arch/arm/kernel/head-common.S > > @@ -115,6 +115,9 @@ __mmap_switched: > > str r8, [r2]

Re: [PATCH] io: prevent compiler reordering on the default writeX() implementation

2018-03-30 Thread Russell King - ARM Linux
On Fri, Mar 30, 2018 at 10:29:58AM -0400, Sinan Kaya wrote: > The default implementation of mapping writeX() to __raw_writeX() is wrong. > writeX() has stronger ordering semantics. Compiler is allowed to reorder > __raw_writeX(). > > In the abscence of a write barrier or when using a strongly orde

Re: [PATCH v2 2/2] net: mvneta: improve suspend/resume

2018-03-30 Thread Russell King - ARM Linux
On Fri, Mar 30, 2018 at 06:36:15PM +0800, Jisheng Zhang wrote: > Current suspend/resume implementation reuses the mvneta_open() and > mvneta_close(), but it could be optimized to take only necessary > actions during suspend/resume. > > One obvious problem of current implementation is: after hundre

Re: [EXT] [PATCH net-next v2 0/2] phylink: API changes

2018-03-29 Thread Russell King - ARM Linux
4 AM > To: net...@vger.kernel.org > Cc: Florian Fainelli ; Thomas Petazzoni > ; Andrew Lunn ; David S. > Miller ; Russell King ; open > list ; Antoine Tenart > ; Yan Markman ; Stefan > Chulski ; Maxime Chevallier > ; Miquel Raynal > ; Marcin Wojtas > Subject: [E

Re: [PATCH net-next 2/2] sfp/phylink: move module EEPROM ethtool access into netdev core ethtool

2018-03-28 Thread Russell King - ARM Linux
On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote: > From: Russell King > > Provide a pointer to the SFP bus in struct net_device, so that the > ethtool module EEPROM methods can access the SFP directly, rather > than needing every user to provide a hook for it. >

Re: [PATCH net-next 1/2] net: phy: phylink: Provide PHY interface to mac_link_{up,down}

2018-03-28 Thread Russell King - ARM Linux
Florian Fainelli Similar comments to previous version wrt documentation, but... Acked-by: Russell King > --- > drivers/net/ethernet/marvell/mvneta.c | 4 +++- > drivers/net/phy/phylink.c | 4 +++- > include/linux/phylink.h | 10 -- > 3 files

Re: Regression with arm in next with stack protector

2018-03-27 Thread Russell King - ARM Linux
On Tue, Mar 27, 2018 at 11:35:25AM -0400, Rich Felker wrote: > On Tue, Mar 27, 2018 at 10:04:10AM +0100, Russell King - ARM Linux wrote: > > On Fri, Mar 23, 2018 at 11:14:53AM -0700, Tony Lindgren wrote: > > > Hi, > > > > > > Looks like commit 5638790d

Re: Regression with arm in next with stack protector

2018-03-27 Thread Russell King - ARM Linux
On Tue, Mar 27, 2018 at 10:04:10AM +0100, Russell King - ARM Linux wrote: > On Fri, Mar 23, 2018 at 11:14:53AM -0700, Tony Lindgren wrote: > > Hi, > > > > Looks like commit 5638790dadae ("zboot: fix stack protector in > > compressed boot phase") breaks booti

Re: Regression with arm in next with stack protector

2018-03-27 Thread Russell King - ARM Linux
On Tue, Mar 27, 2018 at 10:04:10AM +0100, Russell King - ARM Linux wrote: > On Fri, Mar 23, 2018 at 11:14:53AM -0700, Tony Lindgren wrote: > > Hi, > > > > Looks like commit 5638790dadae ("zboot: fix stack protector in > > compressed boot phase") breaks booti

Re: Regression with arm in next with stack protector

2018-03-27 Thread Russell King - ARM Linux
On Fri, Mar 23, 2018 at 11:14:53AM -0700, Tony Lindgren wrote: > Hi, > > Looks like commit 5638790dadae ("zboot: fix stack protector in > compressed boot phase") breaks booting on arm. > > This is all I get from the bootloader on omap3: > > Starting kernel ... > > data abort > pc : [<810002d0>]

Re: [PATCH 1/5] bus: arm-cci: use asm unreachable

2018-03-20 Thread Russell King - ARM Linux
On Wed, Mar 21, 2018 at 12:02:02AM +0100, Stefan Agner wrote: > Mixing asm and C code is not recommended in a naked function by > gcc and leads to an error when using clang: > drivers/bus/arm-cci.c:2107:2: error: non-ASM statement in naked > function is not supported > unreachable(); >

Re: [PATCH 5/5] ARM: add support for building ARM kernel with clang

2018-03-20 Thread Russell King - ARM Linux
On Wed, Mar 21, 2018 at 12:02:06AM +0100, Stefan Agner wrote: > Use cc-options call for compiler options which are not available > in clang. With this patch an ARMv7 multi platform kernel can be > successfully build using clang (tested with version 5.0.1). > > Based-on-patches-by: Behan Webster >

Re: [PATCH 3/5] ARM: trusted_foundations: do not use naked function

2018-03-20 Thread Russell King - ARM Linux
On Wed, Mar 21, 2018 at 12:02:04AM +0100, Stefan Agner wrote: > As documented in GCC naked functions should only use Basic asm > syntax. The Extended asm or mixture of Basic asm and "C" code is > not guaranteed. Currently this works because it was hard coded > to follow and check GCC behavior for a

Re: [PATCH] arm: dts: hummingboard2: convert onboard audio to simple-audio-card

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 09:53:26AM -0400, Matt Porter wrote: > The HB2 onboard audio currently makes use of the imx-audio-sgtl5000 > binding. This binding does not support auxiliary audio devices such > as external amplifiers. The simple-audio-card binding does support > this property which allows

Re: [EXT] Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 01:19:24PM +, Stefan Chulski wrote: > > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Monday, March 19, 2018 3:08 PM > > To: Stefan Chulski > > Cc: Antoine Tenart ; Russell King - ARM

Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 02:10:09PM +0100, Antoine Tenart wrote: > Hi Andrew, > > On Mon, Mar 19, 2018 at 01:59:53PM +0100, Andrew Lunn wrote: > > > > If they don't have PHYs, how are the connected to the outside world? > > On 7k/8k you have the following scheme for 10G only interfaces: > >M

Re: [EXT] Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 01:01:07PM +, Yan Markman wrote: > The DTS-patch for this board (in "old" format) is attached > > > Yan Markman > Tel. 05-44732819 > > > -Original Message- > From: Stefan Chulski > Sent: Monday, March 19, 201

Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-19 Thread Russell King - ARM Linux
On Mon, Mar 19, 2018 at 09:52:52AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Fri, Mar 16, 2018 at 03:53:07PM +, Russell King - ARM Linux wrote: > > On Fri, Mar 16, 2018 at 11:33:43AM +0100, Antoine Tenart wrote: > > > The PHY mode 10GKR can use in-band negotiat

Re: [PATCH 1/7] 2 1-byte checks more safer for memory_is_poisoned_16

2018-03-18 Thread Russell King - ARM Linux
On Sun, Mar 18, 2018 at 08:53:36PM +0800, Abbott Liu wrote: > Because in some architecture(eg. arm) instruction set, non-aligned > access support is not very well, so 2 1-byte checks is more > safer than 1 2-byte check. The impact on performance is small > because 16-byte accesses are not too commo

Re: [PATCH net-next 03/10] net: mvpp2: phylink support

2018-03-16 Thread Russell King - ARM Linux
On Fri, Mar 16, 2018 at 11:33:44AM +0100, Antoine Tenart wrote: > +static void mvpp2_phylink_validate(struct net_device *dev, > +unsigned long *supported, > +struct phylink_link_state *state) > +{ > + __ETHTOOL_DECLARE_LINK_MODE_MA

Re: [PATCH net-next 02/10] net: phy: phylink: allow 10GKR interface to use in-band negotiation

2018-03-16 Thread Russell King - ARM Linux
On Fri, Mar 16, 2018 at 11:33:43AM +0100, Antoine Tenart wrote: > The PHY mode 10GKR can use in-band negotiation. This patches allows this > mode to be used with MLO_AN_INBAND in phylink. > > Signed-off-by: Antoine Tenart > --- > drivers/net/phy/phylink.c | 3 ++- > 1 file changed, 2 insertions(

Re: [PATCH] arm: mm: Kconfig: Disable KUSER_HELPERS in ARMv6 or later as default

2018-03-06 Thread Russell King - ARM Linux
On Tue, Mar 06, 2018 at 08:22:41PM +0900, Jinbum Park wrote: > Codes for KUSER_HELPERS can be abused as ROP gadaget, > So that It's better to disable that as if possible. > > Since over ARMv6 has ldrex/strex at user-space, > NEED_KUSER_HELPERS is not selected for over ARMv6. > > But, Even though

Re: [PATCH] drm/bridge/synopsys: dw-hdmi: Fix memleak in __dw_hdmi_remove

2018-03-05 Thread Russell King - ARM Linux
On Mon, Mar 05, 2018 at 03:45:55PM +0800, Jeffy Chen wrote: > The platform_device_register_full() will allocate dma_mask for > hdmi->audio, so we should free before platform_device_unregister(). > > Reported by kmemleak: > unreferenced object 0xffc0ef70ff00 (size 128): > comm "kworker/4:1",

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-03 Thread Russell King - ARM Linux
On Sat, Mar 03, 2018 at 06:25:17PM +0200, Andy Shevchenko wrote: > On Fri, Mar 2, 2018 at 6:28 PM, Mark Rutland wrote: > > On Fri, Mar 02, 2018 at 03:32:22PM +, Russell King - ARM Linux wrote: > >> How do we break this status quo and finally solve the IRQ 0 and > >&

Re: [alsa-devel] regression v4.16 on Nokia N900: sound does not work

2018-03-02 Thread Russell King - ARM Linux
On Fri, Mar 02, 2018 at 08:22:52AM -0600, Andrew F. Davis wrote: > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > > index 84e5a9d..f0fab26 100644 > > --- a/drivers/gpio/gpiolib-of.c > > +++ b/drivers/gpio/gpiolib-of.c > > @@ -241,29 +241,17 @@ struct gpio_desc *of_find_gpio(

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-02 Thread Russell King - ARM Linux
On Fri, Mar 02, 2018 at 05:09:01PM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 02:58:54PM +0100, Wolfram Sang wrote: > > > > > It needs platform maintainers to be motivated to fix it, and one way to > > > provide that motivation is for subsystem maintainers to say no to patches > > > lik

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-02 Thread Russell King - ARM Linux
On Fri, Mar 02, 2018 at 01:46:47PM +0100, Wolfram Sang wrote: > > So, maybe some words why I accepted this patch. > > On Fri, Mar 02, 2018 at 11:19:31AM +0000, Russell King - ARM Linux wrote: > > Note that there have been patches proposed to make platform_get_irq() > >

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-02 Thread Russell King - ARM Linux
On Fri, Mar 02, 2018 at 03:26:56PM +0300, Dan Carpenter wrote: > Ok, but in that case the original code is still wrong because it returns > early with success. I guess it could be changed to: > > if (irq <= 0) > return -ENXIO; What if platform_get_irq() returns -EPROBE_DEFER

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-02 Thread Russell King - ARM Linux
On Fri, Mar 02, 2018 at 02:49:09PM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 11:19:31AM +0000, Russell King - ARM Linux wrote: > > On Thu, Mar 01, 2018 at 09:34:44PM +0100, Krzysztof Kozlowski wrote: > > > Interrupt number 0 (returned by platform_get_irq()) mi

Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0

2018-03-02 Thread Russell King - ARM Linux
On Thu, Mar 01, 2018 at 09:34:44PM +0100, Krzysztof Kozlowski wrote: > Interrupt number 0 (returned by platform_get_irq()) might be a valid IRQ > so do not treat it as an error. If interrupt 0 was configured, the driver > would exit the probe early, before finishing initialization, but with > 0-ex

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

2018-02-28 Thread Russell King
oft_reset = gen10g_soft_reset, > .config_init= mv3310_config_init, > .config_aneg= mv3310_config_aneg, > .aneg_done = mv3310_aneg_done, > -- > 2.14.1 > -- Russell King ARM architecture Linux Kernel maintainer

Re: [PATCH net-next 2/5] net: phy: Export gen10g_* functions

2018-02-28 Thread Russell King
_reset() doesn't do the soft-reset thing, which could be argued to be a bug, as there's a generic way to do that. However, doing that for the Marvell 10G driver would be a big mistake. The PHY crashes if you try to set the reset bit in any of the control register 1s. -- Russell King

Re: [PATCH] clk: don't call __of_clk_get_by_name() unnecessarily from clk_get()

2018-02-12 Thread Russell King - ARM Linux
On Mon, Feb 12, 2018 at 02:51:57PM -0600, David Lechner wrote: > On 02/12/2018 08:24 AM, Bartosz Golaszewski wrote: > >From: Bartosz Golaszewski > > > >The way this function is implemented caused some confusion when > >converting the TI DaVinci platform to using the common clock framework. > > > >

Re: [PATCHv2] arch/arm/Kconfig: default ARM_MODULE_PLTS to 'y'

2018-01-31 Thread Russell King - ARM Linux
On Wed, Jan 31, 2018 at 09:19:11PM +0100, Anders Roxell wrote: > While testing multi_v7_defconfig with LOCKDEP enabled, the kernel > fails to load simple modules, as reported by kselftest: > > [ 34.107620] test_printf: section 4 reloc 2 sym 'memset': relocation > 28 out of range (0xbf046044 -> 0

Re: [PATCH] arch/arm/Kconfig: enable ARM_MODULE_PLTS when LOCKDEP=y

2018-01-31 Thread Russell King - ARM Linux
On Wed, Jan 31, 2018 at 12:25:33PM +0100, Arnd Bergmann wrote: > On Tue, Jan 30, 2018 at 12:57 AM, Russell King - ARM Linux > wrote: > > On Tue, Jan 30, 2018 at 12:49:00AM +0100, Anders Roxell wrote: > >> While testing multi_v7_defconfig with LOCKDEP enabled, the kernel >

Re: [PATCH v2 08/16] arm/arm64: KVM: Advertise SMCCC v1.1

2018-01-29 Thread Russell King - ARM Linux
On Mon, Jan 29, 2018 at 05:45:51PM +, Marc Zyngier wrote: > The new SMC Calling Convention (v1.1) allows for a reduced overhead > when calling into the firmware, and provides a new feature discovery > mechanism. > > Make it visible to KVM guests. > > Signed-off-by: Marc Zyngier > --- > Docu

Re: [PATCH] arch/arm/Kconfig: enable ARM_MODULE_PLTS when LOCKDEP=y

2018-01-29 Thread Russell King - ARM Linux
On Tue, Jan 30, 2018 at 12:49:00AM +0100, Anders Roxell wrote: > While testing multi_v7_defconfig with LOCKDEP enabled, the kernel > fails to load simple modules, as reported by kselftest: > > [ 34.107620] test_printf: section 4 reloc 2 sym 'memset': relocation > 28 out of range (0xbf046044 -> 0

Re: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory

2018-01-26 Thread Russell King - ARM Linux
On Fri, Jan 26, 2018 at 02:30:47PM +0100, Marek Szyprowski wrote: > Hi Russell, > > On 2018-01-26 12:32, Russell King - ARM Linux wrote: > >On Fri, Jan 26, 2018 at 12:14:40PM +0100, Marek Szyprowski wrote: > >>glibc in calls cacheflush syscall on the whole textrels sect

Re: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory

2018-01-26 Thread Russell King - ARM Linux
On Fri, Jan 26, 2018 at 12:14:40PM +0100, Marek Szyprowski wrote: > glibc in calls cacheflush syscall on the whole textrels section of the > relocated binaries. However, relocation usually doesn't touch all pages > of that section, so not all of them are read to memory when calling this > syscall.

Re: [PATCH] arm64: Stop printing the virtual memory layout

2018-01-18 Thread Russell King - ARM Linux
On Thu, Jan 18, 2018 at 12:01:31PM -0800, Florian Fainelli wrote: > On 12/19/2017 11:28 AM, Laura Abbott wrote: > > Printing kernel addresses should be done in limited circumstances, mostly > > for debugging purposes. Printing out the virtual memory layout at every > > kernel bootup doesn't really

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Russell King - ARM Linux
On Wed, Jan 17, 2018 at 10:45:10AM -0600, Eric W. Biederman wrote: > Russell King - ARM Linux writes: > >From your description there still seems to be an association with an > instruction so I don't know if I would really call the signal > asynchronous. It sounds like the

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Russell King - ARM Linux
On Wed, Jan 17, 2018 at 03:37:31PM +, Dave Martin wrote: > On Wed, Jan 17, 2018 at 12:37:52PM +0000, Russell King - ARM Linux wrote: > > On Wed, Jan 17, 2018 at 12:15:05PM +, Dave Martin wrote: > > > On Wed, Jan 17, 2018 at 11:57:09AM +, Russell King

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Russell King - ARM Linux
On Wed, Jan 17, 2018 at 12:15:05PM +, Dave Martin wrote: > On Wed, Jan 17, 2018 at 11:57:09AM +0000, Russell King - ARM Linux wrote: > > On Tue, Jan 16, 2018 at 04:28:50PM -0600, Eric W. Biederman wrote: > > > I will keep FPE_FIXME as a place holder until th

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Russell King - ARM Linux
On Tue, Jan 16, 2018 at 04:28:50PM -0600, Eric W. Biederman wrote: > I will keep FPE_FIXME as a place holder until this gets sorted out. > > There is a second issue I am looking at in this location, > and maybe I don't have to address it now. But it looks like the code is > calling send_sig_info

Re: [PATCH] ARM: make memzero optimization smarter

2018-01-17 Thread Russell King - ARM Linux
On Tue, Jan 16, 2018 at 11:07:34PM -0500, Nicolas Pitre wrote: > On Tue, 16 Jan 2018, Arnd Bergmann wrote: > > > On Tue, Jan 16, 2018 at 6:10 PM, Nicolas Pitre > > wrote: > > > On Tue, 16 Jan 2018, Arnd Bergmann wrote: > > > > > >> However, we can avoid this class of bogus warnings for the memse

Re: [PATCH net-next v5 0/4] net: mvpp2: 1000BaseX and 2500BaseX support

2018-01-16 Thread Russell King - ARM Linux
On Fri, Jan 12, 2018 at 08:51:26AM +0100, Antoine Tenart wrote: > Hi all, > > This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2 > driver. In order to use it, the 2.5 SGMII mode is added in the Marvell > common PHY driver (cp110-comphy). > > This was tested on a mcbin. > > All

Re: [PATCH 08/11] signal/arm: Document conflicts with SI_USER and SIGFPE

2018-01-15 Thread Russell King - ARM Linux
On Thu, Jan 11, 2018 at 06:59:37PM -0600, Eric W. Biederman wrote: > Setting si_code to 0 results in a userspace seeing an si_code of 0. > This is the same si_code as SI_USER. Posix and common sense requires > that SI_USER not be a signal specific si_code. As such this use of 0 > for the si_code

Re: [PATCH] i2c: acorn: add MODULE_LICENSE tag

2018-01-15 Thread Russell King
-acorn.c > > +++ b/drivers/i2c/busses/i2c-acorn.c > > @@ -94,3 +94,7 @@ static int __init i2c_ioc_init(void) > > } > > > > module_init(i2c_ioc_init); > > + > > +MODULE_AUTHOR("Russell King "); li...@armlinux.org.uk please - dspam on _this_ account files such mails i

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-12 Thread Russell King - ARM Linux
Do you think that the appropriate patches could be copied to the appropriate people please? On Thu, Jan 11, 2018 at 04:46:24PM -0800, Dan Williams wrote: > Changes since v1 [1]: > * fixup the ifence definition to use alternative_2 per recent AMD > changes in tip/x86/pti (Tom) > > * drop 'nospec

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Russell King - ARM Linux
On Thu, Jan 11, 2018 at 05:00:03PM +0100, Geert Uytterhoeven wrote: > On Thu, Jan 11, 2018 at 4:54 PM, Geert Uytterhoeven > wrote: > > On Thu, Jan 11, 2018 at 4:53 PM, Russell King - ARM Linux > > wrote: > >> On Thu, Jan 11, 2018 at 10:48:35AM -0500, David Mill

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-11 Thread Russell King - ARM Linux
On Thu, Jan 11, 2018 at 10:48:35AM -0500, David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 9 Jan 2018 12:11:21 +0100 > > > In case of success, the return values of (__)phy_write() and > > (__)phy_modify() are not compatible: (__)phy_write() returns 0, while > > (__)phy_modify() return

Re: [PATCH 34/38] arm: Implement thread_struct whitelist for hardened usercopy

2018-01-11 Thread Russell King - ARM Linux
hat this patch is wrong and will introduce a regression. Thanks. > > Cc: Russell King > Cc: Ingo Molnar > Cc: Christian Borntraeger > Cc: "Peter Zijlstra (Intel)" > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Kees Cook > --- > arch/arm/Kc

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 07:25:40PM +0100, Geert Uytterhoeven wrote: > Hi Russell, > > On Tue, Jan 9, 2018 at 3:22 PM, Russell King - ARM Linux > wrote: > > On Tue, Jan 09, 2018 at 03:10:08PM +0100, Andrew Lunn wrote: > >> On Tue, Jan 09, 2018 at 12:11:21PM +010

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 03:48:13PM +0100, Andrew Lunn wrote: > > > I took a quick look at the uses of phy_modify(). I don't see any uses > > > of the return code other than as an error indicator. So having it > > > return 0 on success seems like a better fix. > > > > I'd like to avoid that, becaus

Re: [PATCH] ARM: locomo: fix free dev incorrectly

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 10:37:55PM +0800, Xiongwei Song wrote: > In function locomo_init_one_child, If kzalloc call is failed for dev we > would goto out label, then call kfree for dev, however, dev is NULL, we > shouldn't do this. kfree() internally checks for NULL pointers so callers don't have

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > nearly the same code path. Sorry, also... > @@ -4668,6 +4692,10 @@ static void mvpp2_p

Re: [PATCH net-next v3 4/4] net: mvpp2: 2500baseX support

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 09:59:45AM +0100, Antoine Tenart wrote: > This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 > driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses > nearly the same code path. For 2500Base-X, do you report a speed of 2500Mbps through et

Re: [PATCH] net: phy: Fix phy_modify() semantic difference fallout

2018-01-09 Thread Russell King - ARM Linux
On Tue, Jan 09, 2018 at 03:10:08PM +0100, Andrew Lunn wrote: > On Tue, Jan 09, 2018 at 12:11:21PM +0100, Geert Uytterhoeven wrote: > > In case of success, the return values of (__)phy_write() and > > (__)phy_modify() are not compatible: (__)phy_write() returns 0, while > > (__)phy_modify() returns

Re: [V4, 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2018-01-05 Thread Russell King - ARM Linux
On Fri, Jan 05, 2018 at 02:05:26PM +0100, Alexandre Belloni wrote: > Hi, > > I'm definitively late to the party but... > > On 17/11/2017 at 11:00:33 +0100, Thomas Gleixner wrote: > > +2. Style: > > + > > + The SPDX license identifier is added in form of a comment. The comment > > + style dep

Re: [PATCH v3 00/20] arm64: Unmap the kernel whilst running in userspace (KPTI)

2018-01-04 Thread Russell King - ARM Linux
On Thu, Jan 04, 2018 at 10:23:40AM -0800, Florian Fainelli wrote: > Great, thanks! Bonus question, if someone is using any of the affected > devices in AArch32, should we be expecting to see ARM/Linux changes as > well, that is, is there a plan to come up with a kpti implementation for > ARM? Give

Re: [kernel-hardening] [PATCH] arm: Always use REFCOUNT_FULL

2018-01-04 Thread Russell King - ARM Linux
On Thu, Jan 04, 2018 at 10:42:21AM -0800, Kees Cook wrote: > On Thu, Jan 4, 2018 at 10:35 AM, Russell King - ARM Linux > wrote: > > On Thu, Jan 04, 2018 at 10:32:46AM -0800, Kees Cook wrote: > >> On Thu, Jan 4, 2018 at 4:28 AM, Jinbum Park wrote: > >> > ar

Re: [kernel-hardening] [PATCH] arm: Always use REFCOUNT_FULL

2018-01-04 Thread Russell King - ARM Linux
On Thu, Jan 04, 2018 at 10:32:46AM -0800, Kees Cook wrote: > On Thu, Jan 4, 2018 at 4:28 AM, Jinbum Park wrote: > > arm prefers to use REFCOUNT_FULL by default. > > This enables it for arm. > > > > Signed-off-by: Jinbum Park > > Acked-by: Kees Cook I'd help if there was some kind of explanatio

Re: [PATCH net-next v2 4/4] net: mvpp2: 2500baseX support

2018-01-03 Thread Russell King - ARM Linux
On Wed, Jan 03, 2018 at 04:20:36PM +0100, Andrew Lunn wrote: > > @@ -4612,6 +4616,9 @@ static int mvpp22_comphy_init(struct mvpp2_port *port) > > case PHY_INTERFACE_MODE_1000BASEX: > > mode = PHY_MODE_SGMII; > > break; > > + case PHY_INTERFACE_MODE_2500BASEX: > > +

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-03 Thread Russell King - ARM Linux
On Wed, Jan 03, 2018 at 05:00:47PM +, Stefan Chulski wrote: > > > > -Original Message- > > > > Hi Russell, > > > > > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named > > > > as 'in- band' to be on par with the specifications. Anyway - this > > > > one is rather a

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2018-01-03 Thread Russell King - ARM Linux
On Wed, Jan 03, 2018 at 04:08:30PM +0100, Andrew Lunn wrote: > > > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > > >>> --- a/include/linux/phy/phy.h > > > >>> +++ b/include/linux/phy/phy.h > > > >>> @@ -28,6 +28,7 @@ enum ph

Re: [PATCH] [v2] ARM: B15: fix unused label warnings

2018-01-02 Thread Russell King - ARM Linux
On Mon, Dec 18, 2017 at 05:21:24PM -0800, Florian Fainelli wrote: > On 12/18/2017 08:52 AM, Arnd Bergmann wrote: > > The new conditionally compiled code leaves some labels and one > > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP > > are disabled: > > > > arch/arm/mm/cache-b15-

Re: [PATCH] arch: drop duplicate exports of abort()

2018-01-02 Thread Russell King - ARM Linux
On Tue, Jan 02, 2018 at 11:34:45AM +, Sudip Mukherjee wrote: > Hi Arnd, > > On Tue, Jan 02, 2018 at 11:31:12AM +0100, Arnd Bergmann wrote: > > We now have exports in both architecture code in in common code, > > which causes a link failure when symbol versioning is eanbled, on > > four archite

Re: [PATCH] arch: drop duplicate exports of abort()

2018-01-02 Thread Russell King - ARM Linux
xit.c:(*ABS*+0xc0e2ec8b): multiple definition of `__crc_abort' > > This removes the four architecture specific exports and only > leaves the export next to the __weak symbol. > > Fixes: mmotm ("kernel/exit.c: export abort() to modules") > Signed-off-by: Arnd Bergmann

Re: [EXT] Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-01-01 Thread Russell King - ARM Linux
On Mon, Jan 01, 2018 at 10:35:25AM +, Stefan Chulski wrote: > > > -Original Message- > > Hi Russell, > > > > Indeed. RGMII MAC behaves same way, although it shouldn't be named as 'in- > > band' to be on par with the specifications. Anyway - this one is rather a > > stub for > > being

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-30 Thread Russell King - ARM Linux
Hi Marcin, On Sat, Dec 30, 2017 at 05:34:23PM +0100, Marcin Wojtas wrote: > Yes, I already split the series and will send first one right away. I > will be followed by MDIO bus / PHY handling proposal, including the > bits related to phylink. I'm looking forward to your opinion on that > once sent

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-29 Thread Russell King - ARM Linux
On Fri, Dec 29, 2017 at 12:12:15PM +0100, Marcin Wojtas wrote: > Hi Russell, > > I see that I misspelled your email address, hence the series remained > unnoticed: > https://lkml.org/lkml/2017/12/18/216 > > In terms of the phylink support, I think the most important are: > * 3/8 > https://lkml.o

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
On Thu, Dec 28, 2017 at 11:04:16AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 11:20:00PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > > > > > > What do you suggest to des

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-28 Thread Russell King - ARM Linux
gt; >> On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > > >>> On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > >>>> > > >>>> +&cps_eth2 { > > >>>> + /* CPS Lane

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:42:52PM +0100, Antoine Tenart wrote: > Hi Russell, > > On Wed, Dec 27, 2017 at 10:24:01PM +, Russell King - ARM Linux wrote: > > On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > > > > > > +&cps_eth2 { &g

Re: [PATCH net-next 5/6] arm64: dts: marvell: mcbin: enable the fourth network interface

2017-12-27 Thread Russell King - ARM Linux
On Wed, Dec 27, 2017 at 11:14:45PM +0100, Antoine Tenart wrote: > This patch enables the fourth network interface on the Marvell > Macchiatobin. It is configured in the 2500Base-X PHY mode. > > Signed-off-by: Antoine Tenart > --- > arch/arm64/boot/dts/marvell/armada-8040-mcbin.dts | 8 >

Re: [PATCH] gpio: gpio-reg: fix build

2017-12-24 Thread Russell King - ARM Linux
On Sun, Dec 24, 2017 at 06:44:07PM +0100, Linus Walleij wrote: > On Sun, Dec 24, 2017 at 4:56 PM, Russell King - ARM Linux > wrote: > > > But the main thing is, this needs to be fixed - it's been causing build > > errors for those of us carrying patches to use it, and

Re: [PATCH] gpio: gpio-reg: fix build

2017-12-24 Thread Russell King - ARM Linux
y are not aplicable to this driver. > > > > Cc: Russell King - ARM Linux > > Fixes: f0fbe7bce733 ("gpio: Move irqdomain into struct gpio_irq_chip") > > Signed-off-by: Grygorii Strashko > > --- > > Sorry, for inconvenience, but this driver has no users

Re: [PATCH 00/11] constify gpio_led

2017-12-23 Thread Russell King - ARM Linux
On Wed, Dec 20, 2017 at 02:17:41PM +0530, Arvind Yadav wrote: > gpio_led are not supposed to change at runtime. > struct gpio_led_platform_data working with const gpio_led > provided by . So mark the non-const structs > as const. Marking the structs as const is fine, but marking them __initconst i

Re: [PATCH] ARM: B15: fix unused label warnings

2017-12-18 Thread Russell King - ARM Linux
On Mon, Dec 18, 2017 at 02:41:11PM +0100, Arnd Bergmann wrote: > The new conditionally compiled code leaves some labels and one > variable unreferenced when CONFIG_HOTPLUG_CPU and CONFIG_PM_SLEEP > are disabled: > > arch/arm/mm/cache-b15-rac.c: In function 'b15_rac_init': > arch/arm/mm/cache-b15-r

Re: [PATCH net-next] net: phy: phylink: Handle NULL fwnode_handle

2017-12-14 Thread Russell King - ARM Linux
arly to -ENOENT. > > Fixes: 8fa7b9b6af25 ("phylink: convert to fwnode") > Signed-off-by: Florian Fainelli Acked-by: Russell King Thanks Florian. > --- > drivers/net/phy/phylink.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/phy/phylink.c b

Re: [PATCH V4 08/12] boot_constraint: Manage deferrable constraints

2017-12-13 Thread Russell King - ARM Linux
On Wed, Dec 13, 2017 at 03:57:07PM +0530, Viresh Kumar wrote: > On 13-12-17, 10:53, Greg Kroah-Hartman wrote: > > On Sun, Oct 29, 2017 at 07:18:56PM +0530, Viresh Kumar wrote: > > > +static void add_deferrable_of_single(struct device_node *np, > > > + struct dev_boot_co

Re: [PATCH] ARM: CPU hotplug: Delegate complete() to surviving CPU

2017-12-12 Thread Russell King - ARM Linux
> readers. This patch therefore uses Thomas Gleixner's trick of delegating > the complete() call to a surviving CPU via smp_call_function_single(). > > Reported-by: Peng Fan > Reported-by: Russell King - ARM Linux > Signed-off-by: Paul E. McKenney > Tested-by: Tested-by

Re: [VDSO]: vdso_test failing on arm 32 bit

2017-12-12 Thread Russell King - ARM Linux
On Tue, Dec 12, 2017 at 09:49:42PM +0530, Pintu Kumar wrote: > Hi All, > > Did anybody tried running vdso_test (under Documentation/vDSO in > kernel 4.1) on an ARM 32 bit system? > > When I test it on iMX.7 board (kernel 4.1, ARM 32 bit), I get this: > # ./vdso_test > Could not find __vdso_gettim

Re: [PATCH net-next v5 2/2] net: ethernet: socionext: add AVE ethernet driver

2017-12-11 Thread Russell King - ARM Linux
On Mon, Dec 11, 2017 at 10:34:17PM +0900, Masami Hiramatsu wrote: > IMHO, even if we use SPDX license identifier, I recommend to use > C-style comments as many other files do, since it is C code. > If SPDX identifier requires C++ style, that is SPDX parser's issue > and should be fixed to get it fr

Re: [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers

2017-12-08 Thread Russell King - ARM Linux
On Thu, Dec 07, 2017 at 05:02:35PM +0100, Andrew Lunn wrote: > > Banks actually comes from the datasheet, Yes. > > I don't mind renaming it but I would be making things up. As you wish ? > > Keep it as is for the moment. > > > Does the usual pages comes with this weird toggle thing to open the a

Re: [PATCH] Arm: mm: ftrace: Only set text back to ro after kernel has been marked ro

2017-12-05 Thread Russell King - ARM Linux
On Tue, Dec 05, 2017 at 11:35:59AM -0800, Kees Cook wrote: > We don't _need_ to, but they're all contiguous, so the ro_perms array > used by set_kernel_text_*() is actually only a single entry: > > static struct section_perm ro_perms[] = { > /* Make kernel code and rodata RX (set RO). */ >

Re: [PATCH] Arm: mm: ftrace: Only set text back to ro after kernel has been marked ro

2017-12-05 Thread Russell King - ARM Linux
On Tue, Dec 05, 2017 at 01:30:11PM +, Phil Elwell wrote: > On 05/12/2017 13:23, Matthias Reichl wrote: > > On Tue, Dec 05, 2017 at 01:14:17PM +, Russell King - ARM Linux wrote: > >> On Tue, Dec 05, 2017 at 12:47:09PM +0100, Matthias Reichl wrote: > >>> On W

Re: [PATCH] Arm: mm: ftrace: Only set text back to ro after kernel has been marked ro

2017-12-05 Thread Russell King - ARM Linux
On Tue, Dec 05, 2017 at 12:47:09PM +0100, Matthias Reichl wrote: > On Wed, Aug 23, 2017 at 03:03:51PM -0400, Steven Rostedt wrote: > > On Wed, 23 Aug 2017 11:48:13 -0700 > > Kees Cook wrote: > > > > > > diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c > > > > index ad80548..fd75f38 100644 > >

Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's error checking

2017-12-05 Thread Russell King - ARM Linux
On Tue, Dec 05, 2017 at 01:12:23PM +0300, Sergei Shtylyov wrote: >Well, we can have: > > return r && r->start ? r->start : -ENXIO; > > instead of: > > return r ? r->start : -ENXIO; > > at the end of platform_get_irq(). But I don't really think it's worth doing > -- request_irq()

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:34:48AM -0500, David Miller wrote: > From: Russell King - ARM Linux > Date: Mon, 4 Dec 2017 16:24:47 + > > > On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > >> From: Arvind Yadav > >> Date: Sun, 3 Dec 201

Re: [PATCH 03/10] net: ezchip: nps_enet: Fix platform_get_irq's error checking

2017-12-04 Thread Russell King - ARM Linux
On Mon, Dec 04, 2017 at 11:20:49AM -0500, David Miller wrote: > From: Arvind Yadav > Date: Sun, 3 Dec 2017 00:56:15 +0530 > > > The platform_get_irq() function returns negative if an error occurs. > > zero or positive number on success. platform_get_irq() error checking > > for zero is not corre

<    6   7   8   9   10   11   12   13   14   15   >