[PATCH v2 7/7] staging: qlge: Fix function argument alignment warning in ql_init_device

Fix checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index

[PATCH v2 6/7] staging: qlge: Fix suspect code indent warning in ql_init_device

Fix checkpatch.pl warnings: WARNING: suspect code indent for conditional statements (16, 23) WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/qlge

[PATCH v2 5/7] staging: qlge: Remove multi-line dereference from ql_request_irq

Fix checkpatch.pl warning: WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/q

[PATCH v2 3/7] staging: qlge: Fix indentation in ql_get_mac_addr_reg

This has similar indentation style issues as ql_set_mac_addr_reg, so I thought I'd re-indent this too. Fix several checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 76 1 file changed

[PATCH v2 4/7] staging: qlge: Remove goto statements from ql_get_mac_addr_reg

Similar to ql_set_mac_addr_reg, ql_get_mac_addr_reg also has several goto statements that can be trivially replaced with a break statement. Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH v2 1/7] staging: qlge: Fix indentation in ql_set_mac_addr_reg

- prefer 'qdev->func' WARNING: line over 80 characters Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 167 +++ 1 file changed, 78 insertions(+), 89 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_ma

[PATCH v2 2/7] staging: qlge: Remove gotos from ql_set_mac_addr_reg

As suggested by Joe Perches, this patch removes the 'exit' label from the ql_set_mac_addr_reg function and replaces the goto statements with break statements. Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions

[PATCH v2 0/7] staging: qlge: Checkpatch.pl indentation fixes in qlge_main.c

by unindenting ql_set_mac_addr_reg and by replacing goto statements with break statements in the function. Rylan Dmello (7): staging: qlge: Fix indentation in ql_set_mac_addr_reg staging: qlge: Remove gotos from ql_set_mac_addr_reg staging: qlge: Fix indentation in ql_get_mac_addr_reg

Re: [PATCH 1/3] staging: qlge: Remove multi-line dereferences from qlge_main.c

On Tue, Apr 28, 2020 at 09:31:10PM -0700, Joe Perches wrote: > On Wed, 2020-04-29 at 00:04 -0400, Rylan Dmello wrote: > > Fix checkpatch.pl warnings: > > > > WARNING: Avoid multiple line dereference - prefer 'qdev->func' > > WARNING: Avoid multiple line der

[PATCH 2/3] staging: qlge: Fix suspect indentation warning in qlge_main.c

Fix checkpatch.pl warning: WARNING: suspect code indent for conditional statements (16, 23) Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge

[PATCH 3/3] staging: qlge: Fix function argument alignment warning in qlge_main.c

Fix checkpatch.pl check: CHECK: Alignment should match open parenthesis Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index

[PATCH 1/3] staging: qlge: Remove multi-line dereferences from qlge_main.c

Fix checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'qdev->func' WARNING: Avoid multiple line dereference - prefer 'qdev->flags' Signed-off-by: Rylan Dmello --- drivers/staging/qlge/qlge_main.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)