[PATCH 3/5] misc/pti: Improve a size determination in two functions

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:28:44 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 3/5] misc/pti: Improve a size determination in two functions

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:28:44 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 2/5] misc/pti: Fix a typo in five comment lines

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:18:15 +0100 Adjust words in these descriptions. Signed-off-by: Markus Elfring --- drivers/misc/pti.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 2/5] misc/pti: Fix a typo in five comment lines

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:18:15 +0100 Adjust words in these descriptions. Signed-off-by: Markus Elfring --- drivers/misc/pti.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/pti.c b/drivers/misc/pti.c index

[PATCH 1/5] misc/pti: Delete an error message for a failed memory allocation in two functions

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:00:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/5] misc/pti: Delete an error message for a failed memory allocation in two functions

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 18:00:15 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/pti.c | 8 +--- 1 file changed, 1 insertion(+), 7

[PATCH 0/5] misc-PTI: Adjustments for some function implementations

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 19:06:36 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an error message for a failed memory allocation in two functions Fix a typo in five comment

[PATCH 0/5] misc-PTI: Adjustments for some function implementations

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 19:06:36 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (5): Delete an error message for a failed memory allocation in two functions Fix a typo in five comment lines Improve a size

[PATCH] misc/phantom: Delete an error message for a failed memory allocation in phantom_probe()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 17:25:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] misc/phantom: Delete an error message for a failed memory allocation in phantom_probe()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 17:25:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/phantom.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH] misc/mic/host: Delete an error message for a failed memory allocation in mic_probe()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 17:03:41 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] misc/mic/host: Delete an error message for a failed memory allocation in mic_probe()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 17:03:41 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/mic/host/mic_main.c | 1 - 1 file changed, 1 deletion(-)

[PATCH] misc/lkdtm_usercopy: Delete an error message for a failed memory allocation in do_usercopy_heap_whitelist()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 13:31:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] misc/lkdtm_usercopy: Delete an error message for a failed memory allocation in do_usercopy_heap_whitelist()

2018-01-09 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 9 Jan 2018 13:31:43 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/lkdtm_usercopy.c | 4 +--- 1 file changed, 1

[PATCH] misc/lis3lv02d: Delete an error message for a failed memory allocation in lis3lv02d_init_device()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 22:26:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] misc/lis3lv02d: Delete an error message for a failed memory allocation in lis3lv02d_init_device()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 22:26:06 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/lis3lv02d/lis3lv02d.c | 5 + 1 file changed, 1

Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-08 Thread SF Markus Elfring
> These messages are not displayed anywhere else: > "unable to allocate receive buffer of size %u\n" > "unable to allocate send buffer of size %u\n", > > After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation > failed without the error message. Do you notice a Linux

Re: hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-08 Thread SF Markus Elfring
> These messages are not displayed anywhere else: > "unable to allocate receive buffer of size %u\n" > "unable to allocate send buffer of size %u\n", > > After set ret = -ENOMEM; and cleanup, we won't know which buffer allocation > failed without the error message. Do you notice a Linux

[PATCH] misc/lattice-ecp3-config: Delete an error message for a failed memory allocation in two functions

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 18:01:39 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] misc/lattice-ecp3-config: Delete an error message for a failed memory allocation in two functions

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 18:01:39 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/lattice-ecp3-config.c | 9 +++-- 1 file changed, 3

[PATCH 4/4] misc/ioc4: Adjust one function call together with a variable assignment

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:43:21 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring

[PATCH 4/4] misc/ioc4: Adjust one function call together with a variable assignment

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:43:21 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/misc/ioc4.c | 5 +++-- 1 file

[PATCH 3/4] misc/ioc4: Improve a size determination in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:18:52 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 3/4] misc/ioc4: Improve a size determination in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:18:52 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 2/4] misc/ioc4: Delete an error message for a failed memory allocation in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:14:49 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 2/4] misc/ioc4: Delete an error message for a failed memory allocation in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:14:49 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/ioc4.c | 3 --- 1 file changed, 3 deletions(-) diff

[PATCH 1/4] misc/ioc4: Return -ENOMEM after a failed kmalloc() in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:12:52 +0100 Replace an error code for the indication of a memory allocation failure in this function. Fixes: 22329b511a97557b293583194037d1f4c71e1504 ("ioc4: Core driver rewrite") Signed-off-by: Markus Elfring

[PATCH 1/4] misc/ioc4: Return -ENOMEM after a failed kmalloc() in ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 16:12:52 +0100 Replace an error code for the indication of a memory allocation failure in this function. Fixes: 22329b511a97557b293583194037d1f4c71e1504 ("ioc4: Core driver rewrite") Signed-off-by: Markus Elfring --- drivers/misc/ioc4.c | 2 +- 1

[PATCH 0/4] misc-IOC4: Adjustments for ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 17:01:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Return -ENOMEM after a failed kmalloc() Delete an error message for a failed memory allocation

[PATCH 0/4] misc-IOC4: Adjustments for ioc4_probe()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 17:01:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Return -ENOMEM after a failed kmalloc() Delete an error message for a failed memory allocation Improve a size determination

Re: [3/3] GenWQE: Adjust 12 checks for null pointers

2018-01-08 Thread SF Markus Elfring
> I personally like the explicit compare (ptr != NULL) more than the !ptr > notation. Coding style aspects can evolve, can't they? > When was the checkpatch.pl script modified to suggest the latter notation? Would you like to take another look at the software update “checkpatch: add --strict

Re: [3/3] GenWQE: Adjust 12 checks for null pointers

2018-01-08 Thread SF Markus Elfring
> I personally like the explicit compare (ptr != NULL) more than the !ptr > notation. Coding style aspects can evolve, can't they? > When was the checkpatch.pl script modified to suggest the latter notation? Would you like to take another look at the software update “checkpatch: add --strict

Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap()

2018-01-08 Thread SF Markus Elfring
>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, struct >> dma_mapping *m, void *uaddr, >>     sizeof(struct page *) + sizeof(dma_addr_t), >>     GFP_KERNEL); >> if (!m->page_list) { >> -    dev_err(_dev->dev, "err: alloc page_list

Re: [PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap()

2018-01-08 Thread SF Markus Elfring
>> @@ -593,7 +593,6 @@ int genwqe_user_vmap(struct genwqe_dev *cd, struct >> dma_mapping *m, void *uaddr, >>     sizeof(struct page *) + sizeof(dma_addr_t), >>     GFP_KERNEL); >> if (!m->page_list) { >> -    dev_err(_dev->dev, "err: alloc page_list

[PATCH 3/3] misc/ibmasm: Adjust two function calls together with a variable assignment

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:53:25 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 3/3] misc/ibmasm: Adjust two function calls together with a variable assignment

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:53:25 +0100 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/misc/ibmasm/module.c | 8 +---

[PATCH 2/3] misc/ibmasm: Improve a size determination in ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:43:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/3] misc/ibmasm: Improve a size determination in ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:43:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/3] misc/ibmasm: Delete an error message for a failed memory allocation in ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:34:55 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] misc/ibmasm: Delete an error message for a failed memory allocation in ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 13:34:55 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/ibmasm/module.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/3] misc-IBM ASM SP: Adjustments for ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 14:01:24 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Improve a size determination Adjust two

[PATCH 0/3] misc-IBM ASM SP: Adjustments for ibmasm_init_one()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 14:01:24 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation Improve a size determination Adjust two function calls together with a

Re: Adjustments for a lot of function implementations

2018-01-08 Thread SF Markus Elfring
> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Are you going to answer any of my remaining questions in a more constructive way? Regards, Markus

Re: Adjustments for a lot of function implementations

2018-01-08 Thread SF Markus Elfring
> ??? I did that: either one patch per directory with the same type of change, > or one patch per driver combining all the changes for that driver. Are you going to answer any of my remaining questions in a more constructive way? Regards, Markus

Re: Rename the SmPL script “kzalloc-….cocci”?

2018-01-08 Thread SF Markus Elfring
> If you want to be more general than kzalloc, then perhaps > zalloc-simple.cocci would be ok. Are you going to commit such a file name adjustment when it seems that you would not like to accept any other suggestion there? Regards, Markus

Re: Rename the SmPL script “kzalloc-….cocci”?

2018-01-08 Thread SF Markus Elfring
> If you want to be more general than kzalloc, then perhaps > zalloc-simple.cocci would be ok. Are you going to commit such a file name adjustment when it seems that you would not like to accept any other suggestion there? Regards, Markus

[PATCH 3/3] GenWQE: Adjust 12 checks for null pointers

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 10:21:25 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 3/3] GenWQE: Adjust 12 checks for null pointers

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 10:21:25 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code

[PATCH 2/3] GenWQE: Fix a typo in two comments

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 09:57:10 +0100 Add a missing character in two words of these descriptions. Signed-off-by: Markus Elfring --- drivers/misc/genwqe/card_utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 2/3] GenWQE: Fix a typo in two comments

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 09:57:10 +0100 Add a missing character in two words of these descriptions. Signed-off-by: Markus Elfring --- drivers/misc/genwqe/card_utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/genwqe/card_utils.c

[PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 09:37:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] GenWQE: Delete an error message for a failed memory allocation in genwqe_user_vmap()

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 09:37:23 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/genwqe/card_utils.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 0/3] GenWQE: Adjustments for some function implementations

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 10:32:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in genwqe_user_vmap() Fix a typo in two

[PATCH 0/3] GenWQE: Adjustments for some function implementations

2018-01-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 Jan 2018 10:32:23 +0100 A few update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in genwqe_user_vmap() Fix a typo in two comments Adjust 12 checks for

Re: [PATCH] atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> @@ -708,11 +708,11 @@ static void svc_addr(struct seq_file *seq, struct >> sockaddr_atmsvc *addr) >> static int e164[] = { 1, 8, 4, 6, 1, 0 }; >> >> if (*addr->sas_addr.pub) { >> - seq_printf(seq, "%s", addr->sas_addr.pub); >> + seq_puts(seq,

Re: [PATCH] atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> @@ -708,11 +708,11 @@ static void svc_addr(struct seq_file *seq, struct >> sockaddr_atmsvc *addr) >> static int e164[] = { 1, 8, 4, 6, 1, 0 }; >> >> if (*addr->sas_addr.pub) { >> - seq_printf(seq, "%s", addr->sas_addr.pub); >> + seq_puts(seq,

[PATCH 2/2] misc/fsa9480: Improve a size determination in fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:20:19 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] misc/fsa9480: Improve a size determination in fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:20:19 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] misc/fsa9480: Delete an error message for a failed memory allocation in fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:17:53 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] misc/fsa9480: Delete an error message for a failed memory allocation in fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:17:53 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/fsa9480.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 0/2] misc/fsa9480: Adjustments for fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:26:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] misc/fsa9480: Adjustments for fsa9480_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 22:26:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/misc/fsa9480.c | 6 ++ 1 file

[PATCH 2/2] misc/apds9802als: Improve a size determination in apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:48:50 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] misc/apds9802als: Improve a size determination in apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:48:50 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] misc/apds9802als: Delete an error message for a failed memory allocation in apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:42:07 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] misc/apds9802als: Delete an error message for a failed memory allocation in apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:42:07 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/misc/apds9802als.c | 5 ++--- 1 file changed, 2 insertions(+),

[PATCH 0/2] misc/apds9802als: Adjustments for apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:58:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] misc/apds9802als: Adjustments for apds9802als_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:58:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/misc/apds9802als.c | 8 +++- 1

[PATCH] hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:03:26 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hyperv/netvsc: Delete two error messages for a failed memory allocation in netvsc_init_buf()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 21:03:26 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/hyperv/netvsc.c | 5 - 1 file changed, 5 deletions(-)

[PATCH v2] video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 19:27:28 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH v2] video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 19:27:28 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

Re: atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> Is the function "seq_puts" a bit more efficient for the desired output >> of a single string in comparison to calling the function "seq_printf" >> for this purpose? > > Will you please be so kind and tell us? How do you think about to get the run time characteristics for these sequence output

Re: atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> Is the function "seq_puts" a bit more efficient for the desired output >> of a single string in comparison to calling the function "seq_printf" >> for this purpose? > > Will you please be so kind and tell us? How do you think about to get the run time characteristics for these sequence output

[PATCH v3 2/3] video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:07:11 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH v3 3/3] video: smscufx: Delete an error message for a failed memory allocation in ufx_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:12:40 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v3: This

[PATCH v3 2/3] video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:07:11 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- v3: This update

[PATCH v3 3/3] video: smscufx: Delete an error message for a failed memory allocation in ufx_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:12:40 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v3: This update suggestion was rebased on source files from the

[PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 15:56:11 +0100 Up to four checks could be repeated by the ufx_usb_probe() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. *

[PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 15:56:11 +0100 Up to four checks could be repeated by the ufx_usb_probe() function during error handling even if the relevant properties can be determined for the involved variables before by source code analysis. * Return directly after a call of the

[PATCH v3 0/3] video-SMSC UFX: Adjustments for two function implementations

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:54:32 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Less checks in ufx_usb_probe() after error detection Return an error code only as a constant in

[PATCH v3 0/3] video-SMSC UFX: Adjustments for two function implementations

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 16:54:32 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Less checks in ufx_usb_probe() after error detection Return an error code only as a constant in ufx_realloc_framebuffer()

[PATCH v2 2/2] video: udlfb: Delete an error message for a failed memory allocation in dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:07:36 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: This

[PATCH v2 2/2] video: udlfb: Delete an error message for a failed memory allocation in dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:07:36 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: This update suggestion was rebased on source files from the

[PATCH v2 1/2] video: udlfb: Return an error code only as a constant in dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:02:36 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring

[PATCH v2 1/2] video: udlfb: Return an error code only as a constant in dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:02:36 +0100 * Return an error code without storing it in an intermediate variable. * Delete the label "error" and local variable "retval" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- v2: This update

[PATCH v2 0/2] video-UDLFB: Adjustments for dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:24:34 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return an error code only as a constant Delete an error message for a failed memory allocation ---

[PATCH v2 0/2] video-UDLFB: Adjustments for dlfb_realloc_framebuffer()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 14:24:34 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Return an error code only as a constant Delete an error message for a failed memory allocation --- v2: Rebased on Linux

[PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 12:34:22 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: This

[PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 12:34:22 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- v2: This update suggestion was rebased on source files from the

[PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 11:33:59 +0100 Replace an error code for the indication of a memory allocation failure in this function. Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac ("Linux-2.6.12-rc2: Initial git repository build") Suggested-by:

[PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 11:33:59 +0100 Replace an error code for the indication of a memory allocation failure in this function. Fixes: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac ("Linux-2.6.12-rc2: Initial git repository build") Suggested-by: Rolf Eike Beer Signed-off-by:

[PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 12:45:54 +0100 Two update suggestions were taken into account. Markus Elfring (2): Return -ENOMEM after a failed kzalloc() Delete an error message for a failed memory allocation drivers/video/fbdev/stifb.c | 6

[PATCH v2 0/2] video/fbdev/stifb: Adjustments for stifb_init_fb()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 12:45:54 +0100 Two update suggestions were taken into account. Markus Elfring (2): Return -ENOMEM after a failed kzalloc() Delete an error message for a failed memory allocation drivers/video/fbdev/stifb.c | 6 ++ 1 file changed, 2

[PATCH] KVM: PPC: Use seq_puts() in kvmppc_exit_timing_show()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 10:07:36 +0100 A headline should be quickly put into a sequence. Thus use the function "seq_puts" instead of "seq_printf" for this purpose. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

[PATCH] KVM: PPC: Use seq_puts() in kvmppc_exit_timing_show()

2018-01-07 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 7 Jan 2018 10:07:36 +0100 A headline should be quickly put into a sequence. Thus use the function "seq_puts" instead of "seq_printf" for this purpose. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> Two strings should be quickly put into a sequence by two function calls. >> Thus use the function "seq_puts" instead of "seq_printf". >> >> This issue was detected by using the Coccinelle software. > > Can you please explain what the issue really is and what you're trying > to do here? Is the

Re: atm/clip: Use seq_puts() in svc_addr()

2018-01-07 Thread SF Markus Elfring
>> Two strings should be quickly put into a sequence by two function calls. >> Thus use the function "seq_puts" instead of "seq_printf". >> >> This issue was detected by using the Coccinelle software. > > Can you please explain what the issue really is and what you're trying > to do here? Is the

[PATCH] atm/clip: Use seq_puts() in svc_addr()

2018-01-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 Jan 2018 22:34:12 +0100 Two strings should be quickly put into a sequence by two function calls. Thus use the function "seq_puts" instead of "seq_printf". This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH] atm/clip: Use seq_puts() in svc_addr()

2018-01-06 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 6 Jan 2018 22:34:12 +0100 Two strings should be quickly put into a sequence by two function calls. Thus use the function "seq_puts" instead of "seq_printf". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

<    6   7   8   9   10   11   12   13   14   15   >