Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. I have got other source code analysis expectations there. This SmPL script contains

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
>> * Do we agree that a proper size determination is essential for every >> condition in the discussed SmPL rules together with forwarding >> this information? > > No. I don't mind a few false positives. I have got other source code analysis expectations there. This SmPL script contains

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
>> The function "kmem_cache_alloc" was specified despite of the technical >> detail that this function does not get a parameter passed which would >> correspond to such a size information. >> >> Thus remove it from the first two SmPL rules and omit the rule "r4". > > Nack. I find such a

Re: Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
>> The function "kmem_cache_alloc" was specified despite of the technical >> detail that this function does not get a parameter passed which would >> correspond to such a size information. >> >> Thus remove it from the first two SmPL rules and omit the rule "r4". > > Nack. I find such a

[PATCH] Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Feb 2018 10:20:47 +0100 The deletion for a call of the function "memset" depends on the specification that a size determination is passed by the expression "E1". The function "kmem_cache_alloc" was specified despite of the

[PATCH] Coccinelle: zalloc-simple: Delete function "kmem_cache_alloc" from SmPL rules

2018-02-01 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Feb 2018 10:20:47 +0100 The deletion for a call of the function "memset" depends on the specification that a size determination is passed by the expression "E1". The function "kmem_cache_alloc" was specified despite of the technical detail that this function

[PATCH] hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 22:20:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-sensor-accel-3d: Delete an error message for a failed memory allocation in hid_accel_3d_probe()

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 22:20:56 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/accel/hid-sensor-accel-3d.c | 6 ++ 1 file changed, 2

[PATCH] iio/adc: Delete an error message for a failed memory allocation in two functions

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:57:50 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] iio/adc: Delete an error message for a failed memory allocation in two functions

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:57:50 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/adc/at91_adc.c | 1 - drivers/iio/adc/max1027.c | 4

[PATCH] hid-sensor-gyro-3d: Delete an error message for a failed memory allocation in hid_gyro_3d_probe()

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:36:53 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] hid-sensor-gyro-3d: Delete an error message for a failed memory allocation in hid_gyro_3d_probe()

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:36:53 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/gyro/hid-sensor-gyro-3d.c | 4 +--- 1 file changed, 1

[PATCH] iio/light: Delete an error message for a failed memory allocation in two functions

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:12:09 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] iio/light: Delete an error message for a failed memory allocation in two functions

2018-01-31 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 31 Jan 2018 21:12:09 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/light/hid-sensor-als.c | 4 +---

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

2018-01-31 Thread SF Markus Elfring
>> Will the rule set be more consistent then? > > If E1 is not bound by the kem_cache_alloc rule, then it will match anything. How much was such a software behaviour intended by the discussed SmPL script? > The user can check if it is appropriate. How does such an information fit to

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

2018-01-31 Thread SF Markus Elfring
>> Will the rule set be more consistent then? > > If E1 is not bound by the kem_cache_alloc rule, then it will match anything. How much was such a software behaviour intended by the discussed SmPL script? > The user can check if it is appropriate. How does such an information fit to

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

2018-01-31 Thread SF Markus Elfring
> I removed the blank line at EOF, > then applied to linux-kbuild/misc. I have taken another look at this script for the semantic patch language. I imagined that I could refactor the shown SmPL disjunctions a bit. But I noticed then that these SmPL rules contain a development mistake. The

Re: [v2] Coccinelle: zalloc-simple: Delete function “kmem_cache_alloc” from SmPL rules

2018-01-31 Thread SF Markus Elfring
> I removed the blank line at EOF, > then applied to linux-kbuild/misc. I have taken another look at this script for the semantic patch language. I imagined that I could refactor the shown SmPL disjunctions a bit. But I noticed then that these SmPL rules contain a development mistake. The

[PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions

2018-01-29 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 29 Jan 2018 22:20:07 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] iio/orientation: Delete an error message for a failed memory allocation in two functions

2018-01-29 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 29 Jan 2018 22:20:07 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/orientation/hid-sensor-incl-3d.c | 4 +---

[PATCH] iio/pressure: Delete an error message for a failed memory allocation in hid_press_probe()

2018-01-29 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 29 Jan 2018 21:55:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] iio/pressure: Delete an error message for a failed memory allocation in hid_press_probe()

2018-01-29 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 29 Jan 2018 21:55:08 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/iio/pressure/hid-sensor-press.c | 4 +--- 1 file changed, 1

Re: [0/3] IB-iSER: Adjustments for three function implementations

2018-01-29 Thread SF Markus Elfring
> Okay, applied to for-next, thanks both Thanks for your acceptance. How are the chances for integration of further software updates from my selection of change possibilities? Example: IB/iser: Add spaces for better code readability https://lkml.org/lkml/2017/4/7/667

Re: [0/3] IB-iSER: Adjustments for three function implementations

2018-01-29 Thread SF Markus Elfring
> Okay, applied to for-next, thanks both Thanks for your acceptance. How are the chances for integration of further software updates from my selection of change possibilities? Example: IB/iser: Add spaces for better code readability https://lkml.org/lkml/2017/4/7/667

Re: mfd: Patch management?

2018-01-29 Thread SF Markus Elfring
>> I imagine that acceptance for these changes could be influenced >> also by review comments from other contributors. > > Influenced yes, but I will also need to review them. Yes. - This is the usual process. > You can't 'go around' me, if that's what you're thinking. I do not think this. -

Re: mfd: Patch management?

2018-01-29 Thread SF Markus Elfring
>> I imagine that acceptance for these changes could be influenced >> also by review comments from other contributors. > > Influenced yes, but I will also need to review them. Yes. - This is the usual process. > You can't 'go around' me, if that's what you're thinking. I do not think this. -

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread SF Markus Elfring
> You don't need 2 patches when changing same lines of code. Are these really the same? > Could you squash both and send your changes in a single patch. I prefer to keep the deletion of questionable error messages separate from the refactoring for a bit of exception handling. > The patches

Re: [0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-29 Thread SF Markus Elfring
> You don't need 2 patches when changing same lines of code. Are these really the same? > Could you squash both and send your changes in a single patch. I prefer to keep the deletion of questionable error messages separate from the refactoring for a bit of exception handling. > The patches

[PATCH 3/3] RDMA/iwpm: Improve a size determination in two functions

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 22:05:54 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 3/3] RDMA/iwpm: Improve a size determination in two functions

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 22:05:54 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 2/3] RDMA/iwpm: Adjust a variable initialisation in iwpm_create_nlmsg()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:56:54 +0100 The local variable "skb" will be reassigned by a following statement. Thus adjust the initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/3] RDMA/iwpm: Adjust a variable initialisation in iwpm_create_nlmsg()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:56:54 +0100 The local variable "skb" will be reassigned by a following statement. Thus adjust the initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/core/iwpm_util.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 1/3] RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:48:01 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] RDMA/iwpm: Delete an error message for a failed memory allocation in iwpm_create_nlmsg()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:48:01 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/core/iwpm_util.c | 5 ++--- 1 file changed, 2

[PATCH 0/3] RDMA/iwpm: Adjustments for three function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 22:12:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iwpm_create_nlmsg() Adjust a variable

[PATCH 0/3] RDMA/iwpm: Adjustments for three function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 22:12:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iwpm_create_nlmsg() Adjust a variable initialisation in

[PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:56:56 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring ---

[PATCH 2/2] RDMA/bnxt_re: Use common error handling code in bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:56:56 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/bnxt_re/qplib_res.c | 13 +++-- 1 file changed, 7 insertions(+), 6

[PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:40:11 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] RDMA/bnxt_re: Delete two error messages for a failed memory allocation in bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:40:11 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/bnxt_re/qplib_res.c | 5 - 1 file changed, 5

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:10:12 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Use common error handling code

[PATCH 0/2] RDMA/bnxt_re: Adjustments for bnxt_qplib_alloc_dpi_tbl()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 21:10:12 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Use common error handling code drivers/infiniband/hw/bnxt_re/qplib_res.c

[PATCH] IB/usnic: Delete an error message for a failed memory allocation in usnic_transport_init()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:06:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] IB/usnic: Delete an error message for a failed memory allocation in usnic_transport_init()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 20:06:59 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/usnic/usnic_transport.c | 4 +--- 1 file

[PATCH 3/3] IB/iser: Combine substrings for three messages

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 18:25:37 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 3/3] IB/iser: Combine substrings for three messages

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 18:25:37 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring ---

[PATCH 2/3] IB/iser: Delete an unnecessary variable initialisation in iser_send_data_out()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:55:13 +0100 The variable "tx_desc" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

[PATCH 2/3] IB/iser: Delete an unnecessary variable initialisation in iser_send_data_out()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:55:13 +0100 The variable "tx_desc" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_initiator.c | 2 +- 1 file changed, 1

[PATCH 1/3] IB/iser: Delete an error message for a failed memory allocation in iser_send_data_out()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:48:47 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/3] IB/iser: Delete an error message for a failed memory allocation in iser_send_data_out()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:48:47 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_initiator.c | 4 +--- 1 file

[PATCH 0/3] IB-iSER: Adjustments for three function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 19:02:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iser_send_data_out() Delete an

[PATCH 0/3] IB-iSER: Adjustments for three function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 19:02:34 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Delete an error message for a failed memory allocation in iser_send_data_out() Delete an unnecessary variable initialisation in

[PATCH 2/2] Input: gamecon: Improve a size determination in gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 16:30:58 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: gamecon: Improve a size determination in gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 16:30:58 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: gamecon: Delete an error message for a failed memory allocation in gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 16:27:11 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: gamecon: Delete an error message for a failed memory allocation in gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 16:27:11 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/joystick/gamecon.c | 4 +--- 1 file changed, 1

[PATCH 0/2] input/joystick/gamecon: Adjustments for gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:07:27 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] input/joystick/gamecon: Adjustments for gc_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 17:07:27 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/joystick/gamecon.c | 6 ++

[PATCH 2/2] Input: turbografx: Improve a size determination in tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:46:24 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: turbografx: Improve a size determination in tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:46:24 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:43:38 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: turbografx: Delete an error message for a failed memory allocation in tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:43:38 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/joystick/turbografx.c | 4 +--- 1 file changed, 1

[PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:55:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] Input-TurboGraFX: Adjustments for tgfx_attach()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:55:44 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/joystick/turbografx.c | 6

[PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:15:52 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] Input: adp5520-keys: Delete an error message for a failed memory allocation in adp5520_keys_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 15:15:52 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/adp5520-keys.c | 4 +--- 1 file changed, 1

[PATCH] Input: gpio_keys: Delete an error message for a failed memory allocation in two functions

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 14:42:19 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] Input: gpio_keys: Delete an error message for a failed memory allocation in two functions

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 14:42:19 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/gpio_keys.c| 4 +---

[PATCH] Input: imx_keypad: Delete an error message for a failed memory allocation in imx_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 14:14:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] Input: imx_keypad: Delete an error message for a failed memory allocation in imx_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 14:14:04 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/imx_keypad.c | 4 +--- 1 file changed, 1

[PATCH 2/2] Input: matrix_keypad: Improve a size determination in matrix_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:43:16 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: matrix_keypad: Improve a size determination in matrix_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:43:16 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: matrix_keypad: Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:35:02 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: matrix_keypad: Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:35:02 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/matrix_keypad.c | 8 ++-- 1 file changed, 2

[PATCH 0/2] Input: matrix_keypad: Adjustments for two function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:48:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt() Improve a

[PATCH 0/2] Input: matrix_keypad: Adjustments for two function implementations

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:48:42 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation in matrix_keypad_parse_dt() Improve a size determination in

[PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:00:10 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:00:10 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: max7359_keypad: Delete an error message for a failed memory allocation in max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 12:56:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: max7359_keypad: Delete an error message for a failed memory allocation in max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 12:56:25 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/max7359_keypad.c | 4 +--- 1 file changed, 1

[PATCH 0/2] Input: max7359_keypad: Adjustments for max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:08:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] Input: max7359_keypad: Adjustments for max7359_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 13:08:24 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/keyboard/max7359_keypad.c | 8

[PATCH 2/2] Input: nspire-keypad: Improve a size determination in nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:36:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: nspire-keypad: Improve a size determination in nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:36:20 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: nspire-keypad: Delete an error message for a failed memory allocation in nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:33:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: nspire-keypad: Delete an error message for a failed memory allocation in nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:33:37 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/nspire-keypad.c | 4 +--- 1 file changed, 1

[PATCH 0/2] Input: nspire-keypad: Adjustments for nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:48:28 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination

[PATCH 0/2] Input: nspire-keypad: Adjustments for nspire_keypad_probe()

2018-01-27 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 27 Jan 2018 10:48:28 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation Improve a size determination drivers/input/keyboard/nspire-keypad.c | 7

Re: mfd: Patch management?

2018-01-26 Thread SF Markus Elfring
>> I am curious if more positive feedback could evolve till then. >> I would appreciate if a potentially needed resend for my selection >> of update suggestions could become smaller (when reviewed steps >> could be already integrated for example). > > I'm not entirely sure what you're trying to

Re: mfd: Patch management?

2018-01-26 Thread SF Markus Elfring
>> I am curious if more positive feedback could evolve till then. >> I would appreciate if a potentially needed resend for my selection >> of update suggestions could become smaller (when reviewed steps >> could be already integrated for example). > > I'm not entirely sure what you're trying to

[PATCH 2/2] Input: omap4-keypad: Improve a size determination in omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:28:07 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] Input: omap4-keypad: Improve a size determination in omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:28:07 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

[PATCH 1/2] Input: omap4-keypad: Delete two error messages for a failed memory allocation in omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:24:35 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/2] Input: omap4-keypad: Delete two error messages for a failed memory allocation in omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:24:35 +0100 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/omap4-keypad.c | 5 + 1 file changed, 1

[PATCH 0/2] Input: omap4-keypad: Adjustments for omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:45:54 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination

[PATCH 0/2] Input: omap4-keypad: Adjustments for omap4_keypad_probe()

2018-01-26 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 26 Jan 2018 14:45:54 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination drivers/input/keyboard/omap4-keypad.c | 7

[PATCH] Input: pxa27x_keypad: Delete an error message for a failed memory allocation

2018-01-25 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 25 Jan 2018 22:15:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] Input: pxa27x_keypad: Delete an error message for a failed memory allocation

2018-01-25 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 25 Jan 2018 22:15:27 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/pxa27x_keypad.c | 4 +--- 1 file changed, 1

[PATCH] Input: sh_keysc: Delete an error message for a failed memory allocation in sh_keysc_probe()

2018-01-25 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 25 Jan 2018 22:02:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH] Input: sh_keysc: Delete an error message for a failed memory allocation in sh_keysc_probe()

2018-01-25 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 25 Jan 2018 22:02:46 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/keyboard/sh_keysc.c | 1 - 1 file changed, 1

<    1   2   3   4   5   6   7   8   9   10   >