From: Markus Elfring
Date: Thu, 25 Jan 2018 21:49:13 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 21:49:13 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/keyboard/spear-keyboard.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 21:36:46 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 21:36:46 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/keyboard/tegra-kbc.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 21:07:00 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 21:07:00 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/matrix-keymap.c | 5 +
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:47:03 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:47:03 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/da9055_onkey.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:24:47 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:24:47 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:22:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:22:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/da9063_onkey.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:30:40 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Thu, 25 Jan 2018 20:30:40 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/input/misc/da9063_onkey.c | 7 ++-
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:37:34 +0100
An error code was assigned to a local variable in an if branch.
This value was not read again before it was used by a return statement
as a constant value at the end of this function.
Thus remove such an
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:37:34 +0100
An error code was assigned to a local variable in an if branch.
This value was not read again before it was used by a return statement
as a constant value at the end of this function.
Thus remove such an unneeded assignment.
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:20:38 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:20:38 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:06:07 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:06:07 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/ims-pcu.c | 1 -
1 file changed, 1 deletion(-)
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:46:56 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
in ims_pcu_buffers_alloc()
Improve a
From: Markus Elfring
Date: Thu, 25 Jan 2018 19:46:56 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
in ims_pcu_buffers_alloc()
Improve a size determination in two
From: Markus Elfring
Date: Thu, 25 Jan 2018 18:13:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 18:13:57 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/kxtj9.c | 5 +
1 file changed, 1 insertion(+),
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:35:13 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:35:13 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:32:09 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:32:09 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/sirfsoc-onkey.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:42:24 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:42:24 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/input/misc/sirfsoc-onkey.c | 7
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:01:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Thu, 25 Jan 2018 16:01:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/twl6040-vibra.c | 1 -
1 file changed, 1
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:58:42 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:58:42 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:55:49 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:55:49 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/misc/wm831x-on.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Wed, 24 Jan 2018 22:15:43 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Wed, 24 Jan 2018 22:15:43 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/input/misc/wm831x-on.c | 7 ++-
1
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:21:11 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:21:11 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:14:51 +0100
Return directly after a call of the function "kmalloc" failed
at the beginning.
Signed-off-by: Markus Elfring
---
drivers/input/mouse/bcm5974.c | 6 ++
1 file changed,
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:14:51 +0100
Return directly after a call of the function "kmalloc" failed
at the beginning.
Signed-off-by: Markus Elfring
---
drivers/input/mouse/bcm5974.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:09:28 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:09:28 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/mouse/bcm5974.c | 1 -
1 file changed, 1 deletion(-)
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:25:24 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
in bcm5974_wellspring_mode()
Return
From: Markus Elfring
Date: Wed, 24 Jan 2018 21:25:24 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
in bcm5974_wellspring_mode()
Return directly after a failed kmalloc()
From: Markus Elfring
Date: Wed, 24 Jan 2018 20:40:54 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 20:40:54 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/mouse/appletouch.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Wed, 24 Jan 2018 20:50:20 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in atp_geyser_init()
Improve a size
From: Markus Elfring
Date: Wed, 24 Jan 2018 20:50:20 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in atp_geyser_init()
Improve a size determination in atp_probe()
From: Markus Elfring
Date: Wed, 24 Jan 2018 19:19:14 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 19:19:14 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/rmi4/rmi_driver.c | 4 +---
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:30:45 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:30:45 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:17:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:17:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/serio/arc_ps2.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:34:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in arc_ps2_probe()
Improve a size
From: Markus Elfring
Date: Wed, 24 Jan 2018 18:34:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation in arc_ps2_probe()
Improve a size determination in two functions
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:21:18 +0100
Adjust two words in this description.
Signed-off-by: Markus Elfring
---
drivers/input/serio/apbps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:21:18 +0100
Adjust two words in this description.
Signed-off-by: Markus Elfring
---
drivers/input/serio/apbps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/apbps2.c b/drivers/input/serio/apbps2.c
index
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:15:39 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:15:39 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
Signed-off-by:
From: Markus Elfring
Date: Wed, 24 Jan 2018 16:43:04 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 16:43:04 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/serio/apbps2.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:30:12 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Improve a size determination
Fix typos in
From: Markus Elfring
Date: Wed, 24 Jan 2018 17:30:12 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation
Improve a size determination
Fix typos in a comment
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:08:42 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:08:42 +0100
Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:03:33 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:03:33 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/tablet/gtco.c | 1 -
1 file changed, 1 deletion(-)
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:26:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
From: Markus Elfring
Date: Wed, 24 Jan 2018 15:26:56 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination
drivers/input/tablet/gtco.c | 3 +--
1 file
> So it works, but you are complaining anyway?
How serious do you interpret such information in the SmPL manual?
>> https://github.com/coccinelle/coccinelle/blob/bf1c6a5869dd324f5faeeaa3a12d57270e478b21/docs/manual/cocci_syntax.tex#L50
>>
>> “…
>> Furthermore, @ should not be used in this code.
> So it works, but you are complaining anyway?
How serious do you interpret such information in the SmPL manual?
>> https://github.com/coccinelle/coccinelle/blob/bf1c6a5869dd324f5faeeaa3a12d57270e478b21/docs/manual/cocci_syntax.tex#L50
>>
>> “…
>> Furthermore, @ should not be used in this code.
> What I should do really is ask you to take all similar (remove error
> message, don't use sizeof(struct X), remove '== NULL') changes and
> squash them into single patches.
I would try such an approach more often if I would get also more
promising indications of corresponding change acceptance
> What I should do really is ask you to take all similar (remove error
> message, don't use sizeof(struct X), remove '== NULL') changes and
> squash them into single patches.
I would try such an approach more often if I would get also more
promising indications of corresponding change acceptance
> My preferred mailer (Mutt) re-orders replied-to mails by putting them
> to the top of my Inbox. At which point I have to re-navigate down to
> the next patch to review.
How much does this tool influence the amount of update suggestions
which you could handle easily and safely?
> This is fine
> My preferred mailer (Mutt) re-orders replied-to mails by putting them
> to the top of my Inbox. At which point I have to re-navigate down to
> the next patch to review.
How much does this tool influence the amount of update suggestions
which you could handle easily and safely?
> This is fine
>> Applied, thanks.
>
> This patch does not apply.
>
> Please rebase and resend.
Did you notice that this update suggestion could eventually be superseded
by the software change “[PATCH v2] mfd: omap-usb-tll: Allocate driver data at
once”?
https://lkml.org/lkml/2018/1/23/277
>> Applied, thanks.
>
> This patch does not apply.
>
> Please rebase and resend.
Did you notice that this update suggestion could eventually be superseded
by the software change “[PATCH v2] mfd: omap-usb-tll: Allocate driver data at
once”?
https://lkml.org/lkml/2018/1/23/277
>> Can you please fix-up all of the patches I've NACKed and collect them
>> up with all the other MFD patches you currently have on the list and
>> send them as a single set please?
>>
>> Reviewing them one after another, is taking a lot of time and causing
>> my a great deal of pain.
There will
>> Can you please fix-up all of the patches I've NACKed and collect them
>> up with all the other MFD patches you currently have on the list and
>> send them as a single set please?
>>
>> Reviewing them one after another, is taking a lot of time and causing
>> my a great deal of pain.
There will
> This patch does not apply.
This change possibility partly depends on the update step
“[PATCH 2/3] mfd/sm501: Improve a size determination in two functions”
which you did not like yesterday.
https://lkml.org/lkml/2018/1/22/564
> Please rebase and resend.
Will the change acceptance grow then
> This patch does not apply.
This change possibility partly depends on the update step
“[PATCH 2/3] mfd/sm501: Improve a size determination in two functions”
which you did not like yesterday.
https://lkml.org/lkml/2018/1/22/564
> Please rebase and resend.
Will the change acceptance grow then
>> Date: Sat, 20 Jan 2018 15:30:17 +0100
>>
>> Omit extra messages for a memory allocation failure in these functions.
>
> Why?
Do you find the wording “WARNING: Possible unnecessary 'out of memory' message”
(from the script “checkpatch.pl”) more reasonable?
> This may as well be "delete some
>> Date: Sat, 20 Jan 2018 15:30:17 +0100
>>
>> Omit extra messages for a memory allocation failure in these functions.
>
> Why?
Do you find the wording “WARNING: Possible unnecessary 'out of memory' message”
(from the script “checkpatch.pl”) more reasonable?
> This may as well be "delete some
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:25:31 +0100
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:25:31 +0100
Omit extra messages for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/touchscreen/atmel_mxt_ts.c | 9 ++---
1 file
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:06:28 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:06:28 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:02:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:02:32 +0100
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/touchscreen/auo-pixcir-ts.c | 4 +---
1 file changed, 1
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:10:44 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
in auo_pixcir_parse_dt()
Delete an
From: Markus Elfring
Date: Sun, 21 Jan 2018 22:10:44 +0100
Two update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an error message for a failed memory allocation
in auo_pixcir_parse_dt()
Delete an unnecessary return statement in
From: Markus Elfring
Date: Sun, 21 Jan 2018 21:15:11 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus
From: Markus Elfring
Date: Sun, 21 Jan 2018 21:15:11 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code
From: Markus Elfring
Date: Sun, 21 Jan 2018 21:13:21 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected functions.
From: Markus Elfring
Date: Sun, 21 Jan 2018 21:13:21 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected functions.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 21 Jan 2018 20:57:40 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Markus Elfring
Date: Sun, 21 Jan 2018 20:57:40 +0100
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/input/touchscreen/cyttsp4_core.c | 2 --
1 file changed, 2
601 - 700 of 10642 matches
Mail list logo