Re: [alsa-devel] [PATCH 15/27] ALSA: hda - Use timecounter_initialize interface

2018-01-09 Thread Sagar Arun Kamble
On 1/5/2018 9:13 PM, Pierre-Louis Bossart wrote: On 1/5/18 4:06 AM, Sagar Arun Kamble wrote: On 1/3/2018 1:23 AM, Pierre-Louis Bossart wrote: On 1/2/18 12:21 PM, Richard Cochran wrote: On Tue, Jan 02, 2018 at 11:15:45AM -0600, Pierre-Louis Bossart wrote: I wrote the code for HDaudio and I

Re: [Intel-wired-lan] [PATCH 01/27] timecounter: Make cyclecounter struct part of timecounter struct

2018-01-09 Thread Sagar Arun Kamble
Thanks Aaron. Regards, Sagar On 1/9/2018 3:50 AM, Brown, Aaron F wrote: From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf Of Sagar Arun Kamble Sent: Thursday, December 14, 2017 11:38 PM To: linux-kernel@vger.kernel.org Cc: alsa-de...@alsa-project.org; linux-r

Re: [alsa-devel] [PATCH 15/27] ALSA: hda - Use timecounter_initialize interface

2018-01-05 Thread Sagar Arun Kamble
On 1/3/2018 1:23 AM, Pierre-Louis Bossart wrote: On 1/2/18 12:21 PM, Richard Cochran wrote: On Tue, Jan 02, 2018 at 11:15:45AM -0600, Pierre-Louis Bossart wrote: I wrote the code for HDaudio and I remember wasting time trying to figure out the gory details of the cycle counter stuff when all

Re: [alsa-devel] [PATCH 15/27] ALSA: hda - Use timecounter_initialize interface

2018-01-01 Thread Sagar Arun Kamble
On 12/28/2017 10:19 PM, Richard Cochran wrote: On Tue, Dec 26, 2017 at 01:07:35PM +0530, Sagar Arun Kamble wrote: Or can we provide simpler versions for covering some defaults? At least reducing the number of arguments would make things easier. Thought about specifying 1. cyclecounter read

Re: [alsa-devel] [PATCH 15/27] ALSA: hda - Use timecounter_initialize interface

2017-12-25 Thread Sagar Arun Kamble
On 12/15/2017 10:40 PM, Takashi Iwai wrote: On Fri, 15 Dec 2017 17:51:25 +0100, Richard Cochran wrote: On Fri, Dec 15, 2017 at 12:10:47PM +0100, Takashi Iwai wrote: - struct cyclecounter *cc = &azx_dev->tc.cc; - cc->read = azx_cc_read; - cc->mask = CLOCKSOURCE_MASK(32); -

[PATCH 04/27] clocksource/arm_arch_timer: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update arch_timer_kvm_info timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Mark Rutland Cc: Marc Zyngier Cc: Daniel Lezcano

[PATCH 05/27] amd-xgbe: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update xgbe tstamp_tc timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Tom Lendacky Cc: net...@vger.kernel.org Cc: linux-kernel

[PATCH 07/27] fec: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update fec ethernet timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Fugang Duan Cc: net...@vger.kernel.org Cc: linux-kernel

[PATCH 08/27] e1000e: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update e1000e timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net

[PATCH 03/27] microblaze: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update xilinx_tc init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Michal Simek Cc: Daniel Lezcano Cc: Neil Armstrong Cc: Nicolai Stange

[PATCH 11/27] net/mlx4: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update mlx4 timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Tariq Toukan Cc: net...@vger.kernel.org Cc: linux-r

[PATCH 06/27] bnx2x: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update bnx2x timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Ariel Elior Cc: everest-linux...@cavium.com Cc: net

[PATCH 12/27] net/mlx5: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update mlx5 timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Saeed Mahameed Cc: Matan Barak Cc: Leon Romanovsky Cc: Eugenia

[PATCH 15/27] ALSA: hda - Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update azx timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Thomas Gleixner Cc: Vinod

[PATCH 14/27] net: cpts: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update cpts timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: "David S. Miller" Cc: Grygorii Strashko Cc: Richard Cochran Cc: Bhumika

[PATCH 18/27] bnx2x: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update bnx2x_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Ariel Elior Cc: everest-linux...@cavium.com Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

[PATCH 16/27] timecounter: Introduce timecounter_reset

2017-12-14 Thread Sagar Arun Kamble
-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Chris Wilson Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: linux-kernel@vger.kernel.org --- include/linux/timecounter.h | 17 +++-- kernel/time/timecounter.c | 9 + 2 files changed, 24 insertions(+), 2 deletions

[PATCH 22/27] ixgbe: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update ixgbe_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net...@vger.kernel.org Cc: linux-kernel

[PATCH 21/27] igb: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update igb_ptp_settime_82576 with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net...@vger.kernel.org Cc: linux-kernel

[PATCH 23/27] net/mlx4: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update mlx4_en_phc_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Tariq Toukan Cc: net...@vger.kernel.org Cc: linux-r...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

[PATCH 24/27] net/mlx5: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update mlx5_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Saeed Mahameed Cc: Matan Barak Cc: Leon Romanovsky Cc: Eugenia Emantayev Cc: Eitan Rabin Cc: Feras

[PATCH 25/27] qede: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update qede_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Ariel Elior Cc: everest-linux...@cavium.com Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org

[PATCH 26/27] net: cpts: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update cpts_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: "David S. Miller" Cc: Grygorii Strashko Cc: Bhumika Goyal Cc: Richard Cochran Cc: Thomas Gleixne

[PATCH 20/27] e1000e: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update e1000e_phc_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net...@vger.kernel.org Cc: linux-kernel

[PATCH 17/27] amd-xgbe: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update xgbe_config_tstamp and xgbe_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Tom Lendacky Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers

[PATCH 27/27] timecounter: Remove timecounter_init

2017-12-14 Thread Sagar Arun Kamble
With all timecounter users now initializing timecounter using timecounter_initialize remove timecounter_init function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: linux-kernel@vger.kernel.org --- include/linux/timecounter.h

[PATCH 19/27] net: fec: ptp: Use timecounter_reset interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_reset we can update the start time for timecounter. Update fec_ptp_settime with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Fugang Duan Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/freescale

[PATCH 13/27] qede: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update qede timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Ariel Elior Cc: everest-linux...@cavium.com Cc: net

[PATCH 10/27] ixgbe: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update ixgbe ptp timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net

[PATCH 02/27] timecounter: Introduce timecounter_initialize to update timecounter and cyclecounter

2017-12-14 Thread Sagar Arun Kamble
timecounter_init which requires initialized cyclecounter can be removed once all drivers are migrated to this new interface. Suggested-by: Richard Cochran Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Chris Wilson Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: linux-kernel

[PATCH 01/27] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-14 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. v2: Rebase. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun

[PATCH 09/27] igb: Use timecounter_initialize interface

2017-12-14 Thread Sagar Arun Kamble
With new interface timecounter_initialize we can initialize timecounter fields and underlying cyclecounter together. Update igb ptp timecounter init with this new function. Signed-off-by: Sagar Arun Kamble Cc: Richard Cochran Cc: Jeff Kirsher Cc: intel-wired-...@lists.osuosl.org Cc: net

[PATCH 00/27] timecounter/cyclecounter struct/interface update

2017-12-14 Thread Sagar Arun Kamble
function timecounter_init(). Cc: Sagar Arun Kamble Cc: Richard Cochran Cc: John Stultz Cc: Thomas Gleixner Cc: Stephen Boyd Cc: linux-kernel@vger.kernel.org Sagar Arun Kamble (27): timecounter: Make cyclecounter struct part of timecounter struct timecounter: Introduce timecounter_initialize to

Re: [PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-03 Thread Sagar Arun Kamble
On 12/2/2017 11:34 PM, Richard Cochran wrote: On Sat, Dec 02, 2017 at 10:01:35AM +0530, Sagar Arun Kamble wrote: There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have

[PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-12-01 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc

[PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-11-30 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

2017-11-30 Thread Sagar Arun Kamble
On 12/1/2017 2:33 AM, Saeed Mahameed wrote: On Mon, Nov 27, 2017 at 2:05 AM, Sagar Arun Kamble wrote: On 11/24/2017 7:01 PM, Thomas Gleixner wrote: On Fri, 24 Nov 2017, Sagar Arun Kamble wrote: On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble wrote

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

2017-11-27 Thread Sagar Arun Kamble
On 11/24/2017 7:01 PM, Thomas Gleixner wrote: On Fri, 24 Nov 2017, Sagar Arun Kamble wrote: On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble wrote: We needed inputs on possible optimization that can be done to timecounter/cyclecounter structures/usage

[PATCH 1/1] timecounter: Make cyclecounter struct part of timecounter struct

2017-11-26 Thread Sagar Arun Kamble
There is no real need for the users of timecounters to define cyclecounter and timecounter variables separately. Since timecounter will always be based on cyclecounter, have cyclecounter struct as member of timecounter struct. Suggested-by: Chris Wilson Signed-off-by: Sagar Arun Kamble Cc: John

Re: Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

2017-11-24 Thread Sagar Arun Kamble
On 11/24/2017 12:29 AM, Thomas Gleixner wrote: On Thu, 23 Nov 2017, Sagar Arun Kamble wrote: We needed inputs on possible optimization that can be done to timecounter/cyclecounter structures/usage. This mail is in response to review of patch https://patchwork.freedesktop.org/patch/188448

Creating cyclecounter and lock member in timecounter structure [ Was Re: [RFC 1/4] drm/i915/perf: Add support to correlate GPU timestamp with system time]

2017-11-22 Thread Sagar Arun Kamble
5:55 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-11-15 12:13:51) #include #include @@ -2149,6 +2150,14 @@ struct i915_perf_stream { * @oa_config: The OA configuration used by the stream. */ struct i915_oa_config *oa_config; + + /** +* S

[PATCH 1/2] iommu: Disable preemption around use of this_cpu_ptr()

2016-06-02 Thread Sagar Arun Kamble
From: Chris Wilson Between acquiring the this_cpu_ptr() and using it, ideally we don't want to be preempted and work on another CPU's private data. this_cpu_ptr() checks whether or not preemption is disable, and get_cpu_ptr() provides a convenient wrapper for operating on the cpu ptr inside a pre

[PATCH 2/2] iommu: Remove cpu-local spinlock

2016-06-02 Thread Sagar Arun Kamble
From: Chris Wilson By avoiding cross-CPU usage of the per-cpu iova cache, we can forgo having a spinlock inside the per-cpu struct. The only place where we actually may touch another CPU's data is when performing a cache flush after running out of memory. Here, we can instead schedule a task to r

Re: [PATCH v2 1/4] drm: Adding new flag to restrict bitmask drm properties as 32 bit type and 32 bit value pair

2014-04-10 Thread Sagar Arun Kamble
Adding Rob and Rusty in the review thread. Kindly review these patches for interface being proposed to set color/alpha property of planes modeled after glBlendFunc. http://lists.freedesktop.org/archives/intel-gfx/2014-March/042350.html http://lists.freedesktop.org/archives/intel-gfx/2014-March

Re: [PATCH v4 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

2014-03-16 Thread Sagar Arun Kamble
Gentle reminder for reviewing this and i-g-t patch. On Mon, 2014-03-10 at 17:06 +0530, sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > With this patch we allow larger cursor planes of sizes 128x128 > and 256x256. > > v2: Added more precise check on size while setting cursor plane. > >

Re: [PATCH v3 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

2014-03-08 Thread Sagar Arun Kamble
On Sun, 2014-03-09 at 00:34 +0530, Sagar Arun Kamble wrote: > On Sat, 2014-03-08 at 13:51 -0500, Alex Deucher wrote: > > On Sat, Mar 8, 2014 at 1:49 PM, wrote: > > > From: Sagar Kamble > > > > > > With this patch we allow larger cursor planes of sizes 128x1

Re: [PATCH v3 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

2014-03-08 Thread Sagar Arun Kamble
On Sat, 2014-03-08 at 13:51 -0500, Alex Deucher wrote: > On Sat, Mar 8, 2014 at 1:49 PM, wrote: > > From: Sagar Kamble > > > > With this patch we allow larger cursor planes of sizes 128x128 > > and 256x256. > > > > v2: Added more precise check on size while setting cursor plane. > > > > v3: Chan

Re: [Intel-gfx] [PATCH v5 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping

2014-02-11 Thread Sagar Arun Kamble
On Tue, 2014-02-11 at 16:56 +0200, Ville Syrjälä wrote: > On Tue, Feb 11, 2014 at 05:02:31PM +0530, Sagar Arun Kamble wrote: > > On Mon, 2014-02-10 at 15:32 +0200, Ville Syrjälä wrote: > > > On Mon, Feb 10, 2014 at 01:01:18PM +0530, sagar.a.kam...@intel.com wrote: > >

Re: [Intel-gfx] [PATCH v5 11/11] drm/i915: Calling rotate and inverse rotate transformations after clipping

2014-02-11 Thread Sagar Arun Kamble
On Tue, 2014-02-11 at 12:59 +0100, Daniel Vetter wrote: > On Tue, Feb 11, 2014 at 05:02:31PM +0530, Sagar Arun Kamble wrote: > > On Mon, 2014-02-10 at 15:32 +0200, Ville Syrjälä wrote: > > > On Mon, Feb 10, 2014 at 01:01:18PM +0530, sagar.a.kam...@intel.com wrote: > >

Re: [PATCH v2 02/11] drm: Add support_bits parameter to drm_property_create_bitmask()

2014-02-11 Thread Sagar Arun Kamble
Reviewed-by: Sagar Kamble Tested-by: Sagar Kamble On Mon, 2014-02-10 at 16:05 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Make drm_property_create_bitmask() a bit more generic by allowing the > caller to specify which bits are in fact supported. This allows multiple >