Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-18 Thread Sai Prakash Ranjan
On 9/19/2018 2:14 AM, Steven Rostedt wrote: On Tue, 18 Sep 2018 23:22:48 +0530 Sai Prakash Ranjan wrote: On 9/18/2018 5:04 AM, Steven Rostedt wrote: It looks like pstore_event_call() gets called from a trace event. You can't call kmalloc() from one. One thing is that kmalloc has tracepoints

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:04 AM, Steven Rostedt wrote: It looks like pstore_event_call() gets called from a trace event. You can't call kmalloc() from one. One thing is that kmalloc has tracepoints itself. You trace those you just entered an infinite loop. Ok will remove it in v2. But any alternative

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:04 AM, Steven Rostedt wrote: It looks like pstore_event_call() gets called from a trace event. You can't call kmalloc() from one. One thing is that kmalloc has tracepoints itself. You trace those you just entered an infinite loop. Ok will remove it in v2. But any alternative

Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:17 PM, Will Deacon wrote: On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 5:09 AM, Steven Rostedt wrote: On Sun, 9 Sep 2018 01:57:06 +0530 Sai Prakash Ranjan wrote: The new asm-generic/io-instrumented.h will keep arch code clean and separate

Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:17 PM, Will Deacon wrote: On Tue, Sep 18, 2018 at 12:40:57PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 5:09 AM, Steven Rostedt wrote: On Sun, 9 Sep 2018 01:57:06 +0530 Sai Prakash Ranjan wrote: The new asm-generic/io-instrumented.h will keep arch code clean and separate

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 2:47 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 02:35:02PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 11:41 AM, Jiri Slaby wrote: On 09/17/2018, 11

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 2:47 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 02:35:02PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 11:41 AM, Jiri Slaby wrote: On 09/17/2018, 11

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 11:41 AM, Jiri Slaby wrote: On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote: sysrq_handle_crash() dereferences a NULL pointer on purpose to force an exception

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 12:50 PM, Greg Kroah-Hartman wrote: On Tue, Sep 18, 2018 at 12:28:39PM +0530, Sai Prakash Ranjan wrote: On 9/18/2018 11:41 AM, Jiri Slaby wrote: On 09/17/2018, 11:33 PM, Matthias Kaehlcke wrote: sysrq_handle_crash() dereferences a NULL pointer on purpose to force an exception

Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:09 AM, Steven Rostedt wrote: On Sun, 9 Sep 2018 01:57:06 +0530 Sai Prakash Ranjan wrote: The new asm-generic/io-instrumented.h will keep arch code clean and separate from instrumented version which traces io register accesses. This instrumented header can later be included

Re: [PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 5:09 AM, Steven Rostedt wrote: On Sun, 9 Sep 2018 01:57:06 +0530 Sai Prakash Ranjan wrote: The new asm-generic/io-instrumented.h will keep arch code clean and separate from instrumented version which traces io register accesses. This instrumented header can later be included

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
in C, therefore an explicit initialization is not needed. Reported-by: Sai Prakash Ranjan Suggested-by: Evan Green Signed-off-by: Matthias Kaehlcke --- drivers/tty/sysrq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
in C, therefore an explicit initialization is not needed. Reported-by: Sai Prakash Ranjan Suggested-by: Evan Green Signed-off-by: Matthias Kaehlcke --- drivers/tty/sysrq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 4:34 AM, Steven Rostedt wrote: On Sun, 16 Sep 2018 12:37:52 +0530 Sai Prakash Ranjan wrote: Hi, Anyone here? You also just caught me from coming back from a trip. I'm looking at your patches now. -- Steve Thanks Steve, I just thought you guys might have missed the patch

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-18 Thread Sai Prakash Ranjan
On 9/18/2018 4:34 AM, Steven Rostedt wrote: On Sun, 16 Sep 2018 12:37:52 +0530 Sai Prakash Ranjan wrote: Hi, Anyone here? You also just caught me from coming back from a trip. I'm looking at your patches now. -- Steve Thanks Steve, I just thought you guys might have missed the patch

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
is not needed. Reported-by: Sai Prakash Ranjan Suggested-by: Evan Green Signed-off-by: Matthias Kaehlcke --- drivers/tty/sysrq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 06ed20dd01ba..49fa8e758690 100644

Re: [PATCH] tty/sysrq: Make local variable 'killer' in sysrq_handle_crash() global

2018-09-18 Thread Sai Prakash Ranjan
is not needed. Reported-by: Sai Prakash Ranjan Suggested-by: Evan Green Signed-off-by: Matthias Kaehlcke --- drivers/tty/sysrq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 06ed20dd01ba..49fa8e758690 100644

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 11:08 PM, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2018-09-11 03:46:01) On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: +void notrace pstore_event_call(struct trace_event_buffer *fbuffer) +{ + struct trace_iterator *iter; + struct trace_seq *s; + struct

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 11:08 PM, Stephen Boyd wrote: Quoting Sai Prakash Ranjan (2018-09-11 03:46:01) On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: +void notrace pstore_event_call(struct trace_event_buffer *fbuffer) +{ + struct trace_iterator *iter; + struct trace_seq *s; + struct

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 8:24 PM, Kees Cook wrote: On Sun, Sep 16, 2018 at 6:55 AM, Joel Fernandes wrote: On Sun, Sep 16, 2018, 12:08 AM Sai Prakash Ranjan wrote: On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: Currently pstore has function trace support which can be used to get the function call chain

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 8:24 PM, Kees Cook wrote: On Sun, Sep 16, 2018 at 6:55 AM, Joel Fernandes wrote: On Sun, Sep 16, 2018, 12:08 AM Sai Prakash Ranjan wrote: On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: Currently pstore has function trace support which can be used to get the function call chain

Re: [PATCH 1/6] dt-bindings: ramoops: Add event-size property

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 11:15 AM, Rob Herring wrote: On Sun, 9 Sep 2018 01:57:02 +0530, Sai Prakash Ranjan wrote: Add an optional property called event-size to reserve log buffer for trace events. Signed-off-by: Sai Prakash Ranjan --- .../devicetree/bindings/reserved-memory/ramoops.txt| 7

Re: [PATCH 1/6] dt-bindings: ramoops: Add event-size property

2018-09-17 Thread Sai Prakash Ranjan
On 9/17/2018 11:15 AM, Rob Herring wrote: On Sun, 9 Sep 2018 01:57:02 +0530, Sai Prakash Ranjan wrote: Add an optional property called event-size to reserve log buffer for trace events. Signed-off-by: Sai Prakash Ranjan --- .../devicetree/bindings/reserved-memory/ramoops.txt| 7

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/16/2018 7:25 PM, Joel Fernandes wrote: Sorry for the top post. I've been wanting to do this as well for some time. It's quite useful. I am out of office this week and away from work machine. I will take a look at your patches next week once I'm back at work. Thanks. Best, J Cool,

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-17 Thread Sai Prakash Ranjan
On 9/16/2018 7:25 PM, Joel Fernandes wrote: Sorry for the top post. I've been wanting to do this as well for some time. It's quite useful. I am out of office this week and away from work machine. I will take a look at your patches next week once I'm back at work. Thanks. Best, J Cool,

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-16 Thread Sai Prakash Ranjan
On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: Currently pstore has function trace support which can be used to get the function call chain with limited data. Event tracing has extra data which is useful to debug wide variety of issues and is heavily used across the kernel. Adding this support

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-16 Thread Sai Prakash Ranjan
On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: Currently pstore has function trace support which can be used to get the function call chain with limited data. Event tracing has extra data which is useful to debug wide variety of issues and is heavily used across the kernel. Adding this support

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-09-11 Thread Sai Prakash Ranjan
On 9/11/2018 8:41 PM, Will Deacon wrote: Hello, On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: This patch series adds Event tracing support to pstore and is continuation to the RFC patch introduced to add a new tracing facility for register accesses called Register Trace

Re: [PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-09-11 Thread Sai Prakash Ranjan
On 9/11/2018 8:41 PM, Will Deacon wrote: Hello, On Sun, Sep 09, 2018 at 01:57:01AM +0530, Sai Prakash Ranjan wrote: This patch series adds Event tracing support to pstore and is continuation to the RFC patch introduced to add a new tracing facility for register accesses called Register Trace

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-11 Thread Sai Prakash Ranjan
On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: +void notrace pstore_event_call(struct trace_event_buffer *fbuffer) +{ + struct trace_iterator *iter; + struct trace_seq *s; + struct trace_event_call *event_call; + struct pstore_record record; + struct trace_event

Re: [PATCH 2/6] pstore: Add event tracing support

2018-09-11 Thread Sai Prakash Ranjan
On 9/9/2018 1:57 AM, Sai Prakash Ranjan wrote: +void notrace pstore_event_call(struct trace_event_buffer *fbuffer) +{ + struct trace_iterator *iter; + struct trace_seq *s; + struct trace_event_call *event_call; + struct pstore_record record; + struct trace_event

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-11 Thread Sai Prakash Ranjan
On 9/11/2018 4:15 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 22:02, Sai Prakash Ranjan wrote: On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-11 Thread Sai Prakash Ranjan
On 9/11/2018 4:15 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 22:02, Sai Prakash Ranjan wrote: On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id

[PATCH 6/6] dynamic_debug: Add flag for dynamic event tracing

2018-09-08 Thread Sai Prakash Ranjan
robe+0x524/0x670 io_write: type=writel cpu=1 ts:1423945889 data=0x0d206608 caller=qcom_smsm_probe+0x524/0x670 Note: Tracing is activated only when flag is enabled either through command line or through dynamic debug control file. Signed-off-by: Sai Prakash Ranjan --- include/asm-

[PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-08 Thread Sai Prakash Ranjan
The new asm-generic/io-instrumented.h will keep arch code clean and separate from instrumented version which traces io register accesses. This instrumented header can later be included in arm as well for tracing io register accesses. Suggested-by: Will Deacon Signed-off-by: Sai Prakash Ranjan

[PATCH 6/6] dynamic_debug: Add flag for dynamic event tracing

2018-09-08 Thread Sai Prakash Ranjan
robe+0x524/0x670 io_write: type=writel cpu=1 ts:1423945889 data=0x0d206608 caller=qcom_smsm_probe+0x524/0x670 Note: Tracing is activated only when flag is enabled either through command line or through dynamic debug control file. Signed-off-by: Sai Prakash Ranjan --- include/asm-

[PATCH 5/6] arm64/io: Add header for instrumentation of io operations

2018-09-08 Thread Sai Prakash Ranjan
The new asm-generic/io-instrumented.h will keep arch code clean and separate from instrumented version which traces io register accesses. This instrumented header can later be included in arm as well for tracing io register accesses. Suggested-by: Will Deacon Signed-off-by: Sai Prakash Ranjan

[PATCH 2/6] pstore: Add event tracing support

2018-09-08 Thread Sai Prakash Ranjan
: comm=reboot pid=1867 prio=120 target_cpu=000 sched_wakeup: comm=reboot pid=1867 prio=120 target_cpu=000 sched_switch: prev_comm=swapper/0 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=reboot next_pid=1867 next_prio=120 Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig

[PATCH 4/6] arm64/io: Add tracepoint for register accesses

2018-09-08 Thread Sai Prakash Ranjan
caller=qcom_smsm_probe+0x52c/0x678 Signed-off-by: Sai Prakash Ranjan --- arch/arm64/kernel/io.c | 22 +++ include/asm-generic/io-trace.h | 70 ++ 2 files changed, 92 insertions(+) create mode 100644 include/asm-generic/io-trace.h diff --git a/arch

[PATCH 2/6] pstore: Add event tracing support

2018-09-08 Thread Sai Prakash Ranjan
: comm=reboot pid=1867 prio=120 target_cpu=000 sched_wakeup: comm=reboot pid=1867 prio=120 target_cpu=000 sched_switch: prev_comm=swapper/0 prev_pid=0 prev_prio=120 prev_state=S ==> next_comm=reboot next_pid=1867 next_prio=120 Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig

[PATCH 4/6] arm64/io: Add tracepoint for register accesses

2018-09-08 Thread Sai Prakash Ranjan
caller=qcom_smsm_probe+0x52c/0x678 Signed-off-by: Sai Prakash Ranjan --- arch/arm64/kernel/io.c | 22 +++ include/asm-generic/io-trace.h | 70 ++ 2 files changed, 92 insertions(+) create mode 100644 include/asm-generic/io-trace.h diff --git a/arch

[PATCH 1/6] dt-bindings: ramoops: Add event-size property

2018-09-08 Thread Sai Prakash Ranjan
Add an optional property called event-size to reserve log buffer for trace events. Signed-off-by: Sai Prakash Ranjan --- .../devicetree/bindings/reserved-memory/ramoops.txt| 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH 3/6] tracing: Add tp_pstore cmdline to have tracepoints go to pstore

2018-09-08 Thread Sai Prakash Ranjan
no affect. Signed-off-by: Sai Prakash Ranjan --- .../admin-guide/kernel-parameters.txt | 21 include/linux/ftrace.h| 6 ++- kernel/sysctl.c | 7 +++ kernel/trace/Kconfig | 22 +++- kernel/tra

[PATCH 1/6] dt-bindings: ramoops: Add event-size property

2018-09-08 Thread Sai Prakash Ranjan
Add an optional property called event-size to reserve log buffer for trace events. Signed-off-by: Sai Prakash Ranjan --- .../devicetree/bindings/reserved-memory/ramoops.txt| 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH 3/6] tracing: Add tp_pstore cmdline to have tracepoints go to pstore

2018-09-08 Thread Sai Prakash Ranjan
no affect. Signed-off-by: Sai Prakash Ranjan --- .../admin-guide/kernel-parameters.txt | 21 include/linux/ftrace.h| 6 ++- kernel/sysctl.c | 7 +++ kernel/trace/Kconfig | 22 +++- kernel/tra

[PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-09-08 Thread Sai Prakash Ranjan
ns. Patch 6 adds new flag for dynamic event tracing. Sai Prakash Ranjan (6): dt-bindings: ramoops: Add event-size property pstore: Add event tracing support tracing: Add tp_pstore cmdline to have tracepoints go to pstore arm64/io: Add tracepoint for register accesses arm64/io: Add heade

[PATCH 0/6] Tracing register accesses with pstore and dynamic debug

2018-09-08 Thread Sai Prakash Ranjan
ns. Patch 6 adds new flag for dynamic event tracing. Sai Prakash Ranjan (6): dt-bindings: ramoops: Add event-size property pstore: Add event tracing support tracing: Add tp_pstore cmdline to have tracepoints go to pstore arm64/io: Add tracepoint for register accesses arm64/io: Add heade

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread Sai Prakash Ranjan
On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { +    { .compatible = "qcom,llcc-edac" }, +    { }, +}; +

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread Sai Prakash Ranjan
On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { +    { .compatible = "qcom,llcc-edac" }, +    { }, +}; +

Re: [RFC PATCH v2 3/3] dynamic_debug: Add support for dynamic register trace

2018-09-06 Thread Sai Prakash Ranjan
On 9/6/2018 3:35 PM, Will Deacon wrote: On Fri, Aug 24, 2018 at 08:15:27PM +0530, Sai Prakash Ranjan wrote: Introduce dynamic debug filtering mechanism to register tracing as dynamic_rtb() which will reduce a lot of overhead otherwise of tracing all the register reads/writes in all files. Now

Re: [RFC PATCH v2 3/3] dynamic_debug: Add support for dynamic register trace

2018-09-06 Thread Sai Prakash Ranjan
On 9/6/2018 3:35 PM, Will Deacon wrote: On Fri, Aug 24, 2018 at 08:15:27PM +0530, Sai Prakash Ranjan wrote: Introduce dynamic debug filtering mechanism to register tracing as dynamic_rtb() which will reduce a lot of overhead otherwise of tracing all the register reads/writes in all files. Now

Re: [PATCH v4 4/4] dt-bindings: msm: Update documentation of qcom,llcc

2018-09-06 Thread Sai Prakash Ranjan
On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Signed-off-by: Venkata Narendra Kumar Gutta Reviewed-by: Rob

Re: [PATCH v4 4/4] dt-bindings: msm: Update documentation of qcom,llcc

2018-09-06 Thread Sai Prakash Ranjan
On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Signed-off-by: Venkata Narendra Kumar Gutta Reviewed-by: Rob

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread Sai Prakash Ranjan
On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { + { .compatible = "qcom,llcc-edac" }, + { }, +}; + Hi Venkata, Devicetree binding for llcc is updated, but what about this compatible? Regards, Sai

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-06 Thread Sai Prakash Ranjan
On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { + { .compatible = "qcom,llcc-edac" }, + { }, +}; + Hi Venkata, Devicetree binding for llcc is updated, but what about this compatible? Regards, Sai

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/28/2018 9:32 PM, Steven Rostedt wrote: On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/28/2018 9:32 PM, Steven Rostedt wrote: On Tue, 28 Aug 2018 18:47:33 +0530 Sai Prakash Ranjan wrote: On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure why and how it is filtered out because I do not see any notrace flag in those functions, maybe that whole

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-28 Thread Sai Prakash Ranjan
On 8/27/2018 9:45 PM, Steven Rostedt wrote: On Sat, 25 Aug 2018 12:54:07 +0530 Sai Prakash Ranjan wrote: Ftrace does not trace __raw{read,write}{b,l,w,q}() functions. I am not sure why and how it is filtered out because I do not see any notrace flag in those functions, maybe that whole

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-25 Thread Sai Prakash Ranjan
On 8/24/2018 8:59 PM, Kees Cook wrote: On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during

Re: [RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-25 Thread Sai Prakash Ranjan
On 8/24/2018 8:59 PM, Kees Cook wrote: On Fri, Aug 24, 2018 at 7:45 AM, Sai Prakash Ranjan wrote: read/write{b,w,l,q} are typically used for reading from memory mapped registers, which can cause hangs if accessed unclocked. Tracing these events can help in debugging various issues faced during

[RFC PATCH v2 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-24 Thread Sai Prakash Ranjan
/fs/pstore # cat /sys/fs/pstore/rtb-ramoops-0 [LOGK_WRITE] ts:1373030419 data:0d5065a4 qcom_smsm_probe+0x51c/0x668 [LOGK_WRITE] ts:1373360576 data:0d506608 qcom_smsm_probe+0x51c/0x668 Signed-off-by: Sai Prakash Ranjan --- arch/arm64/include/asm/io.h

[RFC PATCH v2 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-24 Thread Sai Prakash Ranjan
/fs/pstore # cat /sys/fs/pstore/rtb-ramoops-0 [LOGK_WRITE] ts:1373030419 data:0d5065a4 qcom_smsm_probe+0x51c/0x668 [LOGK_WRITE] ts:1373360576 data:0d506608 qcom_smsm_probe+0x51c/0x668 Signed-off-by: Sai Prakash Ranjan --- arch/arm64/include/asm/io.h

[RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Sai Prakash Ranjan
data:0800d010 gic_handle_irq+0x124/0x128 Output has below 5 fields: * Log type, Timestamp, Data from caller which is the address of read/write{b,w,l,q}, Caller ip and Caller name. Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig | 12 +++ fs/pstore/Makefile | 1 + fs

[RFC PATCH v2 2/3] pstore: Add register read/write{b,w,l,q} tracing support

2018-08-24 Thread Sai Prakash Ranjan
data:0800d010 gic_handle_irq+0x124/0x128 Output has below 5 fields: * Log type, Timestamp, Data from caller which is the address of read/write{b,w,l,q}, Caller ip and Caller name. Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig | 12 +++ fs/pstore/Makefile | 1 + fs

[RFC PATCH v2 1/3] tracing: Add support for logging data to uncached buffer

2018-08-24 Thread Sai Prakash Ranjan
from being flooded with some I/O operations. This is based on RTB driver in CAF. Link below: * https://source.codeaurora.org/quic/la/kernel/msm-4.9 Modified to support pstore for viewing traces. Signed-off-by: Sai Prakash Ranjan --- .../bindings/reserved-memory/ramoops.txt | 7 +- inc

[RFC PATCH v2 0/3] Register read/write tracing with dynamic debug and pstore

2018-08-24 Thread Sai Prakash Ranjan
,w,q} instead of readl/writel since we will be tracing all Sai Prakash Ranjan (3): tracing: Add support for logging data to uncached buffer pstore: Add register read/write{b,w,l,q} tracing support dynamic_debug: Add support for dynamic register trace .../bindings/reserved-memory/ramoops.t

[RFC PATCH v2 1/3] tracing: Add support for logging data to uncached buffer

2018-08-24 Thread Sai Prakash Ranjan
from being flooded with some I/O operations. This is based on RTB driver in CAF. Link below: * https://source.codeaurora.org/quic/la/kernel/msm-4.9 Modified to support pstore for viewing traces. Signed-off-by: Sai Prakash Ranjan --- .../bindings/reserved-memory/ramoops.txt | 7 +- inc

[RFC PATCH v2 0/3] Register read/write tracing with dynamic debug and pstore

2018-08-24 Thread Sai Prakash Ranjan
,w,q} instead of readl/writel since we will be tracing all Sai Prakash Ranjan (3): tracing: Add support for logging data to uncached buffer pstore: Add register read/write{b,w,l,q} tracing support dynamic_debug: Add support for dynamic register trace .../bindings/reserved-memory/ramoops.t

Re: [RFC PATCH 1/3] tracing: Add support for logging data to uncached buffer

2018-08-16 Thread Sai Prakash Ranjan
instrumentation in arch code and was about to respin a v2 patch. I have replied inline, let me know if any more corrections or improvements can be done. I would also like if Kees or someone from pstore could comment on patch 2. On Fri, 3 Aug 2018 19:58:42 +0530 Sai Prakash Ranjan wrote

Re: [RFC PATCH 1/3] tracing: Add support for logging data to uncached buffer

2018-08-16 Thread Sai Prakash Ranjan
instrumentation in arch code and was about to respin a v2 patch. I have replied inline, let me know if any more corrections or improvements can be done. I would also like if Kees or someone from pstore could comment on patch 2. On Fri, 3 Aug 2018 19:58:42 +0530 Sai Prakash Ranjan wrote

Re: [RFC PATCH 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-08 Thread Sai Prakash Ranjan
On 8/7/2018 10:27 PM, Will Deacon wrote: On Fri, Aug 03, 2018 at 07:58:44PM +0530, Sai Prakash Ranjan wrote: Introduce dynamic debug filtering mechanism to register tracing as dynamic_rtb() which will reduce a lot of overhead otherwise of tracing all the register reads/writes in all files. Now

Re: [RFC PATCH 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-08 Thread Sai Prakash Ranjan
On 8/7/2018 10:27 PM, Will Deacon wrote: On Fri, Aug 03, 2018 at 07:58:44PM +0530, Sai Prakash Ranjan wrote: Introduce dynamic debug filtering mechanism to register tracing as dynamic_rtb() which will reduce a lot of overhead otherwise of tracing all the register reads/writes in all files. Now

[RFC PATCH 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-03 Thread Sai Prakash Ranjan
i to readl/writel definitions for arm64 as of now. This can be extended to arm as well later for tracing. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/include/asm/io.h | 93 +++ include/linux/dynamic_debug.h | 10 kernel/trace/Kconfig | 1 + 3 fil

[RFC PATCH 3/3] dynamic_debug: Add support for dynamic register trace

2018-08-03 Thread Sai Prakash Ranjan
i to readl/writel definitions for arm64 as of now. This can be extended to arm as well later for tracing. Signed-off-by: Sai Prakash Ranjan --- arch/arm64/include/asm/io.h | 93 +++ include/linux/dynamic_debug.h | 10 kernel/trace/Kconfig | 1 + 3 fil

[RFC PATCH 2/3] pstore: Add register readl/writel tracing support

2018-08-03 Thread Sai Prakash Ranjan
data:0800d010 gic_handle_irq+0x124/0x128 Output has below 5 fields: * Log type, Timestamp, Data from caller which is the address of read/write, Caller ip and Caller name. Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig | 12 +++ fs/pstore/Makefile | 1

[RFC PATCH 2/3] pstore: Add register readl/writel tracing support

2018-08-03 Thread Sai Prakash Ranjan
data:0800d010 gic_handle_irq+0x124/0x128 Output has below 5 fields: * Log type, Timestamp, Data from caller which is the address of read/write, Caller ip and Caller name. Signed-off-by: Sai Prakash Ranjan --- fs/pstore/Kconfig | 12 +++ fs/pstore/Makefile | 1

[RFC PATCH 1/3] tracing: Add support for logging data to uncached buffer

2018-08-03 Thread Sai Prakash Ranjan
/msm-4.9 Modified to support pstore for viewing traces. Signed-off-by: Sai Prakash Ranjan --- .../bindings/reserved-memory/ramoops.txt | 7 +- include/linux/rtb.h | 24 +++ kernel/trace/Kconfig | 7 + kernel/trace/Makefile

[RFC PATCH 1/3] tracing: Add support for logging data to uncached buffer

2018-08-03 Thread Sai Prakash Ranjan
/msm-4.9 Modified to support pstore for viewing traces. Signed-off-by: Sai Prakash Ranjan --- .../bindings/reserved-memory/ramoops.txt | 7 +- include/linux/rtb.h | 24 +++ kernel/trace/Kconfig | 7 + kernel/trace/Makefile

[RFC PATCH 0/3] Register read/write tracing with dynamic debug and pstore

2018-08-03 Thread Sai Prakash Ranjan
Patch 2 adds the pstore support for viewing the logs. Patch 3 adds dynamic debug support to filter the register readl/writel access. Sai Prakash Ranjan (3): tracing: Add support for logging data to uncached buffer pstore: Add register readl/writel tracing support dynamic_debug: Add suppor

[RFC PATCH 0/3] Register read/write tracing with dynamic debug and pstore

2018-08-03 Thread Sai Prakash Ranjan
Patch 2 adds the pstore support for viewing the logs. Patch 3 adds dynamic debug support to filter the register readl/writel access. Sai Prakash Ranjan (3): tracing: Add support for logging data to uncached buffer pstore: Add register readl/writel tracing support dynamic_debug: Add suppor

<    3   4   5   6   7   8