RE: RE: [PATCH] infiniband/i40iw: Fix a use after free in i40iw_cm_event_handler

2021-03-12 Thread Saleem, Shiraz
> Subject: Re: RE: [PATCH] infiniband/i40iw: Fix a use after free in > i40iw_cm_event_handler > > > > > > -原始邮件- > > 发件人: "Saleem, Shiraz" > > 发送时间: 2021-03-12 09:13:39 (星期五) > > 收件人: "Jason Gunthorpe" , "Lv Yunlong&q

RE: [PATCH] infiniband/i40iw: Fix a use after free in i40iw_cm_event_handler

2021-03-11 Thread Saleem, Shiraz
> Subject: Re: [PATCH] infiniband/i40iw: Fix a use after free in > i40iw_cm_event_handler > > On Wed, Mar 10, 2021 at 07:14:14PM -0800, Lv Yunlong wrote: > > In the case of I40IW_CM_EVENT_ABORTED, i40iw_event_connect_error() > > could be called to free the event->cm_node. However, event->cm_node

RE: [PATCH] infiniband: i40iw: replace atomic_add_return()

2020-12-01 Thread Saleem, Shiraz
> Subject: [PATCH] infiniband: i40iw: replace atomic_add_return() > > atomic_inc_return() is a little neater > > Signed-off-by: Yejune Deng > --- > drivers/infiniband/hw/i40iw/i40iw_cm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

RE: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get

2020-04-29 Thread Saleem, Shiraz
> Subject: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get > > Local variable netdev is not used in these calls. > > It should be noted, that this change is required to work in bonded mode. > In the other case we would get the following assert: > "RTNL: assertion failed at

RE: [PATCH v2] infiniband: i40iw: fix potential NULL pointer dereferences

2019-03-18 Thread Saleem, Shiraz
>Subject: [PATCH v2] infiniband: i40iw: fix potential NULL pointer dereferences Something like "RDMA/i40iw: Handle workqueue allocation failure" is a more appropriate subject line. > >alloc_ordered_workqueue may fail and return NULL. >The fix captures the failure and handles it properly to

RE: [PATCH] infiniband: i40iw: fix potential NULL pointer dereferences

2019-03-14 Thread Saleem, Shiraz
>Subject: [PATCH] infiniband: i40iw: fix potential NULL pointer dereferences > >alloc_ordered_workqueue may fail and return NULL. >The fix captures the failure and handles it properly to avoid potential NULL >pointer >dereferences. > >Signed-off-by: Kangjie Lu >--- >V2: add return value to

RE: [PATCH] infiniband: i40iw: fix potential NULL pointer dereferences

2019-03-12 Thread Saleem, Shiraz
>Subject: [PATCH] infiniband: i40iw: fix potential NULL pointer dereferences > >alloc_ordered_workqueue may fail and return NULL. Let's check its return value >to ensure it is not NULL so as to avoid potential NULL pointer dereferences. > >Signed-off-by: Kangjie Lu >--- >

RE: [PATCH] RDMA/i40iw: Fix incorrect iterator type

2018-09-23 Thread Saleem, Shiraz
>Subject: [PATCH] RDMA/i40iw: Fix incorrect iterator type > >Commit f27b4746f378 ("i40iw: add connection management code") uses an >incorrect rcu iterator, whilst holding the rtnl_lock. Since the critical >region invokes >i40iw_manage_qhash(), which is a sleeping function, the rcu locking and

RE: [PATCH] RDMA/i40iw: Fix incorrect iterator type

2018-09-23 Thread Saleem, Shiraz
>Subject: [PATCH] RDMA/i40iw: Fix incorrect iterator type > >Commit f27b4746f378 ("i40iw: add connection management code") uses an >incorrect rcu iterator, whilst holding the rtnl_lock. Since the critical >region invokes >i40iw_manage_qhash(), which is a sleeping function, the rcu locking and

RE: [PATCH] RDMA/i40iw: Convert timers to use timer_setup() (part 2)

2017-10-18 Thread Saleem, Shiraz
> Subject: [PATCH] RDMA/i40iw: Convert timers to use timer_setup() (part 2) > > In preparation for unconditionally passing the struct timer_list pointer to > all timer > callbacks, switch to using the new timer_setup() and from_timer() to pass the > timer > pointer explicitly. > > This

RE: [PATCH] RDMA/i40iw: Convert timers to use timer_setup() (part 2)

2017-10-18 Thread Saleem, Shiraz
> Subject: [PATCH] RDMA/i40iw: Convert timers to use timer_setup() (part 2) > > In preparation for unconditionally passing the struct timer_list pointer to > all timer > callbacks, switch to using the new timer_setup() and from_timer() to pass the > timer > pointer explicitly. > > This

RE: [infiniband-hw-i40iw] question about identical code for different branches

2017-05-18 Thread Saleem, Shiraz
> Subject: [infiniband-hw-i40iw] question about identical code for different > branches > > > index f4d1368..48fd327 100644 > --- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c > +++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c > @@ -443,10 +443,7 @@ enum i40iw_status_code

RE: [infiniband-hw-i40iw] question about identical code for different branches

2017-05-18 Thread Saleem, Shiraz
> Subject: [infiniband-hw-i40iw] question about identical code for different > branches > > > index f4d1368..48fd327 100644 > --- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c > +++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c > @@ -443,10 +443,7 @@ enum i40iw_status_code