Re: [f2fs-dev] [PATCH] f2fs: fix to avoid out-of-bounds memory access

2021-04-20 Thread Salvatore Bonaccorso
Hi, On Tue, Mar 23, 2021 at 02:43:29PM +0800, Chao Yu wrote: > Hi butt3rflyh4ck, > > On 2021/3/23 13:48, butt3rflyh4ck wrote: > > Hi, I have tested the patch on 5.12.0-rc4+, it seems to fix the problem. > > Thanks for helping to test this patch. Was this patch applied? I do not see it in

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-19 Thread Salvatore Bonaccorso
Hi Shyam, On Mon, Apr 19, 2021 at 05:48:24AM +, Shyam Prasad wrote: > > > Hi Salvatore, > > Attached is a proposed fix from Paulo for older kernels. > Can you please confirm that this works for you too? I re-applied commit a738c93fb1c1 ("cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-19 Thread Salvatore Bonaccorso
Hi Shyam, On Mon, Apr 19, 2021 at 05:48:24AM +, Shyam Prasad wrote: > > > Hi Salvatore, > > Attached is a proposed fix from Paulo for older kernels. > Can you please confirm that this works for you too? So just to be clear, first apply again a738c93fb1c1 and then your additional patch

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-18 Thread Salvatore Bonaccorso
Hi Greg, On Mon, Apr 12, 2021 at 10:01:33AM +0200, Greg Kroah-Hartman wrote: > On Thu, Apr 08, 2021 at 01:41:05PM +0200, Salvatore Bonaccorso wrote: > > Hi Shyam, > > > > On Tue, Apr 06, 2021 at 05:01:17PM +0200, Salvatore Bonaccorso wrote: > > > Hi, > > &g

Re: Bug#986561: linux: Regression in drivers/hid/hid-dr.c causing horizontal D-pad to malfunction on SNES joystick

2021-04-14 Thread Salvatore Bonaccorso
Hi Ioan-Adrian, On Wed, Apr 07, 2021 at 02:47:24PM +0200, Alessandro Grassi wrote: > Source: linux > Severity: normal > Tags: upstream > X-Debbugs-Cc: alessan...@aggro.it > > Greetings, > > I am encountering the issue described in this thread[1], using a gamepad > identified as "DragonRise"

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-08 Thread Salvatore Bonaccorso
Hi Shyam, On Tue, Apr 06, 2021 at 05:01:17PM +0200, Salvatore Bonaccorso wrote: > Hi, > > On Tue, Apr 06, 2021 at 02:00:48PM +, Shyam Prasad wrote: > > Hi Greg, > > We'll need to debug this further to understand what's going on. > > Greg asked it the same hap

Re: [EXTERNAL] Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-06 Thread Salvatore Bonaccorso
Hi, On Tue, Apr 06, 2021 at 02:00:48PM +, Shyam Prasad wrote: > Hi Greg, > We'll need to debug this further to understand what's going on. Greg asked it the same happens with 5.4 as well, I do not know I was not able to test 5.4.y (yet) but only 5.10.y and 4.19.y. > > Hi Salvatore, > Any

Re: [PATCH 4.19 013/247] cifs: Set CIFS_MOUNT_USE_PREFIX_PATH flag on setting cifs_sb->prepath.

2021-04-06 Thread Salvatore Bonaccorso
Hi, On Mon, Mar 01, 2021 at 05:10:33PM +0100, Greg Kroah-Hartman wrote: > From: Shyam Prasad N > > [ Upstream commit a738c93fb1c17e386a09304b517b1c6b2a6a5a8b ] > > While debugging another issue today, Steve and I noticed that if a > subdir for a file share is already mounted on the client, any

Re: turbostat: Fix Pkg Power on Zen

2021-03-24 Thread Salvatore Bonaccorso
Hi Len, On Mon, Mar 15, 2021 at 10:54:24PM +0100, Christian Kastner wrote: > Hi, > > On 01.02.21 10:01, Kurt Garloff wrote: > > Issue persists on Ryzen in 5.11-rc6: > > > > kvmadmin@KurtSrv2018(//):~ [0]$ sudo > > /casa/src/linux-stable/tools/power/x86/turbostat/turbostat > > [...] > >

Re: NFS Caching broken in 4.19.37

2021-02-21 Thread Salvatore Bonaccorso
Hi, On Sat, Feb 20, 2021 at 08:16:26PM +, Chuck Lever wrote: > > > > On Feb 20, 2021, at 3:13 PM, Anton Ivanov > > wrote: > > > > On 20/02/2021 20:04, Salvatore Bonaccorso wrote: > >> Hi, > >> > >> On Mon, Jul 08, 20

Re: NFS Caching broken in 4.19.37

2021-02-20 Thread Salvatore Bonaccorso
Hi, On Mon, Jul 08, 2019 at 07:19:54PM +0100, Anton Ivanov wrote: > Hi list, > > NFS caching appears broken in 4.19.37. > > The more cores/threads the easier to reproduce. Tested with identical > results on Ryzen 1600 and 1600X. > > 1. Mount an openwrt build tree over NFS v4 > 2. Run make -j

Re: Ubuntu mainline kernel builds now failing not able to find module.lds file

2020-11-24 Thread Salvatore Bonaccorso
Hi Steve, On Fri, Oct 30, 2020 at 12:43:24AM -0500, Steve French wrote: > I typically build cifs.ko for testing using the latest Ubuntu mainline > build - but building a module in the 5.10-rc1 kernel - while booted to > the 5.10-rc1 ubuntu mainlinekerel - e.g. "make C=1 -C >

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

2020-11-17 Thread Salvatore Bonaccorso
Hi Guenter, On Sat, Nov 14, 2020 at 05:27:41AM -0800, Guenter Roeck wrote: > On 11/14/20 12:35 AM, Salvatore Bonaccorso wrote: > > Hi Guenter, > > > > On Sat, Oct 31, 2020 at 07:31:32AM -0700, Guenter Roeck wrote: > >> On 10/31/20 2:45 AM, Salvatore B

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

2020-11-14 Thread Salvatore Bonaccorso
Hi Guenter, On Sat, Oct 31, 2020 at 07:31:32AM -0700, Guenter Roeck wrote: > On 10/31/20 2:45 AM, Salvatore Bonaccorso wrote: > > Hi Greg, > > > > On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: > >> Retry. > >> > >> On Wed, Oct 2

Re: [PATCH 4.19 000/264] 4.19.153-rc1 review

2020-10-31 Thread Salvatore Bonaccorso
Hi Greg, On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: > Retry. > > On Wed, Oct 28, 2020 at 10:10:35AM -0700, Guenter Roeck wrote: > > On Tue, Oct 27, 2020 at 02:50:58PM +0100, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.19.153 release.

Re: [PATCH 4.19 00/21] 4.19.152-rc1 review

2020-10-17 Thread Salvatore Bonaccorso
Hi, On Sat, Oct 17, 2020 at 11:49:43AM +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 17, 2020 at 11:41:53AM +0200, Salvatore Bonaccorso wrote: > > hi, > > > > On Fri, Oct 16, 2020 at 12:01:51PM -0700, Guenter Roeck wrote: > > > On Fri, Oct 16, 2020 at 11:07:19AM +

Re: [PATCH 4.19 00/21] 4.19.152-rc1 review

2020-10-17 Thread Salvatore Bonaccorso
hi, On Fri, Oct 16, 2020 at 12:01:51PM -0700, Guenter Roeck wrote: > On Fri, Oct 16, 2020 at 11:07:19AM +0200, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.152 release. > > There are 21 patches in this series, all will be posted as a response > > to this

Re: [PATCH 4.19 142/206] gfs2: fix use-after-free on transaction ail lists

2020-09-12 Thread Salvatore Bonaccorso
Hi Bob, hi Greg, On Fri, Sep 11, 2020 at 08:49:14AM -0400, Bob Peterson wrote: > - Original Message - > > On Fri, Sep 11, 2020 at 08:08:35AM -0400, Bob Peterson wrote: > > > - Original Message - > > > > On Thu, Sep 10, 2020 at 09:43:19PM +02

Re: [PATCH 4.19 142/206] gfs2: fix use-after-free on transaction ail lists

2020-09-11 Thread Salvatore Bonaccorso
Hi Bob, On Fri, Sep 11, 2020 at 08:49:14AM -0400, Bob Peterson wrote: > - Original Message - > > On Fri, Sep 11, 2020 at 08:08:35AM -0400, Bob Peterson wrote: > > > - Original Message - > > > > On Thu, Sep 10, 2020 at 09:43:19PM +0200, Salvatore

Re: [PATCH 4.19 142/206] gfs2: fix use-after-free on transaction ail lists

2020-09-11 Thread Salvatore Bonaccorso
Hi Greg, Thanks for your quick reply. On Fri, Sep 11, 2020 at 01:58:16PM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 10, 2020 at 09:43:19PM +0200, Salvatore Bonaccorso wrote: > > Hi, > > > > On Tue, Jun 23, 2020 at 09:57:50PM +0200, Greg Kroah-Hartman wrote: >

Re: [PATCH 4.19 142/206] gfs2: fix use-after-free on transaction ail lists

2020-09-10 Thread Salvatore Bonaccorso
Hi, On Tue, Jun 23, 2020 at 09:57:50PM +0200, Greg Kroah-Hartman wrote: > From: Bob Peterson > > [ Upstream commit 83d060ca8d90fa1e3feac227f995c013100862d3 ] > > Before this patch, transactions could be merged into the system > transaction by function gfs2_merge_trans(), but the transaction

Re: kworker/0:3+pm hogging CPU

2020-08-29 Thread Salvatore Bonaccorso
Hi Alan, I'm following up on this thread because a user in Debian (Dirk, Cc'ed) as well encountered the same/similar issue: On Tue, Jul 21, 2020 at 10:33:25AM -0400, Alan Stern wrote: > On Tue, Jul 21, 2020 at 07:59:17AM +0200, Michal Hocko wrote: > > > Sorry, my mistake. The module name needs

Re: Documentation: build failure with sphinx >= 3.0.0: exception: cannot import name 'c_funcptr_sig_re' from 'sphinx.domains.c'

2020-08-12 Thread Salvatore Bonaccorso
Hi, On Sun, Aug 09, 2020 at 03:23:27PM +0200, Salvatore Bonaccorso wrote: > Hi > On Thu, Apr 09, 2020 at 05:04:54AM +0530, Bhaskar Chowdhury wrote: > > On 13:25 Wed 08 Apr 2020, Jonathan Corbet wrote: > > > On Wed, 8 Apr 2020 17:07:05 +0530 > >

Documentation: build failure with sphinx >= 3.0.0: exception: cannot import name 'c_funcptr_sig_re' from 'sphinx.domains.c' (was: Re: Kernel build failed ...SPHINX extension error)

2020-08-09 Thread Salvatore Bonaccorso
Hi On Thu, Apr 09, 2020 at 05:04:54AM +0530, Bhaskar Chowdhury wrote: > On 13:25 Wed 08 Apr 2020, Jonathan Corbet wrote: > > On Wed, 8 Apr 2020 17:07:05 +0530 > > Bhaskar Chowdhury wrote: > > > > > Extension error: > > > Could not import extension cdomain (exception: cannot import name > > >

Re: [PATCH] usbip: tools: fix build error for multiple definition

2020-07-23 Thread Salvatore Bonaccorso
3,7 +23,7 @@ > > #include "list.h" > > #include "sysfs_utils.h" > > -struct udev *udev_context; > > +extern struct udev *udev_context; > > static int32_t read_attr_usbip_status(struct usbip_usb_device *udev) > > { > > > > L

[PATCH] docs: hw-vuln: SRBDS: Fix "Title underline too short" warnings during build

2020-06-09 Thread Salvatore Bonaccorso
Gross Cc: Josh Poimboeuf Cc: Borislav Petkov Cc: Tony Luck Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org Cc: triv...@kernel.org Signed-off-by: Salvatore Bonaccorso --- .../hw-vuln/special-register-buffer-data-sampling.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH v2] relay: handle alloc_percpu returning NULL in relay_open

2020-05-21 Thread Salvatore Bonaccorso
Hi, On Fri, Dec 20, 2019 at 11:00:56AM -0800, David Rientjes wrote: > On Thu, 19 Dec 2019, Daniel Axtens wrote: > > > alloc_percpu() may return NULL, which means chan->buf may be set to > > NULL. In that case, when we do *per_cpu_ptr(chan->buf, ...), we > > dereference an invalid pointer: > > >

Re: [PATCH 2/2] Fix a stack buffer overflow bug in check_input_term

2019-09-01 Thread Salvatore Bonaccorso
Hi Hui, On Fri, Aug 30, 2019 at 05:47:29PM -0400, Hui Peng wrote: > `check_input_term` recursively calls itself with input from > device side (e.g., uac_input_terminal_descriptor.bCSourceID) > as argument (id). In `check_input_term`, if `check_input_term` > is called with the same `id` argument

Re: [PATCH 1/2] Fix an OOB bug in parse_audio_mixer_unit

2019-09-01 Thread Salvatore Bonaccorso
On Fri, Aug 30, 2019 at 05:46:49PM -0400, Hui Peng wrote: > The `uac_mixer_unit_descriptor` shown as below is read from the > device side. In `parse_audio_mixer_unit`, `baSourceID` field is > accessed from index 0 to `bNrInPins` - 1, the current implementation > assumes that descriptor is always

Re: [Linux 5.2.x] /sys/kernel/debug/tracing/events/power/cpu_idle/id: BUG: kernel NULL pointer dereference, address: 0000000000000000

2019-08-11 Thread Salvatore Bonaccorso
Thomas, On Sun, Aug 11, 2019 at 02:58:15PM +0200, Thomas Gleixner wrote: > Salvatore, > > On Sun, 11 Aug 2019, Salvatore Bonaccorso wrote: > > On Sun, Aug 11, 2019 at 08:22:35AM +0200, Thomas Gleixner wrote: > > > On Sat, 10 Aug 2019, Paul Menzel wrote: > >

Re: [Linux 5.2.x] /sys/kernel/debug/tracing/events/power/cpu_idle/id: BUG: kernel NULL pointer dereference, address: 0000000000000000

2019-08-11 Thread Salvatore Bonaccorso
hi, On Sun, Aug 11, 2019 at 08:22:35AM +0200, Thomas Gleixner wrote: > On Sat, 10 Aug 2019, Paul Menzel wrote: > > Cc+ Steven > > > [+ INTEL IDLE DRIVER] > > > > Dear Linux folks, > > > > > > On 10.08.19 20:28, Paul Menzel wrote: > > > > > On 10.08.19 19:31, Thomas Gleixner wrote: > > > >

Re: [PATCH v15 23/26] sched: early boot clock

2019-01-02 Thread Salvatore Bonaccorso
Hi, On Tue, Nov 06, 2018 at 06:35:36AM -0500, Steven Sistare wrote: > Pavel has a new email address, cc'd - steve > > On 11/6/2018 12:42 AM, Dominique Martinet wrote: > > (added various kvm/virtualization lists in Cc as well as qemu as I don't > > know who's "wrong" here) > > > > Pavel Tatashin

Re: [PATCH 4.9 75/95] random: set up the NUMA crng instances after the CRNG is fully initialized

2018-04-23 Thread Salvatore Bonaccorso
nt. Finally, we fix a potential deadlock between primary_crng.lock and batched_entropy_reset_lock, where they could be called in opposite order. Moving the call to invalidate_batched_entropy to outside the lock rectifies this issue. Fixes: b169c13de473a85b3c859bb36216a4cb5f00a54a Signed-off-by: Jason

Re: [PATCH 4.9 75/95] random: set up the NUMA crng instances after the CRNG is fully initialized

2018-04-23 Thread Salvatore Bonaccorso
te order. Moving the call to invalidate_batched_entropy to outside the lock rectifies this issue. Fixes: b169c13de473a85b3c859bb36216a4cb5f00a54a Signed-off-by: Jason A. Donenfeld Signed-off-by: Theodore Ts'o Cc: sta...@vger.kernel.org [Salvatore Bonaccorso: backport

Re: [ANNOUNCE] v4.14.15-rt12

2018-01-28 Thread Salvatore Bonaccorso
Hi On Thu, Jan 25, 2018 at 04:17:06PM +0100, Sebastian Andrzej Siewior wrote: > Dear RT folks! > > I'm pleased to announce the v4.14.15-rt12 patch set. > > Changes since v4.14.15-rt11: > > - Drop ping-sysrq. Since it won't reach mainline in its current shape, > lets drop. Suggested by

Re: [ANNOUNCE] v4.14.15-rt12

2018-01-28 Thread Salvatore Bonaccorso
Hi On Thu, Jan 25, 2018 at 04:17:06PM +0100, Sebastian Andrzej Siewior wrote: > Dear RT folks! > > I'm pleased to announce the v4.14.15-rt12 patch set. > > Changes since v4.14.15-rt11: > > - Drop ping-sysrq. Since it won't reach mainline in its current shape, > lets drop. Suggested by