Re: [EXTERNAL] Re: [PATCH 1/1] drm/bochs: Fix connector leak during driver unload

2019-06-16 Thread Sam Bobroff
On Tue, May 21, 2019 at 10:10:29AM +0200, Gerd Hoffmann wrote: > Hi, > > The bug is in the driver, so ... > > > Bisecting the issue for commits to drivers/gpu/drm/bochs/ points to: > > 6579c39594ae ("drm/bochs: atomic: switch planes to atomic, wire up > > helpers.") > > ... but the issue also

Re: [EXTERNAL] Re: [PATCH v3 1/3] PCI: Introduce pcibios_ignore_alignment_request

2019-05-30 Thread Sam Bobroff
ssignments otherwise things > break. QEMU however doesn't do any BAR assignments and relies on that > being handled by the guest. At boot time this is done by SLOF, but > Linux only keeps SLOF around until it's extracted the device-tree. > Once that's done SLOF gets blown away and the

Re: [PATCH] powerpc: eeh_event: convert semaphore to completion

2018-12-10 Thread Sam Bobroff
On Tue, Dec 11, 2018 at 10:18:31AM +1100, Oliver wrote: > On Tue, Dec 11, 2018 at 8:52 AM Arnd Bergmann wrote: > > > > For this use case, completions and semaphores are equivalent, > > but semaphores are an awkward interface that should generally > > be avoided, so use the completion instead. >

Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction

2016-06-08 Thread Sam Bobroff
On Thu, Jun 02, 2016 at 07:38:58AM -0500, Shreyas B. Prabhu wrote: ... > +/* Power Management - PSSCR Fields */ It might be nice to give the full name of the register, as below with the FPSCR. > +#define PSSCR_RL_MASK0x000F > +#define PSSCR_MTL_MASK 0x00F0

Re: [PATCH v5 08/11] powerpc/powernv: Add platform support for stop instruction

2016-06-08 Thread Sam Bobroff
On Thu, Jun 02, 2016 at 07:38:58AM -0500, Shreyas B. Prabhu wrote: ... > +/* Power Management - PSSCR Fields */ It might be nice to give the full name of the register, as below with the FPSCR. > +#define PSSCR_RL_MASK0x000F > +#define PSSCR_MTL_MASK 0x00F0

Re: [PATCH] book3s_hv_rmhandlers:Pass the correct trap argument to kvmhv_commence_exit

2015-08-13 Thread Sam Bobroff
purious trap number. > > Fix this by copying r12 into r3 before calling kvmhv_commence_exit as > r12 contains the trap number > > Signed-off-by: Gautham R. Shenoy Hi Gautham, I agree with your logic: r3 is quite clearly corrupted in that path. So: Reviewed-by: Sam Bobroff Ju

Re: [PATCH v3] powerpc: Add an inline function to update POWER8 HID0

2015-08-13 Thread Sam Bobroff
e function name update_power8_hid0() which follows this > recipe and invoke it from the static split core path. > > Signed-off-by: Gautham R. Shenoy Hi Gautham, I've tested this on a Power 8 machine and verified that it is able to change split modes and that when doing so the new code is used.

Re: [PATCH] book3s_hv_rmhandlers:Pass the correct trap argument to kvmhv_commence_exit

2015-08-13 Thread Sam Bobroff
. Fix this by copying r12 into r3 before calling kvmhv_commence_exit as r12 contains the trap number Signed-off-by: Gautham R. Shenoy e...@linux.vnet.ibm.com Hi Gautham, I agree with your logic: r3 is quite clearly corrupted in that path. So: Reviewed-by: Sam Bobroff sam.bobr...@au1

Re: [PATCH v3] powerpc: Add an inline function to update POWER8 HID0

2015-08-13 Thread Sam Bobroff
-by: Sam Bobroff sam.bobr...@au1.ibm.com Tested-by: Sam Bobroff sam.bobr...@au1.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

[PATCH v2 1/1] merge_config.sh: exit on missing input files

2015-07-19 Thread Sam Bobroff
Add a check for the existence of input files and exit (with failure) if they are missing. Without this additional check, missing files produce error messages but still result in an output file being generated and a successful exit code. Signed-off-by: Sam Bobroff --- The current behaviour

[PATCH v2 1/1] merge_config.sh: exit on missing input files

2015-07-19 Thread Sam Bobroff
Add a check for the existence of input files and exit (with failure) if they are missing. Without this additional check, missing files produce error messages but still result in an output file being generated and a successful exit code. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com

[PATCH 1/1] merge_config.sh: exit on missing input files

2015-07-02 Thread Sam Bobroff
Add a check for the existence of input files and exit (with failure) if they are missing. Without this additional check, missing files produce error messages but still result in an output file being generated and a successful exit code. Signed-off-by: Sam Bobroff --- The current behaviour

[PATCH 1/1] merge_config.sh: exit on missing input files

2015-07-02 Thread Sam Bobroff
Add a check for the existence of input files and exit (with failure) if they are missing. Without this additional check, missing files produce error messages but still result in an output file being generated and a successful exit code. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com

[PATCH 1/1] checkpatch: improve operator spacing check

2015-04-06 Thread Sam Bobroff
king for a close parenthesis. Signed-off-by: Sam Bobroff --- scripts/checkpatch.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d124359..f65c4de 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3565,7 +3565,

[PATCH 1/1] checkpatch: improve operator spacing check

2015-04-06 Thread Sam Bobroff
parenthesis. Signed-off-by: Sam Bobroff sam.bobr...@au1.ibm.com --- scripts/checkpatch.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d124359..f65c4de 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3565,7

Re: [PATCH V3 2/3] powerpc, ptrace: Enable support for transactional memory register sets

2014-07-24 Thread Sam Bobroff
On 24/05/14 01:15, Anshuman Khandual wrote: > This patch enables get and set of transactional memory related register > sets through PTRACE_GETREGSET/PTRACE_SETREGSET interface by implementing > four new powerpc specific register sets i.e REGSET_TM_SPR, REGSET_TM_CGPR, > REGSET_TM_CFPR,

Re: [PATCH V3 0/3] Add new PowerPC specific ELF core notes

2014-07-24 Thread Sam Bobroff
On 24/05/14 01:15, Anshuman Khandual wrote: > This patch series adds five new ELF core note sections which can be > used with existing ptrace request PTRACE_GETREGSET/SETREGSET for accessing > various transactional memory and miscellaneous register sets on PowerPC > platform. Please find a

Re: [PATCH V3 0/3] Add new PowerPC specific ELF core notes

2014-07-24 Thread Sam Bobroff
On 24/05/14 01:15, Anshuman Khandual wrote: This patch series adds five new ELF core note sections which can be used with existing ptrace request PTRACE_GETREGSET/SETREGSET for accessing various transactional memory and miscellaneous register sets on PowerPC platform. Please find a test

Re: [PATCH V3 2/3] powerpc, ptrace: Enable support for transactional memory register sets

2014-07-24 Thread Sam Bobroff
On 24/05/14 01:15, Anshuman Khandual wrote: This patch enables get and set of transactional memory related register sets through PTRACE_GETREGSET/PTRACE_SETREGSET interface by implementing four new powerpc specific register sets i.e REGSET_TM_SPR, REGSET_TM_CGPR, REGSET_TM_CFPR, REGSET_CVMX

Re: [PATCH V3 0/3] Add new PowerPC specific ELF core notes

2014-07-17 Thread Sam Bobroff
On 17/07/14 21:14, Michael Neuling wrote: > > On Jul 17, 2014 9:11 PM, "Benjamin Herrenschmidt" > mailto:b...@kernel.crashing.org>> wrote: >> >> > > >> > >> Outstanding Issues >> > >> == >> > >> (1) Running DSCR register value inside a transaction does not > seem to be saved >> >

Re: [PATCH V3 0/3] Add new PowerPC specific ELF core notes

2014-07-17 Thread Sam Bobroff
On 17/07/14 21:14, Michael Neuling wrote: On Jul 17, 2014 9:11 PM, Benjamin Herrenschmidt b...@kernel.crashing.org mailto:b...@kernel.crashing.org wrote: Outstanding Issues == (1) Running DSCR register value inside a transaction does not seem to be saved at